qemu-img.c possibly overflowing shifts by BDRV_SECTOR_BITS

2021-11-09 Thread Peter Maydell
Hi; Coverity is complaining about some of the places in qemu-img.c where it takes a 32-bit variable and shifts it left by BDRV_SECTOR_BITS to convert a sector count to a byte count, because it's doing the shift in 32-bits rather than 64 and so Coverity thinks there might be overflow (CID 1465221, 1

[PULL 1/3] docs/block-replication: use blockdev-backup

2021-11-09 Thread Vladimir Sementsov-Ogievskiy
We are going to deprecate drive-backup, so don't mention it here. Moreover, blockdev-backup seems more correct in the context. Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: John Snow --- docs/block-replication.txt | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

[PULL 0/3] jobs: deprecate drive-backup qmp command

2021-11-09 Thread Vladimir Sementsov-Ogievskiy
The following changes since commit 2b22e7540d6ab4efe82d442363e3fc900cea6584: Merge tag 'm68k-for-6.2-pull-request' of git://github.com/vivier/qemu-m68k into staging (2021-11-09 13:16:56 +0100) are available in the Git repository at: https://src.openvz.org/scm/~vsementsov/qemu.git tags/pull-

[PULL 3/3] qapi: deprecate drive-backup

2021-11-09 Thread Vladimir Sementsov-Ogievskiy
Modern way is using blockdev-add + blockdev-backup, which provides a lot more control on how target is opened. As example of drive-backup problems consider the following: User of drive-backup expects that target will be opened in the same cache and aio mode as source. Corresponding logic is in dr

[PULL 2/3] docs/interop/bitmaps: use blockdev-backup

2021-11-09 Thread Vladimir Sementsov-Ogievskiy
We are going to deprecate drive-backup, so use modern interface here. In examples where target image creation is shown, show blockdev-add as well. If target creation omitted, omit blockdev-add as well. Reviewed-by: Kashyap Chamarthy Signed-off-by: Vladimir Sementsov-Ogievskiy --- docs/interop/b

Re: [PULL 22/22] python, iotests: replace qmp with aqmp

2021-11-09 Thread John Snow
On Tue, Nov 9, 2021 at 9:07 AM Thomas Huth wrote: > On 01/11/2021 18.30, John Snow wrote: > > Swap out the synchronous QEMUMonitorProtocol from qemu.qmp with the sync > > wrapper from qemu.aqmp instead. > > > > Add an escape hatch in the form of the environment variable > > QEMU_PYTHON_LEGACY_QMP

Re: Poking around bdrv_is_inserted()

2021-11-09 Thread Markus Armbruster
Kevin Wolf writes: > Am 09.11.2021 um 07:44 hat Markus Armbruster geschrieben: >> Screwed up qemu-de...@nongnu.org, sorry for the inconvenience. >> >> Markus Armbruster writes: >> >> > bdrv_is_inserted() returns false when: >> > >> > /** >> > * Return TRUE if the media is present >> >

Re: [PULL 22/22] python, iotests: replace qmp with aqmp

2021-11-09 Thread Thomas Huth
On 01/11/2021 18.30, John Snow wrote: Swap out the synchronous QEMUMonitorProtocol from qemu.qmp with the sync wrapper from qemu.aqmp instead. Add an escape hatch in the form of the environment variable QEMU_PYTHON_LEGACY_QMP which allows you to cajole QEMUMachine into using the old implementati

Re: [PATCH v2 0/3] virtio: increase VIRTQUEUE_MAX_SIZE to 32k

2021-11-09 Thread Christian Schoenebeck
On Dienstag, 9. November 2021 11:56:35 CET Stefan Hajnoczi wrote: > On Thu, Nov 04, 2021 at 03:41:23PM +0100, Christian Schoenebeck wrote: > > On Mittwoch, 3. November 2021 12:33:33 CET Stefan Hajnoczi wrote: > > > On Mon, Nov 01, 2021 at 09:29:26PM +0100, Christian Schoenebeck wrote: > > > > On Do

Re: [PATCH 12/15] hw/nvme: Initialize capability structures for primary/secondary controllers

2021-11-09 Thread Klaus Jensen
On Nov 8 14:57, Łukasz Gieryk wrote: > On Mon, Nov 08, 2021 at 09:25:58AM +0100, Klaus Jensen wrote: > > On Nov 5 15:04, Łukasz Gieryk wrote: > > > On Fri, Nov 05, 2021 at 09:46:28AM +0100, Łukasz Gieryk wrote: > > > > On Thu, Nov 04, 2021 at 04:48:43PM +0100, Łukasz Gieryk wrote: > > > > > On We

Re: [PATCH v2 0/3] virtio: increase VIRTQUEUE_MAX_SIZE to 32k

2021-11-09 Thread Stefan Hajnoczi
On Thu, Nov 04, 2021 at 03:41:23PM +0100, Christian Schoenebeck wrote: > On Mittwoch, 3. November 2021 12:33:33 CET Stefan Hajnoczi wrote: > > On Mon, Nov 01, 2021 at 09:29:26PM +0100, Christian Schoenebeck wrote: > > > On Donnerstag, 28. Oktober 2021 11:00:48 CET Stefan Hajnoczi wrote: > > > > On

Re: Poking around bdrv_is_inserted()

2021-11-09 Thread Kevin Wolf
Am 09.11.2021 um 07:44 hat Markus Armbruster geschrieben: > Screwed up qemu-de...@nongnu.org, sorry for the inconvenience. > > Markus Armbruster writes: > > > bdrv_is_inserted() returns false when: > > > > /** > > * Return TRUE if the media is present > > */ > > bool bdrv_is_in