[PULL for-6.2 2/3] hw/nvme: change nvme-ns 'shared' default

2021-11-19 Thread Klaus Jensen
From: Klaus Jensen Change namespaces to be shared namespaces by default (parameter shared=on). Keep shared=off for older machine types. Reviewed-by: Keith Busch Signed-off-by: Klaus Jensen --- docs/system/devices/nvme.rst | 24 ++-- hw/core/machine.c| 1 + hw/

[PULL for-6.2 1/3] hw/nvme: reattach subsystem namespaces on hotplug

2021-11-19 Thread Klaus Jensen
From: Hannes Reinecke With commit 5ffbaeed16 ("hw/nvme: fix controller hot unplugging") namespaces get moved from the controller to the subsystem if one is specified. That keeps the namespaces alive after a controller hot-unplug, but after a controller hotplug we have to reconnect the namespaces

[PULL for-6.2 0/3] hw/nvme fixes

2021-11-19 Thread Klaus Jensen
From: Klaus Jensen Hi, The following changes since commit 44a3aa0608f01274418487b655d42467c1d8334e: Merge tag 'sev-hashes-pull-request' of https://gitlab.com/berrange/qemu into staging (2021-11-18 15:06:05 +0100) are available in the Git repository at: git://git.infradead.org/qemu-nvme.g

[PULL for-6.2 3/3] hw/nvme: fix buffer overrun in nvme_changed_nslist (CVE-2021-3947)

2021-11-19 Thread Klaus Jensen
From: Klaus Jensen Fix missing offset verification. Cc: qemu-sta...@nongnu.org Cc: Philippe Mathieu-Daudé Reported-by: Qiuhao Li Fixes: f432fdfa121 ("support changed namespace asynchronous event") Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Klaus Jensen --- hw/nvme/ctrl.c | 5 +

Re: [PATCH v2 1/2] iotests: Use aes-128-cbc

2021-11-19 Thread Thomas Huth
On 17/11/2021 16.17, Hanna Reitz wrote: Our gnutls crypto backend (which is the default as of 8bd0931f6) supports neither twofish-128 nor the CTR mode. CBC and aes-128 are supported by all of our backends (as far as I can tell), so use aes-128-cbc in our iotests. (We could also use e.g. aes-256

Re: [PATCH v4 08/25] block: introduce assert_bdrv_graph_writable

2021-11-19 Thread Emanuele Giuseppe Esposito
On 18/11/2021 16:17, Hanna Reitz wrote: On 18.11.21 10:55, Emanuele Giuseppe Esposito wrote: On 12/11/2021 15:40, Hanna Reitz wrote: On 25.10.21 12:17, Emanuele Giuseppe Esposito wrote: We want to be sure that the functions that write the child and parent list of a bs are under BQL and dra

[PATCH-for-6.2? v2 0/3] misc: Spell QEMU all caps

2021-11-19 Thread Philippe Mathieu-Daudé
Replace Qemu -> QEMU. Supersedes: <2028143401.4101497-1-phi...@redhat.com> Philippe Mathieu-Daudé (3): docs: Spell QEMU all caps misc: Spell QEMU all caps qga: Spell QEMU all caps docs/devel/modules.rst | 2 +- docs/devel/multi-thread-tcg.rst| 2 +- docs/deve

[PATCH-for-6.2? v2 1/3] docs: Spell QEMU all caps

2021-11-19 Thread Philippe Mathieu-Daudé
QEMU should be written all caps. Normally checkpatch.pl warns when it is not (see commit 9964d8f9422: "checkpatch: Add QEMU specific rule"). Replace Qemu -> QEMU. Reviewed-by: Darren Kenny Reviewed-by: Markus Armbruster Signed-off-by: Philippe Mathieu-Daudé --- docs/devel/modules.rst

[PATCH-for-6.2? v2 2/3] misc: Spell QEMU all caps

2021-11-19 Thread Philippe Mathieu-Daudé
QEMU should be written all caps. Normally checkpatch.pl warns when it is not (see commit 9964d8f9422: "checkpatch: Add QEMU specific rule"). Replace Qemu -> QEMU. Signed-off-by: Philippe Mathieu-Daudé --- qapi/block-core.json | 2 +- python/qemu/machine/machine.py | 2

Re: [PATCH-for-6.2?] docs: Spell QEMU all caps

2021-11-19 Thread Paolo Bonzini
On 11/18/21 15:34, Philippe Mathieu-Daudé wrote: Replace Qemu -> QEMU. Signed-off-by: Philippe Mathieu-Daudé --- docs/devel/modules.rst| 2 +- docs/devel/multi-thread-tcg.rst | 2 +- docs/devel/style.rst | 2 +- docs/devel/ui.rst

Re: [PATCH-for-6.2?] docs: Spell QEMU all caps

2021-11-19 Thread Philippe Mathieu-Daudé
On 11/19/21 10:17, Paolo Bonzini wrote: > On 11/18/21 15:34, Philippe Mathieu-Daudé wrote: >> Replace Qemu -> QEMU. >> >> Signed-off-by: Philippe Mathieu-Daudé >> --- >>   docs/devel/modules.rst    |  2 +- >>   docs/devel/multi-thread-tcg.rst   |  2 +- >>   docs/devel/style.rst

[PATCH-for-6.2? v2 3/3] qga: Spell QEMU all caps

2021-11-19 Thread Philippe Mathieu-Daudé
QEMU should be written all caps. Normally checkpatch.pl warns when it is not (see commit 9964d8f9422: "checkpatch: Add QEMU specific rule"). Replace Qemu -> QEMU, update the error message to use the more descriptive "Guest Agent" name instead of "GA". Signed-off-by: Philippe Mathieu-Daudé ---

Re: [PATCH v4 00/25] block layer: split block APIs in global state and I/O

2021-11-19 Thread Emanuele Giuseppe Esposito
On 19/11/2021 04:13, Paolo Bonzini wrote: El jue., 18 nov. 2021 16:31, Hanna Reitz > escribió: On 18.11.21 14:50, Paolo Bonzini wrote: > On 11/15/21 17:03, Hanna Reitz wrote: >> >> I only really see four solutions for this: >> (1) We someho

Re: [PULL for-6.2 0/3] hw/nvme fixes

2021-11-19 Thread Richard Henderson
On 11/19/21 9:09 AM, Klaus Jensen wrote: From: Klaus Jensen Hi, The following changes since commit 44a3aa0608f01274418487b655d42467c1d8334e: Merge tag 'sev-hashes-pull-request' of https://gitlab.com/berrange/qemu into staging (2021-11-18 15:06:05 +0100) are available in the Git repositor

[PATCH] block vvfat.c fix leak when failure occurs

2021-11-19 Thread Daniella Lee
Based on your suggestions. I made a new patch which contians: 1.format detection 2.replace calloc with g_malloc0 in enable_write_target function 3.use g_free without null pointer detection in vvfat_open function 4.delete line "ret = 0", use return ret directly in vvfat_open function Signed-off-by

Re: [PATCH v9 5/8] qmp: decode feature & status bits in virtio-status

2021-11-19 Thread Markus Armbruster
Jonah Palmer writes: > On 11/10/21 08:49, Markus Armbruster wrote: >> Jonah Palmer writes: >> >>> From: Laurent Vivier >>> >>> Display feature names instead of bitmaps for host, guest, and >>> backend for VirtIODevice. >>> >>> Display status names instead of bitmaps for VirtIODevice. >>> >>> Dis

Re: [PATCH v9 7/8] qmp: add QMP command x-query-virtio-queue-element

2021-11-19 Thread Markus Armbruster
Jonah Palmer writes: > On 11/10/21 08:52, Markus Armbruster wrote: >> Jonah Palmer writes: >> >>> From: Laurent Vivier >>> >>> This new command shows the information of a VirtQueue element. >>> >>> Signed-off-by: Jonah Palmer >> [...] >> >>> diff --git a/qapi/virtio.json b/qapi/virtio.json >>> i

Re: [PATCH v2 02/13] hw: Replace trivial drive_get_next() by drive_get()

2021-11-19 Thread Alistair Francis
On Thu, Nov 18, 2021 at 2:42 AM Markus Armbruster wrote: > > drive_get_next() is basically a bad idea. It returns the "next" block > backend of a certain interface type. "Next" means bus=0,unit=N, where > subsequent calls count N up from zero, per interface type. > > This lets you define unit nu

Re: [PATCH v2 01/13] hw/sd/ssi-sd: Do not create SD card within controller's realize

2021-11-19 Thread Alistair Francis
On Thu, Nov 18, 2021 at 2:35 AM Markus Armbruster wrote: > > ssi_sd_realize() creates an "sd-card" device. This is inappropriate, > and marked FIXME. > > Move it to the boards that create these devices. Prior art: commit > eb4f566bbb for device "generic-sdhci", and commit 26c607b86b for > device

RE: [PATCH-for-6.2? v2 2/3] misc: Spell QEMU all caps

2021-11-19 Thread Taylor Simpson
> -Original Message- > From: Philippe Mathieu-Daudé > Sent: Friday, November 19, 2021 3:17 AM > To: qemu-de...@nongnu.org > Cc: Cleber Rosa ; John Snow ; Eric > Blake ; Markus Armbruster ; > Hanna Reitz ; Michael Roth ; > qemu-block@nongnu.org; Marcelo Tosatti ; Vladimir > Sementsov-Ogie

[PATCH-for-6.2 0/2] hw/scsi/megasas: Avoid overflowing the SGL buffer

2021-11-19 Thread Philippe Mathieu-Daudé
Fix issue #521 reported by Alex some months ago: https://gitlab.com/qemu-project/qemu/-/issues/521 Philippe Mathieu-Daudé (2): hw/scsi/megasas: Fails command if SGL buffer overflows tests/qtest/fuzz-megasas-test: Add test for GitLab issue #521 hw/scsi/megasas.c | 1 + tests/qt

[PATCH-for-6.2 1/2] hw/scsi/megasas: Fails command if SGL buffer overflows

2021-11-19 Thread Philippe Mathieu-Daudé
If we detect an overflow on the SGL buffer, do not keep processing the command: discard it. TARGET_FAILURE sense code will be returned (MFI_STAT_SCSI_DONE_WITH_ERROR). Reported-by: Alexander Bulekov Resolves: https://gitlab.com/qemu-project/qemu/-/issues/521 Signed-off-by: Philippe Mathieu-Daudé

[PATCH-for-6.2 2/2] tests/qtest/fuzz-megasas-test: Add test for GitLab issue #521

2021-11-19 Thread Philippe Mathieu-Daudé
Without the previous commit, this test triggers: $ make check-qtest-x86_64 [...] Running test qtest-x86_64/fuzz-megasas-test qemu-system-x86_64: softmmu/physmem.c:3229: address_space_unmap: Assertion `mr != NULL' failed. Broken pipe ERROR qtest-x86_64/fuzz-megasas-test - too few tests