> Am 12.01.2022 um 22:57 schrieb Ilya Dryomov :
>
> On Wed, Jan 12, 2022 at 9:37 PM Peter Lieven wrote:
>>
>>> Am 12.01.22 um 20:51 schrieb Ilya Dryomov:
>>> On Wed, Jan 12, 2022 at 1:32 PM Peter Lieven wrote:
Am 12.01.22 um 13:22 schrieb Ilya Dryomov:
> On Wed, Jan 12, 2022 at 12:
On Wed, Jan 12, 2022 at 9:37 PM Peter Lieven wrote:
>
> Am 12.01.22 um 20:51 schrieb Ilya Dryomov:
> > On Wed, Jan 12, 2022 at 1:32 PM Peter Lieven wrote:
> >> Am 12.01.22 um 13:22 schrieb Ilya Dryomov:
> >>> On Wed, Jan 12, 2022 at 12:55 PM Peter Lieven wrote:
> Am 12.01.22 um 10:59 schrie
> Am 12.01.2022 um 22:06 schrieb Ilya Dryomov :
>
> On Wed, Jan 12, 2022 at 9:39 PM Peter Lieven wrote:
>>
>>> Am 12.01.22 um 10:05 schrieb Ilya Dryomov:
>>> On Mon, Jan 10, 2022 at 12:42 PM Peter Lieven wrote:
the assumption that we can't hit a hole if we do not diff against a
sn
On Wed, Jan 12, 2022 at 9:39 PM Peter Lieven wrote:
>
> Am 12.01.22 um 10:05 schrieb Ilya Dryomov:
> > On Mon, Jan 10, 2022 at 12:42 PM Peter Lieven wrote:
> >> the assumption that we can't hit a hole if we do not diff against a
> >> snapshot was wrong.
> >>
> >> We can see a hole in an image if
Am 12.01.22 um 10:05 schrieb Ilya Dryomov:
> On Mon, Jan 10, 2022 at 12:42 PM Peter Lieven wrote:
>> the assumption that we can't hit a hole if we do not diff against a snapshot
>> was wrong.
>>
>> We can see a hole in an image if we diff against base if there exists an
>> older snapshot
>> of t
Am 12.01.22 um 20:51 schrieb Ilya Dryomov:
> On Wed, Jan 12, 2022 at 1:32 PM Peter Lieven wrote:
>> Am 12.01.22 um 13:22 schrieb Ilya Dryomov:
>>> On Wed, Jan 12, 2022 at 12:55 PM Peter Lieven wrote:
Am 12.01.22 um 10:59 schrieb Ilya Dryomov:
> On Mon, Jan 10, 2022 at 12:43 PM Peter Liev
Hi Hanna, Kevin:
I think this series is pretty close, it's mostly reviewed by Vladimir
and Beraldo. Only patches 22 and 23 touch iotests, and quite
minimally. Everything appears to test fine on my end, but I don't
wanna sneak any changes past you without an ACK.
(OK, admittedly, patch 22 is a tou
On Wed, Jan 12, 2022 at 8:52 AM Beraldo Leal wrote:
>
> On Mon, Jan 10, 2022 at 06:28:53PM -0500, John Snow wrote:
> > We have a replacement for async QMP, but it doesn't have feature parity
> > yet. For now, then, port the old tool onto the new backend.
> >
> > Signed-off-by: John Snow
> > Revie
Adaptive polling measures the execution time of the polling check plus
handlers called when a polled event becomes ready. Handlers can take a
significant amount of time, making it look like polling was running for
a long time when in fact the event handler was running for a long time.
For example,
Am 02.09.2021 um 11:37 hat Vladimir Sementsov-Ogievskiy geschrieben:
> First, this permission never protected a node from being changed, as
> generic child-replacing functions don't check it.
>
> Second, it's a strange thing: it presents a permission of parent node
> to change its child. But gener
Now that virtio-blk and virtio-scsi are ready, get rid of
the handle_aio_output() callback. It's no longer needed.
Signed-off-by: Stefan Hajnoczi
Reviewed-by: Stefano Garzarella
Message-id: 20211207132336.36627-7-stefa...@redhat.com
Signed-off-by: Stefan Hajnoczi
---
include/hw/virtio/virtio.h
The difference between ->handle_output() and ->handle_aio_output() was
that ->handle_aio_output() returned a bool return value indicating
progress. This was needed by the old polling API but now that the bool
return value is gone, the two functions can be unified.
Signed-off-by: Stefan Hajnoczi
R
The virtqueue host notifier API
virtio_queue_aio_set_host_notifier_handler() polls the virtqueue for new
buffers. AioContext previously required a bool progress return value
indicating whether an event was handled or not. This is no longer
necessary because the AioContext polling API has been split
The following changes since commit 91f5f7a5df1fda8c34677a7c49ee8a4bb5b56a36:
Merge remote-tracking branch
'remotes/lvivier-gitlab/tags/linux-user-for-7.0-pull-request' into staging
(2022-01-12 11:51:47 +)
are available in the Git repository at:
https://gitlab.com/stefanha/qemu.git tags
Prepare virtio_scsi_handle_cmd() to be used by both dataplane and
non-dataplane by making the condition for starting ioeventfd more
specific. This way it won't trigger when dataplane has already been
started.
Signed-off-by: Stefan Hajnoczi
Reviewed-by: Stefano Garzarella
Message-id: 202112071323
The return value of virtio_blk_handle_vq() is no longer used. Get rid of
it. This is a step towards unifying the dataplane and non-dataplane
virtqueue handler functions.
Prepare virtio_blk_handle_output() to be used by both dataplane and
non-dataplane by making the condition for starting ioeventfd
On Tue, Jan 11, 2022 at 09:17:43PM +0100, Philippe Mathieu-Daudé wrote:
> On 1/11/22 20:43, Nir Soffer wrote:
> > NBDRequestData struct has unused QSIMPLEQ_ENTRY filed. It seems that
s/filed/field/
> > this field exists since the first git commit and was never used.
If my git sleuthing is right,
Le 18/12/2021 à 12:19, Philippe Mathieu-Daudé a écrit :
This code is easier to review using the load/store API.
Reviewed-by: Richard Henderson
Signed-off-by: Philippe Mathieu-Daudé
---
v2: Fixed offset in megasas_setup_inquiry (rth)
---
hw/scsi/megasas.c | 17 +++--
1 file chang
On Mon, Jan 10, 2022 at 06:29:09PM -0500, John Snow wrote:
> Now that we are fully switched over to the new QMP library, move it back
> over the old namespace. This is being done primarily so that we may
> upload this package simply as "qemu.qmp" without introducing confusion
> over whether or not
On Mon, Jan 10, 2022 at 06:29:10PM -0500, John Snow wrote:
> This is the last vestige of the "aqmp" moniker surviving in the tree; remove
> it.
>
> Signed-off-by: John Snow
> ---
> python/qemu/qmp/{aqmp_tui.py => qmp_tui.py} | 12 ++--
> python/setup.cfg| 6
On Mon, Jan 10, 2022 at 06:28:53PM -0500, John Snow wrote:
> We have a replacement for async QMP, but it doesn't have feature parity
> yet. For now, then, port the old tool onto the new backend.
>
> Signed-off-by: John Snow
> Reviewed-by: Vladimir Sementsov-Ogievskiy
> ---
> python/qemu/aqmp/le
On Mon, Jan 10, 2022 at 06:28:44PM -0500, John Snow wrote:
> Reported-by: Vladimir Sementsov-Ogievskiy
> Signed-off-by: John Snow
> ---
> python/qemu/aqmp/__init__.py | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/python/qemu/aqmp/__init__.py b/python/qemu/aqmp/__init_
On Mon, Jan 10, 2022 at 06:28:55PM -0500, John Snow wrote:
> Signed-off-by: John Snow
> Reviewed-by: Vladimir Sementsov-Ogievskiy
> Reviewed-by: Beraldo Leal
> ---
> python/README.rst | 2 +-
> python/qemu/{qmp => aqmp}/qmp_shell.py | 0
> python/setup.cfg
On Mon, Jan 10, 2022 at 06:28:54PM -0500, John Snow wrote:
> In order to upload a QMP package to PyPI, I want to remove any scripts
> that I am not 100% confident I want to support upstream, beyond our
> castle walls.
>
> Move most of our QMP utilities into the utils package so we can split
> them
On Mon, Jan 10, 2022 at 06:28:47PM -0500, John Snow wrote:
> Copy the remaining type definitions from QMP into the qemu.aqmp.legacy
> module. Now, users that require the legacy interface don't need to
> import anything else but qemu.aqmp.legacy wrapper.
>
> Signed-off-by: John Snow
> Reviewed-by:
On Mon, Jan 10, 2022 at 06:28:49PM -0500, John Snow wrote:
> This is in preparation for renaming qemu.aqmp to qemu.qmp. I should have
> done this from this from the very beginning, but it's a convenient time
> to make sure this churn is taken care of.
s/this from this from/this from/
--
Beraldo
Am 17.12.2021 um 17:46 hat Vladimir Sementsov-Ogievskiy geschrieben:
> Hi all!
>
> 01: only update test output rebasing on master
> 02: replaced with my proposed solution.
Thanks, applied to the block branch.
Kevin
On Wed, Jan 12, 2022 at 12:55 PM Peter Lieven wrote:
>
> Am 12.01.22 um 10:59 schrieb Ilya Dryomov:
> > On Mon, Jan 10, 2022 at 12:43 PM Peter Lieven wrote:
> >> librbd had a bug until early 2022 that affected all versions of ceph that
> >> supported fast-diff. This bug results in reporting of in
Am 12.01.22 um 10:59 schrieb Ilya Dryomov:
> On Mon, Jan 10, 2022 at 12:43 PM Peter Lieven wrote:
>> librbd had a bug until early 2022 that affected all versions of ceph that
>> supported fast-diff. This bug results in reporting of incorrect offsets
>> if the offset parameter to rbd_diff_iterate2
On Tue, Jan 11, 2022 at 07:32:52PM -0500, John Snow wrote:
> On Tue, Jan 11, 2022 at 6:53 PM John Snow wrote:
> >
> > On Thu, Dec 23, 2021 at 6:08 AM Vladimir Sementsov-Ogievskiy
> > wrote:
> > >
> > > Add possibility to generate trace points for each qmp command.
> > >
> > > We should generate b
On Tue, Jan 11, 2022 at 06:44:58PM -0500, John Snow wrote:
> On Mon, Jan 10, 2022 at 11:06 AM Stefan Hajnoczi wrote:
> >
> > On Thu, Dec 23, 2021 at 12:07:53PM +0100, Vladimir Sementsov-Ogievskiy
> > wrote:
> > > diff --git a/block/trace-events b/block/trace-events
> > > index 549090d453..5be3e39
Am 03.01.2022 um 13:00 hat Hanna Reitz geschrieben:
> With CAP_DAC_OVERRIDE (which e.g. root generally has), permission checks
> will be bypassed when opening files.
>
> 308 in one instance tries to open a read-only file (FUSE export) with
> qemu-io as read/write, and expects this to fail. Howeve
Am 11.01.2022 um 16:36 hat Stefan Hajnoczi geschrieben:
> This series fixes use-after-free bugs when blk->root changes across
> aio_poll().
> For example, a temporary filter node can be removed by a blockjob when a
> drained section begins. If the caller doesn't hold a ref on the BDS then it
> wil
On Mon, Jan 10, 2022 at 12:43 PM Peter Lieven wrote:
>
> librbd had a bug until early 2022 that affected all versions of ceph that
> supported fast-diff. This bug results in reporting of incorrect offsets
> if the offset parameter to rbd_diff_iterate2 is not object aligned.
> Work around this bug
On 11.01.22 19:43, Philippe Mathieu-Daudé wrote:
> In the next commit we will use the dma_addr_t type in the QEMUSGList
> structure. Since currently dma_addr_t is defined after QEMUSGList,
> move the declarations to have dma_addr_t defined first. This is a
> pure code-movement patch.
Oh, that was
On Mon, 10 Jan 2022 at 23:25, John Snow wrote:
>
> The following changes since commit de3f5223fa4cf8bfc5e3fe1fd495ddf468edcdf7:
>
> Merge remote-tracking branch
> 'remotes/vivier/tags/m68k-for-7.0-pull-request' into staging (2022-01-10
> 14:43:03 +)
>
> are available in the Git repository
On 11.01.22 19:43, Philippe Mathieu-Daudé wrote:
> fw_cfg_arch_key_name() stub is only required for sysemu.
>
> Signed-off-by: Philippe Mathieu-Daudé
> ---
> stubs/meson.build | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/stubs/meson.build b/stubs/meson.build
> index
On 11.01.22 19:43, Philippe Mathieu-Daudé wrote:
> From: Philippe Mathieu-Daudé
>
> fw_cfg QOM interface is required by system emulation and
> qemu-storage-daemon. User-mode emulation doesn't need it.
>
> Signed-off-by: Philippe Mathieu-Daudé
> Signed-off-by: Philippe Mathieu-Daudé
> ---
> hw
On Mon, Jan 10, 2022 at 12:42 PM Peter Lieven wrote:
>
> the assumption that we can't hit a hole if we do not diff against a snapshot
> was wrong.
>
> We can see a hole in an image if we diff against base if there exists an
> older snapshot
> of the image and we have discarded blocks in the imag
39 matches
Mail list logo
