Re: [PATCH] block-qdict: Fix -Werror=maybe-uninitialized build failure

2022-03-11 Thread Murilo Opsfelder Araújo
Hi, Markus. On 3/11/22 06:33, Markus Armbruster wrote: Murilo Opsfelder Araujo writes: Building QEMU on Fedora 37 (Rawhide Prerelease) ppc64le failed with the following error: $ ../configure --prefix=/usr/local/qemu-disabletcg --target-list=ppc-softmmu,ppc64-softmmu --disable-tcg --dis

[PATCH v2] block-qdict: Fix -Werror=maybe-uninitialized build failure

2022-03-11 Thread Murilo Opsfelder Araujo
Building QEMU on Fedora 37 (Rawhide Prerelease) ppc64le failed with the following error: $ ../configure --prefix=/usr/local/qemu-disabletcg --target-list=ppc-softmmu,ppc64-softmmu --disable-tcg --disable-linux-user ... $ make -j$(nproc) ... FAILED: libqemuutil.a.p/qobject_bloc

Re: [PATCH] block: Fix BB.root changing across bdrv_next()

2022-03-11 Thread Hanna Reitz
On 01.03.22 18:39, Hanna Reitz wrote: bdrv_next() has no guarantee that its caller has stopped all block graph operations; for example, bdrv_flush_all() does not. The latter can actually provoke such operations, because its bdrv_flush() call, which runs a coroutine (bdrv_co_flush()), may run thi

Re: [PATCH v5 13/15] hw/nvme: Add support for the Virtualization Management command

2022-03-11 Thread Lukasz Maniak
On Wed, Mar 09, 2022 at 01:41:27PM +0100, Łukasz Gieryk wrote: > On Tue, Mar 01, 2022 at 02:07:08PM +0100, Klaus Jensen wrote: > > On Feb 17 18:45, Lukasz Maniak wrote: > > > From: Łukasz Gieryk > > > > > > With the new command one can: > > > - assign flexible resources (queues, interrupts) to p

Re: [PATCH experiment 00/35] stackless coroutine backend

2022-03-11 Thread Daniel P . Berrangé
On Fri, Mar 11, 2022 at 01:04:33PM +0100, Paolo Bonzini wrote: > On 3/11/22 10:27, Stefan Hajnoczi wrote: > > > Not quite voluntarily, but I noticed I had to add one 0 to make them run > > > for > > > a decent amount of time. So yeah, it's much faster than siglongjmp. > > That's a nice first indi

Re: [PATCH experiment 00/35] stackless coroutine backend

2022-03-11 Thread Paolo Bonzini
On 3/11/22 10:27, Stefan Hajnoczi wrote: Not quite voluntarily, but I noticed I had to add one 0 to make them run for a decent amount of time. So yeah, it's much faster than siglongjmp. That's a nice first indication that performance will be good. I guess that deep coroutine_fn stacks could be

Re: [PATCH v2 4/4] util/event-loop-base: Introduce options to set the thread pool size

2022-03-11 Thread Nicolas Saenz Julienne
On Thu, 2022-03-10 at 10:45 +, Stefan Hajnoczi wrote: > On Thu, Mar 03, 2022 at 04:13:07PM +0100, Nicolas Saenz Julienne wrote: > > @@ -537,10 +546,19 @@ > > # 0 means that the engine will use its default > > # (default:0, since 6.1) > > # > > +# @thread-pool-

Re: [PATCH v2 2/4] Introduce event-loop-base abstract class

2022-03-11 Thread Nicolas Saenz Julienne
On Thu, 2022-03-10 at 10:25 +, Stefan Hajnoczi wrote: > On Thu, Mar 03, 2022 at 03:58:20PM +0100, Nicolas Saenz Julienne wrote: > > @@ -2935,13 +2947,6 @@ qemu_syms = custom_target('qemu.syms', output: > > 'qemu.syms', > > capture: true, > >

Re: [PATCH] block-qdict: Fix -Werror=maybe-uninitialized build failure

2022-03-11 Thread Markus Armbruster
Murilo Opsfelder Araujo writes: > Building QEMU on Fedora 37 (Rawhide Prerelease) ppc64le failed with the > following error: > > $ ../configure --prefix=/usr/local/qemu-disabletcg > --target-list=ppc-softmmu,ppc64-softmmu --disable-tcg --disable-linux-user > ... > $ make -j$(nproc) >

Re: [PATCH experiment 00/35] stackless coroutine backend

2022-03-11 Thread Stefan Hajnoczi
On Thu, Mar 10, 2022 at 09:14:07PM +0100, Paolo Bonzini wrote: > On 3/10/22 18:42, Stefan Hajnoczi wrote: > > There are a lot of details to decide on in the translator tool and > > runtime to optimize the code. I think the way the stack frames are > > organized in this patch series is probably for