On Fri, Mar 18, 2022 at 2:50 PM Thomas Huth wrote:
>
> On 10/03/2022 18.53, Jon Maloy wrote:
> >
> > On 3/10/22 12:14, Thomas Huth wrote:
> >> On 06/02/2022 20.19, Jon Maloy wrote:
> >>> Trying again with correct email address.
> >>> ///jon
> >>>
> >>> On 2/6/22 14:15, Jon Maloy wrote:
>
>
On Wed, Mar 16, 2022 at 5:18 PM Eric Blake wrote:
>
> On Tue, Mar 15, 2022 at 12:32:24AM +0300, Vladimir Sementsov-Ogievskiy wrote:
> > From: Vladimir Sementsov-Ogievskiy
> >
> > Rename the type to be reused. Old name is "what is it for". To be
> > natively reused for other needs, let's name it
On Mon, 21 Mar 2022 at 17:03, Thomas Huth wrote:
>
> The following changes since commit 2058fdbe81e2985c226a026851dd26b146d3395c:
>
> Merge tag 'fixes-20220318-pull-request' of git://git.kraxel.org/qemu into
> staging (2022-03-19 11:28:54 +)
>
> are available in the Git repository at:
>
>
On Tue, Mar 22, 2022 at 12:39 PM Hanna Reitz wrote:
>
> On 18.03.22 21:36, John Snow wrote:
> > I know we just added it, sorry. This is done in favor of qemu_io() which
> > *also* returns the console output and status, but with more robust error
> > handling on failure.
> >
> > Signed-off-by:
Quite a few of these tests have stale contact information. This patch
updates the stale ones that I happen to be aware of at the moment.
Signed-off-by: John Snow
---
tests/qemu-iotests/025 | 2 +-
tests/qemu-iotests/027 | 2 +-
tests/qemu-iotests/028 | 2 +-
tests/qemu-iotests/036 | 2 +-
On Mar 15 15:41, Markus Armbruster wrote:
> g_new(T, n) is neater than g_malloc(sizeof(T) * n). It's also safer,
> for two reasons. One, it catches multiplication overflowing size_t.
> Two, it returns T * rather than void *, which lets the compiler catch
> more type errors.
>
> This commit only
On 18.03.22 21:36, John Snow wrote:
Howdy,
Heya,
[...]
- Uh, actually, test 040 fails with this patchset and I don't understand
if it's intentional, harmless, a test design problem, or worse:
==
ERROR:
On Tue, Mar 22, 2022 at 1:00 PM Hanna Reitz wrote:
>
> On 18.03.22 21:36, John Snow wrote:
> > Like qemu-img, qemu-io returning 0 should be the norm and not the
> > exception. Remove all calls to qemu_io_silent that just assert the
> > return code is zero (That's every last call, as it turns
On 22.03.22 17:19, John Snow wrote:
On Tue, Mar 22, 2022, 10:22 AM Hanna Reitz wrote:
On 18.03.22 21:36, John Snow wrote:
> qemu-io fails on read/write with zero-length raw images, so skip
these
> when running the zero-length image tests.
>
> Signed-off-by: John Snow
On Tue, Mar 22, 2022 at 12:37 PM Hanna Reitz wrote:
>
> On 18.03.22 21:36, John Snow wrote:
> > Modify this test to use assertRaises for its negative testing of
> > qemu_io. If the exception raised does not match the one we tell it to
> > expect, we get *that* exception unhandled. If we get no
On 18.03.22 21:36, John Snow wrote:
Just like qemu_img_log(), upgrade qemu_io_log() to enforce a return code
of zero by default.
Affected tests: 242 245 255 274 303 307 nbd-reconnect-on-open
Signed-off-by: John Snow
---
tests/qemu-iotests/iotests.py | 5 +++--
On Tue, 22 Mar 2022 at 11:56, Hanna Reitz wrote:
>
> The following changes since commit 330724977b10f5b92610817e8b7d1dfed122df87:
>
> Merge tag 'pull-misc-2022-03-21' of git://repo.or.cz/qemu/armbru into
> staging (2022-03-21 17:46:40 +)
>
> are available in the Git repository at:
>
>
On 18.03.22 21:36, John Snow wrote:
Like qemu-img, qemu-io returning 0 should be the norm and not the
exception. Remove all calls to qemu_io_silent that just assert the
return code is zero (That's every last call, as it turns out), and
replace them with a normal qemu_io() call.
Signed-off-by:
On Fri, Mar 18, 2022 at 4:37 PM John Snow wrote:
>
> (Merge with prior patch.)
>
> Signed-off-by: John Snow
> ---
> tests/qemu-iotests/242 | 2 +-
^ Oh, there's the stray import changes that needed to be folded into
patch #1. Fixed for v2.
On 18.03.22 21:36, John Snow wrote:
I know we just added it, sorry. This is done in favor of qemu_io() which
*also* returns the console output and status, but with more robust error
handling on failure.
Signed-off-by: John Snow
---
tests/qemu-iotests/iotests.py | 3 ---
On 18.03.22 21:36, John Snow wrote:
Modify this test to use assertRaises for its negative testing of
qemu_io. If the exception raised does not match the one we tell it to
expect, we get *that* exception unhandled. If we get no exception, we
get a unittest assertion failure and the provided emsg
On 22.03.22 17:36, John Snow wrote:
On Tue, Mar 22, 2022, 12:30 PM Hanna Reitz wrote:
On 18.03.22 21:36, John Snow wrote:
> (Merge with prior patch.)
>
> Signed-off-by: John Snow
> ---
> tests/qemu-iotests/242 | 2 +-
> tests/qemu-iotests/245 | 2 +-
> 2
On Tue, Mar 22, 2022, 12:30 PM Hanna Reitz wrote:
> On 18.03.22 21:36, John Snow wrote:
> > (Merge with prior patch.)
> >
> > Signed-off-by: John Snow
> > ---
> > tests/qemu-iotests/242 | 2 +-
> > tests/qemu-iotests/245 | 2 +-
> > 2 files changed, 2 insertions(+), 2 deletions(-)
> >
> >
On Tue, Mar 22, 2022, 11:04 AM Hanna Reitz wrote:
> On 18.03.22 21:36, John Snow wrote:
> > Rework qemu_io() to be analogous to qemu_img(); a function that requires
> > a return code of zero by default unless disabled explicitly.
> >
> > Tests that use qemu_io():
> > 030 040 041 044 055 056 093
On 18.03.22 21:36, John Snow wrote:
(Merge with prior patch.)
Signed-off-by: John Snow
---
tests/qemu-iotests/242 | 2 +-
tests/qemu-iotests/245 | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/tests/qemu-iotests/242 b/tests/qemu-iotests/242
index
On 18.03.22 21:36, John Snow wrote:
(Merge into prior patch.)
Notes: I don't quite like this change, but I'm at a loss for what would
be cleaner. This is a funky test.
Signed-off-by: John Snow
---
tests/qemu-iotests/149 | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
I mean,
On Tue, Mar 22, 2022, 10:49 AM Hanna Reitz wrote:
> On 18.03.22 21:36, John Snow wrote:
> > reimplement qemu_img() in terms of qemu_tool() in preparation for doing
> > the same with qemu_io().
> >
> > Signed-off-by: John Snow
> > ---
> > tests/qemu-iotests/iotests.py | 37
On Tue, Mar 22, 2022, 10:22 AM Hanna Reitz wrote:
> On 18.03.22 21:36, John Snow wrote:
> > qemu-io fails on read/write with zero-length raw images, so skip these
> > when running the zero-length image tests.
> >
> > Signed-off-by: John Snow
> > ---
> > tests/qemu-iotests/040 | 14
On Tue, Dec 07, 2021 at 06:14:23PM +0200, Wouter Verhelst wrote:
> On Mon, Dec 06, 2021 at 05:00:47PM -0600, Eric Blake wrote:
> > On Mon, Dec 06, 2021 at 02:40:45PM +0300, Vladimir Sementsov-Ogievskiy
> > wrote:
> > > > Simple reply message
> > > >
> > > > The simple reply message MUST
On 18.03.22 21:36, John Snow wrote:
Rework qemu_io() to be analogous to qemu_img(); a function that requires
a return code of zero by default unless disabled explicitly.
Tests that use qemu_io():
030 040 041 044 055 056 093 124 129 132 136 148 149 151 152 163 165 205
209 219 236 245 248 254 255
On Mon, Mar 21, 2022 at 11:29:42AM +0100, Lukáš Doktor wrote:
> Hello Stefan,
>
> Dne 21. 03. 22 v 10:42 Stefan Hajnoczi napsal(a):
> > On Mon, Mar 21, 2022 at 09:46:12AM +0100, Lukáš Doktor wrote:
> >> Dear qemu developers,
> >>
> >> you might remember the "replied to" email from a bit over year
On 18.03.22 21:36, John Snow wrote:
reimplement qemu_img() in terms of qemu_tool() in preparation for doing
the same with qemu_io().
Signed-off-by: John Snow
---
tests/qemu-iotests/iotests.py | 37 +++
1 file changed, 24 insertions(+), 13 deletions(-)
diff
On 18.03.22 21:36, John Snow wrote:
qemu-io fails on read/write with zero-length raw images, so skip these
when running the zero-length image tests.
Signed-off-by: John Snow
---
tests/qemu-iotests/040 | 14 --
1 file changed, 12 insertions(+), 2 deletions(-)
Doesn’t look
On 18.03.22 21:36, John Snow wrote:
A forthcoming commit updates qemu_io() to raise an exception on non-zero
return by default, and changes its return type.
In preparation, simplify some calls to qemu_io() that assert that
specific error message strings do not appear in qemu-io's
output.
On 18.03.22 21:36, John Snow wrote:
The 'read' commands to qemu-io were malformed, and this invocation only
worked by coincidence because the error messages were identical. Oops.
There's no point in checking the patterning of the reference image, so
just check the empty image by itself instead.
On 18.03.22 21:36, John Snow wrote:
This makes these callsites a little simpler, but the real motivation is
a forthcoming commit will change the return type of qemu_io(), so removing
users of the return value now is helpful.
Signed-off-by: John Snow
---
tests/qemu-iotests/242 | 2 +-
On Tue, Mar 15, 2022 at 03:41:53PM +0100, Markus Armbruster wrote:
> g_new(T, n) is neater than g_malloc(sizeof(T) * n). It's also safer,
> for two reasons. One, it catches multiplication overflowing size_t.
> Two, it returns T * rather than void *, which lets the compiler catch
> more type
Allow filters for VM.run_job(), and pass the filters given to
VM.blockdev_create() to it.
(Use this opportunity to annotate VM.run_job()'s parameter types;
unfortunately, for the filter, I could not come up with anything better
than Callable[[Any], Any] that would pass mypy's scrutiny.)
At one
From: John Snow
Add a `check: bool = True` parameter to both functions and make their
qemu_img() invocations raise on error by default.
users of img_info_log:
206, 207, 210, 211, 212, 213, 237, 242, 266, 274, 302
users of qemu_img_log:
044, 209, 274, 302, 304
iotests 242 and 266 need to use
From: John Snow
Admittedly a mostly lateral move, but qemu_img() is essentially the
replacement for qemu_img_pipe_and_status(). It will give slightly better
diagnostics on crash.
Signed-off-by: John Snow
Reviewed-by: Hanna Reitz
Message-Id: <20220321201618.903471-16-js...@redhat.com>
From: John Snow
This removes two more usages of qemu_img_pipe() and replaces them with
calls to qemu_img(), which provides better diagnostic information on
failure.
Signed-off-by: John Snow
Reviewed-by: Hanna Reitz
Message-Id: <20220321201618.903471-10-js...@redhat.com>
Signed-off-by: Hanna
Commit e3296cc796aeaf319f3ed4e064ec309baf5e4da4 made the ssh block
driver's error message for fingerprint mismatches more verbose, so it
now prints the actual host key fingerprint and the key type.
iotest 207 tests such errors, but was not amended to filter that
fingerprint (which is
From: John Snow
Add a qemu_img_map() function by analogy with qemu_img_measure(),
qemu_img_check(), and qemu_img_info() that all return JSON information.
Replace calls to qemu_img_pipe('map', '--output=json', ...) with this
new function, which provides better diagnostic information on failure.
From: John Snow
With the exceptional 'create' calls removed in the prior commit, change
qemu_img_log() and img_info_log() to call qemu_img() directly
instead.
For now, allow these calls to qemu-img to return non-zero on the basis
that any unusual output will be logged anyway. The very next
From: John Snow
As part of moving all python iotest invocations of qemu-img onto a
single qemu_img() implementation, remove a few lingering uses of
qemu_img_pipe() from outside of iotests.py itself.
Several cases here rely on the knowledge that qemu_img_pipe() suppresses
*all* output on a
From: John Snow
qemu_img_log() calls into qemu_img_pipe(), which always removes output
for 'create' commands on success anyway. Replace all of these calls to
the simpler qemu_img_create(...) which doesn't log, but raises a
detailed exception object on failure instead.
Blank lines are removed
From: John Snow
qemu_img_json() is a new helper built on top of qemu_img() that tries to
pull a valid JSON document out of the stdout stream.
In the event that the return code is negative (the program crashed), or
the code is greater than zero and did not produce valid JSON output, the
From: John Snow
re-write qemu_img() as a function that will by default raise a
VerboseProcessException (extended from CalledProcessException) on
non-zero return codes. This will produce a stack trace that will show
the command line arguments and return code from the failed process run.
Users
From: John Snow
qemu_img_pipe calls blank their output when the command being run is a
'create' call and the command succeeds. Thus, the normative output for
this command in iotest 149 is to print a blank line. We can remove the
logging from this invocation and use a checked invocation, but we
From: John Snow
qemu_img_pipe() discards the return code from qemu-img in favor of
returning just its output. Some tests using this function don't save,
log, or check the output either, though, which is unsafe.
Replace all of these calls with a checked version.
Tests affected are 194, 202,
From: John Snow
This adds an Exception that extends the Python stdlib
subprocess.CalledProcessError.
The difference is that the str() method of this exception also adds the
stdout/stderr logs. In effect, if this exception goes unhandled, Python
will print the output in a visually distinct
From: John Snow
Fortify compare_images() to be more discerning about the status codes it
receives. If qemu_img() returns an exit code that implies it didn't
actually perform the comparison, treat that as an exceptional
circumstance and force the caller to be aware of the peril.
If a negative
From: John Snow
Similar to other recent changes: use the qemu_img() invocation that
supports throwing loud, nasty exceptions when it fails for surprising
reasons.
(Why would "--help" ever fail? I don't know, but eliminating *all* calls
to qemu-img that do not go through qemu_img() is my goal,
From: John Snow
Add qemu_img_info() by analogy with qemu_img_measure() and
qemu_img_check(). Modify image_size() to use this function instead to
take advantage of the better diagnostic information on failure provided
(ultimately) by qemu_img().
Signed-off-by: John Snow
Reviewed-by: Hanna Reitz
From: John Snow
qemu_img() returning zero ought to be the rule, not the
exception. Remove all explicit checks against the condition in
preparation for making non-zero returns an Exception.
Signed-off-by: John Snow
Reviewed-by: Eric Blake
Reviewed-by: Hanna Reitz
Message-Id:
From: John Snow
qemu_img_json() gives better diagnostic information on failure.
Signed-off-by: John Snow
Reviewed-by: Hanna Reitz
Message-Id: <20220321201618.903471-8-js...@redhat.com>
Signed-off-by: Hanna Reitz
---
tests/qemu-iotests/iotests.py | 8
1 file changed, 4
From: John Snow
>>> print(add_visual_margin(msg, width=72, name="Commit Message"))
┏━ Commit Message ━━
┃ add_visual_margin() takes a chunk of text and wraps it in a visual
┃ container that force-wraps to a specified width. An optional title
┃
From: Thomas Huth
If there is a failing iotest, the output is currently not logged to
the console anymore. To get this working again, we need to run the
meson test runner with "--print-errorlogs" (and without "--verbose"
due to a current meson bug that will be fixed here:
From: Thomas Huth
Quoting the TAP specification: "The plan tells how many tests will be
run [...]. It’s a check that the test file hasn’t stopped prematurely."
That's a good idea of course, so let's support that in the iotest
testrunner, too.
Signed-off-by: Thomas Huth
Message-Id:
From: Stefano Garzarella
Commit d24f80234b ("block/rbd: increase dynamically the image size")
added a workaround to support growing images (eg. qcow2), resizing
the image before write operations that exceed the current size.
We recently added support for write zeroes and without the
workaround
From: Thomas Huth
These two spots have been missed in commit 9086c7639822 ("Rework the
checks and spots using GNU sed") - they need GNU sed, too, since they
are using the "+" address form.
Signed-off-by: Thomas Huth
Message-Id: <20220309101626.637836-1-th...@redhat.com>
Reviewed-by: Eric Blake
From: laokz
Some qemu-iotests(040 etc) use PCI disk to do test. Without the
mapping, RISC-V flavor use spike as default machine which has no
PCI bus, causing test failure.
Resolves: https://gitlab.com/qemu-project/qemu/-/issues/894
Signed-off-by: Kai Zhang
Message-Id:
Reviewed-by: Alistair
The following changes since commit 330724977b10f5b92610817e8b7d1dfed122df87:
Merge tag 'pull-misc-2022-03-21' of git://repo.or.cz/qemu/armbru into staging
(2022-03-21 17:46:40 +)
are available in the Git repository at:
https://gitlab.com/hreitz/qemu.git tags/pull-block-2022-03-22
for
On Tue, 15 Mar 2022 15:41:56 +0100
Markus Armbruster wrote:
> g_new(T, n) is neater than g_malloc(sizeof(T) * n). It's also safer,
> for two reasons. One, it catches multiplication overflowing size_t.
> Two, it returns T * rather than void *, which lets the compiler catch
> more type errors.
>
22.03.2022 12:48, Hanna Reitz wrote:
Ping
On 02.03.22 13:45, Hanna Reitz wrote:
Hi,
v1 cover letter:
https://lists.nongnu.org/archive/html/qemu-devel/2022-02/msg04592.html
We have two tests (as far as I know) that use compression_type=zstd for
qcow2 but do not check whether that is actually
On 02/03/2022 13.45, Hanna Reitz wrote:
Hi,
v1 cover letter:
https://lists.nongnu.org/archive/html/qemu-devel/2022-02/msg04592.html
We have two tests (as far as I know) that use compression_type=zstd for
qcow2 but do not check whether that is actually supported. Thomas
reported this for 065,
Ping
On 02.03.22 13:45, Hanna Reitz wrote:
Hi,
v1 cover letter:
https://lists.nongnu.org/archive/html/qemu-devel/2022-02/msg04592.html
We have two tests (as far as I know) that use compression_type=zstd for
qcow2 but do not check whether that is actually supported. Thomas
reported this for
On 18.03.22 13:53, Hanna Reitz wrote:
Hi,
Commit e3296cc796aeaf (“block: print the server key type and fingerprint
on failure”) improved the verbosity of our ssh block driver's error
messages for fingerprint mismatches. However, iotest 207, which tests
such errors, has not been adjusted
On 21.03.22 21:16, John Snow wrote:
V5 hotfix:
- Quote the subprocess.CompletedProcess[str] type annotations,
Python 3.6 chokes on them at runtime :(
- Reduce line length in the text decoration fn,
even though check-patch still doesn't like it.
- Reflow docstring for qemu_img.*
V5
On 21.03.22 09:31, Stefano Garzarella wrote:
On Sat, Mar 19, 2022 at 04:15:33PM +0100, Peter Lieven wrote:
Am 18.03.2022 um 17:47 schrieb Stefano Garzarella
:
On Fri, Mar 18, 2022 at 04:48:18PM +0100, Peter Lieven wrote:
Am 18.03.2022 um 09:25 schrieb Stefano Garzarella
:
On Thu,
On Mar 21 13:36, Lukasz Maniak wrote:
> On Tue, Mar 01, 2022 at 01:23:18PM +0100, Klaus Jensen wrote:
> > On Feb 17 18:45, Lukasz Maniak wrote:
> > > Signed-off-by: Lukasz Maniak
> >
> > Please add a short commit description as well. Otherwise,
>
> Klaus,
>
> Sorry I forgot to add the
66 matches
Mail list logo
