[PATCH 3/3] iotests: add backup-discard-source

2022-03-31 Thread Vladimir Sementsov-Ogievskiy
Add test for a new backup option: discard-source. Signed-off-by: Vladimir Sementsov-Ogievskiy --- .../qemu-iotests/tests/backup-discard-source | 154 ++ .../tests/backup-discard-source.out | 5 + 2 files changed, 159 insertions(+) create mode 100755

[PATCH 0/3] backup: discard-source parameter

2022-03-31 Thread Vladimir Sementsov-Ogievskiy
Hi all! Here is a new option for backup, that brings two things into push-backup-with-fleecing scheme: - discard copied region in temporary image to save disk space - avoid extra copy-before-write operation in the region that is already copied This is based on "[PATCH v5 00/45]

[PATCH 2/3] qapi: blockdev-backup: add discard-source parameter

2022-03-31 Thread Vladimir Sementsov-Ogievskiy
Add a parameter that enables discard-after-copy. That is mostly useful in "push backup with fleecing" scheme, when source is snapshot-access format driver node, based on copy-before-write filter snapshot-access API: [guest] [snapshot-access] ~~ blockdev-backup ~~> [backup target] |

[PATCH 1/3] block/copy-before-write: create block_copy bitmap in filter node

2022-03-31 Thread Vladimir Sementsov-Ogievskiy
Currently block_copy creates copy_bitmap in source node. But that is in bad relation with .independent_close=true of copy-before-write filter: source node may be detached and removed before .bdrv_close() handler called, which should call block_copy_state_free(), which in turn should remove

Re: [RFC PATCH 0/5] Removal of AioContext lock, bs->parents and ->children: proof of concept

2022-03-31 Thread Paolo Bonzini
On 3/31/22 15:51, Emanuele Giuseppe Esposito wrote: bdrv_graph_list_wrlock <-> start_exclusive bdrv_graph_list_wrunlock <-> end_exclusive bdrv_graph_list_rdlock <-> cpu_exec_start bdrv_graph_list_rdunlock <-> cpu_exec_end This wouldn't protect the list but the whole graph, i.e. the parents

Re: [PATCH v2 05/17] iotests/040: Fix TestCommitWithFilters test

2022-03-31 Thread John Snow
On Thu, Mar 24, 2022 at 9:33 PM Eric Blake wrote: > > On Thu, Mar 24, 2022 at 02:30:06PM -0400, John Snow wrote: > > Without this change, asserting that qemu_io always returns 0 causes this > > test to fail in a way we happened not to be catching previously: > > > >

Re: [PATCH] hw/vhost-user-blk: fix ioeventfd add failed when start reenter

2022-03-31 Thread Raphael Norwitz
High level looks good but I have some questions. Rather than a new boolean I'd rather we re-used started_vu by changing it to an enum and having different values for starting and started. On Tue, Mar 29, 2022 at 12:15:46AM +0800, Jie Wang wrote: > During Virtio1.0 dev(start_on_kick) in

Re: [RFC PATCH 0/5] Removal of AioContext lock, bs->parents and ->children: proof of concept

2022-03-31 Thread Emanuele Giuseppe Esposito
Am 31/03/2022 um 11:59 schrieb Paolo Bonzini: > On 3/30/22 18:02, Paolo Bonzini wrote: >> On 3/30/22 12:53, Hanna Reitz wrote: Seems a good compromise between drains and rwlock. What do you think? >>> >>> Well, sounds complicated.  So I’m asking myself whether this would be >>>

Re: [PATCH v7 12/12] hw/acpi: Make the PCI hot-plug aware of SR-IOV

2022-03-31 Thread Igor Mammedov
On Fri, 18 Mar 2022 20:18:19 +0100 Lukasz Maniak wrote: > From: Łukasz Gieryk > > PCI device capable of SR-IOV support is a new, still-experimental > feature with only a single working example of the Nvme device. > > This patch in an attempt to fix a double-free problem when a >

Re: [PATCH experiment 00/16] C++20 coroutine backend

2022-03-31 Thread Markus Armbruster
Daniel P. Berrangé writes: > On Tue, Mar 15, 2022 at 03:50:26PM +0100, Kevin Wolf wrote: [...] >> ...using C++ in coroutine code means that all of the block layer would >> suddenly become C++ and would be most affected by this effect. I'm not >> sure if that's something I would like to see, at

Re: [PATCH experiment 00/16] C++20 coroutine backend

2022-03-31 Thread Markus Armbruster
Hanna Reitz writes: > On 17.03.22 16:11, Paolo Bonzini wrote: >> On 3/16/22 13:32, Stefan Hajnoczi wrote: >>> You can define rules and a way to enforce a subset of C++, but I think >>> over time the code will be C++. A policy that is complicated discourages >>> contributors. >>> >>> For these

Re: qemu iotest 161 and make check

2022-03-31 Thread Li Zhang
On 3/31/22 09:44, Christian Borntraeger wrote: Am 21.02.22 um 11:27 schrieb Christian Borntraeger: Am 10.02.22 um 18:44 schrieb Vladimir Sementsov-Ogievskiy: 10.02.2022 20:13, Thomas Huth wrote: On 10/02/2022 15.51, Christian Borntraeger wrote: Am 10.02.22 um 15:47 schrieb Vladimir

Re: [RFC PATCH 0/5] Removal of AioContext lock, bs->parents and ->children: proof of concept

2022-03-31 Thread Paolo Bonzini
On 3/30/22 18:02, Paolo Bonzini wrote: On 3/30/22 12:53, Hanna Reitz wrote: Seems a good compromise between drains and rwlock. What do you think? Well, sounds complicated.  So I’m asking myself whether this would be noticeably better than just an RwLock for graph modifications, like the

Re: qemu iotest 161 and make check

2022-03-31 Thread Christian Borntraeger
Am 31.03.22 um 09:44 schrieb Christian Borntraeger: Am 21.02.22 um 11:27 schrieb Christian Borntraeger: Am 10.02.22 um 18:44 schrieb Vladimir Sementsov-Ogievskiy: 10.02.2022 20:13, Thomas Huth wrote: On 10/02/2022 15.51, Christian Borntraeger wrote: Am 10.02.22 um 15:47 schrieb

Re: qemu iotest 161 and make check

2022-03-31 Thread Christian Borntraeger
Am 21.02.22 um 11:27 schrieb Christian Borntraeger: Am 10.02.22 um 18:44 schrieb Vladimir Sementsov-Ogievskiy: 10.02.2022 20:13, Thomas Huth wrote: On 10/02/2022 15.51, Christian Borntraeger wrote: Am 10.02.22 um 15:47 schrieb Vladimir Sementsov-Ogievskiy: 10.02.2022 10:57, Christian