On Thu, May 5, 2022 at 12:55 PM Daniel P. Berrangé wrote:
>
> On Thu, May 05, 2022 at 12:42:47PM -0300, Leonardo Bras Soares Passos wrote:
> >
> > Hello Daniel,
> >
> > But what if this gets compiled in a Linux system without MSG_ZEROCOPY
> > support?
> > As qapi will have zero-copy-send as an
On 5/5/22 03:42, Stefan Hajnoczi wrote:
The following changes since commit 9cf289af47bcfae5c75de37d8e5d6fd23705322c:
Merge tag 'qga-pull-request' of gitlab.com:marcandre.lureau/qemu into
staging (2022-05-04 03:42:49 -0700)
are available in the Git repository at:
On Thu, May 05, 2022 at 05:50:00PM +0200, Paolo Bonzini wrote:
> On 5/5/22 16:13, John Snow wrote:
> >
> > I would rather keep python/qemu/qmp as a submodule for a longer time,
> > and still go through a virtual environment that installs it together
> > with its pip dependencies.
> >
On Thu, May 05, 2022 at 12:42:47PM -0300, Leonardo Bras Soares Passos wrote:
>
> Hello Daniel,
>
> But what if this gets compiled in a Linux system without MSG_ZEROCOPY support?
> As qapi will have zero-copy-send as an option we could have this scenario:
>
> - User request migration using
On 5/5/22 16:13, John Snow wrote:
I would rather keep python/qemu/qmp as a submodule for a longer time,
and still go through a virtual environment that installs it together
with its pip dependencies.
A small headache relating fixes to both locations, but if you'd like to
see it
On Thu, May 5, 2022 at 5:05 AM Daniel P. Berrangé wrote:
>
> On Wed, May 04, 2022 at 04:18:31PM -0300, Leonardo Bras wrote:
> > For CONFIG_LINUX, implement the new zero copy flag and the optional callback
> > io_flush on QIOChannelSocket, but enables it only when MSG_ZEROCOPY
> > feature is
Reviewed-by: Konstantin Kostiuk
On Thu, May 5, 2022 at 11:16 AM wrote:
> From: Marc-André Lureau
>
> Use more conventional variables to set the location of pre-built
> DLL/bin.
>
> Signed-off-by: Marc-André Lureau
> ---
> configure | 9 ++---
> meson.build
Reviewed-by: Konstantin Kostiuk
On Thu, May 5, 2022 at 11:16 AM wrote:
> From: Marc-André Lureau
>
> Sadly, wixl doesn't have 'elif'.
>
> Signed-off-by: Marc-André Lureau
> ---
> qga/installer/qemu-ga.wxs | 20 +++-
> 1 file changed, 7 insertions(+), 13 deletions(-)
>
> diff
Reviewed-by: Konstantin Kostiuk
On Thu, May 5, 2022 at 11:16 AM wrote:
> From: Marc-André Lureau
>
> No clear reason to make guesses here.
>
> Signed-off-by: Marc-André Lureau
> ---
> qga/installer/qemu-ga.wxs | 9 -
> 1 file changed, 9 deletions(-)
>
> diff --git
On Thu, May 5, 2022, 9:16 AM Paolo Bonzini wrote:
> On 5/5/22 15:10, John Snow wrote:
> >
> > > Hm, do we need iotests during an rpm build? Is it because of
> > "make check"?
> >
> > Yes, and this is good, because it prevents us from outputting an
> > RPM build that has a broken
Reviewed-by: Konstantin Kostiuk
On Thu, May 5, 2022 at 11:16 AM wrote:
> From: Marc-André Lureau
>
> No need to setup an environment or to check if the variable is undefined
> manually.
>
> Signed-off-by: Marc-André Lureau
> ---
> qga/installer/qemu-ga.wxs | 30
Marc-André Lureau writes:
> Hi
>
> On Thu, May 5, 2022 at 3:47 PM Markus Armbruster wrote:
>>
>> marcandre.lur...@redhat.com writes:
>>
>> > From: Marc-André Lureau
>> >
>> > Signed-off-by: Marc-André Lureau
>> > ---
>> > tests/unit/test-qga.c | 125 +++---
On 5/5/22 15:10, John Snow wrote:
> Hm, do we need iotests during an rpm build? Is it because of
"make check"?
Yes, and this is good, because it prevents us from outputting an
RPM build that has a broken QEMU in it.
Guess this means I need to make a Fedora package too,
On Thu, May 5, 2022, 8:33 AM Daniel P. Berrangé wrote:
> On Thu, May 05, 2022 at 08:08:42AM -0400, John Snow wrote:
> > On Thu, May 5, 2022, 4:09 AM Daniel P. Berrangé
> wrote:
> >
> > > On Wed, May 04, 2022 at 03:38:45PM -0400, John Snow wrote:
> > > > Howdy!
> > > >
> > > > So, I want to
On 5/4/22 09:25, Kevin Wolf wrote:
The following changes since commit 2e3408b3cc7de4e87a9adafc8c19bfce3abec947:
Merge tag 'misc-pull-request' of gitlab.com:marcandre.lureau/qemu into
staging (2022-05-03 09:13:17 -0700)
are available in the Git repository at:
On Thu, May 05, 2022 at 01:20:04AM -0300, Leonardo Bras Soares Passos wrote:
> (2) is already implemented in v11, but I have no issue implementing
> (1) for v12 if it's ok to create this 'global' define.
Dan's suggestion in the other thread sounds good to me with current
approach, on having
Am 05.05.2022 um 14:24 hat Paolo Bonzini geschrieben:
> On 5/5/22 12:59, Kevin Wolf wrote:
> > Am 05.05.2022 um 11:28 hat Paolo Bonzini geschrieben:
> > > > Or actually, it could just unconditionally run 'make check-venv' by
> > > > itself, which is probably easier to implement than checking the
>
On Thu, May 05, 2022 at 08:08:42AM -0400, John Snow wrote:
> On Thu, May 5, 2022, 4:09 AM Daniel P. Berrangé wrote:
>
> > On Wed, May 04, 2022 at 03:38:45PM -0400, John Snow wrote:
> > > Howdy!
> > >
> > > So, I want to finally delete python/qemu/qmp from qemu.git, and this
> > > creates a small
On 5/5/22 12:59, Kevin Wolf wrote:
Am 05.05.2022 um 11:28 hat Paolo Bonzini geschrieben:
Or actually, it could just unconditionally run 'make check-venv' by
itself, which is probably easier to implement than checking the
dependencies and more convenient for the user, too.
One small
On Thu, May 5, 2022, 4:09 AM Daniel P. Berrangé wrote:
> On Wed, May 04, 2022 at 03:38:45PM -0400, John Snow wrote:
> > Howdy!
> >
> > So, I want to finally delete python/qemu/qmp from qemu.git, and this
> > creates a small problem -- namely, iotests needs access to it in order
> > to run the
On Thu, May 5, 2022, 4:51 AM Kevin Wolf wrote:
> Am 04.05.2022 um 21:38 hat John Snow geschrieben:
> > Howdy!
> >
> > So, I want to finally delete python/qemu/qmp from qemu.git, and this
> > creates a small problem -- namely, iotests needs access to it in order
> > to run the python-based tests.
Hi
On Thu, May 5, 2022 at 3:43 PM Markus Armbruster wrote:
> marcandre.lur...@redhat.com writes:
>
> > From: Marc-André Lureau
> >
> > qemu_open_old() uses qemu_open_internal() which handles special
> > "/dev/fdset/" path for monitor fd sets, set CLOEXEC, and uses Error
> > reporting (and some
Peter Maydell writes:
> The sysbus floppy controllers (devices sysbus-fdc and sun-fdtwo)
> don't support DMA. The core floppy controller code expects this to
> be indicated by setting FDCtrl::dma_chann to -1. This used to be
> done in the device instance_init functions sysbus_fdc_initfn() and
Hi
On Thu, May 5, 2022 at 3:47 PM Markus Armbruster wrote:
>
> marcandre.lur...@redhat.com writes:
>
> > From: Marc-André Lureau
> >
> > Signed-off-by: Marc-André Lureau
> > ---
> > tests/unit/test-qga.c | 125 +++---
> > 1 file changed, 45 insertions(+),
marcandre.lur...@redhat.com writes:
> From: Marc-André Lureau
>
> Signed-off-by: Marc-André Lureau
> ---
> tests/unit/test-qga.c | 125 +++---
> 1 file changed, 45 insertions(+), 80 deletions(-)
>
> diff --git a/tests/unit/test-qga.c b/tests/unit/test-qga.c
Hi
On Thu, May 5, 2022 at 3:41 PM Markus Armbruster wrote:
> marcandre.lur...@redhat.com writes:
>
> > From: Marc-André Lureau
> >
> > Allow for a single point of error reporting, and further refactoring.
>
> This sounds like there is no behavioral change intended. But it looks
> like there
marcandre.lur...@redhat.com writes:
> From: Marc-André Lureau
>
> qemu_open_old() uses qemu_open_internal() which handles special
> "/dev/fdset/" path for monitor fd sets, set CLOEXEC, and uses Error
> reporting (and some O_DIRECT special error casing).
>
> The monitor fdset handling is
marcandre.lur...@redhat.com writes:
> From: Marc-André Lureau
>
> Allow for a single point of error reporting, and further refactoring.
This sounds like there is no behavioral change intended. But it looks
like there is change; see below.
> Signed-off-by: Marc-André Lureau
> ---
>
marcandre.lur...@redhat.com writes:
> From: Marc-André Lureau
>
> The function takes care of setting CLOEXEC, and reporting error.
>
> Signed-off-by: Marc-André Lureau
> ---
> qga/commands-posix.c | 11 +++
> 1 file changed, 3 insertions(+), 8 deletions(-)
>
> diff --git
Hi
On Thu, May 5, 2022 at 3:20 PM Markus Armbruster wrote:
> marcandre.lur...@redhat.com writes:
>
> > From: Marc-André Lureau
> >
> > There is a bit too much branching in the function, this can be
> > simplified a bit, and have a common exit point thanks to ERRP_PROPAGATE.
>
> Do you mean
marcandre.lur...@redhat.com writes:
> From: Marc-André Lureau
>
> There is a bit too much branching in the function, this can be
> simplified a bit, and have a common exit point thanks to ERRP_PROPAGATE.
Do you mean ERRP_GUARD()?
I'm not sure the commit reduces "branching", but it certainly
Am 05.05.2022 um 11:28 hat Paolo Bonzini geschrieben:
> On 5/5/22 10:51, Kevin Wolf wrote:
> > If not, I guess it would be enough if iotests just checks that the venv
> > exists and all of the dependencies are there in the right version and
> > error out if not, telling the user to run 'make
Hi
On Thu, May 5, 2022 at 2:52 PM Markus Armbruster wrote:
>
> marcandre.lur...@redhat.com writes:
>
> > From: Marc-André Lureau
> >
> > Signed-off-by: Marc-André Lureau
> > Reviewed-by: Thomas Huth
> > ---
> > tests/qtest/libqmp.h | 2 ++
> > tests/qtest/libqmp.c | 35
marcandre.lur...@redhat.com writes:
> From: Marc-André Lureau
>
> Signed-off-by: Marc-André Lureau
> Reviewed-by: Thomas Huth
> ---
> tests/qtest/libqmp.h | 2 ++
> tests/qtest/libqmp.c | 35 +--
> 2 files changed, 31 insertions(+), 6 deletions(-)
>
> diff
marcandre.lur...@redhat.com writes:
> From: Marc-André Lureau
Pointing to commit 49f9522193 "include: rename qemu-common.h
qemu/help-texts.h" wouldn't hurt.
> Signed-off-by: Marc-André Lureau
> Reviewed-by: Stefan Weil
> ---
> include/qemu/help-texts.h | 4 ++--
> 1 file changed, 2
common.rc has some complicated logic to find the common.config that
dates back to xfstests and is completely unnecessary now. Just include
the contents of the file.
Signed-off-by: Paolo Bonzini
---
tests/qemu-iotests/common.config | 41
The sysbus floppy controllers (devices sysbus-fdc and sun-fdtwo)
don't support DMA. The core floppy controller code expects this to
be indicated by setting FDCtrl::dma_chann to -1. This used to be
done in the device instance_init functions sysbus_fdc_initfn() and
sun4m_fdc_initfn(), but in
On 5/5/22 10:51, Kevin Wolf wrote:
If not, I guess it would be enough if iotests just checks that the venv
exists and all of the dependencies are there in the right version and
error out if not, telling the user to run 'make check-venv'.
Or actually, it could just unconditionally run 'make
Am 04.05.2022 um 21:38 hat John Snow geschrieben:
> Howdy!
>
> So, I want to finally delete python/qemu/qmp from qemu.git, and this
> creates a small problem -- namely, iotests needs access to it in order
> to run the python-based tests.
>
> What I think needs to happen is that we create a
From: Nicolas Saenz Julienne
'event-loop-base' provides basic property handling for all 'AioContext'
based event loops. So let's define a new 'MainLoopClass' that inherits
from it. This will permit tweaking the main loop's properties through
qapi as well as through the command line using the
From: Nicolas Saenz Julienne
The thread pool regulates itself: when idle, it kills threads until
empty, when in demand, it creates new threads until full. This behaviour
doesn't play well with latency sensitive workloads where the price of
creating a new thread is too high. For example, when
From: Nicolas Saenz Julienne
Introduce the 'event-loop-base' abstract class, it'll hold the
properties common to all event loops and provide the necessary hooks for
their creation and maintenance. Then have iothread inherit from it.
EventLoopBaseClass is defined as user creatable and provides a
Previously, max_pdiscard would be zero in the following assertion:
qemu-system-x86_64: ../block/io.c:3166: bdrv_co_pdiscard: Assertion
`max_pdiscard >= bs->bl.request_alignment' failed.
Fixes: 0c8022876f ("block: use int64_t instead of int in driver discard
handlers")
Cc: qemu-sta...@nongnu.org
The following changes since commit 9cf289af47bcfae5c75de37d8e5d6fd23705322c:
Merge tag 'qga-pull-request' of gitlab.com:marcandre.lureau/qemu into staging
(2022-05-04 03:42:49 -0700)
are available in the Git repository at:
https://gitlab.com/stefanha/qemu.git tags/block-pull-request
for
From: Marc-André Lureau
Signed-off-by: Marc-André Lureau
---
tests/unit/test-qga.c | 125 +++---
1 file changed, 45 insertions(+), 80 deletions(-)
diff --git a/tests/unit/test-qga.c b/tests/unit/test-qga.c
index ab0b12a2dd16..53cefc2c2649 100644
---
From: Marc-André Lureau
This a more accurate way to lookup the test data, and will allow to move
the test in a subproject.
Signed-off-by: Marc-André Lureau
---
tests/unit/test-qga.c | 11 +--
1 file changed, 5 insertions(+), 6 deletions(-)
diff --git a/tests/unit/test-qga.c
From: Marc-André Lureau
No need to setup an environment or to check if the variable is undefined
manually.
Signed-off-by: Marc-André Lureau
---
qga/installer/qemu-ga.wxs | 30 +-
qga/meson.build | 9 -
2 files changed, 13 insertions(+), 26
From: Marc-André Lureau
qemu_open_old() uses qemu_open_internal() which handles special
"/dev/fdset/" path for monitor fd sets, set CLOEXEC, and uses Error
reporting (and some O_DIRECT special error casing).
The monitor fdset handling is unnecessary for qga, use
qemu_open_cloexec() instead.
From: Marc-André Lureau
Allow for a single point of error reporting, and further refactoring.
Signed-off-by: Marc-André Lureau
---
qga/channel-posix.c | 42 +-
1 file changed, 17 insertions(+), 25 deletions(-)
diff --git a/qga/channel-posix.c
From: Marc-André Lureau
Use more conventional variables to set the location of pre-built
DLL/bin.
Signed-off-by: Marc-André Lureau
---
configure | 9 ++---
meson.build | 5 -
qga/installer/qemu-ga.wxs | 24
qga/meson.build
From: Marc-André Lureau
Sadly, wixl doesn't have 'elif'.
Signed-off-by: Marc-André Lureau
---
qga/installer/qemu-ga.wxs | 20 +++-
1 file changed, 7 insertions(+), 13 deletions(-)
diff --git a/qga/installer/qemu-ga.wxs b/qga/installer/qemu-ga.wxs
index
From: Marc-André Lureau
No clear reason to make guesses here.
Signed-off-by: Marc-André Lureau
---
qga/installer/qemu-ga.wxs | 9 -
1 file changed, 9 deletions(-)
diff --git a/qga/installer/qemu-ga.wxs b/qga/installer/qemu-ga.wxs
index 8a19aa165651..651db6e51cda 100644
---
From: Marc-André Lureau
The function is required by get_relocated_path() (already in cutils),
and used by qemu-ga and may be generally useful.
Signed-off-by: Marc-André Lureau
---
include/qemu/cutils.h| 7 ++
include/qemu/osdep.h | 8 --
qemu-io.c
From: Marc-André Lureau
Used in the next patch, to simplify qga code.
Signed-off-by: Marc-André Lureau
---
include/qemu/osdep.h | 1 +
util/osdep.c | 10 --
2 files changed, 9 insertions(+), 2 deletions(-)
diff --git a/include/qemu/osdep.h b/include/qemu/osdep.h
index
From: Marc-André Lureau
Signed-off-by: Marc-André Lureau
Reviewed-by: Stefan Weil
---
include/qemu/help-texts.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/include/qemu/help-texts.h b/include/qemu/help-texts.h
index ba32cc8b1f39..4f265fed8df1 100644
---
From: Marc-André Lureau
The function takes care of setting CLOEXEC, and reporting error.
Signed-off-by: Marc-André Lureau
---
qga/commands-posix.c | 11 +++
1 file changed, 3 insertions(+), 8 deletions(-)
diff --git a/qga/commands-posix.c b/qga/commands-posix.c
index
On Wed, May 04, 2022 at 03:38:45PM -0400, John Snow wrote:
> Howdy!
>
> So, I want to finally delete python/qemu/qmp from qemu.git, and this
> creates a small problem -- namely, iotests needs access to it in order
> to run the python-based tests.
>
> What I think needs to happen is that we
From: Marc-André Lureau
There is a bit too much branching in the function, this can be
simplified a bit, and have a common exit point thanks to ERRP_PROPAGATE.
This also helps with the following error handling changes.
Signed-off-by: Marc-André Lureau
---
qga/commands-posix.c | 124
From: Marc-André Lureau
Signed-off-by: Marc-André Lureau
Reviewed-by: Thomas Huth
---
tests/qtest/libqmp.h | 2 ++
tests/qtest/libqmp.c | 35 +--
2 files changed, 31 insertions(+), 6 deletions(-)
diff --git a/tests/qtest/libqmp.h b/tests/qtest/libqmp.h
index
From: Marc-André Lureau
SHGetFolderPath() is a deprecated API:
https://docs.microsoft.com/en-us/windows/win32/api/shlobj_core/nf-shlobj_core-shgetfolderpatha
It is a wrapper for SHGetKnownFolderPath() and CSIDL_COMMON_PATH is
mapped to FOLDERID_ProgramData:
From: Marc-André Lureau
Hi,
v2:
- drop "compiler.h: add QEMU_{BEGIN,END}_IGNORE_INITIALIZER_OVERRIDES",
"qobject/json-lexer: disable -Winitializer-overrides warnings" &
"qapi/error: add g_autoptr(Error) support" and adjust related code.
- add "test/qga: use g_auto wherever sensible"
- add
On Wed, May 04, 2022 at 04:18:31PM -0300, Leonardo Bras wrote:
> For CONFIG_LINUX, implement the new zero copy flag and the optional callback
> io_flush on QIOChannelSocket, but enables it only when MSG_ZEROCOPY
> feature is available in the host kernel, which is checked on
>
Looks good apart from the two patches I comment on.
Paolo
Il 4 maggio 2022 19:30:09 CEST, marcandre.lur...@redhat.com ha scritto:
>From: Marc-André Lureau
>
>Hi,
>
>Perhaps the last series of preliminary patches before I propose a longer series
>to add qemu-common & qga meson subprojects.
>If other projects want to borrow bits of QEMU code then
>they need to either (a) abide by our conventions for
>what compiler warnings to enable or disable, or else
>(b) fork the code and fiddle with their own copy.
Agreed, it's not a huge deal if a single add_project_arguments call is
This was rejected before on the grounds that propagating or printing the error
is usually the right thing to do, and neither needs an autoptr:
https://patchew.org/QEMU/20210912124834.503032-1-pbonz...@redhat.com/
So while I do agree with the patch, for it to be accepted some Error* functions
65 matches
Mail list logo
