Re: [PATCH] block/gluster: correctly set max_pdiscard which is int64_t

2022-05-08 Thread Fabian Ebner
Am 06.05.22 um 17:39 schrieb Eric Blake: > On Thu, May 05, 2022 at 10:31:24AM +0200, Fabian Ebner wrote: >> Previously, max_pdiscard would be zero in the following assertion: >> qemu-system-x86_64: ../block/io.c:3166: bdrv_co_pdiscard: Assertion >> `max_pdiscard >= bs->bl.request_alignment' failed.

Re: iotests and python dependencies

2022-05-08 Thread Paolo Bonzini
If we want to provide an installable rpm in Fedora then yes; but we can leave distribution to pypi and use a bundled copy in the virtual environment that is used to run tests. Paolo Il 5 maggio 2022 17:57:24 CEST, "Daniel P. Berrangé" ha scritto: >On Thu, May 05, 2022 at 05:50:00PM +0200, Pao

[PATCH 2/3] hw/ide/piix: Add some documentation to pci_piix3_xen_ide_unplug()

2022-05-08 Thread Bernhard Beschow
The comment is based on commit message ae4d2eb273b167dad748ea4249720319240b1ac2 'xen-platform: add missing disk unplug option'. Since it seems to describe design decisions and limitations that still apply it seems worth having. Signed-off-by: Bernhard Beschow --- hw/ide/piix.c | 11 +++

[PATCH 3/3] include/hw/ide: Unexport pci_piix3_xen_ide_unplug()

2022-05-08 Thread Bernhard Beschow
This function was declared in a generic and public header, implemented in a device-specific source file but only used in xen_platform. Given its 'aux' parameter, this function is more xen-specific than piix-specific. Also, the hardcoded magic constants seem to be generic and related to PCIIDEState

[PATCH 1/3] hw/ide/piix: Remove redundant "piix3-ide-xen" device class

2022-05-08 Thread Bernhard Beschow
Commit 0f8445820f11a69154309863960328dda3dc1ad4 'xen: piix reuse pci generic class init function' already resolved redundant code which in turn rendered piix3-ide-xen redundant. Signed-off-by: Bernhard Beschow --- hw/i386/pc_piix.c | 3 +-- hw/ide/piix.c | 7 --- 2 files changed, 1 inser