[PATCH v2 2/2] hw: m25p80: add tests for write protect

2022-06-08 Thread Iris Chen
Signed-off-by: Iris Chen --- Include the tests in a separate patch. Using qtest_set_irq_in() as per review. tests/qtest/aspeed_smc-test.c | 60 +++ 1 file changed, 60 insertions(+) diff --git a/tests/qtest/aspeed_smc-test.c b/tests/qtest/aspeed_smc-test.c index

[PATCH v2 1/2] hw: m25p80: add WP# pin and SRWD bit for write protection

2022-06-08 Thread Iris Chen
From: Iris Chen Signed-off-by: Iris Chen --- Addressed all comments from V1. The biggest change: removed object_class_property_add. hw/block/m25p80.c | 37 +++ tests/qtest/aspeed_smc-test.c | 2 ++ 2 files changed, 39 insertions(+) diff --git

Re: [External] [PATCH v13 3/8] QIOChannelSocket: Implement io_writev zero copy flag & io_flush for CONFIG_LINUX

2022-06-08 Thread Peter Xu
On Wed, Jun 08, 2022 at 03:14:36PM -0300, Leonardo Bras Soares Passos wrote: > On Wed, Jun 8, 2022 at 8:41 AM Peter Xu wrote: > > > > On Wed, Jun 08, 2022 at 02:37:28AM -0300, Leonardo Bras Soares Passos wrote: > > > (1) is not an option, as the interface currently uses ret=1 to make > > > sure

Re: [External] [PATCH v13 3/8] QIOChannelSocket: Implement io_writev zero copy flag & io_flush for CONFIG_LINUX

2022-06-08 Thread Leonardo Bras Soares Passos
On Wed, Jun 8, 2022 at 8:41 AM Peter Xu wrote: > > On Wed, Jun 08, 2022 at 02:37:28AM -0300, Leonardo Bras Soares Passos wrote: > > (1) is not an option, as the interface currently uses ret=1 to make > > sure MSG_ZEROCOPY is getting used, > > I added that so the user of qio_channel can switch off

Re: [PATCH 03/20] migration: remove unreachble RDMA code in save_hook impl

2022-06-08 Thread Dr. David Alan Gilbert
* Daniel P. Berrangé (berra...@redhat.com) wrote: > The QEMUFile 'save_hook' callback has a 'size_t size' parameter. > > The RDMA impl of this has logic that takes different actions > depending on whether the value is zero or non-zero. It has > commented out logic that would have taken further

Re: [PATCH v3 07/10] block: Implement bdrv_{pread,pwrite,pwrite_zeroes}() using generated_co_wrapper

2022-06-08 Thread Stefan Hajnoczi
On Mon, Jun 06, 2022 at 05:10:38PM +0100, Alberto Faria wrote: > Thanks for the feedback, and apologies for the delayed response. > > On Mon, May 30, 2022 at 1:49 PM Stefan Hajnoczi wrote: > > If you find it's safe to change to -EINVAL then that's consistent with > > how file I/O syscalls work

Re: [External] [PATCH v13 3/8] QIOChannelSocket: Implement io_writev zero copy flag & io_flush for CONFIG_LINUX

2022-06-08 Thread Leonardo Bras Soares Passos
Hello Peter, On Wed, Jun 1, 2022 at 10:58 AM Peter Xu wrote: > [...] > > Hi, Leonardo. I'm also paying attention to the application of MSG_ZEROCOPY > > in live migration recently. I noticed that you defined a member > > `zero_copy_queued` in the struct QIOChannelSocket, but I can't find out > >

Re: [PATCH v5 21/45] block: add bdrv_try_set_aio_context_tran transaction action

2022-06-08 Thread Hanna Reitz
On 30.03.22 23:28, Vladimir Sementsov-Ogievskiy wrote: To be used in further commit. Signed-off-by: Vladimir Sementsov-Ogievskiy --- block.c | 48 1 file changed, 48 insertions(+) Looking at bdrv_child_try_set_aio_context(), it looks like

Re: [External] [PATCH v13 3/8] QIOChannelSocket: Implement io_writev zero copy flag & io_flush for CONFIG_LINUX

2022-06-08 Thread Peter Xu
On Wed, Jun 08, 2022 at 02:37:28AM -0300, Leonardo Bras Soares Passos wrote: > (1) is not an option, as the interface currently uses ret=1 to make > sure MSG_ZEROCOPY is getting used, > I added that so the user of qio_channel can switch off zero-copy if > it's not getting used, and save some cpu.

Re: [PATCH v5 20/45] block: make permission update functions public

2022-06-08 Thread Hanna Reitz
On 30.03.22 23:28, Vladimir Sementsov-Ogievskiy wrote: We'll need them in further commits in blockdev.c for new transaction block-graph modifying API. Signed-off-by: Vladimir Sementsov-Ogievskiy --- block.c| 7 +++ include/block/block-global-state.h | 4

Re: [PATCH v5 19/45] block: refactor bdrv_list_refresh_perms to allow any list of nodes

2022-06-08 Thread Hanna Reitz
On 30.03.22 23:28, Vladimir Sementsov-Ogievskiy wrote: We are going to increase usage of collecting nodes in a list to then update, and calling bdrv_topological_dfs() each time is not convenient, and not correct as we are going to interleave graph modifying with filling the node list. So, let's

Re: [PATCH v5 18/45] block: bdrv_refresh_perms(): allow external tran

2022-06-08 Thread Hanna Reitz
On 30.03.22 23:28, Vladimir Sementsov-Ogievskiy wrote: Allow passing external Transaction pointer, stop creating extra Transaction objects. Signed-off-by: Vladimir Sementsov-Ogievskiy --- block.c | 31 --- 1 file changed, 20 insertions(+), 11 deletions(-)

Re: [PATCH v5 17/45] block: drop bdrv_remove_filter_or_cow_child

2022-06-08 Thread Hanna Reitz
On 30.03.22 23:28, Vladimir Sementsov-Ogievskiy wrote: Drop this simple wrapper used only in one place. We have too many graph modifying functions even without it. Signed-off-by: Vladimir Sementsov-Ogievskiy --- block.c | 15 +-- 1 file changed, 1 insertion(+), 14 deletions(-)

Re: [PATCH v8 00/12] hw/nvme: SR-IOV with Virtualization Enhancements

2022-06-08 Thread Lukasz Maniak
On Wed, Jun 08, 2022 at 10:28:55AM +0200, Klaus Jensen wrote: > On May 9 16:16, Lukasz Maniak wrote: > > Changes since v7: > > - Fixed description of hw/acpi: Make the PCI hot-plug aware of SR-IOV > > - Added description to docs: Add documentation for SR-IOV and > > Virtualization Enhancements

Re: [PATCH v5 16/45] block: drop bdrv_detach_child()

2022-06-08 Thread Hanna Reitz
On 30.03.22 23:28, Vladimir Sementsov-Ogievskiy wrote: The only caller is bdrv_root_unref_child(), let's just do the logic directly in it. It simplifies further convertion of bdrv_root_unref_child() to transaction action. Signed-off-by: Vladimir Sementsov-Ogievskiy --- block.c | 45

Re: [PATCH v5 15/45] block: refactor bdrv_remove_file_or_backing_child to bdrv_remove_child

2022-06-08 Thread Hanna Reitz
On 30.03.22 23:28, Vladimir Sementsov-Ogievskiy wrote: Now the function can remove any child, so give it more common name. Drop assertions and drop bs argument which becomes unused. Function would be reused in a further commit. Signed-off-by: Vladimir Sementsov-Ogievskiy --- block.c | 22

Re: [PATCH v3] hw/nvme: clean up CC register write logic

2022-06-08 Thread Łukasz Gieryk
On Tue, Jun 07, 2022 at 01:23:20PM +0200, Klaus Jensen wrote: > From: Klaus Jensen > > The SRIOV series exposed an issued with how CC register writes are > handled and how CSTS is set in response to that. Specifically, after > applying the SRIOV series, the controller could end up in a state

Re: [PATCH v8 00/12] hw/nvme: SR-IOV with Virtualization Enhancements

2022-06-08 Thread Klaus Jensen
On May 9 16:16, Lukasz Maniak wrote: > Changes since v7: > - Fixed description of hw/acpi: Make the PCI hot-plug aware of SR-IOV > - Added description to docs: Add documentation for SR-IOV and > Virtualization Enhancements > - Added Reviewed-by and Acked-by tags > - Rebased on master > >

Re: [PATCH v6 02/18] job.h: categorize fields in struct Job

2022-06-08 Thread Emanuele Giuseppe Esposito
Am 07/06/2022 um 17:41 schrieb Paolo Bonzini: > On 6/7/22 15:20, Emanuele Giuseppe Esposito wrote: >> >> >> Am 03/06/2022 um 18:00 schrieb Kevin Wolf: >>> Am 14.03.2022 um 14:36 hat Emanuele Giuseppe Esposito geschrieben: Categorize the fields in struct Job to understand which ones

Re: [External] [PATCH v13 3/8] QIOChannelSocket: Implement io_writev zero copy flag & io_flush for CONFIG_LINUX

2022-06-08 Thread chuang xu
On 2022/6/8 下午1:24, Leonardo Bras Soares Passos wrote: I will send a fix shortly. Is that ok if I include a "Reported-by: 徐闯 " in the patch? okay. Best Regards, chuang xu