* Daniel P. Berrangé (berra...@redhat.com) wrote:
> The name 'ftell' gives the misleading impression that the QEMUFile
> objects are seekable. This is not the case, as in general we just
> have an opaque stream. The users of this method are only interested
> in the total bytes processed. This
* Daniel P. Berrangé (berra...@redhat.com) wrote:
> This renames the following QEMUFile fields
>
> * bytes_xfer -> rate_limit_used
> * xfer_limit -> rate_limit_max
>
> The intent is to make it clear that 'bytes_xfer' is specifically related
> to rate limiting of data and applies to data
* Daniel P. Berrangé (berra...@redhat.com) wrote:
> This makes the field name align with the newly introduced method
> names in the previous commit.
I think that's the method in the following commits?
tbh I'm not sure about this; 'pos' is still passed to writev_buffer
and get_buffer to say where
On Thu, Jun 09, 2022 at 10:51:27AM +0100, Dr. David Alan Gilbert wrote:
> * Daniel P. Berrangé (berra...@redhat.com) wrote:
> > This makes the field name align with the newly introduced method
> > names in the previous commit.
>
> I think that's the method in the following commits?
Opps, yeah, I
On Mon, Mar 14, 2022 at 09:36:52AM -0400, Emanuele Giuseppe Esposito wrote:
> job_event_* functions can all be static, as they are not used
> outside job.c.
>
> Same applies for job_txn_add_job().
>
> Signed-off-by: Emanuele Giuseppe Esposito
> ---
> include/qemu/job.h | 18 --
* Daniel P. Berrangé (berra...@redhat.com) wrote:
> On Thu, Jun 09, 2022 at 10:51:27AM +0100, Dr. David Alan Gilbert wrote:
> > * Daniel P. Berrangé (berra...@redhat.com) wrote:
> > > This makes the field name align with the newly introduced method
> > > names in the previous commit.
> >
> > I
On Mon, Mar 14, 2022 at 09:37:00AM -0400, Emanuele Giuseppe Esposito wrote:
> /**
> - * Release a reference that was previously acquired with job_ref() or
> + * Release a reference that was previously acquired with job_ref_locked() or
> * job_create(). If it's the last reference to the object,
On Mon, Mar 14, 2022 at 09:36:59AM -0400, Emanuele Giuseppe Esposito wrote:
> @@ -530,20 +540,24 @@ void job_enter(Job *job)
> job_enter_cond(job, NULL);
> }
>
> -/* Yield, and schedule a timer to reenter the coroutine after @ns
> nanoseconds.
> +/*
> + * Yield, and schedule a timer to
On Mon, Mar 14, 2022 at 09:37:01AM -0400, Emanuele Giuseppe Esposito wrote:
> @@ -135,32 +137,37 @@ void block_job_remove_all_bdrv(BlockJob *job);
> bool block_job_has_bdrv(BlockJob *job, BlockDriverState *bs);
>
> /**
> - * block_job_set_speed:
> + * block_job_set_speed_locked:
> * @job:
On Mon, Mar 14, 2022 at 09:37:02AM -0400, Emanuele Giuseppe Esposito wrote:
> /**
> * @job: The job to enter.
> + * Called with job_mutex *not* held.
> *
> * Continue the specified job by entering the coroutine.
> + * Called with job_mutex lock *not* held.
A similar comment was added just
On Mon, Mar 14, 2022 at 09:36:54AM -0400, Emanuele Giuseppe Esposito wrote:
> In preparation to the job_lock/unlock usage, create _locked
> duplicates of some functions, since they will be sometimes called with
> job_mutex held (mostly within job.c),
> and sometimes without (mostly from JobDrivers
On 09/06/2022 05.13, Iris Chen wrote:
Signed-off-by: Iris Chen
---
Include the tests in a separate patch. Using qtest_set_irq_in() as per review.
tests/qtest/aspeed_smc-test.c | 60 +++
1 file changed, 60 insertions(+)
diff --git
101 - 112 of 112 matches
Mail list logo
