Re: [PATCH v5 00/13] Instantiate VT82xx functions in host device

2022-09-16 Thread Bernhard Beschow
Am 16. September 2022 14:36:05 UTC schrieb "Philippe Mathieu-Daudé" : >On 12/9/22 21:50, Bernhard Beschow wrote: >> Am 1. September 2022 11:41:14 UTC schrieb Bernhard Beschow >> : > >>> Testing done: >>> >>> * `qemu-system-ppc -machine pegasos2 -rtc base=localtime -device >>> ati-vga,guest_hwcu

Re: [PATCH 10/11] hw/sd/sdhci: Implement Freescale eSDHC device model

2022-09-16 Thread Bernhard Beschow
Am 16. September 2022 15:15:03 UTC schrieb Bin Meng : >On Thu, Sep 15, 2022 at 11:30 PM Bernhard Beschow wrote: >> >> Will allow e500 boards to access SD cards using just their own devices. >> >> Signed-off-by: Bernhard Beschow >> --- >> hw/sd/sdhci.c | 147 ++

Re: [PATCH 04/11] hw/ppc/mpc8544ds: Add platform bus

2022-09-16 Thread Bernhard Beschow
Am 16. September 2022 06:15:53 UTC schrieb Bin Meng : >On Thu, Sep 15, 2022 at 11:29 PM Bernhard Beschow wrote: >> >> Models the real device more closely. > >Please describe the source (e.g.: I assume it's MPC8544DS board manual >or something like that?) that describe such memory map for the >plat

Re: [PATCH 09/11] hw/sd/sdhci: Rename ESDHC_* defines to USDHC_*

2022-09-16 Thread Bernhard Beschow
Am 16. September 2022 10:07:28 UTC schrieb Bin Meng : >On Thu, Sep 15, 2022 at 11:42 PM Bernhard Beschow wrote: >> >> The device model's functions start with "usdhc_", so rename the defines >> accordingly for consistency. >> >> Signed-off-by: Bernhard Beschow >> --- >> hw/sd/sdhci.c | 68 +++

Re: [PATCH 07/11] hw/ppc/e500: Implement pflash handling

2022-09-16 Thread Bernhard Beschow
Am 16. September 2022 15:00:06 UTC schrieb Bin Meng : >On Thu, Sep 15, 2022 at 11:36 PM Bernhard Beschow wrote: >> >> Allows e500 boards to have their root file system reside on flash using >> only builtin devices. >> >> Note that the flash memory area is only created when a -pflash argument is >>

Re: [PATCH 11/11] hw/ppc/e500: Add Freescale eSDHC to e500 boards

2022-09-16 Thread Bernhard Beschow
On Fri, Sep 16, 2022 at 5:26 PM Bin Meng wrote: > On Thu, Sep 15, 2022 at 11:30 PM Bernhard Beschow > wrote: > > > > Adds missing functionality to emulated e500 SOCs which increases the > > chance of given "real" firmware images to access SD cards. > > By "firmware" do you mean U-Boot? > No, I

Re: [PATCH 00/11] ppc/e500: Add support for two types of flash, cleanup

2022-09-16 Thread Bernhard Beschow
On Fri, Sep 16, 2022 at 5:27 PM Bin Meng wrote: > Hi Bernhard, > Hi Bin, > On Thu, Sep 15, 2022 at 11:25 PM Bernhard Beschow > wrote: > > > > This series adds support for -pflash and direct SD card access to the > > PPC e500 boards. The idea is to increase compatibility with "real" > firmware

Re: [PATCH 00/11] ppc/e500: Add support for two types of flash, cleanup

2022-09-16 Thread Bin Meng
Hi Bernhard, On Thu, Sep 15, 2022 at 11:25 PM Bernhard Beschow wrote: > > This series adds support for -pflash and direct SD card access to the > PPC e500 boards. The idea is to increase compatibility with "real" firmware > images where only the bare minimum of drivers is compiled in. > > The ser

Re: [PATCH 11/11] hw/ppc/e500: Add Freescale eSDHC to e500 boards

2022-09-16 Thread Bin Meng
On Thu, Sep 15, 2022 at 11:30 PM Bernhard Beschow wrote: > > Adds missing functionality to emulated e500 SOCs which increases the > chance of given "real" firmware images to access SD cards. By "firmware" do you mean U-Boot? > > Signed-off-by: Bernhard Beschow > --- > docs/system/ppc/ppce500.r

Re: [PATCH 10/11] hw/sd/sdhci: Implement Freescale eSDHC device model

2022-09-16 Thread Bin Meng
On Thu, Sep 15, 2022 at 11:30 PM Bernhard Beschow wrote: > > Will allow e500 boards to access SD cards using just their own devices. > > Signed-off-by: Bernhard Beschow > --- > hw/sd/sdhci.c | 147 +- > include/hw/sd/sdhci.h | 3 + > 2 files chan

Re: [PATCH 07/11] hw/ppc/e500: Implement pflash handling

2022-09-16 Thread Bin Meng
On Thu, Sep 15, 2022 at 11:36 PM Bernhard Beschow wrote: > > Allows e500 boards to have their root file system reside on flash using > only builtin devices. > > Note that the flash memory area is only created when a -pflash argument is > given, and that the size is determined by the given file. Th

Re: [PATCH v5 13/13] hw/isa/vt82c686: Create rtc-time alias in boards instead

2022-09-16 Thread Philippe Mathieu-Daudé via
On 1/9/22 13:41, Bernhard Beschow wrote: According to good QOM practice, an object should only deal with objects of its own sub tree. Having devices create an alias on the machine object doesn't respect this good practice. To resolve this, create the alias in the machine's code. Signed-off-by: B

Re: [PATCH v5 00/13] Instantiate VT82xx functions in host device

2022-09-16 Thread Philippe Mathieu-Daudé via
On 12/9/22 21:50, Bernhard Beschow wrote: Am 1. September 2022 11:41:14 UTC schrieb Bernhard Beschow : Testing done: * `qemu-system-ppc -machine pegasos2 -rtc base=localtime -device ati-vga,guest_hwcursor=true,romfile="" -cdrom morphos-3.17.iso -kernel morphos-3.17/boot.img` Boots succes

Re: [PATCH v5 11/13] hw/mips/fuloong2e: Inline vt82c686b_southbridge_init() and remove it

2022-09-16 Thread Philippe Mathieu-Daudé via
On 1/9/22 13:41, Bernhard Beschow wrote: The previous patches moved most of this function into the via-isa device model such that it has become fairly trivial. So inline it for simplicity. Suggested-by: BALATON Zoltan Signed-off-by: Bernhard Beschow --- hw/mips/fuloong2e.c | 28 ++---

Re: [PATCH 09/11] hw/sd/sdhci: Rename ESDHC_* defines to USDHC_*

2022-09-16 Thread Bin Meng
On Thu, Sep 15, 2022 at 11:42 PM Bernhard Beschow wrote: > > The device model's functions start with "usdhc_", so rename the defines > accordingly for consistency. > > Signed-off-by: Bernhard Beschow > --- > hw/sd/sdhci.c | 68 +-- > 1 file changed

Re: [PATCH 08/11] hw/sd/sdhci-internal: Unexport ESDHC defines

2022-09-16 Thread Bin Meng
On Thu, Sep 15, 2022 at 11:39 PM Bernhard Beschow wrote: > > These defines aren't used outside of sdhci.c, so can be defined there. > > Signed-off-by: Bernhard Beschow > --- > hw/sd/sdhci-internal.h | 20 > hw/sd/sdhci.c | 19 +++ > 2 files changed,

Re: [PATCH 00/27] qapi: Elide redundant has_FOO in generated C

2022-09-16 Thread Vladimir Sementsov-Ogievskiy
On 9/15/22 23:42, Markus Armbruster wrote: In QAPI, absent optional members are distinct from any present value. We thus represent an optional schema member FOO as two C members: a FOO with the member's type, and a bool has_FOO. Likewise for function arguments. However, the has_FOO is actually

Re: [PATCH 12/27] qapi job: Elide redundant has_FOO in generated C

2022-09-16 Thread Vladimir Sementsov-Ogievskiy
On 9/15/22 23:43, Markus Armbruster wrote: The has_FOO for pointer-valued FOO are redundant, except for arrays. They are also a nuisance to work with. Recent commit "qapi: Start to elide redundant has_FOO in generated C" provided the means to elide them step by step. This is the step for qapi/j