Re: [PATCH v9 1/7] include: add zoned device structs

2022-09-18 Thread Sam Li
Stefan Hajnoczi 于2022年9月18日周日 04:17写道: > > On Thu, Sep 15, 2022 at 06:06:38PM +0800, Sam Li wrote: > > Eric Blake 于2022年9月15日周四 16:05写道: > > > > > > On Sat, Sep 10, 2022 at 01:27:53PM +0800, Sam Li wrote: > > > > Signed-off-by: Sam Li > > > > Reviewed-by: Stefan Hajnoczi > > > > Reviewed-by:

Re: [PATCH v11 21/21] job: remove unused functions

2022-09-18 Thread Emanuele Giuseppe Esposito
Am 14/09/2022 um 16:28 schrieb Vladimir Sementsov-Ogievskiy: > On 8/26/22 16:21, Emanuele Giuseppe Esposito wrote: >> These public functions are not used anywhere, thus can be dropped. >> Also, since this is the final job API that doesn't use AioContext >> lock and replaces it with job_lock,

Re: [PATCH v11 18/21] job.c: enable job lock/unlock and remove Aiocontext locks

2022-09-18 Thread Emanuele Giuseppe Esposito
Am 15/09/2022 um 16:52 schrieb Vladimir Sementsov-Ogievskiy: > On 8/26/22 16:21, Emanuele Giuseppe Esposito wrote: >> Change the job_{lock/unlock} and macros to use job_mutex. >> >> Now that they are not nop anymore, remove the aiocontext >> to avoid deadlocks. >> >> Therefore: >> - when

Re: [PATCH v11 13/21] jobs: protect job.aio_context with BQL and job_mutex

2022-09-18 Thread Emanuele Giuseppe Esposito
Am 14/09/2022 um 15:25 schrieb Vladimir Sementsov-Ogievskiy: > On 8/26/22 16:20, Emanuele Giuseppe Esposito wrote: >> In order to make it thread safe, implement a "fake rwlock", >> where we allow reads under BQL *or* job_mutex held, but >> writes only under BQL *and* job_mutex. >> >> The only

Re: [PATCH v11 11/21] jobs: group together API calls under the same job lock

2022-09-18 Thread Emanuele Giuseppe Esposito
Am 14/09/2022 um 14:36 schrieb Vladimir Sementsov-Ogievskiy: > On 8/26/22 16:20, Emanuele Giuseppe Esposito wrote: >> Now that the API offers also _locked() functions, take advantage >> of it and give also the caller control to take the lock and call >> _locked functions. >> >> This makes sense

Re: [PATCH 00/11] ppc/e500: Add support for two types of flash, cleanup

2022-09-18 Thread Philippe Mathieu-Daudé via
On 15/9/22 17:25, Bernhard Beschow wrote: This series adds support for -pflash and direct SD card access to the PPC e500 boards. The idea is to increase compatibility with "real" firmware images where only the bare minimum of drivers is compiled in. The series is structured as follows: Patches

Re: [PATCH 03/11] docs/system/ppc/ppce500: Add heading for networking chapter

2022-09-18 Thread Philippe Mathieu-Daudé via
On 15/9/22 17:25, Bernhard Beschow wrote: The sudden change of topics is slightly confusing and makes the networking information less visible. So separate the networking chapter to improve comprehensibility. Signed-off-by: Bernhard Beschow --- docs/system/ppc/ppce500.rst | 3 +++ 1 file

Re: [PATCH 08/11] hw/sd/sdhci-internal: Unexport ESDHC defines

2022-09-18 Thread Philippe Mathieu-Daudé via
On 15/9/22 17:25, Bernhard Beschow wrote: These defines aren't used outside of sdhci.c, so can be defined there. Signed-off-by: Bernhard Beschow --- hw/sd/sdhci-internal.h | 20 hw/sd/sdhci.c | 19 +++ 2 files changed, 19 insertions(+), 20

Re: [PATCH 02/11] hw/gpio/meson: Introduce dedicated config switch for hw/gpio/mpc8xxx

2022-09-18 Thread Philippe Mathieu-Daudé via
On 15/9/22 17:25, Bernhard Beschow wrote: Having a dedicated config switch makes dependency handling cleaner. Signed-off-by: Bernhard Beschow --- hw/gpio/Kconfig | 3 +++ hw/gpio/meson.build | 2 +- hw/ppc/Kconfig | 1 + 3 files changed, 5 insertions(+), 1 deletion(-)

Re: [PATCH 05/11] hw/ppc/e500: Remove if statement which is now always true

2022-09-18 Thread Philippe Mathieu-Daudé via
On 15/9/22 17:25, Bernhard Beschow wrote: Now that the MPC8544DS board also has a platform bus, the if statement was always true. s/was/is/. Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Bernhard Beschow --- hw/ppc/e500.c | 30 ++ hw/ppc/e500.h

Re: [PATCH 01/11] hw/ppc/meson: Allow e500 boards to be enabled separately

2022-09-18 Thread Philippe Mathieu-Daudé via
On 15/9/22 17:25, Bernhard Beschow wrote: Gives users more fine-grained control over what should be compiled into QEMU. Signed-off-by: Bernhard Beschow --- configs/devices/ppc-softmmu/default.mak | 3 ++- hw/ppc/Kconfig | 8 hw/ppc/meson.build

Re: [PATCH 0/3] Add qemu-img checksum command using blkhash

2022-09-18 Thread Nir Soffer
ping Kevin, Hanna, I hope you have time to take a look. https://lists.nongnu.org/archive/html/qemu-block/2022-09/msg00021.html On Thu, Sep 1, 2022 at 5:32 PM Nir Soffer wrote: > > Since blkhash is available only via copr now, the new command is added as > optional feature, built only if