Re: [PATCH] hw/ide/microdrive: Use device_cold_reset() for self-resets

2022-10-17 Thread Philippe Mathieu-Daudé
On 13/10/22 19:40, Peter Maydell wrote: Currently the microdrive code uses device_legacy_reset() to reset itself, and has its reset method call reset on the IDE bus as the last thing it does. Switch to using device_cold_reset(). The only concrete microdrive device is the TYPE_DSCM1; it is

Re: [PATCH v3 2/9] hw/{arm,ppc}: Resolve unreachable code

2022-10-17 Thread Philippe Mathieu-Daudé
On 16/10/22 14:27, Bernhard Beschow wrote: pflash_cfi01_register() always returns with a non-NULL pointer (otherwise it would crash internally). Therefore, the bodies of the if-statements are unreachable. This is true, pflash_cfi0X_register() use an hardcoded _fatal. Shouldn't it be better to

Re: [PATCH v3 2/9] hw/{arm,ppc}: Resolve unreachable code

2022-10-17 Thread Bernhard Beschow
Am 17. Oktober 2022 20:57:06 UTC schrieb "Philippe Mathieu-Daudé" : >On 16/10/22 14:27, Bernhard Beschow wrote: >> pflash_cfi01_register() always returns with a non-NULL pointer (otherwise >> it would crash internally). Therefore, the bodies of the if-statements >> are unreachable. > >This is

[PATCH v2] nbd/client: Use smarter assert

2022-10-17 Thread Eric Blake
Assigning strlen() to a uint32_t and then asserting that it isn't too large doesn't catch the case of an input string 4G in length. Thankfully, the incoming strings can never be that large: if the export name or query is reflecting a string the client got from the server, we already guarantee that

Re: [PATCH] nbd/server: Use smarter assert

2022-10-17 Thread Eric Blake
Given the file touched by this patch[1], The subject should use 'nbd/client:' On Mon, Oct 17, 2022 at 12:37:27PM -0500, Eric Blake wrote: > Assigning strlen() to a uint32_t and then asserting that it isn't too > large doesn't catch the case of an input string 4G in length. > Thankfully, the

Re: [PATCH] nbd/server: Use smarter assert

2022-10-17 Thread Dr. David Alan Gilbert
* Eric Blake (ebl...@redhat.com) wrote: > Assigning strlen() to a uint32_t and then asserting that it isn't too > large doesn't catch the case of an input string 4G in length. > Thankfully, the incoming string can never be that large: if the export > name is reflecting what the client asked about,

[PATCH] nbd/server: Use smarter assert

2022-10-17 Thread Eric Blake
Assigning strlen() to a uint32_t and then asserting that it isn't too large doesn't catch the case of an input string 4G in length. Thankfully, the incoming string can never be that large: if the export name is reflecting what the client asked about, we already guarantee that we drop the NBD

Re: [PATCH v5 00/18] tests/qtest: Enable running qtest on Windows

2022-10-17 Thread Christian Schoenebeck
On Monday, October 17, 2022 5:00:56 PM CEST Bin Meng wrote: > Hi Alex, > > On Fri, Oct 7, 2022 at 1:31 PM Bin Meng wrote: > > On Fri, Oct 7, 2022 at 4:35 AM Alex Bennée wrote: > > > Bin Meng writes: > > > > In preparation to adding virtio-9p support on Windows, this series > > > > enables

Re: [PATCH v5 00/18] tests/qtest: Enable running qtest on Windows

2022-10-17 Thread Bin Meng
Hi Alex, On Fri, Oct 7, 2022 at 1:31 PM Bin Meng wrote: > > On Fri, Oct 7, 2022 at 4:35 AM Alex Bennée wrote: > > > > > > Bin Meng writes: > > > > > In preparation to adding virtio-9p support on Windows, this series > > > enables running qtest on Windows, so that we can run the virtio-9p > > >

Re: [PATCH v12 3/7] block: add block layer APIs resembling Linux ZonedBlockDevice ioctls

2022-10-17 Thread Stefan Hajnoczi
On Sun, Oct 16, 2022 at 10:51:06PM +0800, Sam Li wrote: > Add a new zoned_host_device BlockDriver. The zoned_host_device option > accepts only zoned host block devices. By adding zone management > operations in this new BlockDriver, users can use the new block > layer APIs including Report Zone