[PATCH v2 02/17] hw/i386/amd_iommu: Omit errp for pci_add_capability

Signed-off-by: Akihiko Odaki --- hw/i386/amd_iommu.c | 21 - 1 file changed, 4 insertions(+), 17 deletions(-) diff --git a/hw/i386/amd_iommu.c b/hw/i386/amd_iommu.c index 725f69095b..8a88cbea0a 100644 --- a/hw/i386/amd_iommu.c +++ b/hw/i386/amd_iommu.c @@ -1539,7 +1539,6 @@

[PATCH v2 03/17] ahci: Omit errp for pci_add_capability

Signed-off-by: Akihiko Odaki --- hw/ide/ich.c | 8 ++-- 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/hw/ide/ich.c b/hw/ide/ich.c index 1007a51fcb..3b478b01f8 100644 --- a/hw/ide/ich.c +++ b/hw/ide/ich.c @@ -106,7 +106,7 @@ static void pci_ich9_ahci_init(Object *obj) static

[PATCH v2 10/17] pci/shpc: Omit errp for pci_add_capability

Signed-off-by: Akihiko Odaki --- hw/pci-bridge/pci_bridge_dev.c | 2 +- hw/pci-bridge/pcie_pci_bridge.c | 2 +- hw/pci/shpc.c | 23 ++- include/hw/pci/shpc.h | 3 +-- 4 files changed, 9 insertions(+), 21 deletions(-) diff --git

[PATCH v2 13/17] hw/pci-bridge/pcie_pci_bridge: Omit errp for pci_add_capability

Signed-off-by: Akihiko Odaki --- hw/pci-bridge/pcie_pci_bridge.c | 11 +++ 1 file changed, 3 insertions(+), 8 deletions(-) diff --git a/hw/pci-bridge/pcie_pci_bridge.c b/hw/pci-bridge/pcie_pci_bridge.c index 99778e3e24..1b839465e7 100644 --- a/hw/pci-bridge/pcie_pci_bridge.c +++

[PATCH v2 17/17] pci: Remove legacy errp from pci_add_capability

Signed-off-by: Akihiko Odaki --- hw/pci/pci.c | 29 +++-- 1 file changed, 7 insertions(+), 22 deletions(-) diff --git a/hw/pci/pci.c b/hw/pci/pci.c index 8ee2171011..8ff71e4553 100644 --- a/hw/pci/pci.c +++ b/hw/pci/pci.c @@ -2513,38 +2513,23 @@ static void

[PATCH v2 00/17] pci: Abort if pci_add_capability fails

pci_add_capability appears most PCI devices. Its error handling required lots of code, and led to inconsistent behaviors such as: - passing error_abort - passing error_fatal - asserting the returned value - propagating the error to the caller - skipping the rest of the function - just ignoring

[PATCH v2 12/17] pci/slotid: Omit errp for pci_add_capability

Signed-off-by: Akihiko Odaki --- hw/pci/slotid_cap.c | 8 ++-- 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/hw/pci/slotid_cap.c b/hw/pci/slotid_cap.c index 36d021b4a6..5da8c82133 100644 --- a/hw/pci/slotid_cap.c +++ b/hw/pci/slotid_cap.c @@ -12,7 +12,7 @@ int

[PATCH v2 01/17] pci: Allow to omit errp for pci_add_capability

pci_add_capability appears most PCI devices. Its error handling required lots of code, and led to inconsistent behaviors such as: - passing error_abort - passing error_fatal - asserting the returned value - propagating the error to the caller - skipping the rest of the function - just ignoring

[PATCH v2 11/17] msix: Omit errp for pci_add_capability

Signed-off-by: Akihiko Odaki --- hw/pci/msix.c | 8 ++-- 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/hw/pci/msix.c b/hw/pci/msix.c index 1e381a9813..28af83403b 100644 --- a/hw/pci/msix.c +++ b/hw/pci/msix.c @@ -311,7 +311,7 @@ int msix_init(struct PCIDevice *dev, unsigned

[PATCH v2 07/17] msi: Omit errp for pci_add_capability

Signed-off-by: Akihiko Odaki --- hw/pci/msi.c | 9 + 1 file changed, 1 insertion(+), 8 deletions(-) diff --git a/hw/pci/msi.c b/hw/pci/msi.c index 058d1d1ef1..5283a08b5a 100644 --- a/hw/pci/msi.c +++ b/hw/pci/msi.c @@ -194,7 +194,6 @@ int msi_init(struct PCIDevice *dev, uint8_t offset,

[PATCH v2 05/17] eepro100: Omit errp for pci_add_capability

Signed-off-by: Akihiko Odaki --- hw/net/eepro100.c | 7 +-- 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/hw/net/eepro100.c b/hw/net/eepro100.c index 679f52f80f..bf2ecdded9 100644 --- a/hw/net/eepro100.c +++ b/hw/net/eepro100.c @@ -549,12 +549,7 @@ static void

[PATCH v2 06/17] hw/nvme: Omit errp for pci_add_capability

Signed-off-by: Akihiko Odaki --- hw/nvme/ctrl.c | 14 ++ 1 file changed, 2 insertions(+), 12 deletions(-) diff --git a/hw/nvme/ctrl.c b/hw/nvme/ctrl.c index 87aeba0564..ff4e2beea6 100644 --- a/hw/nvme/ctrl.c +++ b/hw/nvme/ctrl.c @@ -7325,17 +7325,9 @@ static void

[PATCH v2 15/17] hw/vfio/pci: Omit errp for pci_add_capability

Signed-off-by: Akihiko Odaki --- hw/vfio/pci.c | 14 +- 1 file changed, 5 insertions(+), 9 deletions(-) diff --git a/hw/vfio/pci.c b/hw/vfio/pci.c index 939dcc3d4a..2b653d01e3 100644 --- a/hw/vfio/pci.c +++ b/hw/vfio/pci.c @@ -1826,7 +1826,7 @@ static void

[PATCH v2 14/17] hw/vfio/pci-quirks: Omit errp for pci_add_capability

Signed-off-by: Akihiko Odaki --- hw/vfio/pci-quirks.c | 15 +++ 1 file changed, 3 insertions(+), 12 deletions(-) diff --git a/hw/vfio/pci-quirks.c b/hw/vfio/pci-quirks.c index f0147a050a..e94fd273ea 100644 --- a/hw/vfio/pci-quirks.c +++ b/hw/vfio/pci-quirks.c @@ -1530,7 +1530,7 @@

[PATCH v2 04/17] e1000e: Omit errp for pci_add_capability

Signed-off-by: Akihiko Odaki --- hw/net/e1000e.c | 18 +++--- 1 file changed, 3 insertions(+), 15 deletions(-) diff --git a/hw/net/e1000e.c b/hw/net/e1000e.c index ac96f7665a..e433b8f9a5 100644 --- a/hw/net/e1000e.c +++ b/hw/net/e1000e.c @@ -377,17 +377,10 @@ e1000e_gen_dsn(uint8_t

Re: [PATCH] hw/block/nvme: re-enable NVMe PCI hotplug

On Tue, Oct 18, 2022 at 10:15:57AM +0200, Daniel Wagner wrote: > On Mon, Oct 10, 2022 at 07:15:08PM +0200, Klaus Jensen wrote: > > This is all upstream. Namespaces with 'shared=on' *should* all be > > automatically attached to any hotplugged controller devices. > > > > With what setup is this not

Re: [PATCH] vhost-user-blk: fix the resize crash

Am 19.09.2022 um 14:18 hat Li Feng geschrieben: > If the os is not installed and doesn't have the virtio guest driver, > the vhost dev isn't started, so the dev->vdev is NULL. > > Reproduce: mount a Win 2019 iso, go into the install ui, then resize > the virtio-blk device, qemu crash. > >

Re: [PATCH v6 1/2] block: Ignore close() failure in get_tmp_filename()

Am 10.10.2022 um 06:04 hat Bin Meng geschrieben: > The temporary file has been created and is ready for use. Checking > return value of close() does not seem useful. The file descriptor > is almost certainly closed; see close(2) under "Dealing with error > returns from close()". > > Let's simply

Re: [PATCH] block/io_uring: revert "Use io_uring_register_ring_fd() to skip fd operations"

Am 24.09.2022 um 16:48 hat Sam Li geschrieben: > Resolves: https://gitlab.com/qemu-project/qemu/-/issues/1193 > > The commit "Use io_uring_register_ring_fd() to skip fd operations" broke > when booting a guest with iothread and io_uring. That is because the > io_uring_register_ring_fd() call is

Re: [PATCH v2 0/2] Fix some problems with vvfat in R/W mode

Am 10.10.2022 um 19:55 hat Hervé Poussineau geschrieben: > Hi, > > When testing vvfat in read-write mode, I came across some blocking > problems when using Windows guests. > This patchset is not here to fix all problems of vvfat, but only the > main ones I encountered. > > First patch allows

Re: [PATCH v6 2/2] block: Refactor get_tmp_filename()

Am 10.10.2022 um 06:04 hat Bin Meng geschrieben: > At present there are two callers of get_tmp_filename() and they are > inconsistent. > > One does: > > /* TODO: extra byte is a hack to ensure MAX_PATH space on Windows. */ > char *tmp_filename = g_malloc0(PATH_MAX + 1); > ... >

Re: [PATCH v3 12/26] block/vvfat: Unify the mkdir() call

Am 20.10.2022 um 13:51 hat Alex Bennée geschrieben: > From: Bin Meng > > There is a difference in the mkdir() call for win32 and non-win32 > platforms, and currently is handled in the codes with #ifdefs. > > glib provides a portable g_mkdir() API and we can use it to unify > the codes without

Re: [PATCH] hw/nvme: reenable cqe batching

at 1:37 PM, Klaus Jensen wrote: > On Okt 21 10:37, Jinhao Fan wrote: >> at 7:35 PM, Klaus Jensen wrote: >> >>> Commit 2e53b0b45024 ("hw/nvme: Use ioeventfd to handle doorbell >>> updates") had the unintended effect of disabling batching of CQEs. >>> >>> This patch changes the sq/cq timers to