On Thu, Nov 10, 2022 at 8:25 AM Akihiko Odaki
wrote:
> GUID_DEVINTERFACE_DISK and GUID_DEVINTERFACE_STORAGEPORT are already
> defined by MinGW-w64. They are not only unnecessary, but can lead to
> duplicate definition errors at link time with some unknown condition.
>
What version of MinGW-w64 d
On 09/11/2022 16.57, mreza...@redhat.com wrote:
From: Miroslav Rezanina
Variable block_count used in img_dd function is only incremented but never read.
This causes 'Unused but set variable' warning on Clang 15.0.1 compiler.
Removing the variable to prevent the warning.
Signed-off-by: Mirosla
On 10/11/22 08:05, Klaus Jensen wrote:
From: Klaus Jensen
Cancelling a format operation neglects to set iocb->ret as well as
clearing the iocb->aiocb after cancelling the underlying aiocb.
Fix this.
Fixes: 3bcf26d3d619 ("hw/nvme: reimplement format nvm to allow cancellation")
Signed-off-by: K
On 10/11/22 10:53, Philippe Mathieu-Daudé wrote:
On 10/11/22 08:05, Klaus Jensen wrote:
From: Klaus Jensen
Cancelling a format operation neglects to set iocb->ret as well as
clearing the iocb->aiocb after cancelling the underlying aiocb.
Fix this.
Fixes: 3bcf26d3d619 ("hw/nvme: reimplement f
On 10/11/22 07:23, Klaus Jensen wrote:
From: Klaus Jensen
Make nvme_check_constraints() return a bool and fix an invalid error
propagation where the actual error is thrown away in favor of an unused
local Error value.
Signed-off-by: Klaus Jensen
---
hw/nvme/ctrl.c | 48 +
Klaus Jensen writes:
> From: Klaus Jensen
>
> Replace the local Error variable with errp and ERRP_GUARD() and change
> the return value to bool.
>
> Reviewed-by: Markus Armbruster
> Signed-off-by: Klaus Jensen
> ---
> hw/nvme/ctrl.c | 23 ++-
> 1 file changed, 10 insertion
Klaus Jensen writes:
> From: Klaus Jensen
>
> Make nvme_check_constraints() return a bool and fix an invalid error
> propagation where the actual error is thrown away in favor of an unused
> local Error value.
Is it? I think you're talking about ...
> Signed-off-by: Klaus Jensen
> ---
> hw/
qemu_get_runtime_dir() returns a dynamically allocated directory path
that is appropriate for storing runtime files. It corresponds to "run"
directory in Unix.
With a tree-wide search, it was found that there are several cases
where such a functionality is implemented so let's have one as a common
qemu_get_runtime_dir() is used to construct the default PID file path.
Signed-off-by: Akihiko Odaki
---
contrib/ivshmem-server/main.c | 20
1 file changed, 16 insertions(+), 4 deletions(-)
diff --git a/contrib/ivshmem-server/main.c b/contrib/ivshmem-server/main.c
index 224d
qemu_get_runtime_dir() returns a dynamically allocated directory path
that is appropriate for storing runtime files. It corresponds to "run"
directory in Unix.
With a tree-wide search, it was found that there are several cases
where such a functionality is implemented so let's have one as a common
There are no users of the function anymore.
Signed-off-by: Akihiko Odaki
---
include/qemu/osdep.h | 8
util/oslib-posix.c | 6 --
util/oslib-win32.c | 10 --
3 files changed, 24 deletions(-)
diff --git a/include/qemu/osdep.h b/include/qemu/osdep.h
index 86445aad25..f2
GUID_DEVINTERFACE_DISK and GUID_DEVINTERFACE_STORAGEPORT are already
defined by MinGW-w64. They are not only unnecessary, but can lead to
duplicate definition errors at link time with some unknown condition.
Signed-off-by: Akihiko Odaki
---
qga/commands-win32.c | 7 ---
1 file changed, 7 del
qemu_get_runtime_dir() is used to construct the default state directory.
Signed-off-by: Akihiko Odaki
---
qga/main.c | 9 -
1 file changed, 4 insertions(+), 5 deletions(-)
diff --git a/qga/main.c b/qga/main.c
index b3580508fa..dc875079f0 100644
--- a/qga/main.c
+++ b/qga/main.c
@@ -46,1
qemu_get_runtime_dir() is used to construct the path to module upgrades.
Signed-off-by: Akihiko Odaki
---
util/module.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/util/module.c b/util/module.c
index 32e263163c..580658edf4 100644
--- a/util/module.c
+++ b/util/module.c
qemu_get_runtime_dir() is used to construct the default Unix socket
path.
Signed-off-by: Akihiko Odaki
---
contrib/rdmacm-mux/main.c | 22 ++
contrib/rdmacm-mux/meson.build | 2 +-
2 files changed, 15 insertions(+), 9 deletions(-)
diff --git a/contrib/rdmacm-mux/main.c
qemu_get_runtime_dir() is used to construct the default paths.
Signed-off-by: Akihiko Odaki
---
scsi/qemu-pr-helper.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/scsi/qemu-pr-helper.c b/scsi/qemu-pr-helper.c
index 196b78c00d..adb7baecaa 100644
--- a/scsi/qemu-pr-hel
qemu_get_runtime_dir() provides QEMU-specific fallback of runtime
directory.
Signed-off-by: Akihiko Odaki
---
ui/spice-app.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/ui/spice-app.c b/ui/spice-app.c
index 7e71e18da9..feb162baa7 100644
--- a/ui/spice-app.c
+++ b/ui/s
qemu_get_runtime_dir() is used to construct the path to a lock file.
Signed-off-by: Akihiko Odaki
---
tools/virtiofsd/fuse_virtio.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/tools/virtiofsd/fuse_virtio.c b/tools/virtiofsd/fuse_virtio.c
index 9368e292e4..b9eeed85e6
Am 09.11.2022 um 17:52 hat Vladimir Sementsov-Ogievskiy geschrieben:
> On 11/8/22 15:37, Kevin Wolf wrote:
> > The subtree drain was introduced in commit b1e1af394d9 as a way to avoid
> > graph changes between finding the base node and changing the block graph
> > as necessary on completion of the
On Wed, Nov 9, 2022 at 1:24 PM Emanuele Giuseppe Esposito
wrote:
> > > What I do know is that it's extremely confusing to understand if a
> > > function that is *not* marked as coroutine_fn is actually being called
> > > also from coroutines or not.
Agreed. This is a huge point in favor of pushin
Am 09.11.2022 um 22:49 hat Stefan Hajnoczi geschrieben:
> On Tue, Nov 08, 2022 at 01:37:26PM +0100, Kevin Wolf wrote:
> > @@ -310,9 +309,20 @@ static void coroutine_fn
> > qed_need_check_timer_entry(void *opaque)
> > (void) ret;
> > }
> >
> > +static void coroutine_fn qed_need_check_timer_
On 11/10/22 13:16, Kevin Wolf wrote:
Am 09.11.2022 um 17:52 hat Vladimir Sementsov-Ogievskiy geschrieben:
On 11/8/22 15:37, Kevin Wolf wrote:
The subtree drain was introduced in commit b1e1af394d9 as a way to avoid
graph changes between finding the base node and changing the block graph
as nece
Am 09.11.2022 um 17:54 hat Hanna Reitz geschrieben:
> Waiting for all active writes to settle before daring to create a
> background copying operation means that we will never do background
> operations while the guest does anything (in write-blocking mode), and
> therefore cannot converge. Yes, w
Am 09.11.2022 um 17:54 hat Hanna Reitz geschrieben:
> mirror_wait_for_free_in_flight_slot() is the only remaining user of
> mirror_wait_for_any_operation(), so inline the latter into the former.
>
> Signed-off-by: Hanna Reitz
Reviewed-by: Kevin Wolf
Am 09.11.2022 um 17:54 hat Hanna Reitz geschrieben:
> There is a small gap in mirror_start_job() before putting the mirror
> filter node into the block graph (bdrv_append() call) and the actual job
> being created. Before the job is created, MirrorBDSOpaque.job is NULL.
>
> It is possible that re
On Wed, Nov 02, 2022 at 02:23:37PM -0400, Stefan Hajnoczi wrote:
> virtio_blk_dma_restart_cb() is tricky because the BH must deal with
> virtio_blk_data_plane_start()/virtio_blk_data_plane_stop() being called.
>
> There are two issues with the code:
>
> 1. virtio_blk_realize() should use qdev_add
Am 09.11.2022 um 17:54 hat Hanna Reitz geschrieben:
> Before this series, a mirror job in write-blocking mode would pause
> issuing background requests while active requests are in flight. Thus,
> if the source is constantly in use by active requests, no actual
> progress can be made.
>
> This se
Am 09.11.2022 um 17:54 hat Hanna Reitz geschrieben:
> Have write requests happen to the source node right when we start a
> mirror job. The mirror filter node may encounter MirrorBDSOpaque.job
> being NULL, but this should not cause a segfault.
>
> Signed-off-by: Hanna Reitz
Reviewed-by: Kevin
On 10.11.22 13:10, Kevin Wolf wrote:
Am 09.11.2022 um 17:54 hat Hanna Reitz geschrieben:
There is a small gap in mirror_start_job() before putting the mirror
filter node into the block graph (bdrv_append() call) and the actual job
being created. Before the job is created, MirrorBDSOpaque.job is
On 08/11/2022 19:52, Vladimir Sementsov-Ogievskiy wrote:
External email: Use caution opening links or attachments
On 11/3/22 19:16, Avihai Horon wrote:
From: Juan Quintela
It was only used for RAM, and in that case, it means that this amount
of data was sent for memory.
Not clear for me,
On 08/11/2022 20:36, Vladimir Sementsov-Ogievskiy wrote:
External email: Use caution opening links or attachments
On 11/3/22 19:16, Avihai Horon wrote:
From: Juan Quintela
And it appears that what is wrong is the code. During bulk stage we
need to make sure that some block is dirty, but no
On 08/11/2022 20:56, Vladimir Sementsov-Ogievskiy wrote:
External email: Use caution opening links or attachments
On 11/3/22 19:16, Avihai Horon wrote:
From: Juan Quintela
Signed-off-by: Juan Quintela
Signed-off-by: Avihai Horon
---
migration/migration.c | 25 +
Am 08.11.2022 um 15:23 hat Alberto Faria geschrieben:
> The nvme-io_uring BlockDriver's path option must point at the character
> device of an NVMe namespace, not at an image file.
>
> Fixes: fd66dbd424f5 ("blkio: add libblkio block driver")
> Suggested-by: Stefano Garzarella
> Signed-off-by: Alb
On 08/11/2022 21:05, Vladimir Sementsov-Ogievskiy wrote:
External email: Use caution opening links or attachments
On 11/3/22 19:16, Avihai Horon wrote:
vfio_migration_init() initializes VFIOMigration->device_state using enum
of VFIO migration protocol v2. Current implemented protocol is v1 s
Am 07.11.2022 um 14:36 hat Claudio Fontana geschrieben:
> Hello Kevin and all,
>
> I seem to be getting intermittent failures with mainline iotest 108. Is this
> already known?
>
> ../configure --enable-tcg --enable-kvm --enable-modules --enable-debug
> make -j
> make -j check
At least I haven'
On 11/10/22 14:50, Kevin Wolf wrote:
> Am 07.11.2022 um 14:36 hat Claudio Fontana geschrieben:
>> Hello Kevin and all,
>>
>> I seem to be getting intermittent failures with mainline iotest 108. Is this
>> already known?
>>
>> ../configure --enable-tcg --enable-kvm --enable-modules --enable-debug
>
Am 08.11.2022 um 15:44 hat Alberto Faria geschrieben:
> Setting it to true can cause the device size to be queried from libblkio
> in otherwise fast paths, degrading performance. Set it to false and
> require users to refresh the device size explicitly instead.
>
> Fixes: 4c8f4fda0504 ("block/blki
Am 07.11.2022 um 16:13 hat Hanna Reitz geschrieben:
> Hi,
>
> v1 cover letter:
> https://lists.nongnu.org/archive/html/qemu-block/2022-09/msg00389.html
>
> bdrv_replace_child_noperm() drains the child via
> bdrv_parent_drained_{begin,end}_single(). When it removes a child, the
> bdrv_parent_drai
On 11/10/22 14:51, Claudio Fontana wrote:
> On 11/10/22 14:50, Kevin Wolf wrote:
>> Am 07.11.2022 um 14:36 hat Claudio Fontana geschrieben:
>>> Hello Kevin and all,
>>>
>>> I seem to be getting intermittent failures with mainline iotest 108. Is
>>> this already known?
>>>
>>> ../configure --enable
On Thu, Nov 10, 2022 at 07:27:59AM -0500, Michael S. Tsirkin wrote:
> On Wed, Nov 02, 2022 at 02:23:37PM -0400, Stefan Hajnoczi wrote:
> > virtio_blk_dma_restart_cb() is tricky because the BH must deal with
> > virtio_blk_data_plane_start()/virtio_blk_data_plane_stop() being called.
> >
> > There
Test streaming a base image into the top image underneath two throttle
nodes. This was reported to make qemu 7.1 hang
(https://gitlab.com/qemu-project/qemu/-/issues/1215), so this serves as
a regression test.
Signed-off-by: Hanna Reitz
---
This is a regression test for
https://lists.nongnu.org/a
On 10.11.22 15:01, Kevin Wolf wrote:
Am 07.11.2022 um 16:13 hat Hanna Reitz geschrieben:
Hi,
v1 cover letter:
https://lists.nongnu.org/archive/html/qemu-block/2022-09/msg00389.html
bdrv_replace_child_noperm() drains the child via
bdrv_parent_drained_{begin,end}_single(). When it removes a chi
Am 10.11.2022 um 12:25 hat Vladimir Sementsov-Ogievskiy geschrieben:
> On 11/10/22 13:16, Kevin Wolf wrote:
> > Am 09.11.2022 um 17:52 hat Vladimir Sementsov-Ogievskiy geschrieben:
> > > On 11/8/22 15:37, Kevin Wolf wrote:
> > > > The subtree drain was introduced in commit b1e1af394d9 as a way to a
Am 10.11.2022 um 17:11 hat Hanna Reitz geschrieben:
> On 10.11.22 15:01, Kevin Wolf wrote:
> > Am 07.11.2022 um 16:13 hat Hanna Reitz geschrieben:
> > > Hi,
> > >
> > > v1 cover letter:
> > > https://lists.nongnu.org/archive/html/qemu-block/2022-09/msg00389.html
> > >
> > > bdrv_replace_child_nop
On Tue, Nov 08, 2022 at 01:37:30PM +0100, Kevin Wolf wrote:
> bdrv_drain_invoke() has now two entirely separate cases that share no
> code any more and are selected depending on a bool parameter. Each case
> has only one caller. Just inline the function.
>
> Signed-off-by: Kevin Wolf
> ---
> blo
On Tue, Nov 08, 2022 at 01:37:25PM +0100, Kevin Wolf wrote:
> I'm aware that exactly nobody has been looking forward to a series with
> this title, but it has to be. The way drain works means that we need to
> poll in bdrv_replace_child_noperm() and that makes things rather messy
> with Emanuele's
On Tue, 8 Nov 2022 at 09:45, Alberto Faria wrote:
>
> Setting it to true can cause the device size to be queried from libblkio
> in otherwise fast paths, degrading performance. Set it to false and
> require users to refresh the device size explicitly instead.
>
> Fixes: 4c8f4fda0504 ("block/blkio:
Hi,
bdrv_coroutine_enter() is IO_CODE but is called from any coroutine
wrapper function. When there is an IOThread and main loop code calls a
coroutine wrapper function then I think bdrv_coroutine_enter() is called
from outside IO_CODE?
Thanks,
Stefan
signature.asc
Description: PGP signature
On Nov 10 10:59, Philippe Mathieu-Daudé wrote:
> On 10/11/22 07:23, Klaus Jensen wrote:
> > From: Klaus Jensen
> >
> > Make nvme_check_constraints() return a bool and fix an invalid error
> > propagation where the actual error is thrown away in favor of an unused
> > local Error value.
> >
> > S
On Nov 10 11:00, Markus Armbruster wrote:
> Klaus Jensen writes:
>
> > From: Klaus Jensen
> >
> > Replace the local Error variable with errp and ERRP_GUARD() and change
> > the return value to bool.
> >
> > Reviewed-by: Markus Armbruster
> > Signed-off-by: Klaus Jensen
> > ---
> > hw/nvme/ctr
From: Klaus Jensen
Fix a couple of invalid errp usages.
v3:
- reword the commit message in patch 1
- fix an embarrassing bug in patch 2
Klaus Jensen (2):
hw/nvme: fix incorrect use of errp/local_err
hw/nvme: cleanup error reporting in nvme_init_pci()
hw/nvme/ctrl.c | 71
From: Klaus Jensen
Replace the local Error variable with errp and ERRP_GUARD() and change
the return value to bool.
Signed-off-by: Klaus Jensen
---
hw/nvme/ctrl.c | 23 ++-
1 file changed, 10 insertions(+), 13 deletions(-)
diff --git a/hw/nvme/ctrl.c b/hw/nvme/ctrl.c
index
From: Klaus Jensen
Remove an unnecessary local Error value in nvme_realize(). In the
process, change nvme_check_constraints() into returning a bool.
Finally, removing the local Error value also fixes a bug where an error
returned from nvme_init_subsys() would be lost.
Reviewed-by: Philippe Math
Klaus Jensen writes:
> From: Klaus Jensen
>
> Remove an unnecessary local Error value in nvme_realize(). In the
> process, change nvme_check_constraints() into returning a bool.
>
> Finally, removing the local Error value also fixes a bug where an error
> returned from nvme_init_subsys() would b
On Nov 11 07:36, Markus Armbruster wrote:
> Klaus Jensen writes:
>
> > From: Klaus Jensen
> >
> > Remove an unnecessary local Error value in nvme_realize(). In the
> > process, change nvme_check_constraints() into returning a bool.
> >
> > Finally, removing the local Error value also fixes a bug
Klaus Jensen writes:
> On Nov 11 07:36, Markus Armbruster wrote:
>> Klaus Jensen writes:
>>
>> > From: Klaus Jensen
>> >
>> > Remove an unnecessary local Error value in nvme_realize(). In the
>> > process, change nvme_check_constraints() into returning a bool.
>> >
>> > Finally, removing the l
On Nov 11 07:55, Markus Armbruster wrote:
> Klaus Jensen writes:
>
> > On Nov 11 07:36, Markus Armbruster wrote:
> >> Klaus Jensen writes:
> >>
> >> > From: Klaus Jensen
> >> >
> >> > Remove an unnecessary local Error value in nvme_realize(). In the
> >> > process, change nvme_check_constraint
57 matches
Mail list logo
