Am 21.11.22 um 23:37 schrieb Michael S. Tsirkin:
[...]
qemu-system-x86_64: ../hw/virtio/vhost-vsock-common.c:203:
vhost_vsock_common_pre_save: Assertion `!vhost_dev_is_started(&vvc->vhost_dev)'
failed.
2022-11-15 16:38:46.096+: shutting down, reason=crashed
Alex were you able to replicate
* Juan Quintela (quint...@redhat.com) wrote:
> We split the function into to:
>
> - state_pending_estimate: We estimate the remaining state size without
> stopping the machine.
>
> - state pending_exact: We calculate the exact amount of remaining
> state.
>
> The only "device" that implement
On Tue, Nov 22, 2022 at 4:13 AM Jason Wang wrote:
>
> On Mon, Nov 21, 2022 at 6:11 PM Stefano Garzarella
> wrote:
> >
> > Commit 69e1c14aa2 ("virtio: core: vq reset feature negotation support")
> > enabled VIRTIO_F_RING_RESET by default for all virtio devices.
> >
> > This feature is not current
* Juan Quintela (quint...@redhat.com) wrote:
> So remove it everywhere.
>
> Signed-off-by: Juan Quintela
Reviewed-by: Dr. David Alan Gilbert
> ---
> include/migration/register.h | 6 ++
> migration/savevm.h | 2 +-
> hw/s390x/s390-stattrib.c | 2 +-
> hw/vfio/migration
On Tue, Nov 22, 2022 at 09:13:44AM +0100, Klaus Jensen wrote:
> There are several bugs in the async cancel code for the Format command.
>
> Firstly, cancelling a format operation neglects to set iocb->ret as well
> as clearing the iocb->aiocb after cancelling the underlying aiocb which
> causes th
On Tue, 22 Nov 2022 at 15:04, Philippe Mathieu-Daudé wrote:
>
> On 21/11/22 17:42, Max Filippov wrote:
> > On Mon, Nov 21, 2022 at 6:01 AM Markus Armbruster wrote:
> >> .../xtensa/core-dsp3400/xtensa-modules.c.inc | 136 +-
> >> target/xtensa/core-lx106/xtensa-modules.c.inc |
On 22/11/22 14:49, Markus Armbruster wrote:
Cc: Fam Zheng
Cc: Kevin Wolf
Cc: Hanna Reitz
Cc: qemu-block@nongnu.org
Signed-off-by: Markus Armbruster
---
block/vmdk.c | 28 +++-
1 file changed, 11 insertions(+), 17 deletions(-)
Reviewed-by: Philippe Mathieu-Daudé
On 21/11/22 17:42, Max Filippov wrote:
On Mon, Nov 21, 2022 at 6:01 AM Markus Armbruster wrote:
.../xtensa/core-dsp3400/xtensa-modules.c.inc | 136 +-
target/xtensa/core-lx106/xtensa-modules.c.inc | 16 +--
These files are generated and were imported from xtensa configurat
On 22/11/22 09:58, Markus Armbruster wrote:
Thomas Huth writes:
On 21/11/2022 17.32, Markus Armbruster wrote:
Philippe Mathieu-Daudé writes:
On 21/11/22 15:36, Peter Maydell wrote:
On Mon, 21 Nov 2022 at 14:03, Markus Armbruster wrote:
Tweak the semantic patch to drop redundant parenth
* Juan Quintela (quint...@redhat.com) wrote:
> It was only used for RAM, and in that case, it means that this amount
> of data was sent for memory. Just delete the field in all callers.
>
> Signed-off-by: Juan Quintela
> ---
> include/migration/register.h | 20 ++--
> migratio
On Tue, 22 Nov 2022 at 13:51, Markus Armbruster wrote:
>
> Cc: Fam Zheng
> Cc: Kevin Wolf
> Cc: Hanna Reitz
> Cc: qemu-block@nongnu.org
> Signed-off-by: Markus Armbruster
> ---
> block/vmdk.c | 28 +++-
> 1 file changed, 11 insertions(+), 17 deletions(-)
>
Reviewed-by
Cc: Fam Zheng
Cc: Kevin Wolf
Cc: Hanna Reitz
Cc: qemu-block@nongnu.org
Signed-off-by: Markus Armbruster
---
block/vmdk.c | 28 +++-
1 file changed, 11 insertions(+), 17 deletions(-)
diff --git a/block/vmdk.c b/block/vmdk.c
index 26376352b9..bac3d8db50 100644
--- a/bloc
On Tue, 22 Nov 2022 at 13:27, Markus Armbruster wrote:
>
> Peter Maydell writes:
> > The obvious answer is "you might have got your manual tweaking
> > wrong". A purely mechanised patch I can review by looking at
> > the script and maybe eyeballing a few instances of the change;
> > a change that
Peter Maydell writes:
> On Tue, 22 Nov 2022 at 08:58, Markus Armbruster wrote:
>> I don't think complete detailed review is necessary or even sensible.
>>
>> Review should start with the Coccinelle script:
>>
>> // replace 'R = X; return R;' with 'return X;'
>> @@
>> identifier VAR;
Am 07.11.2022 um 17:35 hat Vladimir Sementsov-Ogievskiy geschrieben:
> Hi all!
>
> Here is 4-more simple already reviewed patches from
> "[PATCH v5 00/45] Transactional block-graph modifying API" [1]
>
> Called v8 because first part of [1] was recently merged as
> "[PATCH v7 for-7.2 00/15] bloc
On Tue, 22 Nov 2022 at 08:58, Markus Armbruster wrote:
> I don't think complete detailed review is necessary or even sensible.
>
> Review should start with the Coccinelle script:
>
> // replace 'R = X; return R;' with 'return X;'
> @@
> identifier VAR;
> expression E;
> type T;
From: Stefano Garzarella
Commit 69e1c14aa2 ("virtio: core: vq reset feature negotation support")
enabled VIRTIO_F_RING_RESET by default for all virtio devices.
This feature is not currently emulated by QEMU, so for vhost and
vhost-user devices we need to make sure it is supported by the offloade
Am 16.11.2022 um 13:22 hat Emanuele Giuseppe Esposito geschrieben:
> bdrv_can_store_new_dirty_bitmap and bdrv_remove_persistent_dirty_bitmap
> check if they are running in a coroutine, directly calling the
> coroutine callback if it's the case.
> Except that no coroutine calls such functions, there
Am 16.11.2022 um 13:22 hat Emanuele Giuseppe Esposito geschrieben:
> This function is never called in coroutine context, therefore
> instead of manually creating a new coroutine, delegate it to the
> block-coroutine-wrapper script, defining it as g_c_w_simple.
>
> Signed-off-by: Emanuele Giuseppe
Am 22/11/2022 um 09:58 schrieb Kevin Wolf:
> Am 16.11.2022 um 13:22 hat Emanuele Giuseppe Esposito geschrieben:
>> It is always called in coroutine_fn callbacks, therefore
>> it can directly call bdrv_co_create().
>>
>> Signed-off-by: Emanuele Giuseppe Esposito
>> ---
>> block.c
Thomas Huth writes:
> On 21/11/2022 17.32, Markus Armbruster wrote:
>> Philippe Mathieu-Daudé writes:
>>
>>> On 21/11/22 15:36, Peter Maydell wrote:
On Mon, 21 Nov 2022 at 14:03, Markus Armbruster wrote:
>
> Tweak the semantic patch to drop redundant parenthesis around the
> r
Am 16.11.2022 um 13:22 hat Emanuele Giuseppe Esposito geschrieben:
> It is always called in coroutine_fn callbacks, therefore
> it can directly call bdrv_co_create().
>
> Signed-off-by: Emanuele Giuseppe Esposito
> ---
> block.c| 6 --
> include/block/block-global
Am 16.11.2022 um 13:22 hat Emanuele Giuseppe Esposito geschrieben:
> Call two different functions depending on whether bdrv_create
> is in coroutine or not, following the same pattern as
> generated_co_wrapper functions.
>
> This allows to also call the coroutine function directly,
> without using
On Nov 17 14:40, Cédric Le Goater wrote:
> On 11/17/22 12:58, Klaus Jensen wrote:
> > On Nov 17 09:01, Cédric Le Goater wrote:
> > > On 11/17/22 08:37, Klaus Jensen wrote:
> > > > On Nov 17 07:56, Cédric Le Goater wrote:
> > > > > On 11/17/22 07:40, Klaus Jensen wrote:
> > > > > > On Nov 16 16:58,
Am 21.11.2022 um 16:52 hat Emanuele Giuseppe Esposito geschrieben:
> Am 21/11/2022 um 16:30 schrieb Kevin Wolf:
> > Am 16.11.2022 um 13:22 hat Emanuele Giuseppe Esposito geschrieben:
> >> Basically BdrvPollCo->bs is only used by bdrv_poll_co(), and the
> >> functions that it uses are both using bdr
Am 21.11.2022 um 22:19 hat Stefan Hajnoczi geschrieben:
> bdrv_*() APIs expect a valid BlockDriverState. Calling them with bs=NULL
> leads to undefined behavior.
>
> Jonathan Cameron reported this following NULL pointer dereference when a
> VM with a virtio-blk device and a memory-backend-file obj
From: Klaus Jensen
If the zone reset operation is cancelled but the block unmap operation
completes normally, the callback will continue resetting the next zone
since it neglects to check iocb->ret which will have been set to
-ECANCELED. Make sure that this is checked and bail out if an error is
From: Klaus Jensen
When the DSM operation is cancelled asynchronously, we set iocb->ret to
-ECANCELED. However, the callback function only checks the return value
of the completed aio, which may have completed succesfully prior to the
cancellation and thus the callback ends up continuing the dsm
From: Klaus Jensen
Make sure that iocb->aiocb is NULL'ed when cancelling.
Fix a potential use-after-free by removing the bottom half and enqueuing
the completion directly.
Fixes: 38f4ac65ac88 ("hw/nvme: reimplement flush to allow cancellation")
Signed-off-by: Klaus Jensen
---
hw/nvme/ctrl.c |
From: Klaus Jensen
Fix a potential use-after-free by removing the bottom half and enqueuing
the completion directly.
Fixes: 796d20681d9b ("hw/nvme: reimplement the copy command to allow aio
cancellation")
Signed-off-by: Klaus Jensen
---
hw/nvme/ctrl.c | 63 +++-
From: Klaus Jensen
There are several bugs in the async cancel code for the Format command.
Firstly, cancelling a format operation neglects to set iocb->ret as well
as clearing the iocb->aiocb after cancelling the underlying aiocb which
causes the aio callback to ignore the cancellation. Trivial
From: Klaus Jensen
A new blktests nvme test unearthed some bad bugs in the asynchronous
cancellation handling.
Fix this for all commands that implement async_cancel(). The fix is the
same for all commands: remove the deferred enqueuing (a bottom half
scheduling) of the request completion.
Klaus
32 matches
Mail list logo
