RE: [PATCH v4 1/2] hw/nvme: Support for Namespaces Management from guest OS - create-ns

2022-12-28 Thread Michael Kropaczek (CW)
Hi Keith, Thank you for the review and I agree with you, the issues will be addressed. Regards, Michael -Original Message- From: Keith Busch Sent: Wednesday, December 28, 2022 12:10 PM To: Jonathan Derrick Cc: qemu-de...@nongnu.org; Michael Kropaczek (CW) ; qemu-block@nongnu.org; K

Re: [PATCH v4 1/2] hw/nvme: Support for Namespaces Management from guest OS - create-ns

2022-12-28 Thread Keith Busch
On Wed, Dec 28, 2022 at 01:41:40PM -0600, Jonathan Derrick wrote: > +static uint16_t nvme_ns_mgmt(NvmeCtrl *n, NvmeRequest *req) > +{ > +NvmeCtrl *n_p = NULL; /* primary controller */ > +NvmeIdCtrl *id = &n->id_ctrl; > +NvmeNamespace *ns; > +NvmeIdNsMgmt id_ns = {}; > +uint8

[PATCH v4 1/2] hw/nvme: Support for Namespaces Management from guest OS - create-ns

2022-12-28 Thread Jonathan Derrick
From: Michael Kropaczek Added support for NVMEe NameSpaces Mangement allowing the guest OS to create namespaces by issuing nvme create-ns command. It is an extension to currently implemented Qemu nvme virtual device. Virtual devices representing namespaces will be created and/or deleted during Qe

[PATCH v4 2/2] hw/nvme: Support for Namespaces Management from guest OS - delete-ns

2022-12-28 Thread Jonathan Derrick
From: Michael Kropaczek Added support for NVMEe NameSpaces Mangement allowing the guest OS to delete namespaces by issuing nvme delete-ns command. It is an extension to currently implemented Qemu nvme virtual device. Virtual devices representing namespaces will be created and/or deleted during Qe

[PATCH v4 0/2] hw/nvme: Support for Namespaces Management from guest OS

2022-12-28 Thread Jonathan Derrick
From: Michael Kropaczek Description: Currently namespaces could be configured as follows: 1. Legacy Namespace - just one namespace within Nvme controller's where the back-end was specified for nvme device by -drive parameter pointing directly to the image file. 2. Additional Namespaces - s