Re: [PATCH 1/2] hw/ide/core.c (cmd_read_native_max): Avoid limited device parameters

John Snow writes: > On Mon, Oct 10, 2022 at 4:52 AM Lev Kujawski wrote: >> >> Always use the native CHS device parameters for the ATA commands READ >> NATIVE MAX ADDRESS and READ NATIVE MAX ADDRESS EXT, not those limited >> by the ATA command INITIALIZE_DEVICE_PARAMETERS (introduced in patch

Re: [PATCH v2 1/4] hw: Remove hardcoded tabs (code style)

On 1/11/23 00:39, Philippe Mathieu-Daudé wrote: We are going to modify this code, fix its style first to avoid the following checkpatch.pl violations: ERROR: code indent should never use tabs ERROR: space prohibited between function name and open parenthesis '(' Signed-off-by: Philippe

Re: [PATCH v2 2/4] bulk: Coding style fixes

On 1/11/23 00:39, Philippe Mathieu-Daudé wrote: Fix the following checkpatch.pl violation on lines using the TARGET_FMT_plx definition to avoid: WARNING: line over 80 characters Signed-off-by: Philippe Mathieu-Daudé --- hw/block/pflash_cfi01.c | 5 +++-- hw/char/digic-uart.c

Re: [PATCH v2 3/4] bulk: Replace TARGET_FMT_plx -> HWADDR_PRIx

On 1/11/23 00:39, Philippe Mathieu-Daudé wrote: The 'hwaddr' type is defined in "exec/hwaddr.h" as: hwaddr is the type of a physical address (its size can be different from 'target_ulong'). All definitions use the 'HWADDR_' prefix, except TARGET_FMT_plx: $ fgrep define

Re: [PATCH v6 25/33] hw/isa/piix4: Use TYPE_ISA_PIC device

Am 11. Januar 2023 17:08:28 UTC schrieb "Philippe Mathieu-Daudé" : >On 9/1/23 18:23, Bernhard Beschow wrote: >> Aligns the code with PIIX3 such that PIIXState can be used in PIIX4, >> too. >> >> Signed-off-by: Bernhard Beschow >> Reviewed-by: Michael S. Tsirkin >> Message-Id:

Re: [PATCH 11/15] block-backend: make queued_requests thread-safe

On Mon, Dec 12, 2022 at 01:59:16PM +0100, Paolo Bonzini wrote: > Protect quiesce_counter and queued_requests with a QemuMutex, so that > they are protected from concurrent access in the main thread (for example > blk_root_drained_end() reached from bdrv_drain_all()) and in the iothread > (where

Re: [PATCH v6 25/33] hw/isa/piix4: Use TYPE_ISA_PIC device

On 9/1/23 18:23, Bernhard Beschow wrote: Aligns the code with PIIX3 such that PIIXState can be used in PIIX4, too. Signed-off-by: Bernhard Beschow Reviewed-by: Michael S. Tsirkin Message-Id: <20221022150508.26830-33-shen...@gmail.com> --- hw/isa/piix4.c | 28 ++--

Re: Questions about how block devices use snapshots

Hi Kevin, Can I ask again how base.img + diff.qcow2 can be re-merged into one image via qemu-img or hmp command when modified.img is discarded? Regards Zhiyong On 1/11/23 10:32 PM, Kevin Wolf wrote: Am 11.01.2023 um 08:55 hat Zhiyong Ye geschrieben: Hi Kevin, Thank you for your reply and

Re: Zoned storage support in libvirt

On Tue, Jan 10, 2023 at 03:29:47PM +, Daniel P. Berrangé wrote: > On Tue, Jan 10, 2023 at 10:19:51AM -0500, Stefan Hajnoczi wrote: > > Hi Peter, > > Zoned storage support > > (https://zonedstorage.io/docs/introduction/zoned-storage) is being added > > to QEMU. Given a zoned host block device,

Re: Questions about how block devices use snapshots

Am 11.01.2023 um 08:55 hat Zhiyong Ye geschrieben: > Hi Kevin, > > Thank you for your reply and detailed answers. > > In my scenario is the iSCSI SAN environment. The network storage device is > connected to the physical machine via iSCSI, and LVM is used as the middle > layer between the

Re: [RFC PATCH 0/4] qom: Introduce object_class_property_deprecate()

On 11/1/23 12:29, Markus Armbruster wrote: Daniel P. Berrangé writes: On Wed, Jan 11, 2023 at 11:08:05AM +0100, Philippe Mathieu-Daudé wrote: On 11/1/23 10:59, Daniel P. Berrangé wrote: On Wed, Jan 11, 2023 at 10:55:47AM +0100, Philippe Mathieu-Daudé wrote: On 10/1/23 14:02, Kevin Wolf

Re: [RFC PATCH 0/4] qom: Introduce object_class_property_deprecate()

Daniel P. Berrangé writes: > On Wed, Jan 11, 2023 at 11:08:05AM +0100, Philippe Mathieu-Daudé wrote: >> On 11/1/23 10:59, Daniel P. Berrangé wrote: >> > On Wed, Jan 11, 2023 at 10:55:47AM +0100, Philippe Mathieu-Daudé wrote: >> > > On 10/1/23 14:02, Kevin Wolf wrote: >> > > > Am 09.01.2023 um

Re: [RFC PATCH 0/4] qom: Introduce object_class_property_deprecate()

On Wed, Jan 11, 2023 at 11:08:05AM +0100, Philippe Mathieu-Daudé wrote: > On 11/1/23 10:59, Daniel P. Berrangé wrote: > > On Wed, Jan 11, 2023 at 10:55:47AM +0100, Philippe Mathieu-Daudé wrote: > > > On 10/1/23 14:02, Kevin Wolf wrote: > > > > Am 09.01.2023 um 23:54 hat Philippe Mathieu-Daudé

Re: [RFC PATCH 0/4] qom: Introduce object_class_property_deprecate()

On 11/1/23 10:59, Daniel P. Berrangé wrote: On Wed, Jan 11, 2023 at 10:55:47AM +0100, Philippe Mathieu-Daudé wrote: On 10/1/23 14:02, Kevin Wolf wrote: Am 09.01.2023 um 23:54 hat Philippe Mathieu-Daudé geschrieben: Hi, There will always be a need to deprecate things. Here I'm tackling the

Re: [PATCH v5 10/14] vfio/migration: Implement VFIO migration protocol v2

On 10/01/2023 18:19, Cédric Le Goater wrote: External email: Use caution opening links or attachments Hello Avihai On 1/10/23 15:08, Avihai Horon wrote: On 09/01/2023 20:36, Jason Gunthorpe wrote: On Mon, Jan 09, 2023 at 06:27:21PM +0100, Cédric Le Goater wrote: also, in

Re: [RFC PATCH 0/4] qom: Introduce object_class_property_deprecate()

On Wed, Jan 11, 2023 at 10:55:47AM +0100, Philippe Mathieu-Daudé wrote: > On 10/1/23 14:02, Kevin Wolf wrote: > > Am 09.01.2023 um 23:54 hat Philippe Mathieu-Daudé geschrieben: > > > Hi, > > > > > > There will always be a need to deprecate things. Here I'm > > > tackling the QOM (class)

Re: [RFC PATCH 0/4] qom: Introduce object_class_property_deprecate()

On 10/1/23 14:02, Kevin Wolf wrote: Am 09.01.2023 um 23:54 hat Philippe Mathieu-Daudé geschrieben: Hi, There will always be a need to deprecate things. Here I'm tackling the QOM (class) properties, since they can be set from some CLI options (-object -device -global ...). As an experiment, we

[PATCH v2 0/4] bulk: Replace TARGET_FMT_plx by HWADDR_PRIx

Since v1: - Fix checkpatch style violations - Use HWADDR_PRIx instead of HWADDR_FMT_plx (Zoltan) Supersedes: <20230110212947.34557-1-phi...@linaro.org> "bulk: Rename TARGET_FMT_plx -> HWADDR_FMT_plx" Philippe Mathieu-Daudé (4): hw: Remove hardcoded tabs (code style) bulk: Coding

[PATCH v2 1/4] hw: Remove hardcoded tabs (code style)

We are going to modify this code, fix its style first to avoid the following checkpatch.pl violations: ERROR: code indent should never use tabs ERROR: space prohibited between function name and open parenthesis '(' Signed-off-by: Philippe Mathieu-Daudé --- hw/dma/etraxfs_dma.c | 196

[RFC PATCH v2 4/4] bulk: Prefix '0x' to hex values displayed with HWADDR_PRIx format

Automatic change running: $ sed -i -E \ 's/([^0][^x])%016" HWADDR_PRIx/\10x%016" HWADDR_PRIx/g' \ $(git grep -l -F '%016" HWADDR_PRIx') Signed-off-by: Philippe Mathieu-Daudé --- RFC: Maybe some non-0x prefix are justified in some cases, i.e. 'info mtree' output, or

[PATCH v2 2/4] bulk: Coding style fixes

Fix the following checkpatch.pl violation on lines using the TARGET_FMT_plx definition to avoid: WARNING: line over 80 characters Signed-off-by: Philippe Mathieu-Daudé --- hw/block/pflash_cfi01.c | 5 +++-- hw/char/digic-uart.c | 8 hw/core/sysbus.c |

[PATCH v2 3/4] bulk: Replace TARGET_FMT_plx -> HWADDR_PRIx

The 'hwaddr' type is defined in "exec/hwaddr.h" as: hwaddr is the type of a physical address (its size can be different from 'target_ulong'). All definitions use the 'HWADDR_' prefix, except TARGET_FMT_plx: $ fgrep define include/exec/hwaddr.h #define HWADDR_H #define HWADDR_BITS 64