Re: completion timeouts with pin-based interrupts in QEMU hw/nvme

On Thu, Jan 12, 2023 at 02:10:51PM +0100, Klaus Jensen wrote: > Hi all (linux-nvme, qemu-devel, maintainers), > > On QEMU riscv64, which does not use MSI/MSI-X and thus relies on > pin-based interrupts, I'm seeing occasional completion timeouts, i.e. > > nvme nvme0: I/O 333 QID 1 timeout,

Re: completion timeouts with pin-based interrupts in QEMU hw/nvme

On Tue, Jan 17, 2023 at 04:18:14PM +, Peter Maydell wrote: > On Tue, 17 Jan 2023 at 16:10, Guenter Roeck wrote: > > > > On Mon, Jan 16, 2023 at 09:58:13PM -0700, Keith Busch wrote: > > > On Mon, Jan 16, 2023 at 10:14:07PM +0100, Klaus Jensen wrote: > > > > I noticed that the Linux driver does

Re: [PATCH] blkdebug: ignore invalid rules in non-coroutine context

Am 17.01.2023 um 16:44 hat Kevin Wolf geschrieben: > Am 15.12.2022 um 14:02 hat Paolo Bonzini geschrieben: > > blkdebug events can be called from either non-coroutine or coroutine > > contexts. However, suspend actions only make sense from within > > a coroutine. Currently, using those action

Re: completion timeouts with pin-based interrupts in QEMU hw/nvme

On Tue, 17 Jan 2023 at 16:10, Guenter Roeck wrote: > > On Mon, Jan 16, 2023 at 09:58:13PM -0700, Keith Busch wrote: > > On Mon, Jan 16, 2023 at 10:14:07PM +0100, Klaus Jensen wrote: > > > I noticed that the Linux driver does not use the INTMS/INTMC registers > > > to mask interrupts on the

Re: completion timeouts with pin-based interrupts in QEMU hw/nvme

On Mon, Jan 16, 2023 at 09:58:13PM -0700, Keith Busch wrote: > On Mon, Jan 16, 2023 at 10:14:07PM +0100, Klaus Jensen wrote: > > I noticed that the Linux driver does not use the INTMS/INTMC registers > > to mask interrupts on the controller while processing CQEs. While not > > required by the

Re: completion timeouts with pin-based interrupts in QEMU hw/nvme

On Mon, Jan 16, 2023 at 10:14:07PM +0100, Klaus Jensen wrote: [ ... ] > > I noticed that the Linux driver does not use the INTMS/INTMC registers > to mask interrupts on the controller while processing CQEs. While not > required by the spec, it is *recommended* in setups not using MSI-X to >

Re: [PATCH] block: remove bdrv_coroutine_enter

Am 15.12.2022 um 14:02 hat Paolo Bonzini geschrieben: > It has only one caller---inline it and remove the function. > > Signed-off-by: Paolo Bonzini Thanks, applied to the block branch. Kevin

Re: [PATCH] qemu-io: do not reinvent the blk_pwrite_zeroes wheel

Am 15.12.2022 um 14:02 hat Paolo Bonzini geschrieben: > qemu-io's do_co_pwrite_zeroes is reinventing the coroutine wrapper > blk_pwrite_zeroes. Just use the real thing directly. > > Signed-off-by: Paolo Bonzini Thanks, applied to the block branch. Kevin

Re: [PATCH] blkdebug: ignore invalid rules in non-coroutine context

Am 15.12.2022 um 14:02 hat Paolo Bonzini geschrieben: > blkdebug events can be called from either non-coroutine or coroutine > contexts. However, suspend actions only make sense from within > a coroutine. Currently, using those action would lead to an abort() in > qemu_coroutine_yield()

Re: [PATCH 0/2] Make coroutine annotations ready for static analysis

Am 16.12.2022 um 12:07 hat Paolo Bonzini geschrieben: > Clang has a generic __annotate__ attribute that can be used by > static analyzers to understand properties of functions and > analyze the control flow. > > Unlike TSA annotations, the __annotate__ attribute applies to function > pointers as

Re: [PATCH 0/4] qemu-img: Fix exit code for errors closing the image

On 12.01.23 20:14, Kevin Wolf wrote: This series addresses the problem described in these bug reports: https://gitlab.com/qemu-project/qemu/-/issues/1330 https://bugzilla.redhat.com/show_bug.cgi?id=2147617 qcow2 can fail when writing back dirty bitmaps in qcow2_inactivate(). However, when the