Re: [PATCH v2 30/32] contrib/gitdm: add revng to domain map

2023-03-15 Thread Alessandro Di Federico via
On Wed, 15 Mar 2023 17:43:29 + Alex Bennée wrote: > +rev.ng revng Can we have "rev.ng Labs"? I suggested this in my previous e-mail too, but maybe it slipped away. -- Alessandro Di Federico rev.ng Labs

Re: [PATCH v6 1/4] file-posix: add tracking of the zone write pointers

2023-03-15 Thread Damien Le Moal
On 3/15/23 21:59, Sam Li wrote: > Damien Le Moal 于2023年3月14日周二 11:49写道: >> >> On 3/14/23 11:23, Dmitry Fomichev wrote: @@ -3339,10 +3473,27 @@ static int coroutine_fn raw_co_zone_mgmt(BlockDriverState *bs, BlockZoneOp op, len >> BDRV_SECTOR_BITS);

RE: [PATCH v2 28/32] contrib/gitdm: add Amazon to the domain map

2023-03-15 Thread Durrant, Paul
> -Original Message- > From: Alex Bennée > Sent: 15 March 2023 17:43 > To: qemu-de...@nongnu.org > Cc: Akihiko Odaki ; Marc-André Lureau > ; qemu-ri...@nongnu.org; Riku Voipio > ; Igor Mammedov ; Xiao Guangrong > ; Thomas Huth ; Wainer dos > Santos Moschetta ; Dr. David Alan Gilbert > ; Al

Re: [RFC 1/2] block: Split padded I/O vectors exceeding IOV_MAX

2023-03-15 Thread Stefan Hajnoczi
On Wed, Mar 15, 2023 at 01:13:29PM +0100, Hanna Czenczek wrote: > When processing vectored guest requests that are not aligned to the > storage request alignment, we pad them by adding head and/or tail > buffers for a read-modify-write cycle. > > The guest can submit I/O vectors up to IOV_MAX (102

Re: [RFC 1/2] block: Split padded I/O vectors exceeding IOV_MAX

2023-03-15 Thread Eric Blake
On Wed, Mar 15, 2023 at 01:13:29PM +0100, Hanna Czenczek wrote: > When processing vectored guest requests that are not aligned to the > storage request alignment, we pad them by adding head and/or tail > buffers for a read-modify-write cycle. > > The guest can submit I/O vectors up to IOV_MAX (102

[PATCH v2 25/32] iotests: remove the check-block.sh script

2023-03-15 Thread Alex Bennée
From: Daniel P. Berrangé Now that meson directly invokes the individual I/O tests, the check-block.sh wrapper script is no longer required. Signed-off-by: Daniel P. Berrangé Reviewed-by: Thomas Huth Acked-by: Hanna Czenczek Tested-by: Thomas Huth Message-Id: <20230303160727.3977246-9-berra..

[PATCH v2 22/32] iotests: connect stdin to /dev/null when running tests

2023-03-15 Thread Alex Bennée
From: Daniel P. Berrangé Currently the tests have their stdin inherited from the test harness, meaning they are connected to a TTY. The QEMU processes spawned by certain tests, however, modify TTY settings and if the test exits abnormally the settings might not be restored. The python test harne

[PATCH v2 11/32] tcg: Clear plugin_mem_cbs on TB exit

2023-03-15 Thread Alex Bennée
From: Richard Henderson Do this in cpu_tb_exec (normal exit) and cpu_loop_exit (exception), adjacent to where we reset can_do_io. Resolves: https://gitlab.com/qemu-project/qemu/-/issues/1381 Signed-off-by: Richard Henderson Message-Id: <20230310195252.210956-2-richard.hender...@linaro.org> Sign

[PATCH v2 30/32] contrib/gitdm: add revng to domain map

2023-03-15 Thread Alex Bennée
Signed-off-by: Alex Bennée Cc: Anton Johansson Cc: Niccolò Izzo Cc: Paolo Montesel Reviewed-by: Alessandro Di Federico Message-Id: <20230310180332.2274827-9-alex.ben...@linaro.org> --- contrib/gitdm/domain-map | 1 + 1 file changed, 1 insertion(+) diff --git a/contrib/gitdm/domain-map b/cont

[PATCH v2 13/32] include/qemu/plugin: Remove QEMU_PLUGIN_ASSERT

2023-03-15 Thread Alex Bennée
From: Richard Henderson This macro is no longer used. Signed-off-by: Richard Henderson Message-Id: <20230310195252.210956-4-richard.hender...@linaro.org> Signed-off-by: Alex Bennée --- include/qemu/plugin.h | 4 1 file changed, 4 deletions(-) diff --git a/include/qemu/plugin.h b/include

[PATCH v2 31/32] contrib/gitdm: add more individual contributors

2023-03-15 Thread Alex Bennée
I've only added the names explicitly acked. Signed-off-by: Alex Bennée Cc: Bernhard Beschow Cc: Amarjargal Gundjalam Cc: Bin Meng Cc: Jason A. Donenfeld Cc: Strahinja Jankovic Acked-by: Bernhard Beschow Message-Id: <20230310180332.2274827-10-alex.ben...@linaro.org> --- contrib/gitdm/group-

[PATCH v2 29/32] contrib/gitdm: add Alibaba to the domain-map

2023-03-15 Thread Alex Bennée
This replaces the previous attempt to add c-sky.com. Group everything under Alibaba now. Added as requested by LIU Zhiwei. Signed-off-by: Alex Bennée Acked-by: Guo Ren Reviewed-by: Xuan Zhuo Reviewed-by: LIU Zhiwei Message-Id: <20230310180332.2274827-8-alex.ben...@linaro.org> --- contrib/git

[PATCH v2 08/32] tests/tcg: disable pauth for aarch64 gdb tests

2023-03-15 Thread Alex Bennée
You need a very new gdb to be able to run with pauth support otherwise your likely to hit asserts and aborts. Disable pauth for now until we can properly probe support in gdb. Message-Id: <20230310103123.2118519-10-alex.ben...@linaro.org> Reviewed-by: Richard Henderson Signed-off-by: Alex Bennée

[PATCH v2 23/32] iotests: always use a unique sub-directory per test

2023-03-15 Thread Alex Bennée
From: Daniel P. Berrangé The current test runner is only safe against parallel execution within a single instance of the 'check' process, and only if -j is given a value greater than 2. This prevents running multiple copies of the 'check' process for different test scenarios. This change switche

[PATCH v2 10/32] tests/avocado: don't use tags to define drive

2023-03-15 Thread Alex Bennée
We are abusing the avocado tags which are intended to provide test selection metadata to provide parameters to our test. This works OK up until the point you need to have ,'s in the field as this is the tag separator character which is the case for a number of the drive parameters. Fix this by maki

[PATCH v2 09/32] include/exec: fix kerneldoc definition

2023-03-15 Thread Alex Bennée
The kerneldoc processor complains about the mismatched variable name. Fix it. Message-Id: <20230310103123.2118519-11-alex.ben...@linaro.org> Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Alex Bennée --- include/exec/memory.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH v2 28/32] contrib/gitdm: add Amazon to the domain map

2023-03-15 Thread Alex Bennée
We have multiple contributors from both .co.uk and .com versions of the address. Signed-off-by: Alex Bennée Cc: Alexander Graf Cc: Paul Durrant Cc: David Wooodhouse Reviewed-by: Philippe Mathieu-Daudé Message-Id: <20230310180332.2274827-7-alex.ben...@linaro.org> --- contrib/gitdm/domain-map

[PATCH v2 12/32] tcg: Drop plugin_gen_disable_mem_helpers from tcg_gen_exit_tb

2023-03-15 Thread Alex Bennée
From: Richard Henderson Now that we call qemu_plugin_disable_mem_helpers in cpu_tb_exec, we don't need to do this in generated code as well. Signed-off-by: Richard Henderson Message-Id: <20230310195252.210956-3-richard.hender...@linaro.org> Signed-off-by: Alex Bennée --- tcg/tcg-op.c | 1 - 1

[PATCH v2 15/32] *: Add missing includes of qemu/plugin.h

2023-03-15 Thread Alex Bennée
From: Richard Henderson This had been pulled in from hw/core/cpu.h, but that will be removed. Signed-off-by: Richard Henderson Reviewed-by: Philippe Mathieu-Daudé Message-Id: <20230310195252.210956-6-richard.hender...@linaro.org> [AJB: also syscall-trace.h] Signed-off-by: Alex Bennée --- inc

[PATCH v2 26/32] contrib/gitdm: Add ASPEED Technology to the domain map

2023-03-15 Thread Alex Bennée
We have a number of contributors from this domain which is a corporate endeavour. Signed-off-by: Alex Bennée Cc: Steven Lee Cc: Troy Lee Cc: Howard Chiu Cc: Jamin Lin Reviewed-by: Troy Lee Message-Id: <20230310180332.2274827-4-alex.ben...@linaro.org> --- contrib/gitdm/domain-map | 1 + 1 fi

[PATCH v2 19/32] iotests: allow test discovery before building

2023-03-15 Thread Alex Bennée
From: Daniel P. Berrangé The 'check' script can be invoked in "dry run" mode, in which case it merely does test discovery and prints out all their names. Despite only doing test discovery it still validates that the various QEMU binaries can be found. This makes it impossible todo test discovery

[PATCH v2 20/32] iotests: strip subdir path when listing tests

2023-03-15 Thread Alex Bennée
From: Daniel P. Berrangé When asking 'check' to list individual tests by invoking it in dry run mode, it prints the paths to the tests relative to the base of the I/O test directory. When asking 'check' to run an individual test, however, it mandates that only the unqualified test name is given,

[PATCH v2 32/32] contrib/gitdm: add group map for AMD

2023-03-15 Thread Alex Bennée
AMD recently acquired Xilinx and contributors have been transitioning their emails across. Signed-off-by: Alex Bennée Cc: Vikram Garhwal Cc: Stefano Stabellini Cc: Sai Pavan Boddu Cc: Tong Ho Reviewed-by: Francisco Iglesias Message-Id: <20230310180332.2274827-11-alex.ben...@linaro.org> ---

[PATCH v2 27/32] contrib/gitdm: Add SYRMIA to the domain map

2023-03-15 Thread Alex Bennée
The company website lists QEMU amongst the things they work on so I assume these are corporate contributions. Signed-off-by: Alex Bennée Cc: Milica Lazarevic Reviewed-by: Philippe Mathieu-Daudé Message-Id: <20230310180332.2274827-6-alex.ben...@linaro.org> --- contrib/gitdm/domain-map | 1 + 1

[PATCH v2 24/32] iotests: register each I/O test separately with meson

2023-03-15 Thread Alex Bennée
From: Daniel P. Berrangé Currently meson registers a single test that invokes an entire group of I/O tests, hiding the test granularity from meson. There are various downsides of doing this * You cannot ask 'meson test' to invoke a single I/O test * The meson test timeout can't be applied to t

[PATCH v2 18/32] iotests: explicitly pass source/build dir to 'check' command

2023-03-15 Thread Alex Bennée
From: Daniel P. Berrangé The 'check' script has some rather dubious logic whereby it assumes that if invoked as a symlink, then it is running from a separate source tree and build tree, otherwise it assumes the current working directory is a combined source and build tree. This doesn't work if y

[PATCH v2 14/32] *: Add missing includes of qemu/error-report.h

2023-03-15 Thread Alex Bennée
From: Richard Henderson This had been pulled in via qemu/plugin.h from hw/core/cpu.h, but that will be removed. Signed-off-by: Richard Henderson Reviewed-by: Philippe Mathieu-Daudé Message-Id: <20230310195252.210956-5-richard.hender...@linaro.org> [AJB: add various additional cases shown by CI

[PATCH v2 21/32] iotests: print TAP protocol version when reporting tests

2023-03-15 Thread Alex Bennée
From: Daniel P. Berrangé Recently meson started complaining that TAP test reports don't include the TAP protocol version. While this warning is bogus and has since been removed from Meson, it looks like good practice to include this header going forward. The GLib library test harness has started

[PATCH v2 00/32] tweaks and fixes for 8.0-rc1 (tests, plugins, docs)

2023-03-15 Thread Alex Bennée
As usual for softfreeze I switch from my usual maintainer trees to collecting up miscellaneous fixes and tweaks as we stabilise the build. I was intending to send it as a PR but I had to squash a number of CI failures by adding stuff to: *: Add missing includes of qemu/error-report.h *

[PATCH v2 16/32] include/qemu: Split out plugin-event.h

2023-03-15 Thread Alex Bennée
From: Richard Henderson The usage in hw/core/cpu.h only requires QEMU_PLUGIN_EV_MAX. Signed-off-by: Richard Henderson Reviewed-by: Philippe Mathieu-Daudé Message-Id: <20230310195252.210956-7-richard.hender...@linaro.org> Signed-off-by: Alex Bennée --- include/hw/core/cpu.h | 2 +- inc

[PATCH v2 06/32] include/qemu: add documentation for memory callbacks

2023-03-15 Thread Alex Bennée
Some API documentation was missed, rectify that. Fixes: https://gitlab.com/qemu-project/qemu/-/issues/1497 Signed-off-by: Alex Bennée --- include/qemu/qemu-plugin.h | 47 ++ 1 file changed, 43 insertions(+), 4 deletions(-) diff --git a/include/qemu/qemu-plugi

[PATCH v2 02/32] tests/docker: all add DOCKER_BUILDKIT to RUNC environment

2023-03-15 Thread Alex Bennée
It seems we also need to pass DOCKER_BUILDKIT as an argument to docker itself to get the full benefit of caching. Signed-off-by: Alex Bennée Suggested-by: Fabiano Rosas --- tests/docker/Makefile.include | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/docker/Makefile.in

[PATCH v2 01/32] tests/avocado: update AArch64 tests to Alpine 3.17.2

2023-03-15 Thread Alex Bennée
From: Marcin Juszkiewicz To test Alpine boot on SBSA-Ref target we need Alpine Linux 'standard' image as 'virt' one lacks kernel modules. So to minimalize Avocado cache I move test to 'standard' image. Signed-off-by: Marcin Juszkiewicz Reviewed-by: Philippe Mathieu-Daudé Message-Id: <20230310

[PATCH v2 17/32] include/qemu/plugin: Inline qemu_plugin_disable_mem_helpers

2023-03-15 Thread Alex Bennée
From: Richard Henderson Now that we've broken the include loop with cpu.h, we can bring this inline. Signed-off-by: Richard Henderson Reviewed-by: Philippe Mathieu-Daudé Message-Id: <20230310195252.210956-8-richard.hender...@linaro.org> Signed-off-by: Alex Bennée --- include/qemu/plugin.h |

[PATCH v2 07/32] tests/tcg: add some help output for running individual tests

2023-03-15 Thread Alex Bennée
So you can do: cd tests/tcg/aarch64-linux-user make -f ../Makefile.target help To see the list of tests. You can then run each one individually. Signed-off-by: Alex Bennée --- tests/tcg/Makefile.target | 7 +++ 1 file changed, 7 insertions(+) diff --git a/tests/tcg/Makefile.target b/t

[PATCH v2 05/32] gitlab: update centos-8-stream job

2023-03-15 Thread Alex Bennée
A couple of clean-ups here: - inherit from the custom runners job for artefacts - call check-avocado directly - add some comments to the top about setup Signed-off-by: Alex Bennée --- .../custom-runners/centos-stream-8-x86_64.yml | 18 ++ 1 file changed, 6 insertions(+),

[PATCH v2 03/32] scripts/ci: add libslirp-devel to build-environment

2023-03-15 Thread Alex Bennée
Without libslip enabled we won't have user networking which means the KVM tests won't run. Reviewed-by: Thomas Huth Signed-off-by: Alex Bennée --- scripts/ci/org.centos/stream/8/build-environment.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/scripts/ci/org.centos/stream/8/build-enviro

[PATCH v2 04/32] scripts/ci: update gitlab-runner playbook to handle CentOS

2023-03-15 Thread Alex Bennée
This was broken when we moved to using the pre-built packages as we didn't take care to ensure we used RPMs where required. NB: I could never get this to complete on my test setup but I suspect this was down to network connectivity and timeouts while downloading. Fixes: 69c4befba1 (scripts/ci: up

Re: [RFC 0/2] Split padded I/O vectors exceeding IOV_MAX

2023-03-15 Thread Hanna Czenczek
On 15.03.23 16:29, Stefan Hajnoczi wrote: On Wed, Mar 15, 2023 at 01:13:28PM +0100, Hanna Czenczek wrote: Hi, We accept I/O vectors with up to 1024 (IOV_MAX) elements from guests. When a guest request does not conform to the underlying storage's alignment requirements, we pad it with head and/o

Re: [RFC 0/2] Split padded I/O vectors exceeding IOV_MAX

2023-03-15 Thread Stefan Hajnoczi
On Wed, Mar 15, 2023 at 01:13:28PM +0100, Hanna Czenczek wrote: > Hi, > > We accept I/O vectors with up to 1024 (IOV_MAX) elements from guests. > When a guest request does not conform to the underlying storage's > alignment requirements, we pad it with head and/or tail buffers as > necessary, whic

Re: [PATCH v6 1/4] file-posix: add tracking of the zone write pointers

2023-03-15 Thread Sam Li
Damien Le Moal 于2023年3月14日周二 11:49写道: > > On 3/14/23 11:23, Dmitry Fomichev wrote: > >> @@ -3339,10 +3473,27 @@ static int coroutine_fn > >> raw_co_zone_mgmt(BlockDriverState *bs, BlockZoneOp op, > >> len >> BDRV_SECTOR_BITS); > >> ret = raw_thread_pool_submit(bs, han

[RFC 0/2] Split padded I/O vectors exceeding IOV_MAX

2023-03-15 Thread Hanna Czenczek
Hi, We accept I/O vectors with up to 1024 (IOV_MAX) elements from guests. When a guest request does not conform to the underlying storage's alignment requirements, we pad it with head and/or tail buffers as necessary, which are simply appended to the I/O vector. As of 4c002cef, we (sensibly) chec

[RFC 1/2] block: Split padded I/O vectors exceeding IOV_MAX

2023-03-15 Thread Hanna Czenczek
When processing vectored guest requests that are not aligned to the storage request alignment, we pad them by adding head and/or tail buffers for a read-modify-write cycle. The guest can submit I/O vectors up to IOV_MAX (1024) in length, but with this padding, the vector can exceed that limit. As

[RFC 2/2] iotests/iov-padding: New test

2023-03-15 Thread Hanna Czenczek
Test that even vectored IO requests with 1024 vector elements that are not aligned to the device's request alignment will succeed. Signed-off-by: Hanna Czenczek --- tests/qemu-iotests/tests/iov-padding | 85 tests/qemu-iotests/tests/iov-padding.out | 59 +