Re: [PATCH 11/11] tests/gitlab: use kaniko to build images

2023-03-30 Thread Alex Bennée
Daniel P. Berrangé writes: > On Thu, Mar 30, 2023 at 11:17:41AM +0100, Daniel P. Berrangé wrote: >> On Thu, Mar 30, 2023 at 11:11:41AM +0100, Alex Bennée wrote: >> > Apparently the docker-in-docker approach has some flaws including >> > needing privileged mode to run and being quite slow. An

Re: [PATCH 03/11] MAINTAINERS: add a section for policy documents

2023-03-30 Thread Kashyap Chamarthy
On Thu, Mar 30, 2023 at 11:11:33AM +0100, Alex Bennée wrote: > We don't update these often but if you are the sort of person who > enjoys debating and tuning project policies you could now add yourself > as a reviewer here so you don't miss the next debate over tabs vs > spaces ;-) > > Who's with

Re: [PATCH 03/11] MAINTAINERS: add a section for policy documents

2023-03-30 Thread Warner Losh
Alex, On Thu, Mar 30, 2023 at 12:11 PM Alex Bennée wrote: > We don't update these often but if you are the sort of person who > enjoys debating and tuning project policies you could now add yourself > as a reviewer here so you don't miss the next debate over tabs vs > spaces ;-) > > Who's with

Re: [PATCH 03/11] MAINTAINERS: add a section for policy documents

2023-03-30 Thread Markus Armbruster
Alex Bennée writes: > We don't update these often but if you are the sort of person who > enjoys debating and tuning project policies you could now add yourself > as a reviewer here so you don't miss the next debate over tabs vs > spaces ;-) > > Who's with me? > > Signed-off-by: Alex Bennée >

Re: [PATCH-for-8.0] block/dmg: Ignore C99 prototype declaration mismatch from

2023-03-30 Thread Philippe Mathieu-Daudé
On 27/3/23 17:13, Philippe Mathieu-Daudé wrote: When liblzfe (Apple LZFSE compression library) is present (for example installed via 'brew') on Darwin, QEMU build fails as: [221/903] Compiling C object libblock.fa.p/block_dmg-lzfse.c.o FAILED: libblock.fa.p/block_dmg-lzfse.c.o

[PULL 3/6] hw/mips/gt64xxx_pci: Don't endian-swap GT_PCI0_CFGADDR

2023-03-30 Thread Philippe Mathieu-Daudé
From: Jiaxun Yang 145e2198d749 ("hw/mips/gt64xxx_pci: Endian-swap using PCI_HOST_BRIDGE MemoryRegionOps") converted CFGADDR/CFGDATA registers to use PCI_HOST_BRIDGE's accessor facility and enabled byte swap for both CFGADDR/CFGDATA register. However CFGADDR as a ISD internal register is not

[PULL 4/6] tests/avocado: Enable TuxRun/mips64 (big-endian) test

2023-03-30 Thread Philippe Mathieu-Daudé
Now that the previous commit ("hw/mips/gt64xxx_pci: Don't endian-swap GT_PCI0_CFGADDR") fixed the issue accessing the GT64120 PCI config-address register on big-endian targets, we can enable this TuxRun test. Signed-off-by: Philippe Mathieu-Daudé Acked-by: Alex Bennée Message-Id:

[PULL 2/6] linux-user/mips: Use P5600 as default CPU to run NaN2008 ELF binaries

2023-03-30 Thread Philippe Mathieu-Daudé
Per the release 6.06 revision history: 5.03 August 21, 2013 • ABS2008 and NAN2008 fields of Table 5.7 “FCSR RegisterField Descriptions” were optional in release 3 and could be R/W, but as of release 5 are required, read-only, and preset by hardware. The P5600 core implements the

[PULL 1/6] linux-user/sparc: Don't use 16-bit UIDs on SPARC V9

2023-03-30 Thread Philippe Mathieu-Daudé
The 64-bit SPARC V9 syscall ABI uses 32-bit UIDs. Only enable the 16-bit UID wrappers for 32-bit SPARC (V7 and V8). Possibly missed in commit 992f48a036 ("Support for 32 bit ABI on 64 bit targets (only enabled Sparc64)"). Reported-by: Gregor Riepl Tested-by: John Paul Adrian Glaubitz

[PULL 6/6] block/dmg: Ignore C99 prototype declaration mismatch from

2023-03-30 Thread Philippe Mathieu-Daudé
When liblzfe (Apple LZFSE compression library) is present (for example installed via 'brew') on Darwin, QEMU build fails as: Has header "lzfse.h" : YES Library lzfse found: YES Dependencies lzo support : NO snappy support : NO bzip2

[PULL 5/6] hw/i2c: pmbus: block uninitialised string reads

2023-03-30 Thread Philippe Mathieu-Daudé
From: Titus Rwantare Devices models calling pmbus_send_string can't be relied upon to send a non-zero pointer. This logs an error and doesn't segfault. Reviewed-by: Patrick Venture Signed-off-by: Titus Rwantare Reviewed-by: Philippe Mathieu-Daudé Message-Id:

[PULL 0/6] Misc fixes for 2023-03-30

2023-03-30 Thread Philippe Mathieu-Daudé
The following changes since commit f00506aeca2f6d92318967693f8da8c713c163f3: Merge tag 'pull-tcg-20230328' of https://gitlab.com/rth7680/qemu into staging (2023-03-29 11:19:19 +0100) are available in the Git repository at: https://github.com/philmd/qemu.git tags/misc-fixes-20230330

Re: [PATCH 01/11] scripts/coverage: initial coverage comparison script

2023-03-30 Thread Thomas Huth
On 30/03/2023 12.11, Alex Bennée wrote: This is a very rough and ready first pass at comparing gcovr's json output between two different runs. At the moment it will give you a file level diff between two runs but hopefully it wont be too hard to extend to give better insight. After generating

Re: [PATCH 11/11] tests/gitlab: use kaniko to build images

2023-03-30 Thread Thomas Huth
On 30/03/2023 12.11, Alex Bennée wrote: Apparently the docker-in-docker approach has some flaws including needing privileged mode to run and being quite slow. An alternative approach is to use Google's kaniko tool. It also works across different gitlab executors. Following the gitlab example

Re: [PATCH 09/11] tests/requirements.txt: bump up avocado-framework version to 101.0

2023-03-30 Thread Thomas Huth
On 30/03/2023 14.12, Alex Bennée wrote: Thomas Huth writes: On 30/03/2023 12.11, Alex Bennée wrote: From: Kautuk Consul Avocado version 101.0 has a fix to re-compute the checksum of an asset file if the algorithm used in the *-CHECKSUM file isn't the same as the one being passed to it by

Re: [PATCH 09/11] tests/requirements.txt: bump up avocado-framework version to 101.0

2023-03-30 Thread Alex Bennée
Thomas Huth writes: > On 30/03/2023 12.11, Alex Bennée wrote: >> From: Kautuk Consul >> Avocado version 101.0 has a fix to re-compute the checksum >> of an asset file if the algorithm used in the *-CHECKSUM >> file isn't the same as the one being passed to it by the >> avocado user (i.e. the

Re: [PATCH 09/11] tests/requirements.txt: bump up avocado-framework version to 101.0

2023-03-30 Thread Thomas Huth
On 30/03/2023 12.11, Alex Bennée wrote: From: Kautuk Consul Avocado version 101.0 has a fix to re-compute the checksum of an asset file if the algorithm used in the *-CHECKSUM file isn't the same as the one being passed to it by the avocado user (i.e. the avocado_qemu python module). In the

Re: [PATCH 10/11] gitlab: fix typo

2023-03-30 Thread Thomas Huth
On 30/03/2023 12.11, Alex Bennée wrote: Signed-off-by: Alex Bennée --- .gitlab-ci.d/base.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.gitlab-ci.d/base.yml b/.gitlab-ci.d/base.yml index 0274228de8..2fbb58d2a3 100644 --- a/.gitlab-ci.d/base.yml +++

Re: [PATCH 08/11] tests/vm: use the default system python for NetBSD

2023-03-30 Thread Thomas Huth
On 30/03/2023 12.11, Alex Bennée wrote: From: Daniel P. Berrangé Currently our NetBSD VM recipe requests instal of the python37 package and explicitly tells QEMU to use that version of python. Since the NetBSD base ISO was updated to version 9.3 though, the default system python version is 3.9

Re: [PATCH 07/11] tests/qemu-iotests: explicitly invoke 'check' via 'python'

2023-03-30 Thread Thomas Huth
On 30/03/2023 12.11, Alex Bennée wrote: From: Daniel P. Berrangé The 'check' script will use "#!/usr/bin/env python3" by default to locate python, but this doesn't work in distros which lack a bare 'python3' binary like NetBSD. We need to explicitly invoke 'check' by referring to the 'python'

Re: [PATCH 05/11] metadata: add .git-blame-ignore-revs

2023-03-30 Thread Thomas Huth
On 30/03/2023 12.11, Alex Bennée wrote: Someone mentioned this on IRC so I thought I would try it out with a few commits that are pure code style fixes. Signed-off-by: Alex Bennée Message-Id: <20230318115657.1345921-1-alex.ben...@linaro.org> Reviewed-by: Philippe Mathieu-Daudé Tested-by:

Re: [PATCH 04/11] qemu-options: finesse the recommendations around -blockdev

2023-03-30 Thread Thomas Huth
On 30/03/2023 12.11, Alex Bennée wrote: We are a bit premature in recommending -blockdev/-device as the best way to configure block devices, especially in the common case. Improve the language to hopefully make things clearer. Suggested-by: Michael Tokarev Signed-off-by: Alex Bennée ---

Re: [PATCH 03/11] MAINTAINERS: add a section for policy documents

2023-03-30 Thread Thomas Huth
On 30/03/2023 12.11, Alex Bennée wrote: We don't update these often but if you are the sort of person who enjoys debating and tuning project policies you could now add yourself as a reviewer here so you don't miss the next debate over tabs vs spaces ;-) Who's with me? Signed-off-by: Alex

Re: [PATCH 11/11] tests/gitlab: use kaniko to build images

2023-03-30 Thread Daniel P . Berrangé
On Thu, Mar 30, 2023 at 11:17:41AM +0100, Daniel P. Berrangé wrote: > On Thu, Mar 30, 2023 at 11:11:41AM +0100, Alex Bennée wrote: > > Apparently the docker-in-docker approach has some flaws including > > needing privileged mode to run and being quite slow. An alternative > > approach is to use

Re: [PATCH 10/11] gitlab: fix typo

2023-03-30 Thread Philippe Mathieu-Daudé
On 30/3/23 12:11, Alex Bennée wrote: Signed-off-by: Alex Bennée --- .gitlab-ci.d/base.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Philippe Mathieu-Daudé

Re: [PATCH 11/11] tests/gitlab: use kaniko to build images

2023-03-30 Thread Daniel P . Berrangé
On Thu, Mar 30, 2023 at 11:11:41AM +0100, Alex Bennée wrote: > Apparently the docker-in-docker approach has some flaws including > needing privileged mode to run and being quite slow. An alternative > approach is to use Google's kaniko tool. It also works across > different gitlab executors. > >

[PATCH 00/11] more misc fixes for 8.0 (tests, gdbstub, meta, docs)

2023-03-30 Thread Alex Bennée
Here are a few more random fixes across the tree. All should be good for the current phase of freeze although I can drop stuff if it causes problems. I've included another run at using the kaniko build tool and will see if it improves the caching of things as it runs through my CI loop. Alex.

[PATCH 03/11] MAINTAINERS: add a section for policy documents

2023-03-30 Thread Alex Bennée
We don't update these often but if you are the sort of person who enjoys debating and tuning project policies you could now add yourself as a reviewer here so you don't miss the next debate over tabs vs spaces ;-) Who's with me? Signed-off-by: Alex Bennée Cc: Thomas Huth Cc: Daniel P. Berrangé

[PATCH 02/11] gdbstub: Only build libgdb_user.fa / libgdb_softmmu.fa if necessary

2023-03-30 Thread Alex Bennée
From: Philippe Mathieu-Daudé It is pointless to build libgdb_user.fa in a system-only build (or libgdb_softmmu.fa in a user-only build). Besides, in some restricted build configurations, some APIs might be restricted / not available. Example in a KVM-only builds where TCG is disabled: $ ninja

[PATCH 04/11] qemu-options: finesse the recommendations around -blockdev

2023-03-30 Thread Alex Bennée
We are a bit premature in recommending -blockdev/-device as the best way to configure block devices, especially in the common case. Improve the language to hopefully make things clearer. Suggested-by: Michael Tokarev Signed-off-by: Alex Bennée --- qemu-options.hx | 8 ++-- 1 file changed,

[PATCH 06/11] Use hexagon toolchain version 16.0.0

2023-03-30 Thread Alex Bennée
From: Marco Liebel Signed-off-by: Marco Liebel Reviewed-by: Brian Cain Message-Id: <20230329142108.1199509-1-quic_mlie...@quicinc.com> Signed-off-by: Alex Bennée --- tests/docker/dockerfiles/debian-hexagon-cross.docker | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH 01/11] scripts/coverage: initial coverage comparison script

2023-03-30 Thread Alex Bennée
This is a very rough and ready first pass at comparing gcovr's json output between two different runs. At the moment it will give you a file level diff between two runs but hopefully it wont be too hard to extend to give better insight. After generating the coverage results you run with something

[PATCH 08/11] tests/vm: use the default system python for NetBSD

2023-03-30 Thread Alex Bennée
From: Daniel P. Berrangé Currently our NetBSD VM recipe requests instal of the python37 package and explicitly tells QEMU to use that version of python. Since the NetBSD base ISO was updated to version 9.3 though, the default system python version is 3.9 which is sufficiently new for QEMU to

[PATCH 07/11] tests/qemu-iotests: explicitly invoke 'check' via 'python'

2023-03-30 Thread Alex Bennée
From: Daniel P. Berrangé The 'check' script will use "#!/usr/bin/env python3" by default to locate python, but this doesn't work in distros which lack a bare 'python3' binary like NetBSD. We need to explicitly invoke 'check' by referring to the 'python' variable in meson, which resolves to the

[PATCH 05/11] metadata: add .git-blame-ignore-revs

2023-03-30 Thread Alex Bennée
Someone mentioned this on IRC so I thought I would try it out with a few commits that are pure code style fixes. Signed-off-by: Alex Bennée Message-Id: <20230318115657.1345921-1-alex.ben...@linaro.org> Reviewed-by: Philippe Mathieu-Daudé Tested-by: Philippe Mathieu-Daudé ---

[PATCH 10/11] gitlab: fix typo

2023-03-30 Thread Alex Bennée
Signed-off-by: Alex Bennée --- .gitlab-ci.d/base.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.gitlab-ci.d/base.yml b/.gitlab-ci.d/base.yml index 0274228de8..2fbb58d2a3 100644 --- a/.gitlab-ci.d/base.yml +++ b/.gitlab-ci.d/base.yml @@ -75,5 +75,5 @@ - if:

[PATCH 11/11] tests/gitlab: use kaniko to build images

2023-03-30 Thread Alex Bennée
Apparently the docker-in-docker approach has some flaws including needing privileged mode to run and being quite slow. An alternative approach is to use Google's kaniko tool. It also works across different gitlab executors. Following the gitlab example code we drop all the direct docker calls and

[PATCH 09/11] tests/requirements.txt: bump up avocado-framework version to 101.0

2023-03-30 Thread Alex Bennée
From: Kautuk Consul Avocado version 101.0 has a fix to re-compute the checksum of an asset file if the algorithm used in the *-CHECKSUM file isn't the same as the one being passed to it by the avocado user (i.e. the avocado_qemu python module). In the earlier avocado versions this fix wasn't