Re: [PATCH v3 13/20] block/export: rewrite vduse-blk drain code

Hi Stefan, On Thu, Apr 20, 2023 at 7:39 PM Stefan Hajnoczi wrote: > > vduse_blk_detach_ctx() waits for in-flight requests using > AIO_WAIT_WHILE(). This is not allowed according to a comment in > bdrv_set_aio_context_commit(): > > /* >* Take the old AioContex when detaching it from bs. >

RE: [PATCH v2 3/4] build: move COLO under CONFIG_REPLICATION

> -Original Message- > From: Vladimir Sementsov-Ogievskiy > Sent: Thursday, April 20, 2023 6:53 AM > To: qemu-de...@nongnu.org > Cc: qemu-block@nongnu.org; michael.r...@amd.com; arm...@redhat.com; > ebl...@redhat.com; jasow...@redhat.com; quint...@redhat.com; Zhang, > Hailiang ;

RE: [PATCH v2 4/4] configure: add --disable-colo-filters option

> -Original Message- > From: Vladimir Sementsov-Ogievskiy > Sent: Thursday, April 20, 2023 7:26 PM > To: Zhang, Chen ; qemu-de...@nongnu.org > Cc: qemu-block@nongnu.org; michael.r...@amd.com; arm...@redhat.com; > ebl...@redhat.com; jasow...@redhat.com; quint...@redhat.com; Zhang, >

Re: [PATCH v2 3/4] build: move COLO under CONFIG_REPLICATION

* Vladimir Sementsov-Ogievskiy (vsement...@yandex-team.ru) wrote: > We don't allow to use x-colo capability when replication is not > configured. So, no reason to build COLO when replication is disabled, > it's unusable in this case. > > Signed-off-by: Vladimir Sementsov-Ogievskiy > --- >

Re: [PATCH v2 28/43] migration: Move migrate_use_tls() to options.c

Fabiano Rosas wrote: > Juan Quintela writes: > > >> +/* >> + * pseudo capabilities >> + * >> + * This are functions that are used in a similar way that capabilities >> + * check, but they are not a capability. > > s/This/These/ > s/that capabilities/to capabilities/ > Fixed, thanks.

Re: [PATCH v2 30/43] migration: Create migrate_max_bandwidth() function

Juan Quintela writes: > Signed-off-by: Juan Quintela Reviewed-by: Fabiano Rosas

Re: [PATCH v2 29/43] migration: Move migrate_postcopy() to options.c

Juan Quintela writes: > Signed-off-by: Juan Quintela Reviewed-by: Fabiano Rosas

Re: [PATCH v2 03/43] migration: Create migration_cap_set()

Fabiano Rosas wrote: > Juan Quintela writes: > >> And remove the convoluted use of qmp_migrate_set_capabilities() to >> enable disable MIGRATION_CAPABILITY_BLOCK. >> >> Signed-off-by: Juan Quintela >> --- >> migration/migration.c | 34 -- >> 1 file changed, 16

Re: [PATCH v2 28/43] migration: Move migrate_use_tls() to options.c

Juan Quintela writes: > Once there, rename it to migrate_tls() and make it return bool for > consistency. > > Signed-off-by: Juan Quintela > --- > migration/migration.c | 9 - > migration/migration.h | 2 -- > migration/options.c | 16 +++- > migration/options.h | 9

Re: [PATCH v2 27/43] migration: Create migrate_cpu_throttle_tailslow() function

Juan Quintela writes: > Signed-off-by: Juan Quintela Reviewed-by: Fabiano Rosas

Re: [PATCH v2 26/43] migration: Create migrate_cpu_throttle_increment() function

Juan Quintela writes: > Signed-off-by: Juan Quintela Reviewed-by: Fabiano Rosas

Re: [PATCH v2 25/43] migration: Create migrate_cpu_throttle_initial() to option.c

Juan Quintela writes: > Signed-off-by: Juan Quintela Reviewed-by: Fabiano Rosas

Re: [PATCH v2 24/43] migration: Move migrate_announce_params() to option.c

Juan Quintela writes: > Signed-off-by: Juan Quintela Reviewed-by: Fabiano Rosas > --- > migration/migration.c | 14 -- > migration/options.c | 19 +++ > 2 files changed, 19 insertions(+), 14 deletions(-) > > diff --git a/migration/migration.c

Re: [PATCH v2 23/43] migration: Create migrate_max_cpu_throttle()

Juan Quintela writes: > Signed-off-by: Juan Quintela Reviewed-by: Fabiano Rosas

Re: [PATCH v2 22/43] migration: Create migrate_checkpoint_delay()

Juan Quintela writes: > Signed-off-by: Juan Quintela Reviewed-by: Fabiano Rosas

Re: [PATCH v2 21/43] migration: Create migrate_throttle_trigger_threshold()

Juan Quintela writes: > Signed-off-by: Juan Quintela > --- > migration/options.c | 9 + > migration/options.h | 1 + > migration/ram.c | 3 +-- > 3 files changed, 11 insertions(+), 2 deletions(-) > > diff --git a/migration/options.c b/migration/options.c > index

Re: [PATCH v2 13/43] migration: Create migrate_rdma_pin_all() function

Juan Quintela writes: > Signed-off-by: Juan Quintela > Reviewed-by: Vladimir Sementsov-Ogievskiy > --- > migration/options.c | 7 +++ > migration/options.h | 1 + > migration/rdma.c| 6 +++--- > 3 files changed, 11 insertions(+), 3 deletions(-) > > diff --git a/migration/options.c

Re: [PATCH v2 03/43] migration: Create migration_cap_set()

Juan Quintela writes: > And remove the convoluted use of qmp_migrate_set_capabilities() to > enable disable MIGRATION_CAPABILITY_BLOCK. > > Signed-off-by: Juan Quintela > --- > migration/migration.c | 34 -- > 1 file changed, 16 insertions(+), 18 deletions(-) >

Re: [PATCH v2 20/43] migration: Move migrate_use_block_incremental() to option.c

On 20.04.23 16:39, Juan Quintela wrote: To be consistent with every other parameter, rename to migrate_block_incremental(). Signed-off-by: Juan Quintela Reviewed-by: Vladimir Sementsov-Ogievskiy -- Best regards, Vladimir

Re: [PATCH v2 19/43] migration: Use migrate_max_postcopy_bandwidth()

On 20.04.23 16:39, Juan Quintela wrote: Signed-off-by: Juan Quintela Reviewed-by: Vladimir Sementsov-Ogievskiy -- Best regards, Vladimir

Re: [PATCH v2 18/43] migration: Move parameters functions to option.c

On 20.04.23 16:39, Juan Quintela wrote: Signed-off-by: Juan Quintela Reviewed-by: Vladimir Sementsov-Ogievskiy -- Best regards, Vladimir

Re: [PATCH v2 17/43] migration: Move migrate_cap_set() to options.c

On 20.04.23 16:39, Juan Quintela wrote: Signed-off-by: Juan Quintela Reviewed-by: Vladimir Sementsov-Ogievskiy -- Best regards, Vladimir

Re: [PATCH v2 16/43] migration: Move qmp_migrate_set_capabilities() to options.c

On 20.04.23 16:39, Juan Quintela wrote: Signed-off-by: Juan Quintela Reviewed-by: Vladimir Sementsov-Ogievskiy -- Best regards, Vladimir

Re: [PATCH v2 15/43] migration: Move qmp_query_migrate_capabilities() to options.c

On 20.04.23 16:39, Juan Quintela wrote: Signed-off-by: Juan Quintela Reviewed-by: Vladimir Sementsov-Ogievskiy -- Best regards, Vladimir

Re: [PATCH v2 14/43] migration: Move migrate_caps_check() to options.c

On 20.04.23 16:39, Juan Quintela wrote: Signed-off-by: Juan Quintela Reviewed-by: Vladimir Sementsov-Ogievskiy -- Best regards, Vladimir

Re: [PATCH v2 2/4] scripts/qapi: allow optional experimental enum values

On 20.04.23 17:43, Eric Blake wrote: On Thu, Apr 20, 2023 at 01:52:30AM +0300, Vladimir Sementsov-Ogievskiy wrote: To be used in the next commit. Signed-off-by: Vladimir Sementsov-Ogievskiy --- scripts/qapi/types.py | 2 ++ 1 file changed, 2 insertions(+) diff --git

Re: [PATCH] nbd: a BlockExport always has a BlockBackend

On Wed, Apr 05, 2023 at 07:54:50AM -0500, Eric Blake wrote: > On Wed, Apr 05, 2023 at 12:16:34PM +0200, Paolo Bonzini wrote: > > exp->common.blk cannot be NULL, nbd_export_delete() is only called from > > blk_exp_unref() and in turn that can only happen after blk_exp_add() > > has asserted

Re: [PATCH v2 2/4] scripts/qapi: allow optional experimental enum values

On Thu, Apr 20, 2023 at 01:52:30AM +0300, Vladimir Sementsov-Ogievskiy wrote: > To be used in the next commit. > > Signed-off-by: Vladimir Sementsov-Ogievskiy > --- > scripts/qapi/types.py | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/scripts/qapi/types.py b/scripts/qapi/types.py

Re: [PATCH v2 1/4] block/meson.build: prefer positive condition for replication

On 20/4/23 00:52, Vladimir Sementsov-Ogievskiy wrote: Signed-off-by: Vladimir Sementsov-Ogievskiy --- block/meson.build | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Philippe Mathieu-Daudé

[PATCH v2 29/43] migration: Move migrate_postcopy() to options.c

Signed-off-by: Juan Quintela --- migration/migration.c | 5 - migration/migration.h | 2 -- migration/options.c | 5 + migration/options.h | 1 + 4 files changed, 6 insertions(+), 7 deletions(-) diff --git a/migration/migration.c b/migration/migration.c index bbc9a07fd7..efb098c4e4

[PATCH v2 15/43] migration: Move qmp_query_migrate_capabilities() to options.c

Signed-off-by: Juan Quintela --- migration/migration.c | 22 -- migration/options.c | 23 +++ 2 files changed, 23 insertions(+), 22 deletions(-) diff --git a/migration/migration.c b/migration/migration.c index 933c96792b..bc796879c0 100644 ---

[PATCH v2 35/43] migration: Create migrate_downtime_limit() function

Signed-off-by: Juan Quintela --- migration/migration.c | 4 ++-- migration/options.c | 7 +++ migration/options.h | 1 + 3 files changed, 10 insertions(+), 2 deletions(-) diff --git a/migration/migration.c b/migration/migration.c index b87aebee9b..3054874743 100644 ---

[PATCH v2 25/43] migration: Create migrate_cpu_throttle_initial() to option.c

Signed-off-by: Juan Quintela --- migration/options.c | 9 + migration/options.h | 1 + migration/ram.c | 2 +- 3 files changed, 11 insertions(+), 1 deletion(-) diff --git a/migration/options.c b/migration/options.c index ed9d2a226f..34a1f58f96 100644 --- a/migration/options.c +++

[PATCH v2 01/43] migration: move migration_global_dump() to migration-hmp-cmds.c

It is only used there, so we can make it static. Once there, remove spice.h that it is not used. Signed-off-by: Juan Quintela --- fix David Edmonson ui/qemu-spice.h unintended removal --- include/migration/misc.h | 1 - migration/migration-hmp-cmds.c | 22 +-

[PATCH v2 03/43] migration: Create migration_cap_set()

And remove the convoluted use of qmp_migrate_set_capabilities() to enable disable MIGRATION_CAPABILITY_BLOCK. Signed-off-by: Juan Quintela --- migration/migration.c | 34 -- 1 file changed, 16 insertions(+), 18 deletions(-) diff --git a/migration/migration.c

[PATCH v2 21/43] migration: Create migrate_throttle_trigger_threshold()

Signed-off-by: Juan Quintela --- migration/options.c | 9 + migration/options.h | 1 + migration/ram.c | 3 +-- 3 files changed, 11 insertions(+), 2 deletions(-) diff --git a/migration/options.c b/migration/options.c index 2b6d88b4b9..b9f3815f7e 100644 --- a/migration/options.c +++

[PATCH v2 43/43] migration: Move migration_properties to options.c

Signed-off-by: Juan Quintela --- migration/migration.c | 157 -- migration/options.c | 155 + migration/options.h | 7 ++ 3 files changed, 162 insertions(+), 157 deletions(-) diff --git a/migration/migration.c

[PATCH v2 18/43] migration: Move parameters functions to option.c

Signed-off-by: Juan Quintela --- migration/migration.c| 91 --- migration/migration.h| 11 - migration/multifd-zlib.c | 1 + migration/multifd-zstd.c | 1 + migration/options.c | 93

[PATCH v2 28/43] migration: Move migrate_use_tls() to options.c

Once there, rename it to migrate_tls() and make it return bool for consistency. Signed-off-by: Juan Quintela --- migration/migration.c | 9 - migration/migration.h | 2 -- migration/options.c | 16 +++- migration/options.h | 9 + migration/tls.c | 3 ++-

[PATCH v2 00/43] Migration: Create options.c for capabilities/params/properties

Hi In this v2: - the first two patches are included on the last pull request. - Changed copyright from Anthony to Orit (thanks David) Some archeology required. - Get all the reviews by from Vladimir. - Rebased on top of my last pull request. The first two patches don't belong in this series,

[PATCH v2 42/43] migration: Create migrate_block_bitmap_mapping() function

Notice that we changed the test of ->has_block_bitmap_mapping for the test that block_bitmap_mapping is not NULL. Signed-off-by: Juan Quintela --- migration/block-dirty-bitmap.c | 14 -- migration/options.c| 7 +++ migration/options.h| 1 + 3 files

[PATCH v2 36/43] migration: Move migrate_set_block_incremental() to options.c

Once there, make it more regular and remove th eneed for MigrationState parameter. Signed-off-by: Juan Quintela --- migration/migration.c | 9 ++--- migration/options.c | 9 + migration/options.h | 4 3 files changed, 15 insertions(+), 7 deletions(-) diff --git

[PATCH v2 22/43] migration: Create migrate_checkpoint_delay()

Signed-off-by: Juan Quintela --- migration/colo.c| 5 ++--- migration/options.c | 9 + migration/options.h | 1 + 3 files changed, 12 insertions(+), 3 deletions(-) diff --git a/migration/colo.c b/migration/colo.c index 93b78c9270..07bfa21fea 100644 --- a/migration/colo.c +++

[PATCH v2 31/43] migration: Move qmp_query_migrate_parameters() to options.c

Signed-off-by: Juan Quintela --- migration/migration.c | 68 --- migration/options.c | 68 +++ 2 files changed, 68 insertions(+), 68 deletions(-) diff --git a/migration/migration.c b/migration/migration.c index

[PATCH v2 12/43] migration: Move migrate_use_return() to options.c

Once that we are there, we rename the function to migrate_return_path() to be consistent with all other capabilities. Signed-off-by: Juan Quintela Reviewed-by: Vladimir Sementsov-Ogievskiy --- migration/migration.c | 11 +-- migration/migration.h | 1 - migration/options.c | 9

[PATCH v2 40/43] migration: Create migrate_tls_authz() function

Signed-off-by: Juan Quintela --- migration/options.c | 7 +++ migration/options.h | 1 + migration/tls.c | 5 + 3 files changed, 9 insertions(+), 4 deletions(-) diff --git a/migration/options.c b/migration/options.c index bb5e055004..303a493388 100644 --- a/migration/options.c +++

[PATCH v2 32/43] migration: Move qmp_migrate_set_parameters() to options.c

Signed-off-by: Juan Quintela --- migration/migration.c | 420 -- migration/options.c | 418 + migration/options.h | 11 ++ 3 files changed, 429 insertions(+), 420 deletions(-) diff --git a/migration/migration.c

[PATCH v2 41/43] migration: Create migrate_tls_hostname() function

Signed-off-by: Juan Quintela --- migration/options.c | 7 +++ migration/options.h | 1 + migration/tls.c | 6 -- 3 files changed, 12 insertions(+), 2 deletions(-) diff --git a/migration/options.c b/migration/options.c index 303a493388..8f0bf1ece6 100644 --- a/migration/options.c +++

[PATCH v2 24/43] migration: Move migrate_announce_params() to option.c

Signed-off-by: Juan Quintela --- migration/migration.c | 14 -- migration/options.c | 19 +++ 2 files changed, 19 insertions(+), 14 deletions(-) diff --git a/migration/migration.c b/migration/migration.c index dbb89c2e7b..2191437b15 100644 ---

Re: [PATCH v3 20/20] aio: remove aio_disable_external() API

On 20/4/23 13:37, Stefan Hajnoczi wrote: All callers now pass is_external=false to aio_set_fd_handler() and aio_set_event_notifier(). The aio_disable_external() API that temporarily disables fd handlers that were registered is_external=true is therefore dead code. Remove aio_disable_external(),

[PATCH v2 23/43] migration: Create migrate_max_cpu_throttle()

Signed-off-by: Juan Quintela --- migration/migration.h | 2 -- migration/options.c | 9 + migration/options.h | 1 + migration/ram.c | 2 +- 4 files changed, 11 insertions(+), 3 deletions(-) diff --git a/migration/migration.h b/migration/migration.h index

[PATCH v2 34/43] migration: Make all functions check have the same format

Signed-off-by: Juan Quintela --- migration/options.c | 153 +++- 1 file changed, 39 insertions(+), 114 deletions(-) diff --git a/migration/options.c b/migration/options.c index 6fa308..fa99e397d0 100644 --- a/migration/options.c +++

[PATCH v2 38/43] migration: Remove MigrationState from block_cleanup_parameters()

This makes the function more regular with everything else. Signed-off-by: Juan Quintela --- migration/migration.c | 4 ++-- migration/options.c | 4 +++- migration/options.h | 2 +- 3 files changed, 6 insertions(+), 4 deletions(-) diff --git a/migration/migration.c b/migration/migration.c

[PATCH v2 37/43] migration: Move block_cleanup_parameters() to options.c

Signed-off-by: Juan Quintela --- migration/migration.c | 10 -- migration/options.c | 10 ++ migration/options.h | 1 + 3 files changed, 11 insertions(+), 10 deletions(-) diff --git a/migration/migration.c b/migration/migration.c index d31e987d1a..f12ab54ae0 100644 ---

[PATCH v2 26/43] migration: Create migrate_cpu_throttle_increment() function

Signed-off-by: Juan Quintela --- migration/options.c | 9 + migration/options.h | 1 + migration/ram.c | 2 +- 3 files changed, 11 insertions(+), 1 deletion(-) diff --git a/migration/options.c b/migration/options.c index 34a1f58f96..e31d907d3d 100644 --- a/migration/options.c +++

[PATCH v2 11/43] migration: Move migrate_use_block() to options.c

Once that we are there, we rename the function to migrate_block() to be consistent with all other capabilities. Signed-off-by: Juan Quintela Reviewed-by: Vladimir Sementsov-Ogievskiy --- migration/block.c | 2 +- migration/migration.c | 11 +-- migration/migration.h | 1 -

[PATCH v2 20/43] migration: Move migrate_use_block_incremental() to option.c

To be consistent with every other parameter, rename to migrate_block_incremental(). Signed-off-by: Juan Quintela --- migration/block.c | 2 +- migration/migration.c | 11 +-- migration/migration.h | 1 - migration/options.c | 9 + migration/options.h | 1 + 5 files

[PATCH v2 14/43] migration: Move migrate_caps_check() to options.c

Signed-off-by: Juan Quintela --- migration/migration.c | 190 - migration/options.c | 192 ++ migration/options.h | 4 + 3 files changed, 196 insertions(+), 190 deletions(-) diff --git a/migration/migration.c

[PATCH v2 09/43] migration: Move migrate_use_zero_copy_send() to options.c

Once that we are there, we rename the function to migrate_zero_copy_send() to be consistent with all other capabilities. We can remove the CONFIG_LINUX guard. We already check that we can't setup this capability in migrate_caps_check(). Signed-off-by: Juan Quintela Reviewed-by: Vladimir

[PATCH v2 02/43] spice: move client_migrate_info command to ui/

It has nothing to do with migration, except for the "migrate" in the name of the command. Move it with the rest of the ui commands. Signed-off-by: Juan Quintela --- I would claim that it should be only compiled with CONFIG_SPICE, but I left that to spice maintainers. ---

[PATCH v2 06/43] migration: Move migrate_use_compression() to options.c

Once that we are there, we rename the function to migrate_compress() to be consistent with all other capabilities. Signed-off-by: Juan Quintela Reviewed-by: Vladimir Sementsov-Ogievskiy --- migration/migration.c | 11 +-- migration/migration.h | 1 - migration/options.c | 9

[PATCH v2 19/43] migration: Use migrate_max_postcopy_bandwidth()

Signed-off-by: Juan Quintela --- migration/migration.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/migration/migration.c b/migration/migration.c index 028c297121..88bcaec08e 100644 --- a/migration/migration.c +++ b/migration/migration.c @@ -3800,7 +3800,7 @@ void

[PATCH v2 13/43] migration: Create migrate_rdma_pin_all() function

Signed-off-by: Juan Quintela Reviewed-by: Vladimir Sementsov-Ogievskiy --- migration/options.c | 7 +++ migration/options.h | 1 + migration/rdma.c| 6 +++--- 3 files changed, 11 insertions(+), 3 deletions(-) diff --git a/migration/options.c b/migration/options.c index

[PATCH v2 27/43] migration: Create migrate_cpu_throttle_tailslow() function

Signed-off-by: Juan Quintela --- migration/options.c | 9 + migration/options.h | 1 + migration/ram.c | 3 +-- 3 files changed, 11 insertions(+), 2 deletions(-) diff --git a/migration/options.c b/migration/options.c index e31d907d3d..a111d0d43f 100644 --- a/migration/options.c +++

[PATCH v2 30/43] migration: Create migrate_max_bandwidth() function

Signed-off-by: Juan Quintela --- migration/migration.c | 2 +- migration/options.c | 9 + migration/options.h | 1 + 3 files changed, 11 insertions(+), 1 deletion(-) diff --git a/migration/migration.c b/migration/migration.c index efb098c4e4..2bbb4e888b 100644 ---

[PATCH v2 39/43] migration: Create migrate_tls_creds() function

Signed-off-by: Juan Quintela --- migration/options.c | 7 +++ migration/options.h | 1 + migration/tls.c | 9 - 3 files changed, 12 insertions(+), 5 deletions(-) diff --git a/migration/options.c b/migration/options.c index da70f62693..bb5e055004 100644 --- a/migration/options.c

[PATCH v2 33/43] migration: Create migrate_params_init() function

Signed-off-by: Juan Quintela --- migration/migration.c | 29 + migration/options.c | 31 +++ migration/options.h | 1 + 3 files changed, 33 insertions(+), 28 deletions(-) diff --git a/migration/migration.c b/migration/migration.c

[PATCH v2 17/43] migration: Move migrate_cap_set() to options.c

Signed-off-by: Juan Quintela --- migration/migration.c | 20 migration/options.c | 21 + migration/options.h | 1 + 3 files changed, 22 insertions(+), 20 deletions(-) diff --git a/migration/migration.c b/migration/migration.c index

[PATCH v2 05/43] migration: Move migrate_colo_enabled() to options.c

Once that we are there, we rename the function to migrate_colo() to be consistent with all other capabilities. Signed-off-by: Juan Quintela Reviewed-by: Vladimir Sementsov-Ogievskiy --- migration/migration.c | 16 +--- migration/migration.h | 1 - migration/options.c | 6 ++

[PATCH v2 10/43] migration: Move migrate_use_xbzrle() to options.c

Once that we are there, we rename the function to migrate_xbzrle() to be consistent with all other capabilities. We change the type to return bool also for consistency. Signed-off-by: Juan Quintela Reviewed-by: Vladimir Sementsov-Ogievskiy --- migration/migration.c | 11 +--

[PATCH v2 16/43] migration: Move qmp_migrate_set_capabilities() to options.c

Signed-off-by: Juan Quintela --- migration/migration.c | 26 -- migration/options.c | 26 ++ 2 files changed, 26 insertions(+), 26 deletions(-) diff --git a/migration/migration.c b/migration/migration.c index bc796879c0..854be12ca6 100644 ---

[PATCH v2 08/43] migration: Move migrate_use_multifd() to options.c

Once that we are there, we rename the function to migrate_multifd() to be consistent with all other capabilities. Signed-off-by: Juan Quintela Reviewed-by: Vladimir Sementsov-Ogievskiy --- migration/migration.c | 19 +-- migration/migration.h | 1 - migration/multifd.c | 16

[PATCH v2 07/43] migration: Move migrate_use_events() to options.c

Once that we are there, we rename the function to migrate_events() to be consistent with all other capabilities. Signed-off-by: Juan Quintela Reviewed-by: Vladimir Sementsov-Ogievskiy --- migration/migration.c | 11 +-- migration/migration.h | 1 - migration/options.c | 9 +

Re: [PATCH v3 00/20] block: remove aio_disable_external() API

Hi Stefan, On 20/4/23 13:37, Stefan Hajnoczi wrote: v3: - Resend full patch series. v2 was sent in the middle of a git rebase and was missing patches. [Eric] - Apply Reviewed-by tags. Based-on: 087bc644b7634436ca9d52fe58ba9234e2bef026 (kevin/block-next) It seems kevin/block-next got

[PATCH v2 04/43] migration: Create options.c

We move there all capabilities helpers from migration.c. Signed-off-by: Juan Quintela Reviewed-by: Dr. David Alan Gilbert --- Following David advise: - looked through the history, capabilities are newer than 2012, so we can remove that bit of the header. - This part is posterior to Anthony.

Re: [PATCH 06/43] migration: Move migrate_use_compression() to options.c

Vladimir Sementsov-Ogievskiy wrote: > On 02.03.23 19:33, Juan Quintela wrote: >> Once that we are there, we rename the function to migrate_compress() >> to be consistent with all other capabilities. >> Signed-off-by: Juan Quintela > > Reviewed-by: Vladimir Sementsov-Ogievskiy > >> --- >>

Re: [PATCH 13/43] migration: Create migrate_rdma_pin_all() function

On 02.03.23 19:33, Juan Quintela wrote: Signed-off-by: Juan Quintela Reviewed-by: Vladimir Sementsov-Ogievskiy -- Best regards, Vladimir

Re: [PATCH 12/43] migration: Move migrate_use_return() to options.c

On 02.03.23 19:33, Juan Quintela wrote: Once that we are there, we rename the function to migrate_return_path() to be consistent with all other capabilities. Signed-off-by: Juan Quintela Reviewed-by: Vladimir Sementsov-Ogievskiy -- Best regards, Vladimir

Re: [PATCH 11/43] migration: Move migrate_use_block() to options.c

On 02.03.23 19:33, Juan Quintela wrote: Once that we are there, we rename the function to migrate_block() to be consistent with all other capabilities. Signed-off-by: Juan Quintela Reviewed-by: Vladimir Sementsov-Ogievskiy -- Best regards, Vladimir

Re: [PATCH 00/43] Migration: Create options.c for capabilities/params/properties

Vladimir Sementsov-Ogievskiy wrote: > On 02.03.23 19:33, Juan Quintela wrote: >> Hi >> This series move to options.c: >> - all migration capabilities code >> - all migration parameters code >> - all properties code >> - all qmp commands that only touch the previous >> And once there: >> - sort of

Re: [PATCH 10/43] migration: Move migrate_use_xbzrle() to options.c

On 02.03.23 19:33, Juan Quintela wrote: Once that we are there, we rename the function to migrate_xbzrle() to be consistent with all other capabilities. We change the type to return bool also for consistency. Signed-off-by: Juan Quintela Reviewed-by: Vladimir Sementsov-Ogievskiy -- Best

Re: [PATCH 09/43] migration: Move migrate_use_zero_copy_send() to options.c

On 02.03.23 19:33, Juan Quintela wrote: Once that we are there, we rename the function to migrate_zero_copy_send() to be consistent with all other capabilities. We can remove the CONFIG_LINUX guard. We already check that we can't setup this capability in migrate_caps_check(). Signed-off-by:

Re: [PATCH 04/43] migration: create options.c

"Dr. David Alan Gilbert" wrote: > * Juan Quintela (quint...@redhat.com) wrote: >> We move there all capabilities helpers from migration.c. >> >> Signed-off-by: Juan Quintela >> --- /dev/null >> +++ b/migration/options.h >> @@ -0,0 +1,34 @@ >> +/* >> + * QEMU migration options >> + * >> + *

Re: [PATCH 08/43] migration: Move migrate_use_multifd() to options.c

On 02.03.23 19:33, Juan Quintela wrote: Once that we are there, we rename the function to migrate_multifd() to be consistent with all other capabilities. Signed-off-by: Juan Quintela Reviewed-by: Vladimir Sementsov-Ogievskiy -- Best regards, Vladimir

Re: [PATCH 07/43] migration: Move migrate_use_events() to options.c

On 02.03.23 19:33, Juan Quintela wrote: Once that we are there, we rename the function to migrate_events() to be consistent with all other capabilities. Signed-off-by: Juan Quintela Reviewed-by: Vladimir Sementsov-Ogievskiy -- Best regards, Vladimir

Re: [PATCH 06/43] migration: Move migrate_use_compression() to options.c

On 02.03.23 19:33, Juan Quintela wrote: Once that we are there, we rename the function to migrate_compress() to be consistent with all other capabilities. Signed-off-by: Juan Quintela Reviewed-by: Vladimir Sementsov-Ogievskiy --- migration/migration.h | 1 - migration/options.h | 1

Re: [PATCH 05/43] migration: Move migrate_colo_enabled() to options.c

On 02.03.23 19:33, Juan Quintela wrote: Once that we are there, we rename the function to migrate_colo() to be consistent with all other capabilities. Signed-off-by: Juan Quintela Reviewed-by: Vladimir Sementsov-Ogievskiy -- Best regards, Vladimir

Re: [PATCH 03/43] migration: Create migration_cap_set()

"Dr. David Alan Gilbert" wrote: > * Juan Quintela (quint...@redhat.com) wrote: >> And remove the convoluted use of qmp_migrate_set_capabilities() to >> enable disable MIGRATION_CAPABILITY_BLOCK. >> >> Signed-off-by: Juan Quintela >> --- >> migration/migration.c | 34

Re: [PATCH v2 16/16] virtio: make it possible to detach host notifier from any thread

Stefan Hajnoczi wrote: > On Wed, 19 Apr 2023 at 14:52, Eric Blake wrote: >> >> On Wed, Apr 19, 2023 at 01:28:17PM -0400, Stefan Hajnoczi wrote: >> > virtio_queue_aio_detach_host_notifier() does two things: >> > 1. It removes the fd handler from the event loop. >> > 2. It processes the virtqueue

[PULL 13/20] qemu-iotests: test zone append operation

From: Sam Li The patch tests zone append writes by reporting the zone wp after the completion of the call. "zap -p" option can print the sector offset value after completion, which should be the start sector where the append write begins. Signed-off-by: Sam Li Reviewed-by: Stefan Hajnoczi

[PULL 15/20] include: update virtio_blk headers to v6.3-rc1

From: Sam Li Use scripts/update-linux-headers.sh to update headers to 6.3-rc1. Signed-off-by: Sam Li Reviewed-by: Stefan Hajnoczi Reviewed-by: Dmitry Fomichev Message-id: 20230407082528.18841-2-faithilike...@gmail.com Signed-off-by: Stefan Hajnoczi ---

[PULL 07/20] block: add some trace events for new block layer APIs

From: Sam Li Signed-off-by: Sam Li Reviewed-by: Stefan Hajnoczi Reviewed-by: Dmitry Fomichev Acked-by: Kevin Wolf Message-id: 20230324090605.28361-8-faithilike...@gmail.com Signed-off-by: Stefan Hajnoczi --- block/file-posix.c | 3 +++ block/trace-events | 2 ++ 2 files changed, 5

[PULL 06/20] iotests: test new zone operations

From: Sam Li The new block layer APIs of zoned block devices can be tested by: $ tests/qemu-iotests/check zoned Run each zone operation on a newly created null_blk device and see whether it outputs the same zone information. Signed-off-by: Sam Li Reviewed-by: Stefan Hajnoczi Acked-by: Kevin

[PULL 12/20] block: introduce zone append write for zoned devices

From: Sam Li A zone append command is a write operation that specifies the first logical block of a zone as the write position. When writing to a zoned block device using zone append, the byte offset of the call may point at any position within the zone to which the data is being appended. Upon

[PULL 16/20] virtio-blk: add zoned storage emulation for zoned devices

From: Sam Li This patch extends virtio-blk emulation to handle zoned device commands by calling the new block layer APIs to perform zoned device I/O on behalf of the guest. It supports Report Zone, four zone oparations (open, close, finish, reset), and Append Zone. The VIRTIO_BLK_F_ZONED

[PULL 11/20] file-posix: add tracking of the zone write pointers

From: Sam Li Since Linux doesn't have a user API to issue zone append operations to zoned devices from user space, the file-posix driver is modified to add zone append emulation using regular writes. To do this, the file-posix driver tracks the wp location of all zones of the device. It uses an

[PULL 19/20] docs/zoned-storage:add zoned emulation use case

From: Sam Li Add the documentation about the example of using virtio-blk driver to pass the zoned block devices through to the guest. Signed-off-by: Sam Li Message-id: 20230407082528.18841-6-faithilike...@gmail.com [Fix Sphinx indentation error by turning command-lines into pre-formatted text.

[PULL 17/20] block: add accounting for zone append operation

From: Sam Li Taking account of the new zone append write operation for zoned devices, BLOCK_ACCT_ZONE_APPEND enum is introduced as other I/O request type (read, write, flush). Signed-off-by: Sam Li Message-id: 20230407082528.18841-4-faithilike...@gmail.com Signed-off-by: Stefan Hajnoczi ---

[PULL 10/20] tracetool: use relative paths for '#line' preprocessor directives

From: Thomas De Schampheleire The event filename is an absolute path. Convert it to a relative path when writing '#line' directives, to preserve reproducibility of the generated output when different base paths are used. Signed-off-by: Thomas De Schampheleire Signed-off-by: Stefan Hajnoczi

[PULL 14/20] block: add some trace events for zone append

From: Sam Li Signed-off-by: Sam Li Reviewed-by: Dmitry Fomichev Reviewed-by: Stefan Hajnoczi Message-id: 20230407081657.17947-5-faithilike...@gmail.com Signed-off-by: Stefan Hajnoczi --- block/file-posix.c | 3 +++ block/trace-events | 2 ++ 2 files changed, 5 insertions(+) diff --git

  1   2   >