On Thu, Jun 01, 2023 at 08:00:55AM -0500, Eric Blake wrote:
> > > @@ -83,13 +96,18 @@ REPLY.STRUCTURED_REPLY.CHECK:
> > > * not worth keeping the connection alive.
> > > */
> > >if (length > MAX_REQUEST_SIZE + sizeof
> > > h->sbuf.reply.payload.offset_data) {
> > > -set_error (0,
On 12/6/23 21:28, Bernhard Beschow wrote:
Am 9. Juni 2023 18:51:19 UTC schrieb Mark Cave-Ayland
:
The aim here is to eliminate any device-specific registers from the main BMDMA
bar memory region so it can potentially be moved into the shared PCI IDE device.
For each BMDMA bus create a new cm
On Mon, Jun 12, 2023 at 10:51:08PM +0200, Juan Quintela wrote:
> Peter Xu wrote:
> > On Mon, Jun 12, 2023 at 09:33:42PM +0200, Juan Quintela wrote:
> >> Only "defer" is recommended. After setting all migation parameters,
> >> start incoming migration with "migrate-incoming uri" command.
> >>
> >
Peter Xu wrote:
> On Mon, Jun 12, 2023 at 09:33:42PM +0200, Juan Quintela wrote:
>> Only "defer" is recommended. After setting all migation parameters,
>> start incoming migration with "migrate-incoming uri" command.
>>
>> Signed-off-by: Juan Quintela
>> ---
>> docs/about/deprecated.rst | 7 ++
On Mon, Jun 12, 2023 at 09:33:42PM +0200, Juan Quintela wrote:
> Only "defer" is recommended. After setting all migation parameters,
> start incoming migration with "migrate-incoming uri" command.
>
> Signed-off-by: Juan Quintela
> ---
> docs/about/deprecated.rst | 7 +++
> softmmu/vl.c
Signed-off-by: Juan Quintela
---
docs/about/deprecated.rst | 8
qapi/migration.json | 92 ---
migration/options.c | 13 ++
3 files changed, 79 insertions(+), 34 deletions(-)
diff --git a/docs/about/deprecated.rst b/docs/about/deprecated.r
Hi this series describe the migration parts that have to be deprecated.
- It is an rfc because I doubt that I did the deprecation process right. Hello
Markus O:-)
- skipped field: It is older than me, I have never know what it stands
for. As far as I know it has always been zero.
- inc/blk m
Only "defer" is recommended. After setting all migation parameters,
start incoming migration with "migrate-incoming uri" command.
Signed-off-by: Juan Quintela
---
docs/about/deprecated.rst | 7 +++
softmmu/vl.c | 2 ++
2 files changed, 9 insertions(+)
diff --git a/docs/about/d
Use 'migrate_set_parameter block_incremental true' instead.
Signed-off-by: Juan Quintela
---
docs/about/deprecated.rst | 7 +++
qapi/migration.json | 11 +--
migration/migration.c | 5 +
3 files changed, 21 insertions(+), 2 deletions(-)
diff --git a/docs/about/deprec
Use 'migrate_set_capability block true' instead.
Signed-off-by: Juan Quintela
---
docs/about/deprecated.rst | 7 +++
qapi/migration.json | 11 +++
migration/migration.c | 5 +
3 files changed, 19 insertions(+), 4 deletions(-)
diff --git a/docs/about/deprecated.rst b/
It is obsolete. It is better to use driver_mirror+NBD instead.
CC: Kevin Wolf
CC: Eric Blake
CC: Stefan Hajnoczi
CC: Hanna Czenczek
Signed-off-by: Juan Quintela
---
Can any of you give one example of how to use driver_mirror+NBD for
deprecated.rst?
Thanks, Juan.
---
docs/about/deprecate
Has return zero for more than 10 years. Just mark it deprecated.
Signed-off-by: Juan Quintela
---
docs/about/deprecated.rst | 10 ++
qapi/migration.json | 12 ++--
2 files changed, 20 insertions(+), 2 deletions(-)
diff --git a/docs/about/deprecated.rst b/docs/about/deprec
Am 9. Juni 2023 18:51:19 UTC schrieb Mark Cave-Ayland
:
>The aim here is to eliminate any device-specific registers from the main BMDMA
>bar memory region so it can potentially be moved into the shared PCI IDE
>device.
>
>For each BMDMA bus create a new cmd646-bmdma-specific memory region
>re
On Mon, Jun 12, 2023 at 06:07:59PM +0300, Vladimir Sementsov-Ogievskiy wrote:
> On 08.06.23 16:56, Eric Blake wrote:
> > The upcoming patches for 64-bit extensions requires various points in
> > the protocol to make decisions based on what was negotiated. While we
> > could easily add a 'bool exte
On Mon, Jun 12, 2023 at 05:27:19PM +0300, Vladimir Sementsov-Ogievskiy wrote:
> On 08.06.23 16:56, Eric Blake wrote:
> > Our code relies on a sentinel cookie value of zero for deciding when a
> > packet has been handled, as well as relying on array indices between 0
> > and MAX_NBD_REQUESTS-1 for d
On 12/06/2023 10:21, Bernhard Beschow wrote:
Am 9. Juni 2023 18:51:16 UTC schrieb Mark Cave-Ayland
:
This will enable CMD646-specific fields to be added to CMD6464IDEState in
future.
Signed-off-by: Mark Cave-Ayland
---
hw/ide/cmd646.c | 4 +++-
include/hw/ide/cmd646.h | 38 ++
On 08.06.23 16:56, Eric Blake wrote:
Add the constants and structs necessary for later patches to start
implementing the NBD_OPT_EXTENDED_HEADERS extension in both the client
and server, matching recent upstream nbd.git (through commit
e6f3b94a934). This patch does not change any existing behavi
On 08.06.23 16:56, Eric Blake wrote:
Once the 64-bit headers extension is enabled, the data layout we send
over the wire for a client request depends on the mode negotiated with
the server. Rather than adding a parameter to nbd_send_request, we
can add a member to struct NBDRequest, since it alr
On 08.06.23 16:56, Eric Blake wrote:
The upcoming patches for 64-bit extensions requires various points in
the protocol to make decisions based on what was negotiated. While we
could easily add a 'bool extended_headers' alongside the existing
'bool structured_reply', this does not scale well if
On 08.06.23 16:56, Eric Blake wrote:
Deciphering the hard-coded list of integer return values from
nbd_start_negotiate() will only get more confusing when adding support
for 64-bit extended headers. Better is to name things in an enum.
Although the function in question is private to client.c, pu
On 08.06.23 16:56, Eric Blake wrote:
Our code relies on a sentinel cookie value of zero for deciding when a
packet has been handled, as well as relying on array indices between 0
and MAX_NBD_REQUESTS-1 for dereferencing purposes. As long as we can
symmetrically convert between two forms, there i
On 08.06.23 16:56, Eric Blake wrote:
Externally, libnbd exposed the 64-bit opaque marker for each client
NBD packet as the "cookie", because it was less confusing when
contrasted with 'struct nbd_handle *' holding all libnbd state. It
also avoids confusion between the nown 'handle' as a way to i
On 08.06.23 16:56, Eric Blake wrote:
Upstream NBD now documents[1] an extension that supports 64-bit effect
lengths in requests. As part of that extension, the size of the reply
headers will change in order to permit a 64-bit length in the reply
for symmetry[2]. Additionally, where the reply he
On 9/6/23 20:51, Mark Cave-Ayland wrote:
Signed-off-by: Mark Cave-Ayland
---
hw/ide/cmd646.c | 13 +++--
1 file changed, 7 insertions(+), 6 deletions(-)
Reviewed-by: Philippe Mathieu-Daudé
On 9/6/23 20:51, Mark Cave-Ayland wrote:
This is to allow us to use the cmd646_bmdma_ops name for the CMD646
device-specific registers in the next commit.
Signed-off-by: Mark Cave-Ayland
---
hw/ide/cmd646.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
Reviewed-by: Philippe Mat
Am 9. Juni 2023 18:51:16 UTC schrieb Mark Cave-Ayland
:
>This will enable CMD646-specific fields to be added to CMD6464IDEState in
>future.
>
>Signed-off-by: Mark Cave-Ayland
>---
> hw/ide/cmd646.c | 4 +++-
> include/hw/ide/cmd646.h | 38 ++
> 2 file
On 08.06.23 17:17, Eric Blake wrote:
On Thu, Jun 08, 2023 at 08:56:31AM -0500, Eric Blake wrote:
We had a mix of struct declarataions followed by typedefs, and direct
declarations
struct definitions as part of a typedef. Pick a single style. Also
float a couple of opaque typedefs earlier i
27 matches
Mail list logo
