Re: [PATCH v2] hw/ide/piix: properly initialize the BMIBA register

Am 5. Juli 2023 10:01:21 UTC schrieb Olaf Hering : >Tue, 4 Jul 2023 08:38:33 +0200 Paolo Bonzini : > >> I agree that calling pci_device_reset() would be a better match for >> pci_xen_ide_unplug(). > >This change works as well: Nice! > >--- a/hw/i386/xen/xen_platform.c >+++

Re: [PATCH 1/2] block/file-posix: fix g_file_get_contents return path

On 6/4/23 2:16 AM, Sam Li wrote: > The g_file_get_contents() function returns a g_boolean. If it fails, the > returned value will be 0 instead of -1. Solve the issue by skipping > assigning ret value. > > This issue was found by Matthew Rosato using virtio-blk-{pci,ccw} backed > by an NVMe

Re: [PATCH v2] hw/ide/piix: properly initialize the BMIBA register

Tue, 4 Jul 2023 08:38:33 +0200 Paolo Bonzini : > I agree that calling pci_device_reset() would be a better match for > pci_xen_ide_unplug(). This change works as well: --- a/hw/i386/xen/xen_platform.c +++ b/hw/i386/xen/xen_platform.c @@ -164,8 +164,9 @@ static void pci_unplug_nics(PCIBus *bus)