On 30/08/2023 17:14, Alexander Graf wrote:
Hi Alex,
Apple has its own virtio-blk PCI device ID where it deviates from the
official virtio-pci spec slightly: It puts a new "apple type"
field at a static offset in config space and introduces a new barrier
command.
This patch first creates a mech
On 30/08/2023 17:14, Alexander Graf wrote:
Hi Alex,
Apple defines a new "vmapple" machine type as part of its proprietary
macOS Virtualization.Framework vmm. This machine type is similar to the
virt one, but with subtle differences in base devices, a few special
vmapple device additions and a v
On 2023/09/01 7:56, Philippe Mathieu-Daudé wrote:
Fix:
net/eth.c:435:20: error: declaration shadows a local variable
[-Werror,-Wshadow]
size_t input_size = iov_size(pkt, pkt_frags);
^
net/eth.c:413:16: note: previous declaration is here
size_t inp
Philippe Mathieu-Daudé writes:
> For rational see Markus cover on
> https://lore.kernel.org/qemu-devel/20230831132546.3525721-1-arm...@redhat.com/
>
> This series contains few more, my take.
>
> Based-on: <20230831132546.3525721-1-arm...@redhat.com>
Awesome, thanks!
Markus Armbruster writes:
> Local variables shadowing other local variables or parameters make the
> code needlessly hard to understand. Bugs love to hide in such code.
> Evidence: PATCH 1.
>
> Enabling -Wshadow would prevent bugs like this one. But we'd have to
> clean up all the offenders fir
Peter Maydell writes:
> On Thu, 31 Aug 2023 at 14:25, Markus Armbruster wrote:
>>
>> Local variables shadowing other local variables or parameters make the
>> code needlessly hard to understand. Tracked down with -Wshadow=local.
>> Clean up: delete inner declarations when they are actually redu
Richard Henderson writes:
> On 8/31/23 06:25, Markus Armbruster wrote:
>> +#define PASTE(a, b) a##b
>
> We already have glue() in qemu/compiler.h.
Missed it, will fix.
> The rest of it looks quite sensible.
Thanks!
From: zhenwei pi
Only one direction is necessary in several scenarios:
- a read-only disk
- operations on a device are considered as *write* only. For example,
encrypt/decrypt/sign/verify operations on a cryptodev use a single
*write* timer(read timer callback is defined, but never invoked).
The following changes since commit f5fe7c17ac4e309e47e78f0f9761aebc8d2f2c81:
Merge tag 'pull-tcg-20230823-2' of https://gitlab.com/rth7680/qemu into
staging (2023-08-28 16:07:04 -0400)
are available in the Git repository at:
https://gitlab.com/hreitz/qemu.git tags/pull-block-2023-09-01
for
From: zhenwei pi
Use enum ThrottleDirection instead in the throttle test codes.
Reviewed-by: Alberto Garcia
Reviewed-by: Hanna Czenczek
Signed-off-by: zhenwei pi
Message-Id: <20230728022006.1098509-3-pizhen...@bytedance.com>
Signed-off-by: Hanna Czenczek
---
tests/unit/test-throttle.c | 6 +
From: zhenwei pi
Reviewed-by: Alberto Garcia
Reviewed-by: Hanna Czenczek
Signed-off-by: zhenwei pi
Message-Id: <20230728022006.1098509-5-pizhen...@bytedance.com>
Signed-off-by: Hanna Czenczek
---
tests/unit/test-throttle.c | 66 ++
1 file changed, 66 inser
From: zhenwei pi
Operations on a cryptodev are considered as *write* only, the callback
of read direction is never invoked. Use NULL instead of an unreachable
path(cryptodev_backend_throttle_timer_cb on read direction).
The dummy read timer(never invoked) is already removed here, it means
that t
From: zhenwei pi
Use enum ThrottleDirection instead of number index.
Reviewed-by: Alberto Garcia
Reviewed-by: Hanna Czenczek
Signed-off-by: zhenwei pi
Message-Id: <20230728022006.1098509-2-pizhen...@bytedance.com>
Signed-off-by: Hanna Czenczek
---
include/qemu/throttle.h | 11 ---
u
From: zhenwei pi
'bool is_write' style is obsolete from throttle framework, adapt
fsdev to the new style.
Cc: Greg Kurz
Reviewed-by: Hanna Czenczek
Signed-off-by: zhenwei pi
Message-Id: <20230728022006.1098509-9-pizhen...@bytedance.com>
Reviewed-by: Greg Kurz
Signed-off-by: Hanna Czenczek
-
We must check that zone information is present before running
update_zones_wp().
Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=2234374
Fixes: Coverity CID 1512459
Signed-off-by: Hanna Czenczek
Message-Id: <20230824155345.109765-4-hre...@redhat.com>
Reviewed-by: Sam Li
---
block/file-posix.
This is a regression test for
https://bugzilla.redhat.com/show_bug.cgi?id=2234374.
All this test needs to do is trigger an I/O error inside of file-posix
(specifically raw_co_prw()). One reliable way to do this without
requiring special privileges is to use a FUSE export, which allows us to
injec
Instead of checking bs->wps or bs->bl.zone_size for whether zone
information is present, check bs->bl.zoned. That is the flag that
raw_refresh_zoned_limits() reliably sets to indicate zone support. If
it is set to something other than BLK_Z_NONE, other values and objects
like bs->wps and bs->bl.z
From: zhenwei pi
enum ThrottleDirection is already there, use ThrottleDirection instead
of 'bool is_write' for throttle API, also modify related codes from
block, fsdev, cryptodev and tests.
Reviewed-by: Hanna Czenczek
Signed-off-by: zhenwei pi
Message-Id: <20230728022006.1098509-7-pizhen...@b
bs->bl.zoned is what indicates whether the zone information is present
and valid; it is the only thing that raw_refresh_zoned_limits() sets if
CONFIG_BLKZONED is not defined, and it is also the only thing that it
sets if CONFIG_BLKZONED is defined, but there are no zones.
Make sure that it is alwa
From: zhenwei pi
The first dimension of both to_check and
bucket_types_size/bucket_types_units is used as throttle direction,
use THROTTLE_MAX instead of hard coded number. Also use ARRAY_SIZE()
to avoid hard coded number for the second dimension.
Hanna noticed that the two array should be stati
We duplicate the same condition three times here, pull it out to the top
level.
Signed-off-by: Hanna Czenczek
Message-Id: <20230824155345.109765-5-hre...@redhat.com>
Reviewed-by: Sam Li
---
block/file-posix.c | 18 +-
1 file changed, 5 insertions(+), 13 deletions(-)
diff --git
From: zhenwei pi
'bool is_write' style is obsolete from throttle framework, adapt
block throttle groups to the new style:
- use ThrottleDirection instead of 'bool is_write'. Ex,
schedule_next_request(ThrottleGroupMember *tgm, bool is_write)
-> schedule_next_request(ThrottleGroupMember *tgm, T
On Thu, Aug 31, 2023 at 6:03 PM Alex Bennée wrote:
>
> Albert Esteve writes:
>
> > Sorry to bring up this post, it's been a while since you posted.
> > But I have been testing the patch the last couple of days.
> >
> > On Mon, Jul 10, 2023 at 9:58 PM Michael S. Tsirkin
> wrote:
> >
> > On Mon,
Am 31.08.2023 um 11:20 hat Richard W.M. Jones geschrieben:
> On Thu, Aug 31, 2023 at 11:05:55AM +0200, Kevin Wolf wrote:
> > [ Cc: qemu-block ]
> >
> > Am 30.08.2023 um 20:26 hat Richard W.M. Jones geschrieben:
> > > On Tue, Aug 29, 2023 at 05:49:24PM -, Daniel Alley wrote:
> > > > > The backg
Eric Blake writes:
> On Thu, Aug 31, 2023 at 03:25:46PM +0200, Markus Armbruster wrote:
>
> [This paragraph written last: Bear with my stream of consciousness
> review below, where I end up duplicating some of the conslusions you
> reached before the point where I saw where the patch was headed]
On Fri, Sep 01, 2023 at 10:48:14AM +0200, Kevin Wolf wrote:
> Am 31.08.2023 um 11:20 hat Richard W.M. Jones geschrieben:
> > On Thu, Aug 31, 2023 at 11:05:55AM +0200, Kevin Wolf wrote:
> > > [ Cc: qemu-block ]
> > >
> > > Am 30.08.2023 um 20:26 hat Richard W.M. Jones geschrieben:
> > > > On Tue, A
On Fri, Sep 01, 2023 at 10:42:16AM +0100, Richard W.M. Jones wrote:
> $ hyperfine 'nbdkit -U - --filter=qcow2dec file test.qcow2.XXX --run
> '\''nbdcopy --request-size "$uri" test.out'\'' '
Sorry, copy and paste error, the command is:
hyperfine 'nbdkit -U - --filter=qcow2dec file test.qcow2.XX
On Fri, Sep 01, 2023 at 10:42:16AM +0100, Richard W.M. Jones wrote:
> On Fri, Sep 01, 2023 at 10:48:14AM +0200, Kevin Wolf wrote:
> > Am 31.08.2023 um 11:20 hat Richard W.M. Jones geschrieben:
> > > On Thu, Aug 31, 2023 at 11:05:55AM +0200, Kevin Wolf wrote:
> > > > [ Cc: qemu-block ]
> > > >
> >
On Fri, Sep 01, 2023 at 10:42:16AM +0100, Richard W.M. Jones wrote:
> Results:
>
> Cluster Compression Compressed size Prog Decompression speed
>
> 4k zlib 3228811264 qemu 5.921 s ± 0.074 s
> 4k zstd 3258097664 qemu 5.189 s ± 0.158 s
>
>
On Mon, Jul 10, 2023 at 6:44 PM Alex Bennée wrote:
> Instead of requiring all the information up front allow the
> vhost_dev_init to complete and then see what information we have from
> the backend.
>
> This does change the order around somewhat.
>
> Signed-off-by: Alex Bennée
> ---
> hw/virti
On Fri, Sep 01, 2023 at 10:55:50AM +0100, Daniel P. Berrangé wrote:
> On Fri, Sep 01, 2023 at 10:42:16AM +0100, Richard W.M. Jones wrote:
> > On Fri, Sep 01, 2023 at 10:48:14AM +0200, Kevin Wolf wrote:
> > > Am 31.08.2023 um 11:20 hat Richard W.M. Jones geschrieben:
> > > > On Thu, Aug 31, 2023 at
On Fri, Sep 01, 2023 at 11:03:54AM +0100, Richard W.M. Jones wrote:
> On Fri, Sep 01, 2023 at 10:55:50AM +0100, Daniel P. Berrangé wrote:
> > On Fri, Sep 01, 2023 at 10:42:16AM +0100, Richard W.M. Jones wrote:
> > > On Fri, Sep 01, 2023 at 10:48:14AM +0200, Kevin Wolf wrote:
> > > > Am 31.08.2023 u
Document the 'compression_type' option for qcow2, and mention that
streamOptimized vmdk supports compression, too.
Reported-by: Richard W.M. Jones
Signed-off-by: Kevin Wolf
---
docs/tools/qemu-img.rst | 19 +--
1 file changed, 17 insertions(+), 2 deletions(-)
diff --git a/docs/
On Fri, Sep 01, 2023 at 11:06:20AM +0100, Daniel P. Berrangé wrote:
> On Fri, Sep 01, 2023 at 11:03:54AM +0100, Richard W.M. Jones wrote:
> > I forgot to say that nbdkit is using zlib-ng, since I made the source
> > level changes a few weeks back (but most of the nbdkit performance
> > improvement
On Fri, Sep 01, 2023 at 12:24:30PM +0200, Kevin Wolf wrote:
> Document the 'compression_type' option for qcow2, and mention that
> streamOptimized vmdk supports compression, too.
>
> Reported-by: Richard W.M. Jones
> Signed-off-by: Kevin Wolf
Looks good, so:
Reviewed-by: Richard W.M. Jones
>
On Thu Aug 31, 2023 at 5:47 PM CEST, Alex Bennée wrote:
>
> Albert Esteve writes:
>
> > Sorry to bring up this post, it's been a while since you posted.
> > But I have been testing the patch the last couple of days.
> >
> > On Mon, Jul 10, 2023 at 9:58 PM Michael S. Tsirkin wrote:
> >
> > On Mon
On Thu, 31 Aug 2023 at 23:56, Philippe Mathieu-Daudé wrote:
>
> Fix:
>
> target/arm/tcg/translate-m-nocp.c:509:18: error: declaration shadows a
> local variable [-Werror,-Wshadow]
> TCGv_i32 tmp = load_cpu_field(v7m.fpdscr[M_REG_NS]);
> ^
> target/arm/tcg/translate-m-
Sam Li writes:
> To configure the zoned format feature on the qcow2 driver, it
> requires following arguments: the device size, zoned profile,
"Zoned profile" is gone in v3.
> zone model, zone size, zone capacity, number of conventional
> zones, limits on zone resources (max append sectors, max
Am 01.09.2023 um 12:03 hat Richard W.M. Jones geschrieben:
> On Fri, Sep 01, 2023 at 10:55:50AM +0100, Daniel P. Berrangé wrote:
> > On Fri, Sep 01, 2023 at 10:42:16AM +0100, Richard W.M. Jones wrote:
> > > On Fri, Sep 01, 2023 at 10:48:14AM +0200, Kevin Wolf wrote:
> > > > I understand the context
Am 31.08.2023 um 14:59 hat Dmitry Frolov geschrieben:
> bdrv_open_child() may return NULL.
> Usually return value is checked for this function.
> Check for return value is more reliable.
>
> Fixes: 24bc15d1f6 ("vmdk: Use BdrvChild instead of BDS for references to
> extents")
>
> Signed-off-by: D
Hello, Kevin.
This was just cleanup, based on the inspection.
Dmitry.
01.09.2023 14:15, Kevin Wolf пишет:
Am 31.08.2023 um 14:59 hat Dmitry Frolov geschrieben:
bdrv_open_child() may return NULL.
Usually return value is checked for this function.
Check for return value is more reliable.
Fixes
On Thu, 31 Aug 2023 at 23:56, Philippe Mathieu-Daudé wrote:
>
> Fix:
>
> hw/arm/virt.c:821:22: error: declaration shadows a local variable
> [-Werror,-Wshadow]
> qemu_irq irq = qdev_get_gpio_in(vms->gic,
> ^
> hw/arm/virt.c:803:13: note: previous declaration i
On Thu, 31 Aug 2023 at 23:56, Philippe Mathieu-Daudé wrote:
>
> Fix:
>
> hw/arm/allwinner-r40.c:412:14: error: declaration shadows a local variable
> [-Werror,-Wshadow]
> for (int i = 0; i < AW_R40_NUM_MMCS; i++) {
> ^
> hw/arm/allwinner-r40.c:299:14: note: previous declarati
On Thu, 31 Aug 2023 at 23:58, Philippe Mathieu-Daudé wrote:
>
> Fix:
>
> target/m68k/translate.c:828:18: error: declaration shadows a local variable
> [-Werror,-Wshadow]
> TCGv tmp = tcg_temp_new();
> ^
> target/m68k/translate.c:801:15: note: previous declaration
Li Feng writes:
> Let's keep the same behavior as vhost-user-blk.
>
> Some old guests kick virtqueue before setting VIRTIO_CONFIG_S_DRIVER_OK.
>
> Signed-off-by: Li Feng
> ---
> hw/scsi/vhost-user-scsi.c | 48 +++
> 1 file changed, 44 insertions(+), 4 deletio
On Fri, Sep 01, 2023 at 01:10:16PM +0200, Kevin Wolf wrote:
> And nbdkit seems to get worse instead of better with larger cluster
> size, no matter whether zlib or zstd is used.
It's caused by nbdcopy's default request size being 256k. Increasing
it to 2M cures the scaling problem - see updated r
Li Feng writes:
> If the backend crashes and restarts, the device is broken.
> This patch adds reconnect for vhost-user-scsi.
>
> Tested with spdk backend.
>
> Signed-off-by: Li Feng
> ---
> hw/scsi/vhost-user-scsi.c | 199 +---
> include/hw/virtio/vhost-user-s
Li Feng writes:
> Add a Error parameter to report the real error, like vhost-user-blk.
>
> Signed-off-by: Li Feng
> ---
> hw/scsi/vhost-scsi-common.c | 16 +---
> hw/scsi/vhost-scsi.c | 5 +++--
> hw/scsi/vhost-user-scsi.c | 14 --
On 8/31/23 16:30, Eric Blake wrote:
On Thu, Aug 31, 2023 at 03:25:46PM +0200, Markus Armbruster wrote:
[This paragraph written last: Bear with my stream of consciousness
review below, where I end up duplicating some of the conslusions you
reached before the point where I saw where the patch was
On Fri, Sep 01, 2023 at 10:48:26AM +0200, Markus Armbruster wrote:
> > Indeed, not fully understanding the preprocessor makes for some
> > interesting death traps.
>
> We use ALL_CAPS for macros to signal "watch out for traps".
>
> >> -#define QOBJECT(obj) ({
Am 01.09.2023 um 13:26 hat Дмитрий Фролов geschrieben:
> Hello, Kevin.
>
> This was just cleanup, based on the inspection.
Thanks for clarifying. I've updated the subject line to "vmdk: Clean up
bdrv_open_child() return value check" to avoid misunderstandings and
applied this to my block branch.
On 1/9/23 14:59, Cédric Le Goater wrote:
On 8/31/23 16:30, Eric Blake wrote:
On Thu, Aug 31, 2023 at 03:25:46PM +0200, Markus Armbruster wrote:
[This paragraph written last: Bear with my stream of consciousness
review below, where I end up duplicating some of the conslusions you
reached before
On 230112 0412, Lev Kujawski wrote:
>
> John Snow writes:
>
> > On Mon, Oct 10, 2022 at 4:52 AM Lev Kujawski wrote:
> >>
> >> Always use the native CHS device parameters for the ATA commands READ
> >> NATIVE MAX ADDRESS and READ NATIVE MAX ADDRESS EXT, not those limited
> >> by the ATA command I
Cédric Le Goater writes:
> On 8/31/23 16:30, Eric Blake wrote:
>> On Thu, Aug 31, 2023 at 03:25:46PM +0200, Markus Armbruster wrote:
>> [This paragraph written last: Bear with my stream of consciousness
>> review below, where I end up duplicating some of the conslusions you
>> reached before the
On 9/1/23 16:50, Markus Armbruster wrote:
Cédric Le Goater writes:
On 8/31/23 16:30, Eric Blake wrote:
On Thu, Aug 31, 2023 at 03:25:46PM +0200, Markus Armbruster wrote:
[This paragraph written last: Bear with my stream of consciousness
review below, where I end up duplicating some of the con
* Richard W. M. Jones:
> I tested the speed of decompression using:
>
> $ hyperfine 'qemu-img convert -W -m 16 -f qcow2 test.qcow2.XXX -O raw
> test.out'
> (qemu 8.0.0-4.fc39.x86_64)
>
> $ hyperfine 'nbdkit -U - --filter=qcow2dec file test.qcow2.XXX --run
> '\''nbdcopy --request-size "$uri
Am 24.08.2023 um 01:59 hat Stefan Hajnoczi geschrieben:
> Use qemu_get_current_aio_context() in mixed wrappers and coroutine
> wrappers so that code runs in the caller's AioContext instead of moving
> to the BlockDriverState's AioContext. This change is necessary for the
> multi-queue block layer w
On Fri, Sep 01, 2023 at 06:45:22PM +0200, Florian Weimer wrote:
> * Richard W. M. Jones:
>
> > I tested the speed of decompression using:
> >
> > $ hyperfine 'qemu-img convert -W -m 16 -f qcow2 test.qcow2.XXX -O raw
> > test.out'
> > (qemu 8.0.0-4.fc39.x86_64)
> >
> > $ hyperfine 'nbdkit -U
The commit 5d8813593f ("block/qapi: Let bdrv_query_image_info()
recurse") removed the loop where we set the 'bs0' variable, so now it
is just the same as 'bs'.
Signed-off-by: Fabiano Rosas
Reviewed-by: Philippe Mathieu-Daudé
---
block/qapi.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletio
Hi,
I'm resending a couple of already reviewed patches that were part of a
larger series[1].
Thanks
1- https://lore.kernel.org/r/20230609201910.12100-1-faro...@suse.de
Fabiano Rosas (2):
block: Remove bdrv_query_block_node_info
block: Remove unnecessary variable in bdrv_block_device_info
The last call site of this function has been removed by commit
c04d0ab026 ("qemu-img: Let info print block graph").
Reviewed-by: Claudio Fontana
Signed-off-by: Fabiano Rosas
---
block/qapi.c | 27 ---
include/block/qapi.h | 3 ---
2 files changed, 30 deletions(-
61 matches
Mail list logo
