Re: [PATCH v2 06/22] target/tricore: Clean up local variable shadowing

On Mon, Sep 04, 2023 at 06:12:18PM +0200, Philippe Mathieu-Daudé wrote: > Fix: > > target/tricore/translate.c:5016:18: warning: declaration of ‘temp’ shadows > a previous local [-Wshadow=compatible-local] >5016 | TCGv temp = tcg_constant_i32(const9); > |

Re: [PATCH v6 05/17] nbd/server: Refactor handling of command sanity checks

On 29.08.23 20:58, Eric Blake wrote: Upcoming additions to support NBD 64-bit effect lengths will add a new command flag NBD_CMD_FLAG_PAYLOAD_LEN that needs to be considered in our sanity checks of the client's messages (that is, more than just CMD_WRITE have the potential to carry a client

Re: [PATCH v2] qdict: Preserve order for iterating qdict elements

On Sat, Sep 02, 2023 at 05:40:40PM +0800, William Tsai wrote: > Changing the structure of qdict so that it can preserve order when > iterating qdict. This will fix array_properties as it relies on `len-` > prefixed argument to be set first. > > Resolves:

Re: [PATCH 3/3] tests/qtest/pflash: Clean up local variable shadowing

On Mon, 4 Sept 2023 at 17:30, Philippe Mathieu-Daudé wrote: > > Fix: > > tests/qtest/pflash-cfi02-test.c: In function ‘test_geometry’: > tests/qtest/pflash-cfi02-test.c:409:22: warning: declaration of ‘byte_addr’ > shadows a previous local [-Wshadow=compatible-local] > 409 |

Re: [PATCH 2/3] hw/intc/openpic: Clean up local variable shadowing

On Mon, 4 Sept 2023 at 17:28, Philippe Mathieu-Daudé wrote: > > Fix: > > hw/intc/openpic.c: In function ‘openpic_gbl_write’: > hw/intc/openpic.c:614:17: warning: declaration of ‘idx’ shadows a previous > local [-Wshadow=compatible-local] > 614 | int idx; > |

Re: [PATCH 1/3] hw/core/machine: Clean up local variable shadowing

On Mon, 4 Sept 2023 at 17:28, Philippe Mathieu-Daudé wrote: > > Fix: > > hw/core/machine.c: In function ‘machine_initfn’: > hw/core/machine.c:1081:17: warning: declaration of ‘obj’ shadows a > parameter [-Wshadow=compatible-local] >1081 | Object *obj = OBJECT(ms); > |

Re: [RFC PATCH v2 22/22] softmmu/physmem: Clean up local variable shadowing

On Mon, Sep 04, 2023 at 06:12:34PM +0200, Philippe Mathieu-Daudé wrote: > Fix: > > softmmu/physmem.c: In function > ‘cpu_physical_memory_snapshot_and_clear_dirty’: > softmmu/physmem.c:916:27: warning: declaration of ‘offset’ shadows a > parameter [-Wshadow=compatible-local] > 916 |

Re: [PATCH v2 16/22] crypto/cipher-gnutls.c: Clean up local variable shadowing

On 4/9/23 18:27, Daniel P. Berrangé wrote: On Mon, Sep 04, 2023 at 06:12:28PM +0200, Philippe Mathieu-Daudé wrote: Fix: In file included from crypto/cipher.c:140: crypto/cipher-gnutls.c.inc: In function ‘qcrypto_gnutls_cipher_encrypt’: crypto/cipher-gnutls.c.inc:116:17: warning:

[PATCH 3/3] tests/qtest/pflash: Clean up local variable shadowing

Fix: tests/qtest/pflash-cfi02-test.c: In function ‘test_geometry’: tests/qtest/pflash-cfi02-test.c:409:22: warning: declaration of ‘byte_addr’ shadows a previous local [-Wshadow=compatible-local] 409 | uint64_t byte_addr = (uint64_t)i * c->sector_len[region]; |

[PATCH 0/3] (few more) Steps towards enabling -Wshadow [3 more]

Just missed while posting v2 eh :/ (https://lore.kernel.org/qemu-devel/20230904161235.84651-1-phi...@linaro.org/) Philippe Mathieu-Daudé (3): hw/core/machine: Clean up local variable shadowing hw/intc/openpic: Clean up local variable shadowing tests/qtest/pflash: Clean up local variable

[PATCH 2/3] hw/intc/openpic: Clean up local variable shadowing

Fix: hw/intc/openpic.c: In function ‘openpic_gbl_write’: hw/intc/openpic.c:614:17: warning: declaration of ‘idx’ shadows a previous local [-Wshadow=compatible-local] 614 | int idx; | ^~~ hw/intc/openpic.c:568:9: note: shadowed declaration is here

[PATCH 1/3] hw/core/machine: Clean up local variable shadowing

Fix: hw/core/machine.c: In function ‘machine_initfn’: hw/core/machine.c:1081:17: warning: declaration of ‘obj’ shadows a parameter [-Wshadow=compatible-local] 1081 | Object *obj = OBJECT(ms); | ^~~ hw/core/machine.c:1065:36: note: shadowed declaration is

Re: [PATCH v2 16/22] crypto/cipher-gnutls.c: Clean up local variable shadowing

On Mon, Sep 04, 2023 at 06:12:28PM +0200, Philippe Mathieu-Daudé wrote: > Fix: > > In file included from crypto/cipher.c:140: > crypto/cipher-gnutls.c.inc: In function ‘qcrypto_gnutls_cipher_encrypt’: > crypto/cipher-gnutls.c.inc:116:17: warning: declaration of ‘err’ shadows a > previous

[PATCH v2 04/22] target/mips: Clean up local variable shadowing

Fix: target/mips/tcg/nanomips_translate.c.inc:4410:33: error: declaration shadows a local variable [-Werror,-Wshadow] int32_t imm = extract32(ctx->opcode, 1, 13) | ^ target/mips/tcg/nanomips_translate.c.inc:3577:9: note: previous

[PATCH v2 15/22] net/eth: Clean up local variable shadowing

Fix: net/eth.c:435:20: error: declaration shadows a local variable [-Werror,-Wshadow] size_t input_size = iov_size(pkt, pkt_frags); ^ net/eth.c:413:16: note: previous declaration is here size_t input_size = iov_size(pkt, pkt_frags); ^

[PATCH v2 14/22] hw/nios2: Clean up local variable shadowing

Fix: hw/nios2/10m50_devboard.c: In function ‘nios2_10m50_ghrd_init’: hw/nios2/10m50_devboard.c:101:22: warning: declaration of ‘dev’ shadows a previous local [-Wshadow=compatible-local] 101 | DeviceState *dev = qdev_new(TYPE_NIOS2_VIC); | ^~~

[PATCH v2 19/22] linux-user/strace: Clean up local variable shadowing

Fix: linux-user/strace.c: In function ‘print_sockaddr’: linux-user/strace.c:370:17: warning: declaration of ‘i’ shadows a previous local [-Wshadow=compatible-local] 370 | int i; | ^ linux-user/strace.c:361:9: note: shadowed declaration is here

[RFC PATCH v2 22/22] softmmu/physmem: Clean up local variable shadowing

Fix: softmmu/physmem.c: In function ‘cpu_physical_memory_snapshot_and_clear_dirty’: softmmu/physmem.c:916:27: warning: declaration of ‘offset’ shadows a parameter [-Wshadow=compatible-local] 916 | unsigned long offset = page % DIRTY_MEMORY_BLOCK_SIZE; |

[PATCH v2 21/22] softmmu/memory: Clean up local variable shadowing

Fix: softmmu/memory.c: In function ‘mtree_print_mr’: softmmu/memory.c:3236:27: warning: declaration of ‘ml’ shadows a previous local [-Wshadow=compatible-local] 3236 | MemoryRegionList *ml; | ^~ softmmu/memory.c:3213:32: note: shadowed

[PATCH v2 03/22] target/arm/hvf: Clean up local variable shadowing

Per Peter Maydell analysis [*]: The hvf_vcpu_exec() function is not documented, but in practice its caller expects it to return either EXCP_DEBUG (for "this was a guest debug exception you need to deal with") or something else (presumably the intention being 0 for OK). The

[PATCH v2 18/22] semihosting/arm-compat: Clean up local variable shadowing

Fix: semihosting/arm-compat-semi.c: In function ‘do_common_semihosting’: semihosting/arm-compat-semi.c:379:13: warning: declaration of ‘ret’ shadows a previous local [-Wshadow=local] 379 | int ret, err = 0; | ^~~ semihosting/arm-compat-semi.c:370:14: note:

Re: [PATCH v6 04/17] nbd: Prepare for 64-bit request effect lengths

On 29.08.23 20:58, Eric Blake wrote: Widen the length field of NBDRequest to 64-bits, although we can assert that all current uses are still under 32 bits: either because of NBD_MAX_BUFFER_SIZE which is even smaller (and where size_t can still be appropriate, even on 32-bit platforms), or

[PATCH v2 17/22] util/vhost-user-server: Clean up local variable shadowing

Fix: util/vhost-user-server.c: In function ‘set_watch’: util/vhost-user-server.c:274:20: warning: declaration of ‘vu_fd_watch’ shadows a previous local [-Wshadow=compatible-local] 274 | VuFdWatch *vu_fd_watch = g_new0(VuFdWatch, 1); |^~~

[PATCH v2 12/22] hw/m68k: Clean up local variable shadowing

Fix: hw/m68k/virt.c:263:13: error: declaration shadows a local variable [-Werror,-Wshadow] BOOTINFOSTR(param_ptr, BI_COMMAND_LINE, ^ hw/m68k/bootinfo.h:47:13: note: expanded from macro 'BOOTINFOSTR' int i; \ ^ hw/m68k/virt.c:130:9: note: previous

[PATCH v2 20/22] sysemu/device_tree: Clean up local variable shadowing

Fix: hw/mips/boston.c:472:5: error: declaration shadows a local variable [-Werror,-Wshadow] qemu_fdt_setprop_cells(fdt, name, "reg", reg_base, reg_size); ^ include/sysemu/device_tree.h:129:13: note: expanded from macro 'qemu_fdt_setprop_cells' int i; ^

[PATCH v2 13/22] hw/microblaze: Clean up local variable shadowing

Fix: hw/microblaze/petalogix_ml605_mmu.c: In function ‘petalogix_ml605_init’: hw/microblaze/petalogix_ml605_mmu.c:186:24: warning: declaration of ‘dinfo’ shadows a previous local [-Wshadow=compatible-local] 186 | DriveInfo *dinfo = drive_get(IF_MTD, 0, i); |

[PATCH v2 08/22] hw/arm/virt: Clean up local variable shadowing

Fix: hw/arm/virt.c:821:22: error: declaration shadows a local variable [-Werror,-Wshadow] qemu_irq irq = qdev_get_gpio_in(vms->gic, ^ hw/arm/virt.c:803:13: note: previous declaration is here int irq; ^ Signed-off-by: Philippe

[PATCH v2 10/22] hw/arm/aspeed: Clean up local variable shadowing

Fix: hw/arm/aspeed_ast2600.c:391:18: error: declaration shadows a local variable [-Werror,-Wshadow] qemu_irq irq = aspeed_soc_get_irq(s, ASPEED_DEV_TIMER1 + i); ^ hw/arm/aspeed_ast2600.c:283:14: note: previous declaration is here qemu_irq irq; ^

[PATCH v2 16/22] crypto/cipher-gnutls.c: Clean up local variable shadowing

Fix: In file included from crypto/cipher.c:140: crypto/cipher-gnutls.c.inc: In function ‘qcrypto_gnutls_cipher_encrypt’: crypto/cipher-gnutls.c.inc:116:17: warning: declaration of ‘err’ shadows a previous local [-Wshadow=compatible-local] 116 | int err =

[PATCH v2 11/22] hw/ide/ahci: Clean up local variable shadowing

hw/ide/ahci.c:1577:23: error: declaration shadows a local variable [-Werror,-Wshadow] IDEState *s = >port.ifs[j]; ^ hw/ide/ahci.c:1569:29: note: previous declaration is here void ahci_uninit(AHCIState *s) ^ Signed-off-by:

[PATCH v2 09/22] hw/arm/allwinner: Clean up local variable shadowing

Fix: hw/arm/allwinner-r40.c:412:14: error: declaration shadows a local variable [-Werror,-Wshadow] for (int i = 0; i < AW_R40_NUM_MMCS; i++) { ^ hw/arm/allwinner-r40.c:299:14: note: previous declaration is here unsigned i; ^ Signed-off-by: Philippe

[PATCH v2 06/22] target/tricore: Clean up local variable shadowing

Fix: target/tricore/translate.c:5016:18: warning: declaration of ‘temp’ shadows a previous local [-Wshadow=compatible-local] 5016 | TCGv temp = tcg_constant_i32(const9); | ^~~~ target/tricore/translate.c:4958:10: note: shadowed declaration is here

[PATCH v2 07/22] hw/arm/armv7m: Clean up local variable shadowing

Fix: hw/arm/armv7m.c: In function ‘armv7m_realize’: hw/arm/armv7m.c:520:27: warning: declaration of ‘sbd’ shadows a previous local [-Wshadow=compatible-local] 520 | SysBusDevice *sbd = SYS_BUS_DEVICE(>bitband[i]); | ^~~

[PATCH v2 05/22] target/m68k: Clean up local variable shadowing

Fix: target/m68k/translate.c:828:18: error: declaration shadows a local variable [-Werror,-Wshadow] TCGv tmp = tcg_temp_new(); ^ target/m68k/translate.c:801:15: note: previous declaration is here TCGv reg, tmp, result; ^ Signed-off-by: Philippe

[PATCH v2 01/22] tcg: Clean up local variable shadowing

Fix: tcg/tcg.c:2551:27: error: declaration shadows a local variable [-Werror,-Wshadow] MemOp op = get_memop(oi); ^ tcg/tcg.c:2437:12: note: previous declaration is here TCGOp *op; ^ accel/tcg/tb-maint.c:245:18: error: declaration

[PATCH v2 02/22] target/arm/tcg: Clean up local variable shadowing

Fix: target/arm/tcg/translate-m-nocp.c: In function ‘gen_M_fp_sysreg_read’: target/arm/tcg/translate-m-nocp.c:509:18: warning: declaration of ‘tmp’ shadows a previous local [-Wshadow=compatible-local] 509 | TCGv_i32 tmp = load_cpu_field(v7m.fpdscr[M_REG_NS]); |

[PATCH v2 00/22] (few more) Steps towards enabling -Wshadow

Since v1: - Addressed review comments - Added R-b tags - More patches For rational see Markus cover on https://lore.kernel.org/qemu-devel/20230831132546.3525721-1-arm...@redhat.com/ This series contains few more, my take. Based-on: <20230831132546.3525721-1-arm...@redhat.com> Philippe

Re: [PATCH v6 01/17] nbd: Replace bool structured_reply with mode enum

On 29.08.23 20:58, Eric Blake wrote: The upcoming patches for 64-bit extensions requires various points in the protocol to make decisions based on what was negotiated. While we could easily add a 'bool extended_headers' alongside the existing 'bool structured_reply', this does not scale well if

[PULL 10/14] block: remove AIOCBInfo->get_aio_context()

From: Stefan Hajnoczi The synchronous bdrv_aio_cancel() function needs the acb's AioContext so it can call aio_poll() to wait for cancellation. It turns out that all users run under the BQL in the main AioContext, so this callback is not needed. Remove the callback, mark bdrv_aio_cancel()

[PULL 09/14] vmdk: Clean up bdrv_open_child() return value check

From: Dmitry Frolov bdrv_open_child() may return NULL. Usually return value is checked for this function. Check for return value is more reliable. Fixes: 24bc15d1f6 ("vmdk: Use BdrvChild instead of BDS for references to extents") Signed-off-by: Dmitry Frolov Message-ID:

[PULL 05/14] qemu-img: omit errno value in error message

From: Michael Tokarev I'm getting io-qcow2-244 test failure on mips* due to output mismatch: Take an internal snapshot: -qemu-img: Could not create snapshot 'test': -95 (Operation not supported) +qemu-img: Could not create snapshot 'test': -122 (Operation not supported) No errors were

[PULL 03/14] block: minimize bs->reqs_lock section in tracked_request_end()

From: Stefan Hajnoczi Signed-off-by: Stefan Hajnoczi Message-ID: <20230808155852.2745350-2-stefa...@redhat.com> Reviewed-by: Eric Blake Reviewed-by: Kevin Wolf Signed-off-by: Kevin Wolf --- block/io.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/block/io.c

[PULL 06/14] block/iscsi: Document why we use raw malloc()

From: Peter Maydell In block/iscsi.c we use a raw malloc() call, which is unusual given the project standard is to use the glib memory allocation functions. Document why we do so, to avoid it being converted to g_malloc() by mistake. Signed-off-by: Peter Maydell Message-ID:

[PULL 12/14] block-backend: process zoned requests in the current AioContext

From: Stefan Hajnoczi Process zoned requests in the current thread's AioContext instead of in the BlockBackend's AioContext. There is no need to use the BlockBackend's AioContext thanks to CoMutex bs->wps->colock, which protects zone metadata. Signed-off-by: Stefan Hajnoczi Message-ID:

[PULL 07/14] block: Be more verbose in create fallback

From: Hanna Czenczek For image creation code, we have central fallback code for protocols that do not support creating new images (like NBD or iscsi). So for them, you can only specify existing paths/exports that are overwritten to make clean new images. In such a case, if the given path

[PULL 08/14] qemu-img: Update documentation for compressed images

Document the 'compression_type' option for qcow2, and mention that streamOptimized vmdk supports compression, too. Reported-by: Richard W.M. Jones Signed-off-by: Kevin Wolf Message-ID: <20230901102430.23856-1-kw...@redhat.com> Reviewed-by: Richard W.M. Jones Signed-off-by: Kevin Wolf ---

[PULL 04/14] block: change reqs_lock to QemuMutex

From: Stefan Hajnoczi CoMutex has poor performance when lock contention is high. The tracked requests list is accessed frequently and performance suffers in QEMU multi-queue block layer scenarios. It is not necessary to use CoMutex for the requests lock. The lock is always released across

[PULL 11/14] block-backend: process I/O in the current AioContext

From: Stefan Hajnoczi Switch blk_aio_*() APIs over to multi-queue by using qemu_get_current_aio_context() instead of blk_get_aio_context(). This change will allow devices to process I/O in multiple IOThreads in the future. I audited existing blk_aio_*() callers: - migration/block.c:

[PULL 14/14] block: Remove unnecessary variable in bdrv_block_device_info

From: Fabiano Rosas The commit 5d8813593f ("block/qapi: Let bdrv_query_image_info() recurse") removed the loop where we set the 'bs0' variable, so now it is just the same as 'bs'. Signed-off-by: Fabiano Rosas Reviewed-by: Philippe Mathieu-Daudé Message-ID:

[PULL 13/14] block: Remove bdrv_query_block_node_info

From: Fabiano Rosas The last call site of this function has been removed by commit c04d0ab026 ("qemu-img: Let info print block graph"). Reviewed-by: Claudio Fontana Signed-off-by: Fabiano Rosas Message-ID: <20230901184605.32260-2-faro...@suse.de> Reviewed-by: Kevin Wolf Signed-off-by: Kevin

[PULL 02/14] iotests: adapt test output for new qemu_cleanup() behavior

From: Fiona Ebner Since commit ca2a5e630d ("qemu_cleanup: begin drained section after vm_shutdown()"), there will be an additional pause for jobs during qemu_cleanup(). The reason is that the bdrv_drain_all() call in do_vm_stop() is not inside the drained section used by qemu_cleanup() anymore.

[PULL 00/14] Block layer patches

The following changes since commit 17780edd81d27fcfdb7a802efc870a99788bd2fc: Merge tag 'quick-fix-pull-request' of https://gitlab.com/bsdimp/qemu into staging (2023-08-31 10:06:29 -0400) are available in the Git repository at: https://repo.or.cz/qemu/kevin.git tags/for-upstream for you to

[PULL 01/14] block/vpc: Avoid dynamic stack allocation

From: Philippe Mathieu-Daudé Use autofree heap allocation instead of variable-length array on the stack. Here we don't expect the bitmap size to be enormous, and since we're about to read/write it to disk the overhead of the allocation should be fine. The codebase has very few VLAs, and if we

Re: [PATCH 02/11] target/arm: Clean up local variable shadowing

On 1/9/23 12:46, Peter Maydell wrote: On Thu, 31 Aug 2023 at 23:56, Philippe Mathieu-Daudé wrote: Fix: target/arm/tcg/translate-m-nocp.c:509:18: error: declaration shadows a local variable [-Werror,-Wshadow] TCGv_i32 tmp = load_cpu_field(v7m.fpdscr[M_REG_NS]);

Re: [PATCH 10/11] net/eth: Clean up local variable shadowing

On 1/9/23 09:07, Akihiko Odaki wrote: On 2023/09/01 7:56, Philippe Mathieu-Daudé wrote: Fix:    net/eth.c:435:20: error: declaration shadows a local variable [-Werror,-Wshadow] size_t input_size = iov_size(pkt, pkt_frags);     ^    net/eth.c:413:16: note:

Re: [PATCH 01/11] tcg: Clean up local variable shadowing

On 1/9/23 02:38, Richard Henderson wrote: On 8/31/23 15:55, Philippe Mathieu-Daudé wrote: -    MemOp op = get_memop(oi); +    MemOp o = get_memop(oi); mop would be a more descriptive replacement. I went with that first, but then noticed 'MemOpIdx oi' and

Re: [PATCH v4 2/3] hw/i2c: add mctp core

On Aug 30 15:31, Jonathan Cameron wrote: > On Wed, 23 Aug 2023 11:21:59 +0200 > Klaus Jensen wrote: > > > From: Klaus Jensen > > > > Add an abstract MCTP over I2C endpoint model. This implements MCTP > > control message handling as well as handling the actual I2C transport > > (packetization).

[PATCH v3 3/4] block: switch to co_wrapper for bdrv_is_allocated_*

Reviewed-by: Eric Blake Signed-off-by: Paolo Bonzini --- block/io.c | 53 ++-- include/block/block-io.h | 12 + 2 files changed, 14 insertions(+), 51 deletions(-) diff --git a/block/io.c b/block/io.c index ea358b6b994..81c9630dac1

[PATCH v3 4/4] block: convert more bdrv_is_allocated* and bdrv_block_status* calls to coroutine versions

Reviewed-by: Eric Blake Signed-off-by: Paolo Bonzini --- block/copy-before-write.c | 2 +- block/copy-on-read.c | 8 block/io.c| 6 +++--- block/mirror.c| 10 +- block/qcow2.c | 5 +++-- block/replication.c | 8

[PATCH v3 2/4] block: complete public block status API

Include both coroutine and non-coroutine versions, the latter being co_wrapper_mixed_bdrv_rdlock of the former. Reviewed-by: Eric Blake Signed-off-by: Paolo Bonzini --- block/io.c | 18 +- include/block/block-io.h | 17 +++-- 2 files changed, 16

[PATCH v3 0/4] block: clean up coroutine versions of bdrv_{is_allocated, block_status}*

Provide coroutine versions of bdrv_is_allocated* and bdrv_block_status*, since the underlying BlockDriver API is coroutine-based, and use automatically-generated wrappers for the "mixed" versions. v2->v3: cleaned up formatting Paolo Bonzini (4): block: rename the bdrv_co_block_status static

[PATCH v3 1/4] block: rename the bdrv_co_block_status static function

bdrv_block_status exists as a wrapper for bdrv_block_status_above, but the name of the (hypothetical) coroutine version, bdrv_co_block_status, is squatted by a random static function. Rename it to bdrv_co_do_block_status. Signed-off-by: Paolo Bonzini --- block/io.c | 21 +++--

Re: [POC 2/2] add test exposing AHCI reset issue

Am 25.08.2023 um 12:17 hat Fiona Ebner geschrieben: > Am 24.08.23 um 15:38 schrieb Fiona Ebner: > > Fails without the previous commit "hw/ide: reset: cancel async DMA > > operation before reseting state". > > > > I haven't ever written such a test before, but I wanted something to > > expose the

Re: [PATCH v2 0/4] block-backend: process I/O in the current AioContext

Am 24.08.2023 um 01:59 hat Stefan Hajnoczi geschrieben: > v2 > - Add patch to remove AIOCBInfo->get_aio_context() [Kevin] > - Add patch to use qemu_get_current_aio_context() in block-coroutine-wrapper > so > that the wrappers use the current AioContext instead of > bdrv_get_aio_context(). >

Re: [PATCH RESEND 0/2] block/qapi: Dead code cleanup

Am 01.09.2023 um 20:46 hat Fabiano Rosas geschrieben: > Hi, > > I'm resending a couple of already reviewed patches that were part of a > larger series[1]. > > Thanks > > 1- https://lore.kernel.org/r/20230609201910.12100-1-faro...@suse.de > > Fabiano Rosas (2): > block: Remove

[PATCH 2/2] blockdev: qmp_transaction: remove bdrv_drain_all from transaction

Now all transaction actions drain their respective bds Also, bdrv_drain_all() did not protect anything in case of IOThreads Signed-off-by: Andrey Zhadchenko --- blockdev.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/blockdev.c b/blockdev.c index 7a376fce90..65932f9afb 100644 ---

[PATCH 1/2] blockdev: qmp_transaction: harden transaction properties for bitmaps

Unlike other transaction commands, bitmap operations do not drain target bds. If we have an IOThread, this may result in some inconsistencies, as bitmap content may change during transaction command. Add bdrv_drained_begin()/end() to bitmap operations. Signed-off-by: Andrey Zhadchenko ---