Re: [PATCH 00/22] block: Graph locking part 5 (protect children/parent links)

2023-10-10 Thread Stefan Hajnoczi
On Fri, Sep 29, 2023 at 04:51:35PM +0200, Kevin Wolf wrote: > After all the preparation in previous series, this series reaches an > important milestone for the graph locking work: TSA can now verify that > all accesses to the children and parent lists of nodes happen under the > graph lock. > >

Re: [PATCH v2 00/10] mirror: allow switching from background to active mode

2023-10-10 Thread Vladimir Sementsov-Ogievskiy
On 10.10.23 20:55, Vladimir Sementsov-Ogievskiy wrote: On 09.10.23 12:46, Fiona Ebner wrote: Changes in v2: * move bitmap to filter which allows to avoid draining when    changing the copy mode * add patch to determine copy_to_target only once * drop patches returning

Re: [PATCH v2 10/10] iotests: adapt test output for new mirror query property

2023-10-10 Thread Vladimir Sementsov-Ogievskiy
On 09.10.23 12:46, Fiona Ebner wrote: Signed-off-by: Fiona Ebner This should be merged to the previous patch, to not break git bisect. Tests should work at any commit. -- Best regards, Vladimir

Re: [PATCH v2 09/10] mirror: return mirror-specific information upon query

2023-10-10 Thread Vladimir Sementsov-Ogievskiy
On 09.10.23 12:46, Fiona Ebner wrote: To start out, only actively-synced is returned. For example, this is useful for jobs that started out in background mode and switched to active mode. Once actively-synced is true, it's clear that the mode switch has been completed. Note that completion of

Re: [PATCH v2 08/10] blockjob: query driver-specific info via a new 'query' driver method

2023-10-10 Thread Vladimir Sementsov-Ogievskiy
On 09.10.23 12:46, Fiona Ebner wrote: Signed-off-by: Fiona Ebner --- No changes in v2. blockjob.c | 4 include/block/blockjob_int.h | 5 + 2 files changed, 9 insertions(+) diff --git a/blockjob.c b/blockjob.c index f8cf6e58e2..7e8cfad0fd 100644 --- a/blockjob.c

Re: [PATCH v2 05/10] mirror: implement mirror_change method

2023-10-10 Thread Vladimir Sementsov-Ogievskiy
On 09.10.23 12:46, Fiona Ebner wrote: which allows switching the @copy-mode from 'background' to 'write-blocking'. This is useful for management applications, so they can start out in background mode to avoid limiting guest write speed and switch to active mode when certain criteria are

Re: [PATCH v2 04/10] block/mirror: determine copy_to_target only once

2023-10-10 Thread Vladimir Sementsov-Ogievskiy
On 09.10.23 12:46, Fiona Ebner wrote: In preparation to allow changing the copy_mode via QMP. When running in an iothread, it could be that copy_mode is changed from the main thread in between reading copy_mode in bdrv_mirror_top_pwritev() and reading copy_mode in bdrv_mirror_top_do_write(), so

Re: [PATCH v2 03/10] block/mirror: move dirty bitmap to filter

2023-10-10 Thread Vladimir Sementsov-Ogievskiy
On 09.10.23 12:46, Fiona Ebner wrote: In preparation to allow switching to active mode without draining. Initialization of the bitmap in mirror_dirty_init() still happens with the original/backing BlockDriverState, which should be fine, because the mirror top has the same length. Suggested-by:

Re: [PATCH v2 01/10] blockjob: introduce block-job-change QMP command

2023-10-10 Thread Vladimir Sementsov-Ogievskiy
On 09.10.23 12:46, Fiona Ebner wrote: which will allow changing job-type-specific options after job creation. In the JobVerbTable, the same allow bits as for set-speed are used, because set-speed can be considered an existing change command. Signed-off-by: Fiona Ebner Reviewed-by: Vladimir

Re: [PATCH v2 00/10] mirror: allow switching from background to active mode

2023-10-10 Thread Vladimir Sementsov-Ogievskiy
On 09.10.23 12:46, Fiona Ebner wrote: Changes in v2: * move bitmap to filter which allows to avoid draining when changing the copy mode * add patch to determine copy_to_target only once * drop patches returning redundant information upon query * update QEMU version in

Re: [PATCH v2] hw/ide/ahci: fix legacy software reset

2023-10-10 Thread Michael Tokarev
05.10.2023 13:04, Niklas Cassel wrote: From: Niklas Cassel Legacy software contains a standard mechanism for generating a reset to a Serial ATA device - setting the SRST (software reset) bit in the Device Control register. Serial ATA has a more robust mechanism called COMRESET, also referred

Re: [PATCH v4 0/6] virtio: cleanup vhost-user-generic and reduce c

2023-10-10 Thread Mark Cave-Ayland
On 09/10/2023 10:59, Alex Bennée wrote: A lot of our vhost-user stubs are large chunks of boilerplate that do (mostly) the same thing. This series continues the cleanups by splitting the vhost-user-base and vhost-user-generic implementations. After adding a new vq_size property the rng, gpio

Re: [PATCH v4 1/6] virtio: split into vhost-user-base and vhost-user-device

2023-10-10 Thread Mark Cave-Ayland
On 09/10/2023 10:59, Alex Bennée wrote: Lets keep a cleaner split between the base class and the derived vhost-user-device which we can use for generic vhost-user stubs. This includes an update to introduce the vq_size property so the number of entries in a virtq can be defined. Signed-off-by:

Re: [PATCH] hw/ufs: Fix incorrect register fields

2023-10-10 Thread Stefan Hajnoczi
On Tue, Oct 10, 2023 at 02:11:13PM +0900, Jeuk Kim wrote: > From: Jeuk Kim > > This patch fixes invalid ufs register fields. > This fixes an issue reported by Bin Meng that > caused ufs to fail over riscv. > > Signed-off-by: Jeuk Kim > --- > include/block/ufs.h | 4 ++-- > 1 file changed, 2

Re: [PATCH 4/4] tests/qtest: Use qtest_get_base_arch()

2023-10-10 Thread Philippe Mathieu-Daudé
On 10/10/23 11:58, Thomas Huth wrote: On 10/10/2023 09.49, Philippe Mathieu-Daudé wrote: Additionally use qtest_get_arch_bits() when relevant. Signed-off-by: Philippe Mathieu-Daudé ---   tests/qtest/ahci-test.c   |  5 ++---   tests/qtest/am53c974-test.c   |  4 +---  

Re: [PATCH] hw/ufs: Fix incorrect register fields

2023-10-10 Thread Bin Meng
On Tue, Oct 10, 2023 at 1:11 PM Jeuk Kim wrote: > > From: Jeuk Kim > > This patch fixes invalid ufs register fields. > This fixes an issue reported by Bin Meng that > caused ufs to fail over riscv. > Fixes: bc4e68d362ec ("hw/ufs: Initial commit for emulated Universal-Flash-Storage")

Re: [PATCH 2/4] tests/qtest: Use qtest_get_arch_bits()

2023-10-10 Thread Ani Sinha
> On 10-Oct-2023, at 3:19 PM, Thomas Huth wrote: > > On 10/10/2023 09.49, Philippe Mathieu-Daudé wrote: > > Some short patch description, please! Why is this necessary/useful? > (I think I know, but other might not, and it is also important for the > history) Other than this, Reviewed-by:

Re: [PATCH 4/4] tests/qtest: Use qtest_get_base_arch()

2023-10-10 Thread Thomas Huth
On 10/10/2023 09.49, Philippe Mathieu-Daudé wrote: Additionally use qtest_get_arch_bits() when relevant. Signed-off-by: Philippe Mathieu-Daudé --- tests/qtest/ahci-test.c | 5 ++--- tests/qtest/am53c974-test.c | 4 +--- tests/qtest/bios-tables-test.c| 6 +++---

Re: [PATCH 3/4] tests/libqtest: Introduce qtest_get_base_arch()

2023-10-10 Thread Thomas Huth
On 10/10/2023 10.42, Philippe Mathieu-Daudé wrote: On 10/10/23 09:49, Philippe Mathieu-Daudé wrote: While qtest_get_arch() returns the target architecture name, such "i386" or "x86_64", qtest_get_base_arch() return the "base" (or real underlying) architecture, in this example that is "x86".

Re: [PATCH 2/4] tests/qtest: Use qtest_get_arch_bits()

2023-10-10 Thread Thomas Huth
On 10/10/2023 09.49, Philippe Mathieu-Daudé wrote: Some short patch description, please! Why is this necessary/useful? (I think I know, but other might not, and it is also important for the history) Signed-off-by: Philippe Mathieu-Daudé --- tests/qtest/arm-cpu-features.c | 49

Re: [PATCH 1/4] tests/libqtest: Introduce qtest_get_arch_bits()

2023-10-10 Thread Philippe Mathieu-Daudé
On 10/10/23 11:46, Thomas Huth wrote: On 10/10/2023 09.49, Philippe Mathieu-Daudé wrote: Add a method to return the architecture bits (currently 8/32/64). Signed-off-by: Philippe Mathieu-Daudé ---   tests/qtest/libqtest.h |  8   tests/qtest/libqtest.c | 21 +   2

Re: [PATCH 1/4] tests/libqtest: Introduce qtest_get_arch_bits()

2023-10-10 Thread Thomas Huth
On 10/10/2023 09.49, Philippe Mathieu-Daudé wrote: Add a method to return the architecture bits (currently 8/32/64). Signed-off-by: Philippe Mathieu-Daudé --- tests/qtest/libqtest.h | 8 tests/qtest/libqtest.c | 21 + 2 files changed, 29 insertions(+) diff

Re: [PATCH 4/4] tests/qtest: Use qtest_get_base_arch()

2023-10-10 Thread Akihiko Odaki
On 2023/10/10 16:49, Philippe Mathieu-Daudé wrote: Additionally use qtest_get_arch_bits() when relevant. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Akihiko Odaki

Re: [PATCH 3/4] tests/libqtest: Introduce qtest_get_base_arch()

2023-10-10 Thread Philippe Mathieu-Daudé
On 10/10/23 09:49, Philippe Mathieu-Daudé wrote: While qtest_get_arch() returns the target architecture name, such "i386" or "x86_64", qtest_get_base_arch() return the "base" (or real underlying) architecture, in this example that is "x86". Signed-off-by: Philippe Mathieu-Daudé ---

[PATCH 3/4] tests/libqtest: Introduce qtest_get_base_arch()

2023-10-10 Thread Philippe Mathieu-Daudé
While qtest_get_arch() returns the target architecture name, such "i386" or "x86_64", qtest_get_base_arch() return the "base" (or real underlying) architecture, in this example that is "x86". Signed-off-by: Philippe Mathieu-Daudé --- tests/qtest/libqtest.h | 7 +++ tests/qtest/libqtest.c |

[PATCH 2/4] tests/qtest: Use qtest_get_arch_bits()

2023-10-10 Thread Philippe Mathieu-Daudé
Signed-off-by: Philippe Mathieu-Daudé --- tests/qtest/arm-cpu-features.c | 49 -- tests/qtest/bios-tables-test.c | 16 +-- 2 files changed, 30 insertions(+), 35 deletions(-) diff --git a/tests/qtest/arm-cpu-features.c b/tests/qtest/arm-cpu-features.c

[PATCH 4/4] tests/qtest: Use qtest_get_base_arch()

2023-10-10 Thread Philippe Mathieu-Daudé
Additionally use qtest_get_arch_bits() when relevant. Signed-off-by: Philippe Mathieu-Daudé --- tests/qtest/ahci-test.c | 5 ++--- tests/qtest/am53c974-test.c | 4 +--- tests/qtest/bios-tables-test.c| 6 +++--- tests/qtest/boot-sector.c | 6 +++---

[PATCH 0/4] tests/qtest: Introduce qtest_get_base_arch() and qtest_get_arch_bits()

2023-10-10 Thread Philippe Mathieu-Daudé
When unifying some 32/64 architectures as a single binary (for example i386 & x86_64 -> x86), some qtests fail because we lose some information (the arch bits). This series introduce the tuple qtest_get_base_arch() / qtest_get_arch_bits() to allow the tests to keep passing. Eventually we should

[PATCH 1/4] tests/libqtest: Introduce qtest_get_arch_bits()

2023-10-10 Thread Philippe Mathieu-Daudé
Add a method to return the architecture bits (currently 8/32/64). Signed-off-by: Philippe Mathieu-Daudé --- tests/qtest/libqtest.h | 8 tests/qtest/libqtest.c | 21 + 2 files changed, 29 insertions(+) diff --git a/tests/qtest/libqtest.h b/tests/qtest/libqtest.h