Thomas Huth writes:
> No need to declare a new variable in the the inner code block
> here, we can re-use the "ret" variable that has been declared
> at the beginning of the function. With this change, the code
> can now be successfully compiled with -Wshadow=local again.
>
> Fixes: a32e781838 ("
Applied, thanks.
Please update the changelog at https://wiki.qemu.org/ChangeLog/8.2 for any
user-visible changes.
signature.asc
Description: PGP signature
On Mon, 23 Oct 2023, Mark Cave-Ayland wrote:
On 20/10/2023 00:09, BALATON Zoltan wrote:
On Thu, 19 Oct 2023, Mark Cave-Ayland wrote:
Allow the VIA IDE controller to switch between both legacy and native
modes by
calling pci_ide_update_mode() to reconfigure the device whenever
PCI_CLASS_PROG
i
On 20/10/2023 00:09, BALATON Zoltan wrote:
On Thu, 19 Oct 2023, Mark Cave-Ayland wrote:
Allow the VIA IDE controller to switch between both legacy and native modes by
calling pci_ide_update_mode() to reconfigure the device whenever PCI_CLASS_PROG
is updated.
This patch also moves the setting o
On 23/10/2023 18:19, Bernhard Beschow wrote:
Am 22. Oktober 2023 22:06:30 UTC schrieb Bernhard Beschow :
Am 19. Oktober 2023 13:04:51 UTC schrieb Mark Cave-Ayland
:
This function reads the value of the PCI_CLASS_PROG register for PCI IDE
controllers and configures the PCI BARs and/or IDE io
Am 22. Oktober 2023 22:06:30 UTC schrieb Bernhard Beschow :
>
>
>Am 19. Oktober 2023 13:04:51 UTC schrieb Mark Cave-Ayland
>:
>>This function reads the value of the PCI_CLASS_PROG register for PCI IDE
>>controllers and configures the PCI BARs and/or IDE ioports accordingly.
>>
>>In the case whe
On 22/10/2023 23:10, Bernhard Beschow wrote:
Am 19. Oktober 2023 13:04:50 UTC schrieb Mark Cave-Ayland
:
This series adds a simple implementation of legacy/native mode switching for PCI
IDE controllers and updates the via-ide device to use it.
The approach I take here is to add a new pci_ide_
On 22/10/2023 23:06, Bernhard Beschow wrote:
Am 19. Oktober 2023 13:04:51 UTC schrieb Mark Cave-Ayland
:
This function reads the value of the PCI_CLASS_PROG register for PCI IDE
controllers and configures the PCI BARs and/or IDE ioports accordingly.
In the case where we switch to legacy mode,
No need to declare a new variable in the the inner code block
here, we can re-use the "ret" variable that has been declared
at the beginning of the function. With this change, the code
can now be successfully compiled with -Wshadow=local again.
Fixes: a32e781838 ("Mark bdrv_snapshot_fallback() and
On 23/10/2023 17.26, Markus Armbruster wrote:
Thomas Huth writes:
No need to declare a new variable in the the inner code block
here, we can re-use the "ret" variable that has been declared
at the beginning of the function. With this change, the code
can now be successfully compiled with -Wsha
Volker Rümelin wrote:
> Am 20.10.23 um 11:07 schrieb Juan Quintela:
>> We can have more than one audio card.
>
> Hi Juan,
>
> I wouldn't use the term "audio card" here. In QEMU speak, Audiodev is an
> "audio backend".
Thanks. Changed that.
> With best regards,
> Volker
>
>>
>> void audio_init_a
Thomas Huth writes:
> No need to declare a new variable in the the inner code block
> here, we can re-use the "ret" variable that has been declared
> at the beginning of the function. With this change, the code
> can now be successfully compiled with -Wshadow=local again.
>
> Fixes: a32e781838 ("
No need to declare a new variable in the the inner code block
here, we can re-use the "ret" variable that has been declared
at the beginning of the function. With this change, the code
can now be successfully compiled with -Wshadow=local again.
Fixes: a32e781838 ("Mark bdrv_snapshot_fallback() and
Am 23.10.23 um 14:59 schrieb Kevin Wolf:
> Am 23.10.2023 um 13:37 hat Fiona Ebner geschrieben:
+current = qatomic_cmpxchg(&s->copy_mode, MIRROR_COPY_MODE_BACKGROUND,
+ change_opts->copy_mode);
+if (current != MIRROR_COPY_MODE_BACKGROUND) {
+
Am 23.10.2023 um 11:30 hat Igor Mammedov geschrieben:
> On Wed, 18 Oct 2023 09:32:47 +0100
> David Woodhouse wrote:
>
> > On Wed, 2023-10-18 at 09:32 +0200, Igor Mammedov wrote:
> > > On Mon, 16 Oct 2023 16:19:08 +0100
> > > David Woodhouse wrote:
> > >
> > > > From: David Woodhouse
> > > >
Am 23.10.2023 um 11:31 hat Fiona Ebner geschrieben:
> Am 18.10.23 um 17:52 schrieb Kevin Wolf:
> > Am 13.10.2023 um 11:21 hat Fiona Ebner geschrieben:
> >> which will allow changing job-type-specific options after job
> >> creation.
> >>
> >> In the JobVerbTable, the same allow bits as for set-spee
Am 23.10.2023 um 13:37 hat Fiona Ebner geschrieben:
> Am 18.10.23 um 18:59 schrieb Kevin Wolf:
> > Am 13.10.2023 um 11:21 hat Fiona Ebner geschrieben:
> >> which allows switching the @copy-mode from 'background' to
> >> 'write-blocking'.
> >>
> >> This is useful for management applications, so they
Am 19.10.23 um 15:36 schrieb Kevin Wolf:
> Most of this series looks good to me. Apart from the comments I made in
> the individual patches, I would like to see iotests coverage of changing
> the mirroring mode. At the least to show that the query result changes,
> but ideally also that requests re
Am 18.10.23 um 18:59 schrieb Kevin Wolf:
> Am 13.10.2023 um 11:21 hat Fiona Ebner geschrieben:
>> which allows switching the @copy-mode from 'background' to
>> 'write-blocking'.
>>
>> This is useful for management applications, so they can start out in
>> background mode to avoid limiting guest wri
On 10/21/23 12:40, Mike Maslenkin wrote:
On Thu, Oct 19, 2023 at 4:05 PM Alexander Ivanov
wrote:
Now dirty bitmaps can be loaded but there is no their saving. Add code for
dirty bitmap storage.
Signed-off-by: Alexander Ivanov
---
block/parallels-ext.c | 167 ++
On 23 October 2023 10:30:02 BST, Igor Mammedov wrote:
>On Wed, 18 Oct 2023 09:32:47 +0100
>David Woodhouse wrote:
>
>> On Wed, 2023-10-18 at 09:32 +0200, Igor Mammedov wrote:
>> > On Mon, 16 Oct 2023 16:19:08 +0100
>> > David Woodhouse wrote:
>> >
>> > > From: David Woodhouse
>> > >
>>
I don’t understand the “valid for resize only” comment. Looks like this is zero
day behavior and I can’t tell why it was added. Does anyone know?
With that, reasoning and code looks good:
Acked-by: Raphael Norwitz
> On Oct 6, 2023, at 4:20 PM, Vladimir Sementsov-Ogievskiy
> wrote:
>
> Let's
Am 18.10.23 um 17:52 schrieb Kevin Wolf:
> Am 13.10.2023 um 11:21 hat Fiona Ebner geschrieben:
>> which will allow changing job-type-specific options after job
>> creation.
>>
>> In the JobVerbTable, the same allow bits as for set-speed are used,
>> because set-speed can be considered an existing c
> On Oct 13, 2023, at 3:48 AM, Emmanouil Pitsidianakis
> wrote:
>
> In preparation of raising -Wimplicit-fallthrough to 5, replace all
> fall-through comments with the fallthrough attribute pseudo-keyword.
>
> Signed-off-by: Emmanouil Pitsidianakis
Reviewed-by: Raphael Norwitz
> ---
> co
> On Oct 13, 2023, at 3:48 AM, Emmanouil Pitsidianakis
> wrote:
>
> Signed-off-by: Emmanouil Pitsidianakis
Reviewed-by: Raphael Norwitz
> ---
> contrib/vhost-user-scsi/vhost-user-scsi.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/contrib/vhost-user-scsi/vhos
On Wed, 18 Oct 2023 09:32:47 +0100
David Woodhouse wrote:
> On Wed, 2023-10-18 at 09:32 +0200, Igor Mammedov wrote:
> > On Mon, 16 Oct 2023 16:19:08 +0100
> > David Woodhouse wrote:
> >
> > > From: David Woodhouse
> > >
> >
> > is this index a user (guest) visible?
>
> Yes. It defines
On Thu, 2023-10-19 at 16:40 +0100, David Woodhouse wrote:
> From: David Woodhouse
>
> Fix the filename in the MAINTAINERS file too.
>
> Signed-off-by: David Woodhouse
> ---
> MAINTAINERS | 2 +-
> tests/avocado/kvm_xen_guest.py | 2 +-
> 2 files changed, 2 insertions(+), 2 d
27 matches
Mail list logo
