Re: [PATCH v2] tests/cdrom-test: Add cdrom test for LoongArch virt machine

2024-02-18 Thread Thomas Huth
On 17/02/2024 11.02, Bibo Mao wrote: The cdrom test skips to execute on LoongArch system with command "make check", this patch enables cdrom test for LoongArch virt machine platform. With this patch, cdrom test passes to run on LoongArch virt machine type. Signed-off-by: Bibo Mao --- Add virti

Re: [PATCH v5 02/11] pcie_sriov: Validate NumVFs

2024-02-18 Thread Michael S. Tsirkin
On Sun, Feb 18, 2024 at 01:56:07PM +0900, Akihiko Odaki wrote: > The guest may write NumVFs greater than TotalVFs and that can lead > to buffer overflow in VF implementations. > > Cc: qemu-sta...@nongnu.org > Fixes: 7c0fa8dff811 ("pcie: Add support for Single Root I/O Virtualization > (SR/IOV)")

Re: [PATCH v5 05/11] vfio: Avoid inspecting option QDict for rombar

2024-02-18 Thread Michael S. Tsirkin
On Sun, Feb 18, 2024 at 01:56:10PM +0900, Akihiko Odaki wrote: > Use pci_rom_bar_explicitly_enabled() to determine if rombar is explicitly > enabled. > > Signed-off-by: Akihiko Odaki I see little point in all this reworks: QDict lookups are robust. But if Alex wants this change, I won't oppose