On 2024/02/19 2:36, Michael S. Tsirkin wrote:
On Sun, Feb 18, 2024 at 01:56:07PM +0900, Akihiko Odaki wrote:
The guest may write NumVFs greater than TotalVFs and that can lead
to buffer overflow in VF implementations.
Cc: qemu-sta...@nongnu.org
Fixes: 7c0fa8dff811 ("pcie: Add support for Single
Let's start to unentangle internal.h by moving public IDE device
related definitions to ide-dev.h.
Signed-off-by: Thomas Huth
---
include/hw/ide/ide-dev.h | 145 +-
include/hw/ide/internal.h | 145 +-
hw/ide/ide-dev.c
While trying to make it possible to compile-out the CompactFlash IDE device
in downstream distributions (first patch), we noticed that there are more
things in the IDE code that could use a proper clean up:
First, hw/ide/qdev.c is quite a mix between IDE BUS specific functions
and (disk) device sp
qdev.c is a mixture between IDE bus specific functions and IDE device
functions. Let's split it up to make it more obvious which part is
related to bus handling and which part is related to device handling.
Signed-off-by: Thomas Huth
---
hw/ide/ide-bus.c | 111 +++
For distros like downstream RHEL, it would be helpful to allow to disable
the CompactFlash device. For making this possible, we need a separate
Kconfig switch for this device, and the code should reside in a separate
file. Let's also introduce a new header ide-dev.h which can be used to
collect def
Let's consolidate the public IDE bus related functions in a separate
header.
Signed-off-by: Thomas Huth
---
include/hw/ide/ide-bus.h | 41 +++
include/hw/ide/internal.h | 38 +---
2 files changed, 42 insertions(+), 37 deletions
include/hw/ide/internal.h is currently included by include/hw/ide/pci.h
and thus exposed to a lot of files that are not part of the IDE subsystem.
Stop including internal.h there and use the appropriate new headers
ide-bus.h and ide-dma.h instead.
Signed-off-by: Thomas Huth
---
include/hw/ide/pc
These definitions are required outside of the hw/ide/ code, too,
so lets's move them from internal.h to a new header called ide-dma.h.
Signed-off-by: Thomas Huth
---
include/hw/ide/ide-dma.h | 30 ++
include/hw/ide/internal.h | 27 +--
2 files
There was only one prototype left in this legacy file. Move it to
ide-dev.h to finally get rid of it.
Signed-off-by: Thomas Huth
---
include/hw/ide.h | 9 -
include/hw/ide/ide-dev.h | 2 ++
include/hw/ide/internal.h | 1 -
3 files changed, 2 insertions(+), 10 deletions(-)
dele
The OSPI DMA reads flash data through the OSPI linear address space (the
iomem_dac region), because of this the reentrancy guard introduced in
commit a2e1753b ("memory: prevent dma-reentracy issues") is disabled for
the memory region.
Signed-off-by: Sai Pavan Boddu
---
Changes for V2:
Add
On 19/2/24 11:49, Thomas Huth wrote:
Let's start to unentangle internal.h by moving public IDE device
related definitions to ide-dev.h.
Signed-off-by: Thomas Huth
---
include/hw/ide/ide-dev.h | 145 +-
include/hw/ide/internal.h | 145 +
On 19/2/24 11:49, Thomas Huth wrote:
While trying to make it possible to compile-out the CompactFlash IDE device
in downstream distributions (first patch), we noticed that there are more
things in the IDE code that could use a proper clean up:
First, hw/ide/qdev.c is quite a mix between IDE BUS
On Mon, 19 Feb 2024, Thomas Huth wrote:
qdev.c is a mixture between IDE bus specific functions and IDE device
functions. Let's split it up to make it more obvious which part is
related to bus handling and which part is related to device handling.
Signed-off-by: Thomas Huth
---
hw/ide/ide-bus.c
On Mon, 19 Feb 2024, Thomas Huth wrote:
These definitions are required outside of the hw/ide/ code, too,
so lets's move them from internal.h to a new header called ide-dma.h.
Signed-off-by: Thomas Huth
---
include/hw/ide/ide-dma.h | 30 ++
include/hw/ide/internal.h |
I apologize for the delayed review.
Sam Li writes:
> To configure the zoned format feature on the qcow2 driver, it
> requires settings as: the device size, zone model, zone size,
> zone capacity, number of conventional zones, limits on zone
> resources (max append bytes, max open zones, and max_
On Fri, Feb 16, 2024 at 12:02:55PM +0100, Philippe Mathieu-Daudé wrote:
> Prefer QDev API for QDev objects, avoid the underlying QOM layer.
>
> Signed-off-by: Philippe Mathieu-Daudé
> ---
> include/hw/tricore/tricore_testdevice.h | 3 ---
> hw/tricore/tricore_testboard.c | 4 +---
> 2 f
On Feb 18 13:56, Akihiko Odaki wrote:
> nvme_sriov_pre_write_ctrl() used to directly inspect SR-IOV
> configurations to know the number of VFs being disabled due to SR-IOV
> configuration writes, but the logic was flawed and resulted in
> out-of-bound memory access.
>
> It assumed PCI_SRIOV_NUM_VF
One more thing...
Markus Armbruster writes:
> I apologize for the delayed review.
>
> Sam Li writes:
>
>> To configure the zoned format feature on the qcow2 driver, it
>> requires settings as: the device size, zone model, zone size,
>> zone capacity, number of conventional zones, limits on zone
Markus Armbruster 于2024年2月19日周一 13:05写道：
>
> One more thing...
>
> Markus Armbruster writes:
>
> > I apologize for the delayed review.
No problems. Thanks for reviewing!
> >
> > Sam Li writes:
> >
> >> To configure the zoned format feature on the qcow2 driver, it
> >> requires settings as: the
On 16/02/2024 12.03, Philippe Mathieu-Daudé wrote:
QDev objects created with qdev_*new() need to manually add
their parent relationship with object_property_add_child().
Signed-off-by: Philippe Mathieu-Daudé
---
hw/s390x/s390-pci-bus.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/hw/s
On 19/2/24 14:38, Thomas Huth wrote:
On 16/02/2024 12.03, Philippe Mathieu-Daudé wrote:
QDev objects created with qdev_*new() need to manually add
their parent relationship with object_property_add_child().
Signed-off-by: Philippe Mathieu-Daudé
---
hw/s390x/s390-pci-bus.c | 1 +
1 file chan
Sam Li writes:
> Markus Armbruster 于2024年2月19日周一 13:05写道：
>>
>> One more thing...
>>
>> Markus Armbruster writes:
>>
>> > I apologize for the delayed review.
>
> No problems. Thanks for reviewing!
>
>> >
>> > Sam Li writes:
>> >
>> >> To configure the zoned format feature on the qcow2 driver,
Markus Armbruster 于2024年2月19日周一 15:40写道：
>
> Sam Li writes:
>
> > Markus Armbruster 于2024年2月19日周一 13:05写道：
> >>
> >> One more thing...
> >>
> >> Markus Armbruster writes:
> >>
> >> > I apologize for the delayed review.
> >
> > No problems. Thanks for reviewing!
> >
> >> >
> >> > Sam Li writes:
On Fri, Feb 16, 2024 at 11:14:15AM +0100, Fiona Ebner wrote:
> Failure was noticed when running the tests for the qcow2 image format.
>
> Fixes: 0bd779e27e ("crypto: Introduce 'detached-header' field in
> QCryptoBlockInfoLUKS")
> Signed-off-by: Fiona Ebner
> ---
> tests/qemu-iotests/198.out | 2
Sam Li writes:
> Markus Armbruster 于2024年2月19日周一 15:40写道：
>>
>> Sam Li writes:
>>
>> > Markus Armbruster 于2024年2月19日周一 13:05写道：
>> >>
>> >> One more thing...
>> >>
>> >> Markus Armbruster writes:
>> >>
>> >> > I apologize for the delayed review.
>> >
>> > No problems. Thanks for reviewing!
>>
Markus Armbruster 于2024年2月19日周一 16:56写道：
>
> Sam Li writes:
>
> > Markus Armbruster 于2024年2月19日周一 15:40写道：
> >>
> >> Sam Li writes:
> >>
> >> > Markus Armbruster 于2024年2月19日周一 13:05写道：
> >> >>
> >> >> One more thing...
> >> >>
> >> >> Markus Armbruster writes:
> >> >>
> >> >> > I apologize fo
On 19/02/2024 12.45, BALATON Zoltan wrote:
On Mon, 19 Feb 2024, Thomas Huth wrote:
qdev.c is a mixture between IDE bus specific functions and IDE device
functions. Let's split it up to make it more obvious which part is
related to bus handling and which part is related to device handling.
Signe
On 19/02/2024 12.32, Philippe Mathieu-Daudé wrote:
On 19/2/24 11:49, Thomas Huth wrote:
Let's start to unentangle internal.h by moving public IDE device
related definitions to ide-dev.h.
Signed-off-by: Thomas Huth
---
include/hw/ide/ide-dev.h | 145 +-
i
On 19/02/2024 12.53, BALATON Zoltan wrote:
On Mon, 19 Feb 2024, Thomas Huth wrote:
These definitions are required outside of the hw/ide/ code, too,
so lets's move them from internal.h to a new header called ide-dma.h.
Signed-off-by: Thomas Huth
---
include/hw/ide/ide-dma.h | 30 ++
Sam Li writes:
> Markus Armbruster 于2024年2月19日周一 16:56写道：
>>
>> Sam Li writes:
>>
>> > Markus Armbruster 于2024年2月19日周一 15:40写道：
>> >>
>> >> Sam Li writes:
>> >>
>> >> > Markus Armbruster 于2024年2月19日周一 13:05写道：
>> >> >>
>> >> >> One more thing...
>> >> >>
>> >> >> Markus Armbruster writes:
>
Markus Armbruster 于2024年2月19日周一 21:42写道：
>
> Sam Li writes:
>
> > Markus Armbruster 于2024年2月19日周一 16:56写道：
> >>
> >> Sam Li writes:
> >>
> >> > Markus Armbruster 于2024年2月19日周一 15:40写道：
> >> >>
> >> >> Sam Li writes:
> >> >>
> >> >> > Markus Armbruster 于2024年2月19日周一 13:05写道：
> >> >> >>
> >> >
Sam Li writes:
> Markus Armbruster 于2024年2月19日周一 21:42写道：
>>
>> Sam Li writes:
>>
>> > Markus Armbruster 于2024年2月19日周一 16:56写道：
>> >>
>> >> Sam Li writes:
>> >>
>> >> > Markus Armbruster 于2024年2月19日周一 15:40写道：
>> >> >>
>> >> >> Sam Li writes:
>> >> >>
>> >> >> > Markus Armbruster 于2024年2月1
On 2/20/24 06:15, Markus Armbruster wrote:
> Making this member @size mandatory means we must specify it when
> BlockdevCreateOptionsQcow2 member @zone is present and @zone's member
> @mode is "host-managed". Feels right to me. Am I missing anything?
That's right. And the ch
On 19/2/24 20:17, Thomas Huth wrote:
On 19/02/2024 12.32, Philippe Mathieu-Daudé wrote:
On 19/2/24 11:49, Thomas Huth wrote:
Let's start to unentangle internal.h by moving public IDE device
related definitions to ide-dev.h.
Signed-off-by: Thomas Huth
---
include/hw/ide/ide-dev.h | 145
34 matches
Mail list logo
