Re: [PATCH 1/2] hw/arm/smmuv3: Check StreamIDs against SMMU_IDR1.SIDSIZE value

2024-02-22 Thread Eric Auger
Hi, On 2/21/24 18:17, Nabih Estefan wrote: > From: Roque Arcudia Hernandez > > Current implementation checks the StreamIDs against STRTAB_BASE_CFG.LOG2SIZE > register field value and a constant SMMU_IDR1_SIDSIZE which is also used as > initial value for field SMMU_IDR1.SIDSIZE. > > This limits th

Re: [PATCH v2 0/2] OSPI updates

2024-02-22 Thread Peter Maydell
On Tue, 20 Feb 2024 at 09:17, Sai Pavan Boddu wrote: > > Add a new 2Gib octal flash mt35xu02gbba. Add an interface for versal > virt board to swap the default flash. > > Changes for V2: > Added type checks for provided flash part name. > > Sai Pavan Boddu (2): > block: m25p80: Add support of m

[PATCH v2] hw/nvme/ns: Add NVMe NGUID property

2024-02-22 Thread Nabih Estefan
From: Roque Arcudia Hernandez This patch adds a way to specify an NGUID for a given NVMe Namespace using a string of hexadecimal digits with an optional '-' separator to group bytes. For instance: -device nvme-ns,nguid="e9accd3b83904e13167cf0593437f57d" If provided, the NGUID will be part of th

Re: [PATCH v2] xlnx-versal-ospi: disable reentrancy detection for iomem_dac

2024-02-22 Thread Peter Maydell
On Mon, 19 Feb 2024 at 10:56, Sai Pavan Boddu wrote: > > The OSPI DMA reads flash data through the OSPI linear address space (the > iomem_dac region), because of this the reentrancy guard introduced in > commit a2e1753b ("memory: prevent dma-reentracy issues") is disabled for > the memory region.

Re: [PATCH] MAINTAINERS: Cover hw/ide/ahci-allwinner.c with AllWinner A10 machine

2024-02-22 Thread Peter Maydell
On Thu, 15 Feb 2024 at 16:09, Philippe Mathieu-Daudé wrote: > > This code -- which was moved many times around -- was added in > commit 377e214539 ("ahci: Add allwinner AHCI") and belong to the > AllWinner machines. See also commit dca625768a ("arm: allwinner-a10: > Add SATA"). > > Signed-off-by:

[PULL v2 00/32] Misc HW patches for 2024-02-22

2024-02-22 Thread Philippe Mathieu-Daudé
The following changes since commit 760b4dcdddba4a40b9fa0eb78fdfc7eda7cb83d0: Merge tag 'for-upstream' of https://gitlab.com/bonzini/qemu into staging (2024-02-20 10:11:08 +) are available in the Git repository at: https://github.com/philmd/qemu.git tags/hw-misc-20240222

[PULL 23/32] hw/acpi/cpu: Use CPUState typedef

2024-02-22 Thread Philippe Mathieu-Daudé
QEMU coding style recommend using structure typedefs: https://www.qemu.org/docs/master/devel/style.html#typedefs Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson Reviewed-by: Zhao Liu Message-Id: <20240126220407.95022-2-phi...@linaro.org> --- include/hw/acpi/cpu.h | 2 +- 1

[PULL 09/32] hw/tricore/testboard: Use qdev_new() instead of QOM basic API

2024-02-22 Thread Philippe Mathieu-Daudé
Prefer QDev API for QDev objects, avoid the underlying QOM layer. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Bastian Koppelmann Message-Id: <20240216110313.17039-5-phi...@linaro.org> --- include/hw/tricore/tricore_testdevice.h | 3 --- hw/tricore/tricore_testboard.c | 4 +--- 2

[PULL 22/32] hw/acpi: Include missing 'qapi/qapi-types-acpi.h' generated header

2024-02-22 Thread Philippe Mathieu-Daudé
ACPIOSTInfo is a QAPI generated structure: $ git grep -w ACPIOSTInfo qapi/acpi.json:81:# @ACPIOSTInfo: qapi/acpi.json:99:{ 'struct': 'ACPIOSTInfo', qapi/acpi.json:109:# Return a list of ACPIOSTInfo for devices that support status Include the "qapi/qapi-types-acpi.h" header to avoid the f

[PULL 32/32] hw/sparc/leon3: Fix wrong usage of DO_UPCAST macro

2024-02-22 Thread Philippe Mathieu-Daudé
From: Thomas Huth leon3.c currently fails to compile with some compilers when the -Wvla option has been enabled: ../hw/sparc/leon3.c: In function ‘leon3_cpu_reset’: ../hw/sparc/leon3.c:153:5: error: ISO C90 forbids variable length array ‘offset_must_be_zero’ [-Werror=vla] 153 | ResetD

[PULL 19/32] hw/i386/pc_sysfw: Use qdev_is_realized() instead of QOM API

2024-02-22 Thread Philippe Mathieu-Daudé
Prefer QDev API for QDev objects, avoid the underlying QOM layer. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Zhao Liu Message-Id: <20240216110313.17039-3-phi...@linaro.org> --- hw/i386/pc_sysfw.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/hw/i386/pc_sysfw.

[PULL 24/32] hw/acpi/ich9_tco: Include missing 'migration/vmstate.h' header

2024-02-22 Thread Philippe Mathieu-Daudé
We need the VMStateDescription structure definition from "migration/vmstate.h" in order to declare vmstate_tco_io_sts. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Zhao Liu Message-Id: <20240219141412.71418-4-phi...@linaro.org> --- include/hw/acpi/ich9_tco.h | 1 + 1 file changed, 1 inser

[PULL 08/32] hw/ppc/pnv_bmc: Use qdev_new() instead of QOM API

2024-02-22 Thread Philippe Mathieu-Daudé
Prefer QDev API for QDev objects, avoid the underlying QOM layer. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Cédric Le Goater Message-Id: <20240216110313.17039-6-phi...@linaro.org> --- hw/ppc/pnv_bmc.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/hw/ppc

[PULL 07/32] hw/ppc/spapr_cpu: Use qdev_is_realized() instead of QOM API

2024-02-22 Thread Philippe Mathieu-Daudé
Prefer QDev API for QDev objects, avoid the underlying QOM layer. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Zhao Liu Message-Id: <20240216110313.17039-4-phi...@linaro.org> --- hw/ppc/spapr_cpu_core.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/hw/ppc/spapr_cpu

[PULL 02/32] hw/sysbus: Inline and remove sysbus_add_io()

2024-02-22 Thread Philippe Mathieu-Daudé
sysbus_add_io(...) is a simple wrapper to memory_region_add_subregion(get_system_io(), ...). It is used in 3 places; inline it directly. Rationale: we want to move to an explicit I/O bus, rather that an implicit one. Besides in heterogeneous setup we can have more than one I/O bus. Reviewed-by: P

Re: [PULL 00/25] Misc HW patches for 2024-02-21

2024-02-22 Thread Philippe Mathieu-Daudé
Hi, On 21/2/24 22:16, Philippe Mathieu-Daudé wrote: The following changes since commit 760b4dcdddba4a40b9fa0eb78fdfc7eda7cb83d0: Merge tag 'for-upstream' of https://gitlab.com/bonzini/qemu into staging (2024-02-20 10:11:08 +) are available in the Git repository at: https://github.c

Re: [PATCH] hw/nvme: fix invalid endian conversion

2024-02-22 Thread Klaus Jensen
On Feb 22 11:08, Philippe Mathieu-Daudé wrote: > Hi Klaus, > > On 22/2/24 10:29, Klaus Jensen wrote: > > From: Klaus Jensen > > > > numcntl is one byte and so is max_vfs. Using cpu_to_le16 on big endian > > hosts results in numcntl being set to 0. > > > > Fix by dropping the endian conversion.

Re: [PATCH 01/21] hw/i386/pc: Do not use C99 mixed-declarations style

2024-02-22 Thread Philippe Mathieu-Daudé
On 22/2/24 10:12, Zhao Liu wrote: Hi Philippe, On Fri, Feb 16, 2024 at 12:02:52PM +0100, Philippe Mathieu-Daudé wrote: Date: Fri, 16 Feb 2024 12:02:52 +0100 From: Philippe Mathieu-Daudé Subject: [PATCH 01/21] hw/i386/pc: Do not use C99 mixed-declarations style X-Mailer: git-send-email 2.41.0

Re: [PATCH] hw/nvme: fix invalid endian conversion

2024-02-22 Thread Philippe Mathieu-Daudé
cpu_to_le16(max_vfs); +list->numcntl = max_vfs; for (i = 0; i < max_vfs; i++) { sctrl = &list->sec[i]; sctrl->pcid = cpu_to_le16(n->cntlid); --- base-commit: 760b4dcdddba4a40b9fa0eb78fdfc7eda7cb83d0 change-id: 20240222-fix-sriov-numcntl-5ebe46a42176 Best regards,

Re: [PATCH 21/21] hw: Add QOM parentship relation with CPUs

2024-02-22 Thread Zhao Liu
On Fri, Feb 16, 2024 at 12:03:12PM +0100, Philippe Mathieu-Daudé wrote: > Date: Fri, 16 Feb 2024 12:03:12 +0100 > From: Philippe Mathieu-Daudé > Subject: [PATCH 21/21] hw: Add QOM parentship relation with CPUs > X-Mailer: git-send-email 2.41.0 > > QDev objects created with object_new() need to ma

Re: [PATCH 03/21] hw/ppc/spapr_cpu: Use qdev_is_realized() instead of QOM API

2024-02-22 Thread Zhao Liu
On Fri, Feb 16, 2024 at 12:02:54PM +0100, Philippe Mathieu-Daudé wrote: > Date: Fri, 16 Feb 2024 12:02:54 +0100 > From: Philippe Mathieu-Daudé > Subject: [PATCH 03/21] hw/ppc/spapr_cpu: Use qdev_is_realized() instead of > QOM API > X-Mailer: git-send-email 2.41.0 > > Prefer QDev API for QDev obj

Re: [PATCH 10/21] hw/usb: Inline usb_new()

2024-02-22 Thread Zhao Liu
On Fri, Feb 16, 2024 at 12:03:01PM +0100, Philippe Mathieu-Daudé wrote: > Date: Fri, 16 Feb 2024 12:03:01 +0100 > From: Philippe Mathieu-Daudé > Subject: [PATCH 10/21] hw/usb: Inline usb_new() > X-Mailer: git-send-email 2.41.0 > > Inline the 2 uses of usb_new(). > > Signed-off-by: Philippe Mathi

Re: [PATCH 07/21] target: Replace DEVICE(object_new) -> qdev_new()

2024-02-22 Thread Zhao Liu
On Fri, Feb 16, 2024 at 12:02:58PM +0100, Philippe Mathieu-Daudé wrote: > Date: Fri, 16 Feb 2024 12:02:58 +0100 > From: Philippe Mathieu-Daudé > Subject: [PATCH 07/21] target: Replace DEVICE(object_new) -> qdev_new() > X-Mailer: git-send-email 2.41.0 > > Prefer QDev API for QDev objects, avoid th

Re: [PATCH 09/21] hw/usb: Inline usb_try_new()

2024-02-22 Thread Zhao Liu
On Fri, Feb 16, 2024 at 12:03:00PM +0100, Philippe Mathieu-Daudé wrote: > Date: Fri, 16 Feb 2024 12:03:00 +0100 > From: Philippe Mathieu-Daudé > Subject: [PATCH 09/21] hw/usb: Inline usb_try_new() > X-Mailer: git-send-email 2.41.0 > > Inline the single use of usb_try_new(). > > Signed-off-by: Ph

Re: [PATCH 06/21] hw: Replace DEVICE(object_new) -> qdev_new()

2024-02-22 Thread Zhao Liu
On Fri, Feb 16, 2024 at 12:02:57PM +0100, Philippe Mathieu-Daudé wrote: > Date: Fri, 16 Feb 2024 12:02:57 +0100 > From: Philippe Mathieu-Daudé > Subject: [PATCH 06/21] hw: Replace DEVICE(object_new) -> qdev_new() > X-Mailer: git-send-email 2.41.0 > > Prefer QDev API for QDev objects, avoid the un

Re: [PATCH 11/21] hw/usb: Add QOM parentship relation with hub devices

2024-02-22 Thread Zhao Liu
Hi Philippe, On Fri, Feb 16, 2024 at 12:03:02PM +0100, Philippe Mathieu-Daudé wrote: > Date: Fri, 16 Feb 2024 12:03:02 +0100 > From: Philippe Mathieu-Daudé > Subject: [PATCH 11/21] hw/usb: Add QOM parentship relation with hub devices > X-Mailer: git-send-email 2.41.0 > > QDev objects created wit

[PATCH] hw/nvme: fix invalid endian conversion

2024-02-22 Thread Klaus Jensen
= cpu_to_le16(n->cntlid); --- base-commit: 760b4dcdddba4a40b9fa0eb78fdfc7eda7cb83d0 change-id: 20240222-fix-sriov-numcntl-5ebe46a42176 Best regards, -- Klaus Jensen

Re: [PATCH] hw/nvme/ns: Add NVMe NGUID property

2024-02-22 Thread Klaus Jensen
On Feb 21 17:38, Nabih Estefan wrote: > From: Roque Arcudia Hernandez > > This patch adds a way to specify an NGUID for a given NVMe Namespace using a > string of hexadecimal digits with an optional '-' separator to group bytes. > For > instance: > > -device nvme-ns,nguid="e9accd3b83904e13167cf

Re: [PATCH 17/21] hw/i386/iommu: Prefer object_initialize_child over object_initialize

2024-02-22 Thread Zhao Liu
Hi Philippe, On Fri, Feb 16, 2024 at 12:03:08PM +0100, Philippe Mathieu-Daudé wrote: > Date: Fri, 16 Feb 2024 12:03:08 +0100 > From: Philippe Mathieu-Daudé > Subject: [PATCH 17/21] hw/i386/iommu: Prefer object_initialize_child over > object_initialize > X-Mailer: git-send-email 2.41.0 > > When

Re: [PATCH 02/21] hw/i386/pc_sysfw: Use qdev_is_realized() instead of QOM API

2024-02-22 Thread Zhao Liu
On Fri, Feb 16, 2024 at 12:02:53PM +0100, Philippe Mathieu-Daudé wrote: > Date: Fri, 16 Feb 2024 12:02:53 +0100 > From: Philippe Mathieu-Daudé > Subject: [PATCH 02/21] hw/i386/pc_sysfw: Use qdev_is_realized() instead of > QOM API > X-Mailer: git-send-email 2.41.0 > > Prefer QDev API for QDev obj

Re: [PATCH 01/21] hw/i386/pc: Do not use C99 mixed-declarations style

2024-02-22 Thread Zhao Liu
Hi Philippe, On Fri, Feb 16, 2024 at 12:02:52PM +0100, Philippe Mathieu-Daudé wrote: > Date: Fri, 16 Feb 2024 12:02:52 +0100 > From: Philippe Mathieu-Daudé > Subject: [PATCH 01/21] hw/i386/pc: Do not use C99 mixed-declarations style > X-Mailer: git-send-email 2.41.0 > > QEMU's coding style gener