Re: [RFC 0/8] virtio,vhost: Add VIRTIO_F_NOTIFICATION_DATA support

2024-03-04 Thread Thomas Huth
On 05/03/2024 04.21, Xinying Yu wrote: One more thing, I would ask how do  I get the full series patch? Do I copy the RFC line by line from this link[1]? For getting patches that you might have missed on the mailing list, I recommend lore.kernel.org : https://lore.kernel.org/qemu-devel/202

Re: [RFC 0/8] virtio,vhost: Add VIRTIO_F_NOTIFICATION_DATA support

2024-03-04 Thread Xinying Yu
Of course, I am glad to do. And I need to clarify that our use case only support VIRTIO_F_NOTIFICATION_DATA transport feature on DPDK vDPA framework which the backend type is NET_CLIENT_DRIVER_VHOST_USER and use user_feature_bits. So the new feature add on vdpa_feature_bits will not under v

Re: [PATCH 0/2] SMBIOS type 9 descriptor implementation

2024-03-04 Thread Nabih Estefan
Friendly ping on review for this patchset! It's been ~2 weeks since it was sent out, please let us know if there's any changes that should be done to upstream it! Thanks, Nabih Estefan Nabih Estefan (he/him) | Software Engineer | nabiheste...@google.com | 857-308-9574 On Wed, Feb 21, 2024 a

[PATCH v1 7/8] vhost/vhost-user: Add VIRTIO_F_NOTIFICATION_DATA to vhost feature bits

2024-03-04 Thread Jonah Palmer
Add support for the VIRTIO_F_NOTIFICATION_DATA feature across a variety of vhost devices. The inclusion of VIRTIO_F_NOTIFICATION_DATA in the feature bits arrays for these devices ensures that the backend is capable of offering and providing support for this feature, and that it can be disabled if

[PATCH v1 8/8] virtio: Add VIRTIO_F_NOTIFICATION_DATA property definition

2024-03-04 Thread Jonah Palmer
Extend the virtio device property definitions to include the VIRTIO_F_NOTIFICATION_DATA feature. The default state of this feature is disabled, allowing it to be explicitly enabled where it's supported. Reviewed-by: Eugenio Pérez Signed-off-by: Jonah Palmer --- include/hw/virtio/virtio.h | 4 +

[PATCH v1 3/8] virtio-mmio: Handle extra notification data

2024-03-04 Thread Jonah Palmer
Add support to virtio-mmio devices for handling the extra data sent from the driver to the device when the VIRTIO_F_NOTIFICATION_DATA transport feature has been negotiated. The extra data that's passed to the virtio-mmio device when this feature is enabled varies depending on the device's virtqueu

[PATCH v1 5/8] virtio-ccw: Handle extra notification data

2024-03-04 Thread Jonah Palmer
Add support to virtio-ccw devices for handling the extra data sent from the driver to the device when the VIRTIO_F_NOTIFICATION_DATA transport feature has been negotiated. The extra data that's passed to the virtio-ccw device when this feature is enabled varies depending on the device's virtqueue

[PATCH v1 1/8] virtio/virtio-pci: Handle extra notification data

2024-03-04 Thread Jonah Palmer
Add support to virtio-pci devices for handling the extra data sent from the driver to the device when the VIRTIO_F_NOTIFICATION_DATA transport feature has been negotiated. The extra data that's passed to the virtio-pci device when this feature is enabled varies depending on the device's virtqueue

[PATCH v1 6/8] virtio-ccw: Lock ioeventfd state with VIRTIO_F_NOTIFICATION_DATA

2024-03-04 Thread Jonah Palmer
Prevent ioeventfd from being enabled/disabled when a virtio-ccw device has negotiated the VIRTIO_F_NOTIFICATION_DATA transport feature. Due to the ioeventfd not being able to carry the extra data associated with this feature, the ioeventfd should be left in a disabled state for emulated virtio-ccw

[PATCH v1 4/8] virtio-mmio: Lock ioeventfd state with VIRTIO_F_NOTIFICATION_DATA

2024-03-04 Thread Jonah Palmer
Prevent ioeventfd from being enabled/disabled when a virtio-mmio device has negotiated the VIRTIO_F_NOTIFICATION_DATA transport feature. Due to ioeventfd not being able to carry the extra data associated with this feature, the ioeventfd should be left in a disabled state for emulated virtio-mmio d

[PATCH v1 0/8] virtio,vhost: Add VIRTIO_F_NOTIFICATION_DATA support

2024-03-04 Thread Jonah Palmer
The goal of these patches are to add support to a variety of virtio and vhost devices for the VIRTIO_F_NOTIFICATION_DATA transport feature. This feature indicates that a driver will pass extra data (instead of just a virtqueue's index) when notifying the corresponding device. The data passed in by

[PATCH v1 2/8] virtio-pci: Lock ioeventfd state with VIRTIO_F_NOTIFICATION_DATA

2024-03-04 Thread Jonah Palmer
Prevent ioeventfd from being enabled/disabled when a virtio-pci device has negotiated the VIRTIO_F_NOTIFICATION_DATA transport feature. Due to ioeventfd not being able to carry the extra data associated with this feature, the ioeventfd should be left in a disabled state for emulated virtio-pci dev

Re: [RFC 1/8] virtio/virtio-pci: Handle extra notification data

2024-03-04 Thread Jonah Palmer
On 3/4/24 12:24 PM, Eugenio Perez Martin wrote: On Mon, Mar 4, 2024 at 6:09 PM Jonah Palmer wrote: On 3/1/24 2:31 PM, Eugenio Perez Martin wrote: On Fri, Mar 1, 2024 at 2:44 PM Jonah Palmer wrote: Add support to virtio-pci devices for handling the extra data sent from the driver to th

Re: [RFC 1/8] virtio/virtio-pci: Handle extra notification data

2024-03-04 Thread Eugenio Perez Martin
On Mon, Mar 4, 2024 at 6:09 PM Jonah Palmer wrote: > > > > On 3/1/24 2:31 PM, Eugenio Perez Martin wrote: > > On Fri, Mar 1, 2024 at 2:44 PM Jonah Palmer wrote: > >> > >> Add support to virtio-pci devices for handling the extra data sent > >> from the driver to the device when the VIRTIO_F_NOTIFI

Re: [RFC 7/8] vhost/vhost-user: Add VIRTIO_F_NOTIFICATION_DATA to vhost feature bits

2024-03-04 Thread Jonah Palmer
On 3/1/24 3:04 PM, Eugenio Perez Martin wrote: On Fri, Mar 1, 2024 at 2:44 PM Jonah Palmer wrote: Add support for the VIRTIO_F_NOTIFICATION_DATA feature across a variety of vhost devices. The inclusion of VIRTIO_F_NOTIFICATION_DATA in the feature bits arrays for these devices ensures that

Re: [RFC 1/8] virtio/virtio-pci: Handle extra notification data

2024-03-04 Thread Jonah Palmer
On 3/1/24 2:31 PM, Eugenio Perez Martin wrote: On Fri, Mar 1, 2024 at 2:44 PM Jonah Palmer wrote: Add support to virtio-pci devices for handling the extra data sent from the driver to the device when the VIRTIO_F_NOTIFICATION_DATA transport feature has been negotiated. The extra data that'

Re: [RFC 1/8] virtio/virtio-pci: Handle extra notification data

2024-03-04 Thread Jonah Palmer
On 3/1/24 2:55 PM, Eugenio Perez Martin wrote: On Fri, Mar 1, 2024 at 2:44 PM Jonah Palmer wrote: Add support to virtio-pci devices for handling the extra data sent from the driver to the device when the VIRTIO_F_NOTIFICATION_DATA transport feature has been negotiated. The extra data that'

Re: [PATCH v2 00/10] mirror: allow switching from background to active mode

2024-03-04 Thread Markus Armbruster
Kevin Wolf writes: > Am 28.02.2024 um 19:07 hat Vladimir Sementsov-Ogievskiy geschrieben: [...] >> About the APIs, I think, of course we should deprecate block-job-* API, >> because we already have jobs which are not block-jobs, so we can't deprecate >> job-* API. >> >> So I suggest a plan:

Re: [PATCH v2 00/10] mirror: allow switching from background to active mode

2024-03-04 Thread Peter Krempa
On Mon, Mar 04, 2024 at 11:48:54 +0100, Kevin Wolf wrote: > Am 28.02.2024 um 19:07 hat Vladimir Sementsov-Ogievskiy geschrieben: > > On 03.11.23 18:56, Markus Armbruster wrote: > > > Kevin Wolf writes: [...] > > > Is the job abstraction a failure? > > > > > > We have > > > > > > block-job

Re: [PATCH v2 00/10] mirror: allow switching from background to active mode

2024-03-04 Thread Kevin Wolf
Am 28.02.2024 um 19:07 hat Vladimir Sementsov-Ogievskiy geschrieben: > On 03.11.23 18:56, Markus Armbruster wrote: > > Kevin Wolf writes: > > > > > Am 03.11.2023 um 10:36 hat Markus Armbruster geschrieben: > > > > Vladimir Sementsov-Ogievskiy writes: > > > > > > > > > On 11.10.23 13:18, Fiona E

Re: [RFC 0/4] mirror: implement incremental and bitmap modes

2024-03-04 Thread Fabian Grünbichler
On February 29, 2024 11:41 am, Fiona Ebner wrote: > Am 28.02.24 um 17:24 schrieb Vladimir Sementsov-Ogievskiy: >> On 16.02.24 13:55, Fiona Ebner wrote: >>> Previous discussion from when this was sent upstream [0] (it's been a >>> while). I rebased the patches and re-ordered and squashed like >>> su