Re: [PULL v2 0/2] ufs queue

2024-06-03 Thread Richard Henderson
repository at: https://gitlab.com/jeuk20.kim/qemu.git tags/pull-ufs-20240603 for you to fetch changes up to 5c079578d2e46df626d13eeb629c7d761a5c4e44: hw/ufs: Add support MCQ of UFSHCI 4.0 (2024-06-03 16:20:42 +0900) hw/ufs patches

Re: [PATCH v3 2/4] block-backend: fix edge case in bdrv_next() where BDS associated to BB changes

2024-06-03 Thread Kevin Wolf
Am 03.06.2024 um 16:17 hat Fiona Ebner geschrieben: > Hi Kevin, > > Am 26.03.24 um 13:44 schrieb Kevin Wolf: > > Am 22.03.2024 um 10:50 hat Fiona Ebner geschrieben: > >> The old_bs variable in bdrv_next() is currently determined by looking > >> at the old block backend. However, if the block

Re: [PATCH v3 2/2] iotests: test NBD+TLS+iothread

2024-06-03 Thread Kevin Wolf
Am 03.06.2024 um 13:45 hat Daniel P. Berrangé geschrieben: > On Fri, May 31, 2024 at 01:04:59PM -0500, Eric Blake wrote: > > Prevent regressions when using NBD with TLS in the presence of > > iothreads, adding coverage the fix to qio channels made in the > > previous patch. > > > > The shell

Re: [PATCH] block/copy-before-write: use uint64_t for timeout in nanoseconds

2024-06-03 Thread Kevin Wolf
Am 03.06.2024 um 16:45 hat Fiona Ebner geschrieben: > Am 28.05.24 um 18:06 schrieb Kevin Wolf: > > Am 29.04.2024 um 16:19 hat Fiona Ebner geschrieben: > >> rather than the uint32_t for which the maximum is slightly more than 4 > >> seconds and larger values would overflow. The QAPI interface

Re: [PATCH 0/2] block/crypto: do not require number of threads upfront

2024-06-03 Thread Kevin Wolf
Am 27.05.2024 um 17:58 hat Stefan Hajnoczi geschrieben: > The block layer does not know how many threads will perform I/O. It is > possible > to exceed the number of threads that is given to qcrypto_block_open() and this > can trigger an assertion failure in qcrypto_block_pop_cipher(). > > This

Re: [PATCH] block/copy-before-write: use uint64_t for timeout in nanoseconds

2024-06-03 Thread Fiona Ebner
Am 28.05.24 um 18:06 schrieb Kevin Wolf: > Am 29.04.2024 um 16:19 hat Fiona Ebner geschrieben: >> rather than the uint32_t for which the maximum is slightly more than 4 >> seconds and larger values would overflow. The QAPI interface allows >> specifying the number of seconds, so only values 0 to 4

[PULL v2 2/2] iotests: test NBD+TLS+iothread

2024-06-03 Thread Eric Blake
Prevent regressions when using NBD with TLS in the presence of iothreads, adding coverage the fix to qio channels made in the previous patch. The shell function pick_unused_port() was copied from nbdkit.git/tests/functions.sh.in, where it had all authors from Red Hat, agreeing to the resulting

[PULL v2 1/2] qio: Inherit follow_coroutine_ctx across TLS

2024-06-03 Thread Eric Blake
Since qemu 8.2, the combination of NBD + TLS + iothread crashes on an assertion failure: qemu-kvm: ../io/channel.c:534: void qio_channel_restart_read(void *): Assertion `qemu_get_current_aio_context() == qemu_coroutine_get_aio_context(co)' failed. It turns out that when we removed AioContext

[PULL v2 0/2] NBD patches for 2024-05-30

2024-06-03 Thread Eric Blake
The following changes since commit 3b2fe44bb7f605f179e5e7feb2c13c2eb3abbb80: Merge tag 'pull-request-2024-05-29' of https://gitlab.com/thuth/qemu into staging (2024-05-29 08:38:20 -0700) are available in the Git repository at: https://repo.or.cz/qemu/ericb.git tags/pull-nbd-2024-05-30-v2

Re: [PATCH v3 2/4] block-backend: fix edge case in bdrv_next() where BDS associated to BB changes

2024-06-03 Thread Fiona Ebner
Hi Kevin, Am 26.03.24 um 13:44 schrieb Kevin Wolf: > Am 22.03.2024 um 10:50 hat Fiona Ebner geschrieben: >> The old_bs variable in bdrv_next() is currently determined by looking >> at the old block backend. However, if the block graph changes before >> the next bdrv_next() call, it might be that

Re: [PATCH 0/2] block/crypto: do not require number of threads upfront

2024-06-03 Thread Daniel P . Berrangé
On Mon, May 27, 2024 at 11:58:49AM -0400, Stefan Hajnoczi wrote: > The block layer does not know how many threads will perform I/O. It is > possible > to exceed the number of threads that is given to qcrypto_block_open() and this > can trigger an assertion failure in qcrypto_block_pop_cipher(). >

Re: [PATCH v3 2/2] iotests: test NBD+TLS+iothread

2024-06-03 Thread Daniel P . Berrangé
On Fri, May 31, 2024 at 01:04:59PM -0500, Eric Blake wrote: > Prevent regressions when using NBD with TLS in the presence of > iothreads, adding coverage the fix to qio channels made in the > previous patch. > > The shell function pick_unused_port() was copied from >

Re: [PATCH v2 2/2] backup: add minimum cluster size to performance options

2024-06-03 Thread Markus Armbruster
Fiona Ebner writes: > In the context of backup fleecing, discarding the source will not work > when the fleecing image has a larger granularity than the one used for > block-copy operations (can happen if the backup target has smaller > cluster size), because cbw_co_pdiscard_snapshot() will

Re: [PATCH v2 1/2] copy-before-write: allow specifying minimum cluster size

2024-06-03 Thread Markus Armbruster
Fiona Ebner writes: > In the context of backup fleecing, discarding the source will not work > when the fleecing image has a larger granularity than the one used for > block-copy operations (can happen if the backup target has smaller > cluster size), because cbw_co_pdiscard_snapshot() will

Re: [PATCH v6 10/12] hostmem: add a new memory backend based on POSIX shm_open()

2024-06-03 Thread Markus Armbruster
Stefano Garzarella writes: > On Wed, May 29, 2024 at 04:50:20PM GMT, Markus Armbruster wrote: >>Stefano Garzarella writes: >> >>> shm_open() creates and opens a new POSIX shared memory object. >>> A POSIX shared memory object allows creating memory backend with an >>> associated file descriptor

Re: [PATCH v2 00/11] qcow2: make subclusters discardable

2024-06-03 Thread Andrey Drobyshev
On 5/13/24 9:31 AM, Andrey Drobyshev wrote: > v1: https://lists.nongnu.org/archive/html/qemu-devel/2023-10/msg07223.html > > Andrey Drobyshev (11): > qcow2: make function update_refcount_discard() global > qcow2: simplify L2 entries accounting for discard-no-unref > qcow2: put discard

[PULL v2 1/2] hw/ufs: Update MCQ-related fields to block/ufs.h

2024-06-03 Thread Jeuk Kim
From: Minwoo Im This patch is a prep patch for the following MCQ support patch for hw/ufs. This patch updated minimal mandatory fields to support MCQ based on UFSHCI 4.0. Signed-off-by: Minwoo Im Reviewed-by: Jeuk Kim Message-Id: <20240528023106.856777-2-minwoo...@samsung.com> Signed-off-by:

[PULL v2 0/2] ufs queue

2024-06-03 Thread Jeuk Kim
.kim/qemu.git tags/pull-ufs-20240603 for you to fetch changes up to 5c079578d2e46df626d13eeb629c7d761a5c4e44: hw/ufs: Add support MCQ of UFSHCI 4.0 (2024-06-03 16:20:42 +0900) hw/ufs patches - Add support MCQ of UFSHCI 4.0

[PULL v2 2/2] hw/ufs: Add support MCQ of UFSHCI 4.0

2024-06-03 Thread Jeuk Kim
From: Minwoo Im This patch adds support for MCQ defined in UFSHCI 4.0. This patch utilized the legacy I/O codes as much as possible to support MCQ. MCQ operation & runtime register is placed at 0x1000 offset of UFSHCI register statically with no spare space among four registers (48B):