Re: [PATCH v3 21/22] qom/object: fix -Werror=maybe-uninitialized

2024-10-01 Thread Markus Armbruster
marcandre.lur...@redhat.com writes: > From: Marc-André Lureau > > object_resolve_path_type() didn't always set *ambiguousp. > > Signed-off-by: Marc-André Lureau Fixes: 81c48dd79655 (hw/i386/acpi: Add object_resolve_type_unambiguous to improve modularity) > --- > qom/object.c | 5 - > 1 f

Re: [PATCH v13 09/10] hw/nvme: add reservation protocal command

2024-10-01 Thread Klaus Jensen
On Sep 26 15:45, Changqi Lu wrote: > Add reservation acquire, reservation register, > reservation release and reservation report commands > in the nvme device layer. > > By introducing these commands, this enables the nvme > device to perform reservation-related tasks, including > querying keys, q

Re: [PATCH 07/23] hw/ppc/e500: Extract ppce500_ccsr.c

2024-10-01 Thread Bernhard Beschow
Am 24. September 2024 20:02:31 UTC schrieb Bernhard Beschow : > > >Am 23. September 2024 10:38:46 UTC schrieb BALATON Zoltan : >>On Mon, 23 Sep 2024, Bernhard Beschow wrote: >>> The device model already has a header file. Also extract its implementation >>> into >>> an accompanying source file

Re: [PULL 3/5] block/reqlist: allow adding overlapping requests

2024-10-01 Thread Michael Tokarev
30.09.2024 11:43, Vladimir Sementsov-Ogievskiy wrote: From: Fiona Ebner Allow overlapping request by removing the assert that made it impossible. There are only two callers: 1. block_copy_task_create() It already asserts the very same condition before calling reqlist_init_req(). 2. cbw_snaps

Re: [PATCH v3 21/22] qom/object: fix -Werror=maybe-uninitialized

2024-10-01 Thread Marc-André Lureau
Hi Vladimir On Tue, Oct 1, 2024 at 6:06 PM Vladimir Sementsov-Ogievskiy < vsement...@yandex-team.ru> wrote: > On 30.09.24 11:14, marcandre.lur...@redhat.com wrote: > > From: Marc-André Lureau > > > > object_resolve_path_type() didn't always set *ambiguousp. > > > > Signed-off-by: Marc-André Lure

Re: [PATCH v6 2/3] vhost-user-blk: split vhost_user_blk_sync_config()

2024-10-01 Thread Stefano Garzarella
On Fri, Sep 20, 2024 at 12:49:35PM GMT, Vladimir Sementsov-Ogievskiy wrote: Split vhost_user_blk_sync_config() out from vhost_user_blk_handle_config_change(), to be reused in the following commit. Signed-off-by: Vladimir Sementsov-Ogievskiy Acked-by: Raphael Norwitz --- hw/block/vhost-user-blk

Re: [PULL 0/5] Block-jobs 2024-09-30

2024-10-01 Thread Peter Maydell
On Mon, 30 Sept 2024 at 09:43, Vladimir Sementsov-Ogievskiy wrote: > > The following changes since commit 3b14a767eaca3df5534a162851f04787b363670e: > > Merge tag 'qemu-openbios-20240924' of https://github.com/mcayland/qemu into > staging (2024-09-28 12:34:44 +0100) > > are available in the Git

Re: [PATCH] hw/sd/sdcard: Fix handling of disabled boot partitions

2024-10-01 Thread Peter Maydell
On Mon, 30 Sept 2024 at 21:05, Jan Lübbe wrote: > > On Mon, 2024-09-30 at 15:18 +0100, Peter Maydell wrote: > > On Fri, 6 Sept 2024 at 17:51, Jan Luebbe wrote: > > > > > > The enable bits in the EXT_CSD_PART_CONFIG ext_csd register do *not* > > > specify whether the boot partitions exist, but whe

Re: [PATCH v3 21/22] qom/object: fix -Werror=maybe-uninitialized

2024-10-01 Thread Vladimir Sementsov-Ogievskiy
On 30.09.24 11:14, marcandre.lur...@redhat.com wrote: From: Marc-André Lureau object_resolve_path_type() didn't always set *ambiguousp. Signed-off-by: Marc-André Lureau --- qom/object.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/qom/object.c b/qom/object.c inde

Re: [PATCH v3 20/22] block: fix -Werror=maybe-uninitialized false-positive

2024-10-01 Thread Vladimir Sementsov-Ogievskiy
On 30.09.24 11:14, marcandre.lur...@redhat.com wrote: From: Marc-André Lureau ../block/file-posix.c:1405:17: error: ‘zoned’ may be used uninitialized [-Werror=maybe-uninitialized] 1405 | if (ret < 0 || zoned == BLK_Z_NONE) { Signed-off-by: Marc-André Lureau Reviewed-by: Vladimir Sement

[PULL 3/5] hw/nvme: support CTRATT.MEM

2024-10-01 Thread Klaus Jensen
From: Arun Kumar Indicate that 'MDTS and Size Limits Exclude Metadata (MEM)' in the Controller Attributes (CTRATT) I/O Command Set Independent Identify Controller Data Structure. Signed-off-by: Arun Kumar Reviewed-by: Klaus Jensen [k.jensen: updated commit message] Signed-off-by: Klaus Jensen

Re: [PATCH 01/23] hw/ppc/e500: Do not leak struct boot_info

2024-10-01 Thread Bernhard Beschow
Am 26. September 2024 00:14:04 UTC schrieb BALATON Zoltan : >On Wed, 25 Sep 2024, Cédric Le Goater wrote: >> On 9/23/24 11:29, Bernhard Beschow wrote: >>> The struct is allocated once with g_new0() but never free()'d. Fix the >>> leakage >>> by adding an attribute to struct PPCE500MachineState

Re: [PATCH v3 15/22] linux-user/hppa: fix -Werror=maybe-uninitialized false-positive

2024-10-01 Thread Laurent Vivier
Le 30/09/2024 à 15:26, Marc-André Lureau a écrit : Hi Laurent On Mon, Sep 30, 2024 at 4:19 PM Laurent Vivier wrote: CC Helge Deller Le 30/09/2024 à 10:14, marcandre.lur...@redhat.com a écrit : From: Marc-André Lureau ../linux-user/hppa/cpu_loop.c: In function ‘hppa_lws’: ../linux-user/hpp

Re: [Bug Report][RFC PATCH 1/1] block: fix failing assert on paused VM migration

2024-10-01 Thread Vladimir Sementsov-Ogievskiy
On 30.09.24 17:07, Andrey Drobyshev wrote: On 9/30/24 12:25 PM, Vladimir Sementsov-Ogievskiy wrote: [add migration maintainers] On 24.09.24 15:56, Andrey Drobyshev wrote: [...] I doubt that this a correct way to go. As far as I understand, "inactive" actually means that "storage is not belo

[PULL 4/5] hw/nvme: add knob for CTRATT.MEM

2024-10-01 Thread Klaus Jensen
From: Klaus Jensen Add a boolean prop (ctratt.mem) for setting CTRATT.MEM and default it to unset (false) to keep existing behavior of the device intact. Reviewed-by: Minwoo Im Reviewed-by: Arun Kumar Signed-off-by: Klaus Jensen --- hw/nvme/ctrl.c | 7 ++- hw/nvme/nvme.h | 4 2 file

Re: [PATCH v3 01/14] hw/display/apple-gfx: Introduce ParavirtualizedGraphics.Framework support

2024-10-01 Thread Akihiko Odaki
On 2024/09/28 17:57, Phil Dennis-Jordan wrote: MacOS provides a framework (library) that allows any vmm to implement a paravirtualized 3d graphics passthrough to the host metal stack called ParavirtualizedGraphics.Framework (PVG). The library abstracts away almost every aspect of the paravirtuali

[PULL 5/5] hw/nvme: add atomic write support

2024-10-01 Thread Klaus Jensen
From: Alan Adamson Adds support for the controller atomic parameters: AWUN and AWUPF. Atomic Compare and Write Unit (ACWU) is not currently supported. Writes that adhere to the ACWU and AWUPF parameters are guaranteed to be atomic. New NVMe QEMU Parameters (See NVMe Specification for details):

[PULL 2/5] hw/nvme: clear masked events from the aer queue

2024-10-01 Thread Klaus Jensen
From: Arun Kumar Clear masked events from the aer queue when get log page is issued with RAE 0 without checking for the presence of outstanding aer requests. Signed-off-by: Arun Kumar [k.jensen: remove unnecessary QTAILQ_EMPTY check] Signed-off-by: Klaus Jensen --- hw/nvme/ctrl.c | 11 +++

[PULL 1/5] hw/nvme: report id controller metadata sgl support

2024-10-01 Thread Klaus Jensen
From: Keith Busch The controller already supports this decoding, so just set the ID_CTRL.SGLS field accordingly. Signed-off-by: Keith Busch Reviewed-by: Klaus Jensen Signed-off-by: Klaus Jensen --- hw/nvme/ctrl.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/hw/nvme/c

Re: [PATCH v3 16/22] target/loongarch: fix -Werror=maybe-uninitialized false-positive

2024-10-01 Thread Vladimir Sementsov-Ogievskiy
On 30.09.24 11:14, marcandre.lur...@redhat.com wrote: From: Marc-André Lureau ../target/loongarch/gdbstub.c:55:20: error: ‘val’ may be used uninitialized [-Werror=maybe-uninitialized] 55 | return gdb_get_reg32(mem_buf, val); |^~

Re: [PATCH v3 00/22] -Werror=maybe-uninitialized fixes

2024-10-01 Thread Marc-André Lureau
Hi On Mon, Sep 30, 2024 at 12:15 PM wrote: > > From: Marc-André Lureau > > Hi, > > Depending on -Doptimization=, GCC (14.2.1 here) produces different > maybe-uninitialized warnings: > - g: produces -Werror=maybe-uninitialized errors > - 0: clean build > - 1: produces -Werror=maybe-uninitialized