Re: [PATCH v6 1/3] hw/i2c: add smbus pec utility function

2023-09-21 Thread Andrew Jeffery
entation :) Reviewed-by: Andrew Jeffery > --- > hw/i2c/smbus_master.c | 26 ++ > include/hw/i2c/smbus_master.h | 2 ++ > 2 files changed, 28 insertions(+) > > diff --git a/hw/i2c/smbus_master.c b/hw/i2c/smbus_master.c > index 6a53c3

Re: [PATCH v6 2/3] hw/i2c: add mctp core

2023-09-21 Thread Andrew Jeffery
@huawei.com/ > [2]: > https://lore.kernel.org/qemu-devel/20221121080445.ga29...@codeconstruct.com.au/ > > Tested-by: Jonathan Cameron > Reviewed-by: Jonathan Cameron > Signed-off-by: Klaus Jensen Nice! Reviewed-by: Andrew Jeffery

Re: [PATCH v6 3/3] hw/nvme: add nvme management interface model

2023-09-21 Thread Andrew Jeffery
gt; +static void nmi_reset(MCTPI2CEndpoint *mctp) > +{ > +NMIDevice *nmi = NMI_I2C_DEVICE(mctp); > +nmi->len = 0; > +} > + > +static void nmi_handle(MCTPI2CEndpoint *mctp) > +{ > +NMIDevice *nmi = NMI_I2C_DEVICE(mctp); > +NMIMessage *msg

Re: [PATCH v5 3/3] hw/nvme: add nvme management interface model

2023-09-14 Thread Andrew Jeffery
Hi Klaus, On Thu, 2023-09-14 at 08:51 +0200, Klaus Jensen wrote: > On Sep 12 13:50, Andrew Jeffery wrote: > > Hi Klaus, > > > > On Tue, 2023-09-05 at 10:38 +0200, Klaus Jensen wrote: > > > > > > > > +static void nmi_handle_mi_config_ge

Re: [PATCH v5 3/3] hw/nvme: add nvme management interface model

2023-09-12 Thread Andrew Jeffery
Hi Klaus, On Tue, 2023-09-05 at 10:38 +0200, Klaus Jensen wrote: > > > > +static void nmi_handle_mi_config_get(NMIDevice *nmi, NMIRequest > > *request) > > +{ > > +    uint32_t dw0 = le32_to_cpu(request->dw0); > > +    uint8_t identifier = FIELD_EX32(dw0, > > NMI_CMD_CONFIGURATION_GET_DW0, > > + 

Re: [RFC 0/3] Add Generic SPI GPIO model

2022-07-31 Thread Andrew Jeffery
On Sun, 31 Jul 2022, at 06:48, Cédric Le Goater wrote: > On 7/29/22 19:30, Peter Delevoryas wrote: >> Certainly we'd like to use IRQ's instead, but she ran into correctness >> problems. Maybe we can investigate that further and fix it. Yes, let's not work around problems that we have the

Re: [PATCH v3 8/8] arm/aspeed: Replace mx25l25635e chip model

2022-07-25 Thread Andrew Jeffery
On Mon, 25 Jul 2022, at 16:02, Cédric Le Goater wrote: > On 7/25/22 04:08, Andrew Jeffery wrote: >> >> >> On Fri, 22 Jul 2022, at 16:06, Cédric Le Goater wrote: >>> aspeed_machine_witherspoon_class_init(ObjectClass *oc, void *data) >>> mc-&

Re: [PATCH v3 8/8] arm/aspeed: Replace mx25l25635e chip model

2022-07-24 Thread Andrew Jeffery
On Fri, 22 Jul 2022, at 16:06, Cédric Le Goater wrote: > A mx25l25635f chip model is generally found on these machines. It's > newer and uses 4B opcodes which is better to exercise the support in > the Linux kernel. > > Signed-off-by: Cédric Le Goater > --- > hw/arm/aspeed.c | 6 +++--- > 1

Re: [PATCH 7/7] hw/watchdog/wdt_aspeed: Reduce timer precision to micro-second

2020-06-22 Thread Andrew Jeffery
On Mon, 22 Jun 2020, at 18:13, Philippe Mathieu-Daudé wrote: > On 6/22/20 2:21 AM, Andrew Jeffery wrote: > > On Wed, 17 Jun 2020, at 13:11, Philippe Mathieu-Daudé wrote: > >> Hi Andrew, > >> > >> On 6/17/20 3:18 AM, Andrew Jeffery wrote: > >>>

Re: [PATCH 7/7] hw/watchdog/wdt_aspeed: Reduce timer precision to micro-second

2020-06-21 Thread Andrew Jeffery
On Wed, 17 Jun 2020, at 13:11, Philippe Mathieu-Daudé wrote: > Hi Andrew, > > On 6/17/20 3:18 AM, Andrew Jeffery wrote: > > On Tue, 16 Jun 2020, at 17:21, Philippe Mathieu-Daudé wrote: > >> The current implementation uses nano-second precision, while > >> the

Re: [PATCH 7/7] hw/watchdog/wdt_aspeed: Reduce timer precision to micro-second

2020-06-16 Thread Andrew Jeffery
On Tue, 16 Jun 2020, at 17:21, Philippe Mathieu-Daudé wrote: > The current implementation uses nano-second precision, while > the watchdog can not be more precise than a micro-second. What's the basis for this assertion? It's true for the AST2500 and AST2600, but the AST2400 can run the