Re: [PATCH 04/21] hw/tricore/testboard: Use qdev_new() instead of QOM basic API

2024-02-19 Thread Bastian Koppelmann
| 4 +--- > 2 files changed, 1 insertion(+), 6 deletions(-) Reviewed-by: Bastian Koppelmann Cheers, Bastian

Re: [PATCH v2 06/22] target/tricore: Clean up local variable shadowing

2023-09-04 Thread Bastian Koppelmann
tant_i32(const9); > | ^~~~ > target/tricore/translate.c:4958:10: note: shadowed declaration is here >4958 | TCGv temp; > | ^~~~ > > Signed-off-by: Philippe Mathieu-Daudé > --- > target/tricore/translate.c | 6 +++--- > 1 file changed, 3 insertion

Re: [PULL 10/10] target/tricore: Rename tricore_feature

2023-07-25 Thread Bastian Koppelmann
Hi Phil, On Tue, Jul 25, 2023 at 04:58:29PM +0200, Philippe Mathieu-Daudé wrote: > From: Bastian Koppelmann > > this name is used by capstone and will lead to a build failure of QEMU, > when capstone is enabled. So we rename it to tricore_has_feature(), to > match has_feature()

Re: [PATCH v3 2/9] target/tricore: Remove pointless CONFIG_SOFTMMU guard

2023-06-13 Thread Bastian Koppelmann
d-by: Richard Henderson > --- > target/tricore/helper.c | 2 -- > 1 file changed, 2 deletions(-) Reviewed-by: Bastian Koppelmann Cheers, Bastian