Re: [PATCH v2 11/15] hw/southbridge/ich9: Add a AHCI function

2024-04-15 Thread Bernhard Beschow
Am 26. Februar 2024 11:14:10 UTC schrieb "Philippe Mathieu-Daudé" : >Instantiate TYPE_ICH9_AHCI in TYPE_ICH9_SOUTHBRIDGE. > >Since the PC machines can disable SATA (see the >PC_MACHINE_SATA dynamic property), add the 'sata-enabled' >property to disable it. > >Signed-off-by: Philippe

Re: [PATCH v2 10/15] hw/southbridge/ich9: Add the DMI-to-PCI bridge

2024-02-26 Thread Bernhard Beschow
Am 26. Februar 2024 11:14:09 UTC schrieb "Philippe Mathieu-Daudé" : >Instantiate TYPE_ICH_DMI_PCI_BRIDGE in TYPE_ICH9_SOUTHBRIDGE. > >Since the Q35 machine doesn't use it, add the 'd2p-enabled' >property to disable it. > >Signed-off-by: Philippe Mathieu-Daudé >--- >

Re: [PATCH v2 00/15] hw/southbridge: Extract ICH9 QOM container model

2024-02-26 Thread Bernhard Beschow
Am 26. Februar 2024 11:13:59 UTC schrieb "Philippe Mathieu-Daudé" : >Since v1 [1]: >- Rebased on top of Bernhard patches >- Rename files with 'ich9_' prefix (Bernhard) > >Hi, > >I have a long standing southbridge QOM rework branches. Since >Bernhard is actively working on the PIIX, I'll try to

Re: [RFC PATCH 0/7] hw/qdev: Split 'wiring' phase from 'realize'

2024-02-09 Thread Bernhard Beschow
a fixed point iteration over all not yet finished user-created devices. When there is no progress within one iteration, QEMU aborts with an error message. This error message could come from the `wire` invocation of any -- or even better -- all not yet finished devices. To demonstrate the approach,

Re: [PATCH v5 00/11] hw/isa/vt82c686: Implement relocation and toggling of SuperI/O functions

2024-01-14 Thread Bernhard Beschow
Am 14. Januar 2024 13:03:07 UTC schrieb "Michael S. Tsirkin" : >On Sun, Jan 14, 2024 at 12:52:53PM +0000, Bernhard Beschow wrote: >> >> >> Am 14. Januar 2024 12:39:00 UTC schrieb Bernhard Beschow : >> >This series implements relocation of

Re: [PATCH v5 00/11] hw/isa/vt82c686: Implement relocation and toggling of SuperI/O functions

2024-01-14 Thread Bernhard Beschow
Am 14. Januar 2024 12:39:00 UTC schrieb Bernhard Beschow : >This series implements relocation of the SuperI/O functions of the VIA south > >bridges which resolves some FIXME's. It is part of my via-apollo-pro-133t > >branch [1] which is an extension of bringing the VIA south br

[PATCH v5 09/11] hw/char/parallel-isa: Implement relocation and enabling/disabling for TYPE_ISA_PARALLEL

2024-01-14 Thread Bernhard Beschow
The real SuperI/O chips emulated by QEMU allow for relocating and enabling or disabling their SuperI/O functions via software. So far this is not implemented. Prepare for that by adding isa_parallel_set_{enabled,iobase}. Signed-off-by: Bernhard Beschow --- include/hw/char/parallel-isa.h | 3

[PATCH v5 10/11] hw/ppc/pegasos2: Let pegasos2 machine configure SuperI/O functions

2024-01-14 Thread Bernhard Beschow
-by: Bernhard Beschow Reviewed-by: BALATON Zoltan --- hw/ppc/pegasos2.c | 12 1 file changed, 12 insertions(+) diff --git a/hw/ppc/pegasos2.c b/hw/ppc/pegasos2.c index d84f3f977d..04d6decb2b 100644 --- a/hw/ppc/pegasos2.c +++ b/hw/ppc/pegasos2.c @@ -285,6 +285,12 @@ static void

[PATCH v5 04/11] exec/ioport: Resolve redundant .base attribute in struct MemoryRegionPortio

2024-01-14 Thread Bernhard Beschow
emoved. Signed-off-by: Bernhard Beschow --- include/exec/ioport.h | 1 - system/ioport.c | 13 ++--- 2 files changed, 6 insertions(+), 8 deletions(-) diff --git a/include/exec/ioport.h b/include/exec/ioport.h index e34f668998..95f1dc30d0 100644 --- a/include/exec/ioport.h +++ b/i

[PATCH v5 08/11] hw/char/serial-isa: Implement relocation and enabling/disabling for TYPE_ISA_SERIAL

2024-01-14 Thread Bernhard Beschow
The real SuperI/O chips emulated by QEMU allow for relocating and enabling or disabling their SuperI/O functions via software. So far this is not implemented. Prepare for that by adding isa_serial_set_{enabled,iobase}. Signed-off-by: Bernhard Beschow --- include/hw/char/serial.h | 2 ++ hw

[PATCH v5 03/11] hw/char/parallel: Move portio_list from ParallelState to ISAParallelState

2024-01-14 Thread Bernhard Beschow
ParallelState::portio_list isn't used inside ParallelState context but only inside ISAParallelState context, so move it there. Signed-off-by: Bernhard Beschow Reviewed-by: BALATON Zoltan --- include/hw/char/parallel-isa.h | 2 ++ include/hw/char/parallel.h | 2 -- hw/char/parallel.c

[PATCH v5 00/11] hw/isa/vt82c686: Implement relocation and toggling of SuperI/O functions

2024-01-14 Thread Bernhard Beschow
make check-avocado` * Run MorphOS on pegasos2 with and without pegasos2.rom * Run Linux on amigaone * Run real-world BIOSes on via-apollo-pro-133t branch * Start rescue-yl on fuloong2e [1] https://github.com/shentok/qemu/tree/via-apollo-pro-133t [2] https://github.com/shentok/qemu/tree/pc-via Bernhard B

[PATCH v5 07/11] hw/block/fdc-isa: Implement relocation and enabling/disabling for TYPE_ISA_FDC

2024-01-14 Thread Bernhard Beschow
The real SuperI/O chips emulated by QEMU allow for relocating and enabling or disabling their SuperI/O functions via software. So far this is not implemented. Prepare for that by adding isa_fdc_set_{enabled,iobase}. Signed-off-by: Bernhard Beschow --- include/hw/block/fdc.h | 3 +++ hw/block

[PATCH v5 11/11] hw/isa/vt82c686: Implement relocation and toggling of SuperI/O functions

2024-01-14 Thread Bernhard Beschow
Fuloong 2e's rescue-yl seems to expect them to be enabled by default). Rely on firmware to configure the functions accordingly. Signed-off-by: Bernhard Beschow Reviewed-by: BALATON Zoltan --- hw/isa/vt82c686.c | 65 +++ 1 file changed, 55 insertions

[PATCH v5 02/11] hw/block/fdc-sysbus: Move iomem from FDCtrl to FDCtrlSysBus

2024-01-14 Thread Bernhard Beschow
FDCtrl::iomem isn't used inside FDCtrl context but only inside FDCtrlSysBus context, so move it there. Signed-off-by: Bernhard Beschow Reviewed-by: BALATON Zoltan --- hw/block/fdc-internal.h | 2 -- hw/block/fdc-sysbus.c | 6 -- 2 files changed, 4 insertions(+), 4 deletions(-) diff

[PATCH v5 06/11] exec/ioport: Add portio_list_set_enabled()

2024-01-14 Thread Bernhard Beschow
-off-by: Bernhard Beschow --- docs/devel/migration.rst | 1 + include/exec/ioport.h| 1 + system/ioport.c | 9 + 3 files changed, 11 insertions(+) diff --git a/docs/devel/migration.rst b/docs/devel/migration.rst index 30b05f0f74..1683fc6026 100644 --- a/docs/devel

[PATCH v5 05/11] exec/ioport: Add portio_list_set_address()

2024-01-14 Thread Bernhard Beschow
duplicate synchronization of I/O port base addresses. The naming of the function is inspired by its memory_region_set_address() pendant. Signed-off-by: Bernhard Beschow --- docs/devel/migration.rst | 5 +++-- include/exec/ioport.h| 2 ++ system/ioport.c | 19 +++ 3

[PATCH v5 01/11] hw/block/fdc-isa: Move portio_list from FDCtrl to FDCtrlISABus

2024-01-14 Thread Bernhard Beschow
FDCtrl::portio_list isn't used inside FDCtrl context but only inside FDCtrlISABus context, so move it there. Signed-off-by: Bernhard Beschow Reviewed-by: BALATON Zoltan --- hw/block/fdc-internal.h | 2 -- hw/block/fdc-isa.c | 4 +++- 2 files changed, 3 insertions(+), 3 deletions(-) diff

Re: [PATCH v4 00/11] hw/isa/vt82c686: Implement relocation and toggling of SuperI/O functions

2024-01-09 Thread Bernhard Beschow
Am 8. Januar 2024 22:12:12 UTC schrieb Mark Cave-Ayland : >On 08/01/2024 20:07, Bernhard Beschow wrote: > >> Am 7. Januar 2024 14:13:44 UTC schrieb Mark Cave-Ayland >> : >>> On 06/01/2024 21:05, Bernhard Beschow wrote: >>> >>>> This series

Re: [PATCH v4 00/11] hw/isa/vt82c686: Implement relocation and toggling of SuperI/O functions

2024-01-08 Thread Bernhard Beschow
Am 7. Januar 2024 14:13:44 UTC schrieb Mark Cave-Ayland : >On 06/01/2024 21:05, Bernhard Beschow wrote: > >> This series implements relocation of the SuperI/O functions of the VIA south >> bridges which resolves some FIXME's. It is part of my via-apollo-pro-133t &

Re: [PATCH v4 10/11] hw/ppc/pegasos2: Let pegasos2 machine configure SuperI/O functions

2024-01-08 Thread Bernhard Beschow
Am 7. Januar 2024 13:54:57 UTC schrieb BALATON Zoltan : >On Sat, 6 Jan 2024, Bernhard Beschow wrote: >> This is a preparation for implementing relocation and toggling of SuperI/O >> functions in the VT8231 device model. Upon reset, all SuperI/O functions >> will be >&

Re: [PATCH v4 11/11] hw/isa/vt82c686: Implement relocation and toggling of SuperI/O functions

2024-01-08 Thread Bernhard Beschow
Am 7. Januar 2024 13:59:44 UTC schrieb BALATON Zoltan : >On Sat, 6 Jan 2024, Bernhard Beschow wrote: >> The VIA south bridges are able to relocate and toggle (enable or disable) >> their >> SuperI/O functions. So far this is hardcoded such that all functions are

Re: [PATCH v2 12/12] hw/isa/vt82c686: Implement relocation and toggling of SuperI/O functions

2024-01-06 Thread Bernhard Beschow
Am 3. Januar 2024 12:26:07 UTC schrieb BALATON Zoltan : >On Tue, 2 Jan 2024, Bernhard Beschow wrote: >> Am 24. Dezember 2023 00:51:53 UTC schrieb BALATON Zoltan >> : >>> On Tue, 19 Dec 2023, Bernhard Beschow wrote: >>>> Am 19. Dezember 2023

[PATCH v4 00/11] hw/isa/vt82c686: Implement relocation and toggling of SuperI/O functions

2024-01-06 Thread Bernhard Beschow
real-world BIOSes on via-apollo-pro-133t branch * Start rescue-yl on fuloong2e [1] https://github.com/shentok/qemu/tree/via-apollo-pro-133t [2] https://github.com/shentok/qemu/tree/pc-via Bernhard Beschow (11): hw/block/fdc-isa: Move portio_list from FDCtrl to FDCtrlISABus hw/block/fdc-sysbus:

[PATCH v4 06/11] exec/ioport: Add portio_list_set_enabled()

2024-01-06 Thread Bernhard Beschow
-off-by: Bernhard Beschow --- docs/devel/migration.rst | 1 + include/exec/ioport.h| 1 + system/ioport.c | 9 + 3 files changed, 11 insertions(+) diff --git a/docs/devel/migration.rst b/docs/devel/migration.rst index 30b05f0f74..1683fc6026 100644 --- a/docs/devel

[PATCH v4 03/11] hw/char/parallel: Move portio_list from ParallelState to ISAParallelState

2024-01-06 Thread Bernhard Beschow
ParallelState::portio_list isn't used inside ParallelState context but only inside ISAParallelState context, so move it there. Signed-off-by: Bernhard Beschow Reviewed-by: BALATON Zoltan --- include/hw/char/parallel-isa.h | 2 ++ include/hw/char/parallel.h | 2 -- hw/char/parallel.c

[PATCH v4 04/11] exec/ioport: Resolve redundant .base attribute in struct MemoryRegionPortio

2024-01-06 Thread Bernhard Beschow
emoved. Signed-off-by: Bernhard Beschow --- include/exec/ioport.h | 1 - system/ioport.c | 13 ++--- 2 files changed, 6 insertions(+), 8 deletions(-) diff --git a/include/exec/ioport.h b/include/exec/ioport.h index e34f668998..95f1dc30d0 100644 --- a/include/exec/ioport.h +++ b/i

[PATCH v4 08/11] hw/char/serial-isa: Implement relocation and enabling/disabling for TYPE_ISA_SERIAL

2024-01-06 Thread Bernhard Beschow
The real SuperI/O chips emulated by QEMU allow for relocating and enabling or disabling their SuperI/O functions via software. So far this is not implemented. Prepare for that by adding isa_serial_set_{enabled,iobase}. Signed-off-by: Bernhard Beschow --- include/hw/char/serial.h | 2 ++ hw

[PATCH v4 10/11] hw/ppc/pegasos2: Let pegasos2 machine configure SuperI/O functions

2024-01-06 Thread Bernhard Beschow
-by: Bernhard Beschow --- hw/ppc/pegasos2.c | 15 +++ 1 file changed, 15 insertions(+) diff --git a/hw/ppc/pegasos2.c b/hw/ppc/pegasos2.c index 3203a4a728..0a40ebd542 100644 --- a/hw/ppc/pegasos2.c +++ b/hw/ppc/pegasos2.c @@ -285,6 +285,15 @@ static void pegasos2_pci_config_write

[PATCH v4 05/11] exec/ioport: Add portio_list_set_address()

2024-01-06 Thread Bernhard Beschow
duplicate synchronization of I/O port base addresses. The naming of the function is inspired by its memory_region_set_address() pendant. Signed-off-by: Bernhard Beschow --- docs/devel/migration.rst | 5 +++-- include/exec/ioport.h| 2 ++ system/ioport.c | 19 +++ 3

[PATCH v4 01/11] hw/block/fdc-isa: Move portio_list from FDCtrl to FDCtrlISABus

2024-01-06 Thread Bernhard Beschow
FDCtrl::portio_list isn't used inside FDCtrl context but only inside FDCtrlISABus context, so move it there. Signed-off-by: Bernhard Beschow Reviewed-by: BALATON Zoltan --- hw/block/fdc-internal.h | 2 -- hw/block/fdc-isa.c | 4 +++- 2 files changed, 3 insertions(+), 3 deletions(-) diff

[PATCH v4 02/11] hw/block/fdc-sysbus: Move iomem from FDCtrl to FDCtrlSysBus

2024-01-06 Thread Bernhard Beschow
FDCtrl::iomem isn't used inside FDCtrl context but only inside FDCtrlSysBus context, so move it there. Signed-off-by: Bernhard Beschow Reviewed-by: BALATON Zoltan --- hw/block/fdc-internal.h | 2 -- hw/block/fdc-sysbus.c | 6 -- 2 files changed, 4 insertions(+), 4 deletions(-) diff

[PATCH v4 07/11] hw/block/fdc-isa: Implement relocation and enabling/disabling for TYPE_ISA_FDC

2024-01-06 Thread Bernhard Beschow
The real SuperI/O chips emulated by QEMU allow for relocating and enabling or disabling their SuperI/O functions via software. So far this is not implemented. Prepare for that by adding isa_fdc_set_{enabled,iobase}. Signed-off-by: Bernhard Beschow --- include/hw/block/fdc.h | 3 +++ hw/block

[PATCH v4 11/11] hw/isa/vt82c686: Implement relocation and toggling of SuperI/O functions

2024-01-06 Thread Bernhard Beschow
Fuloong 2e's rescue-yl seems to expect them to be enabled by default). Rely on firmware to configure the functions accordingly. Signed-off-by: Bernhard Beschow --- hw/isa/vt82c686.c | 66 --- 1 file changed, 56 insertions(+), 10 deletions(-) diff

[PATCH v4 09/11] hw/char/parallel-isa: Implement relocation and enabling/disabling for TYPE_ISA_PARALLEL

2024-01-06 Thread Bernhard Beschow
The real SuperI/O chips emulated by QEMU allow for relocating and enabling or disabling their SuperI/O functions via software. So far this is not implemented. Prepare for that by adding isa_parallel_set_{enabled,iobase}. Signed-off-by: Bernhard Beschow --- include/hw/char/parallel-isa.h | 3

Re: [PATCH v2 12/12] hw/isa/vt82c686: Implement relocation and toggling of SuperI/O functions

2024-01-02 Thread Bernhard Beschow
Am 24. Dezember 2023 00:51:53 UTC schrieb BALATON Zoltan : >On Tue, 19 Dec 2023, Bernhard Beschow wrote: >> Am 19. Dezember 2023 00:26:15 UTC schrieb BALATON Zoltan >> : >>> On Mon, 18 Dec 2023, Bernhard Beschow wrote: >>>> The VIA south bridges are

Re: [PATCH v2 1/5] system/cpus: rename qemu_mutex_lock_iothread() to bql_lock()

2024-01-02 Thread Bernhard Beschow
Am 12. Dezember 2023 15:39:00 UTC schrieb Stefan Hajnoczi : >The Big QEMU Lock (BQL) has many names and they are confusing. The >actual QemuMutex variable is called qemu_global_mutex but it's commonly >referred to as the BQL in discussions and some code comments. The >locking APIs, however, are

[PATCH v3 09/11] hw/char/parallel-isa: Implement relocation and enabling/disabling for TYPE_ISA_PARALLEL

2023-12-21 Thread Bernhard Beschow
The real SuperI/O chips emulated by QEMU allow for relocating and enabling or disabling their SuperI/O functions via software. So far this is not implemented. Prepare for that by adding isa_parallel_set_{enabled,iobase}. Signed-off-by: Bernhard Beschow --- include/hw/char/parallel-isa.h | 3

[PATCH v3 10/11] hw/ppc/pegasos2: Let pegasos2 machine configure SuperI/O functions

2023-12-21 Thread Bernhard Beschow
-by: Bernhard Beschow --- hw/ppc/pegasos2.c | 15 +++ 1 file changed, 15 insertions(+) diff --git a/hw/ppc/pegasos2.c b/hw/ppc/pegasos2.c index 3203a4a728..0a40ebd542 100644 --- a/hw/ppc/pegasos2.c +++ b/hw/ppc/pegasos2.c @@ -285,6 +285,15 @@ static void pegasos2_pci_config_write

[PATCH v3 11/11] hw/isa/vt82c686: Implement relocation and toggling of SuperI/O functions

2023-12-21 Thread Bernhard Beschow
Fuloong 2e's rescue-yl seems to expect them to be enabled by default). Rely on firmware to configure the functions accordingly. Signed-off-by: Bernhard Beschow --- hw/isa/vt82c686.c | 115 +- 1 file changed, 84 insertions(+), 31 deletions(-) diff

[PATCH v3 07/11] hw/block/fdc-isa: Implement relocation and enabling/disabling for TYPE_ISA_FDC

2023-12-21 Thread Bernhard Beschow
The real SuperI/O chips emulated by QEMU allow for relocating and enabling or disabling their SuperI/O functions via software. So far this is not implemented. Prepare for that by adding isa_fdc_set_{enabled,iobase}. Signed-off-by: Bernhard Beschow --- include/hw/block/fdc.h | 3 +++ hw/block

[PATCH v3 00/11] hw/isa/vt82c686: Implement relocation and toggling of SuperI/O functions

2023-12-21 Thread Bernhard Beschow
rescue-yl on fuloong2e [1] https://github.com/shentok/qemu/tree/via-apollo-pro-133t [2] https://github.com/shentok/qemu/tree/pc-via Bernhard Beschow (11): hw/block/fdc-isa: Move portio_list from FDCtrl to FDCtrlISABus hw/block/fdc-sysbus: Move iomem from FDCtrl to FDCtrlSysBus hw/char/parallel: Move p

[PATCH v3 02/11] hw/block/fdc-sysbus: Move iomem from FDCtrl to FDCtrlSysBus

2023-12-21 Thread Bernhard Beschow
FDCtrl::iomem isn't used inside FDCtrl context but only inside FDCtrlSysBus context, so move it there. Signed-off-by: Bernhard Beschow Reviewed-by: BALATON Zoltan --- hw/block/fdc-internal.h | 2 -- hw/block/fdc-sysbus.c | 6 -- 2 files changed, 4 insertions(+), 4 deletions(-) diff

[PATCH v3 04/11] exec/ioport: Resolve redundant .base attribute in struct MemoryRegionPortio

2023-12-21 Thread Bernhard Beschow
emoved. Signed-off-by: Bernhard Beschow --- include/exec/ioport.h | 1 - system/ioport.c | 13 ++--- 2 files changed, 6 insertions(+), 8 deletions(-) diff --git a/include/exec/ioport.h b/include/exec/ioport.h index e34f668998..95f1dc30d0 100644 --- a/include/exec/ioport.h +++ b/i

[PATCH v3 03/11] hw/char/parallel: Move portio_list from ParallelState to ISAParallelState

2023-12-21 Thread Bernhard Beschow
ParallelState::portio_list isn't used inside ParallelState context but only inside ISAParallelState context, so move it there. Signed-off-by: Bernhard Beschow Reviewed-by: BALATON Zoltan --- include/hw/char/parallel-isa.h | 2 ++ include/hw/char/parallel.h | 2 -- hw/char/parallel.c

[PATCH v3 05/11] exec/ioport: Add portio_list_set_address()

2023-12-21 Thread Bernhard Beschow
duplicate synchronization of I/O port base addresses. The naming of the function is inspired by its memory_region_set_address() pendant. Signed-off-by: Bernhard Beschow --- docs/devel/migration.rst | 5 +++-- include/exec/ioport.h| 2 ++ system/ioport.c | 19 +++ 3

[PATCH v3 06/11] exec/ioport: Add portio_list_set_enabled()

2023-12-21 Thread Bernhard Beschow
-off-by: Bernhard Beschow --- docs/devel/migration.rst | 1 + include/exec/ioport.h| 1 + system/ioport.c | 9 + 3 files changed, 11 insertions(+) diff --git a/docs/devel/migration.rst b/docs/devel/migration.rst index dc35a17461..9317091d1a 100644 --- a/docs/devel

[PATCH v3 01/11] hw/block/fdc-isa: Move portio_list from FDCtrl to FDCtrlISABus

2023-12-21 Thread Bernhard Beschow
FDCtrl::portio_list isn't used inside FDCtrl context but only inside FDCtrlISABus context, so move it there. Signed-off-by: Bernhard Beschow Reviewed-by: BALATON Zoltan --- hw/block/fdc-internal.h | 2 -- hw/block/fdc-isa.c | 4 +++- 2 files changed, 3 insertions(+), 3 deletions(-) diff

[PATCH v3 08/11] hw/char/serial-isa: Implement relocation and enabling/disabling for TYPE_ISA_SERIAL

2023-12-21 Thread Bernhard Beschow
The real SuperI/O chips emulated by QEMU allow for relocating and enabling or disabling their SuperI/O functions via software. So far this is not implemented. Prepare for that by adding isa_serial_set_{enabled,iobase}. Signed-off-by: Bernhard Beschow --- include/hw/char/serial.h | 2 ++ hw

Re: [PATCH v2 11/12] hw/ppc/pegasos2: Let pegasos2 machine configure SuperI/O functions

2023-12-21 Thread Bernhard Beschow
Am 19. Dezember 2023 00:11:37 UTC schrieb BALATON Zoltan : >On Mon, 18 Dec 2023, Bernhard Beschow wrote: >> This is a preparation for implementing relocation and toggling of SuperI/O >> functions in the VT8231 device model. Upon reset, all SuperI/O functions >> will

Re: [PATCH v2 08/12] hw/block/fdc-isa: Implement relocation and toggling for TYPE_ISA_FDC

2023-12-21 Thread Bernhard Beschow
Am 19. Dezember 2023 00:09:23 UTC schrieb BALATON Zoltan : >On Mon, 18 Dec 2023, Bernhard Beschow wrote: >> Implement isa_fdc_set_{enabled,iobase} in order to implement relocation and >> toggling of SuperI/O functions in the VIA south bridges without breaking >> encapsula

Re: [PATCH v2 12/12] hw/isa/vt82c686: Implement relocation and toggling of SuperI/O functions

2023-12-19 Thread Bernhard Beschow
Am 19. Dezember 2023 00:26:15 UTC schrieb BALATON Zoltan : >On Mon, 18 Dec 2023, Bernhard Beschow wrote: >> The VIA south bridges are able to relocate and toggle (enable or disable) >> their >> SuperI/O functions. So far this is hardcoded such that all functions are

[PATCH v2 10/12] hw/char/parallel-isa: Implement relocation and toggling for TYPE_ISA_PARALLEL

2023-12-18 Thread Bernhard Beschow
Implement isa_parallel_set_{enabled,iobase} in order to implement relocation and toggling of SuperI/O functions in the VIA south bridges without breaking encapsulation. Signed-off-by: Bernhard Beschow --- include/hw/char/parallel-isa.h | 3 +++ hw/char/parallel-isa.c | 14

[PATCH v2 12/12] hw/isa/vt82c686: Implement relocation and toggling of SuperI/O functions

2023-12-18 Thread Bernhard Beschow
2e's rescue-yl seems to expect them to be enabled by default). Rely on firmware -- or in case of pegasos2 on board code if no -bios is given -- to configure the functions accordingly. Signed-off-by: Bernhard Beschow --- hw/isa/vt82c686.c | 121 ++ 1 file

[PATCH v2 05/12] exec/ioport: Resolve redundant .base attribute in struct MemoryRegionPortio

2023-12-18 Thread Bernhard Beschow
emoved. Signed-off-by: Bernhard Beschow --- include/exec/ioport.h | 1 - system/ioport.c | 13 ++--- 2 files changed, 6 insertions(+), 8 deletions(-) diff --git a/include/exec/ioport.h b/include/exec/ioport.h index e34f668998..95f1dc30d0 100644 --- a/include/exec/ioport.h +++ b/i

Re: [PATCH 04/12] hw/block/fdc: Expose internal header

2023-12-18 Thread Bernhard Beschow
Am 18. Dezember 2023 10:54:56 UTC schrieb BALATON Zoltan : >On Sun, 17 Dec 2023, Bernhard Beschow wrote: >> Am 17. Dezember 2023 15:47:33 UTC schrieb BALATON Zoltan >> : >>> On Sun, 17 Dec 2023, Bernhard Beschow wrote: >>>> Exposing the internal header all

[PATCH v2 06/12] exec/ioport: Add portio_list_set_address()

2023-12-18 Thread Bernhard Beschow
duplicate synchronization of I/O port base addresses. The naming of the function is inspired by its memory_region_set_address() pendant. Signed-off-by: Bernhard Beschow --- docs/devel/migration.rst | 1 + include/exec/ioport.h| 2 ++ system/ioport.c | 19 +++ 3 files

[PATCH v2 04/12] hw/char/parallel: Free struct ParallelState from PortioList

2023-12-18 Thread Bernhard Beschow
ParallelState::portio_list isn't used inside ParallelState context but only inside ISAParallelState context, so more it there. Signed-off-by: Bernhard Beschow --- include/hw/char/parallel-isa.h | 2 ++ include/hw/char/parallel.h | 2 -- hw/char/parallel.c | 2 +- 3 files changed

[PATCH v2 07/12] exec/ioport: Add portio_list_set_enabled()

2023-12-18 Thread Bernhard Beschow
-off-by: Bernhard Beschow --- docs/devel/migration.rst | 1 + include/exec/ioport.h| 1 + system/ioport.c | 9 + 3 files changed, 11 insertions(+) diff --git a/docs/devel/migration.rst b/docs/devel/migration.rst index 389fa24bde..466be609a2 100644 --- a/docs/devel

[PATCH v2 02/12] hw/block/fdc-sysbus: Free struct FDCtrl from MemoryRegion

2023-12-18 Thread Bernhard Beschow
FDCtrl::iomem isn't used inside FDCtrl context but only inside FDCtrlSysBus context, so more it there. Signed-off-by: Bernhard Beschow --- hw/block/fdc-internal.h | 2 -- hw/block/fdc-sysbus.c | 6 -- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/hw/block/fdc-internal.h b

[PATCH v2 03/12] hw/char/serial: Free struct SerialState from MemoryRegion

2023-12-18 Thread Bernhard Beschow
SerialState::io isn't used within TYPE_SERIAL directly. Push it to its users to make them the owner of the MemoryRegion. Signed-off-by: Bernhard Beschow --- include/hw/char/serial.h | 2 +- hw/char/serial-isa.c | 7 +-- hw/char/serial-pci-multi.c | 7 --- hw/char/serial-pci.c

[PATCH v2 11/12] hw/ppc/pegasos2: Let pegasos2 machine configure SuperI/O functions

2023-12-18 Thread Bernhard Beschow
the meantime this will be a no-op. Signed-off-by: Bernhard Beschow --- hw/ppc/pegasos2.c | 15 +++ 1 file changed, 15 insertions(+) diff --git a/hw/ppc/pegasos2.c b/hw/ppc/pegasos2.c index 3203a4a728..0a40ebd542 100644 --- a/hw/ppc/pegasos2.c +++ b/hw/ppc/pegasos2.c @@ -285,6 +285,15 @@ static

[PATCH v2 08/12] hw/block/fdc-isa: Implement relocation and toggling for TYPE_ISA_FDC

2023-12-18 Thread Bernhard Beschow
Implement isa_fdc_set_{enabled,iobase} in order to implement relocation and toggling of SuperI/O functions in the VIA south bridges without breaking encapsulation. Signed-off-by: Bernhard Beschow --- include/hw/block/fdc.h | 3 +++ hw/block/fdc-isa.c | 14 ++ 2 files changed

[PATCH v2 00/12] hw/isa/vt82c686: Implement relocation and toggling of SuperI/O functions

2023-12-18 Thread Bernhard Beschow
Linux on amigaone * Run real-world BIOSes on via-apollo-pro-133t branch * Start rescue-yl on fuloong2e [1] https://github.com/shentok/qemu/tree/via-apollo-pro-133t [2] https://github.com/shentok/qemu/tree/pc-via Bernhard Beschow (12): hw/block/fdc-isa: Free struct FDCtrl from PortioList hw/block

[PATCH v2 01/12] hw/block/fdc-isa: Free struct FDCtrl from PortioList

2023-12-18 Thread Bernhard Beschow
FDCtrl::portio_list isn't used inside FDCtrl context but only inside FDCtrlISABus context, so more it there. Signed-off-by: Bernhard Beschow --- hw/block/fdc-internal.h | 2 -- hw/block/fdc-isa.c | 4 +++- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/hw/block/fdc

[PATCH v2 09/12] hw/char/serial-isa: Implement relocation and toggling for TYPE_ISA_SERIAL

2023-12-18 Thread Bernhard Beschow
Implement isa_serial_set_{enabled,iobase} in order to implement relocation and toggling of SuperI/O functions in the VIA south bridges without breaking encapsulation. Signed-off-by: Bernhard Beschow --- include/hw/char/serial.h | 2 ++ hw/char/serial-isa.c | 14 ++ 2 files

Re: [PATCH 12/12] hw/isa/vt82c686: Implement relocation of SuperI/O functions

2023-12-18 Thread Bernhard Beschow
Am 17. Dezember 2023 15:40:58 UTC schrieb BALATON Zoltan : >On Sun, 17 Dec 2023, Bernhard Beschow wrote: >> The VIA south bridges are able to relocate and enable or disable their >> SuperI/O >> functions. So far this is hardcoded such that all functions a

Re: [PATCH 04/12] hw/block/fdc: Expose internal header

2023-12-17 Thread Bernhard Beschow
Am 17. Dezember 2023 15:47:33 UTC schrieb BALATON Zoltan : >On Sun, 17 Dec 2023, Bernhard Beschow wrote: >> Exposing the internal header allows for exposing struct FDCtrlISABus which is >> encuraged by qdev guidelines. > >Hopefully the guidelines don't encourage this

[PATCH 11/12] exec/ioport: Add portio_list_set_enabled()

2023-12-17 Thread Bernhard Beschow
-off-by: Bernhard Beschow --- docs/devel/migration.rst | 1 + include/exec/ioport.h| 1 + system/ioport.c | 9 + 3 files changed, 11 insertions(+) diff --git a/docs/devel/migration.rst b/docs/devel/migration.rst index 389fa24bde..466be609a2 100644 --- a/docs/devel

[PATCH 02/12] hw/i386/pc: No need to include hw/block/fdc.h in header

2023-12-17 Thread Bernhard Beschow
Only the source file uses fdc.h but not the header, so remove it from the public interface. Signed-off-by: Bernhard Beschow --- include/hw/i386/pc.h | 1 - hw/i386/pc.c | 1 + 2 files changed, 1 insertion(+), 1 deletion(-) diff --git a/include/hw/i386/pc.h b/include/hw/i386/pc.h index

[PATCH 06/12] hw/block/fdc-isa: Expose struct FDCtrlISABus

2023-12-17 Thread Bernhard Beschow
Exposing device structs in headers is encuraged by qdev guidelines. Signed-off-by: Bernhard Beschow --- include/hw/block/fdc-isa.h | 15 +++ hw/block/fdc-isa.c | 17 - 2 files changed, 15 insertions(+), 17 deletions(-) diff --git a/include/hw/block/fdc-isa.h

[PATCH 05/12] hw/block/fdc: Move constant #define to where it is imposed

2023-12-17 Thread Bernhard Beschow
The MAX_FD is a limitation of struct FDCtrl which is defined in fdc.h. Now that this header is exposed the definition can be moved there. Signed-off-by: Bernhard Beschow --- include/hw/block/fdc-isa.h | 3 --- include/hw/block/fdc.h | 3 ++- hw/block/fdc.c | 1 - hw/i386/pc.c

[PATCH 08/12] hw/char/serial-isa: Export struct ISASerialState

2023-12-17 Thread Bernhard Beschow
Exposing device structs in headers is encuraged by qdev guidelines. Signed-off-by: Bernhard Beschow --- include/hw/char/serial-isa.h | 50 include/hw/char/serial.h | 7 - hw/char/serial-isa.c | 14 +- hw/i386/microvm-dt.c

[PATCH 01/12] hw: Remove unused includes of hw/block/fdc.h

2023-12-17 Thread Bernhard Beschow
Results running grep: `grep -i -e "fdc" hw/ppc/prep.c` (no output) `grep -i -e "fdc" hw/m68k/next-cube.c` DPRINTF("FDCSR Write: %x\n", value); This indicates that hw/block/fdc.h isn't used there. Signed-off-by: Bernhard Beschow --- hw/m68k/next-cube.c

[PATCH 09/12] exec/ioport: Resolve redundant .base attribute in struct MemoryRegionPortio

2023-12-17 Thread Bernhard Beschow
emoved. Signed-off-by: Bernhard Beschow --- include/exec/ioport.h | 1 - system/ioport.c | 13 ++--- 2 files changed, 6 insertions(+), 8 deletions(-) diff --git a/include/exec/ioport.h b/include/exec/ioport.h index e34f668998..95f1dc30d0 100644 --- a/include/exec/ioport.h +++ b/i

[PATCH 12/12] hw/isa/vt82c686: Implement relocation of SuperI/O functions

2023-12-17 Thread Bernhard Beschow
handle it since it enables and relocates the I/O region accordingly. Signed-off-by: Bernhard Beschow --- hw/isa/vt82c686.c | 140 -- hw/ppc/pegasos2.c | 15 + 2 files changed, 124 insertions(+), 31 deletions(-) diff --git a/hw/isa/vt82c686.c b/hw

[PATCH 07/12] MAINTAINERS: Add include/hw/char/serial*.h to the "PC Chipset" section

2023-12-17 Thread Bernhard Beschow
The source files are already in this section. Add the headers, too. Signed-off-by: Bernhard Beschow --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index 939f518701..69135a45b4 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -1827,6 +1827,7 @@ F: hw

[PATCH 04/12] hw/block/fdc: Expose internal header

2023-12-17 Thread Bernhard Beschow
Exposing the internal header allows for exposing struct FDCtrlISABus which is encuraged by qdev guidelines. Signed-off-by: Bernhard Beschow --- MAINTAINERS | 2 +- hw/block/fdc-internal.h => include/hw/block/fdc.h | 4 ++-- hw/block/fdc-is

[PATCH 03/12] hw/block/fdc-isa: Rename header to match source file

2023-12-17 Thread Bernhard Beschow
Rename the header which allows for exposing fdc-internal.h (dropping the -internal suffix) which in turn allows for exposing struct FDCtrlISABus. Exposing a device struct is in line with OOM/qdev guidelines. Signed-off-by: Bernhard Beschow --- MAINTAINERS | 2 +- hw

[PATCH 10/12] exec/ioport: Add portio_list_set_address()

2023-12-17 Thread Bernhard Beschow
duplicate synchronization of I/O port base addresses. The naming of the function is inspired by its memory_region_set_address() pendant. Signed-off-by: Bernhard Beschow --- docs/devel/migration.rst | 1 + include/exec/ioport.h| 2 ++ system/ioport.c | 19 +++ 3 files

[PATCH 00/12] hw/isa/vt82c686: Implement relocation and toggling of SuperI/O functions

2023-12-17 Thread Bernhard Beschow
://github.com/shentok/qemu/tree/pc-via Bernhard Beschow (12): hw: Remove unused includes of hw/block/fdc.h hw/i386/pc: No need to include hw/block/fdc.h in header hw/block/fdc-isa: Rename header to match source file hw/block/fdc: Expose internal header hw/block/fdc: Move constant #define

Re: [PATCH v2 0/3] ide: implement simple legacy/native mode switching for PCI IDE controllers

2023-11-02 Thread Bernhard Beschow
ea. However for the moment I've kept it simple (and >restricted it to the via-ide device) which is good enough for Zoltan's PPC >images whilst paving the way for future improvements after 8.2. > >Signed-off-by: Mark Cave-Ayland FWIW: Reviewed-by: Bernhard Beschow > >[1] https://lists

Re: [PATCH 1/2] ide/pci.c: introduce pci_ide_update_mode() function

2023-10-24 Thread Bernhard Beschow
Am 23. Oktober 2023 21:06:11 UTC schrieb Mark Cave-Ayland : >On 23/10/2023 18:19, Bernhard Beschow wrote: > >> Am 22. Oktober 2023 22:06:30 UTC schrieb Bernhard Beschow >> : >>> >>> >>> Am 19. Oktober 2023 13:04:51 UTC schrieb Mark Cave-Ayl

Re: [PATCH 1/2] ide/pci.c: introduce pci_ide_update_mode() function

2023-10-23 Thread Bernhard Beschow
Am 22. Oktober 2023 22:06:30 UTC schrieb Bernhard Beschow : > > >Am 19. Oktober 2023 13:04:51 UTC schrieb Mark Cave-Ayland >: >>This function reads the value of the PCI_CLASS_PROG register for PCI IDE >>controllers and configures the PCI BARs and/or IDE ioports accor

Re: [PATCH 0/2] ide: implement simple legacy/native mode switching for PCI IDE controllers

2023-10-22 Thread Bernhard Beschow
ea. However for the moment I've kept it simple (and >restricted it to the via-ide device) which is good enough for Zoltan's PPC >images whilst paving the way for future improvements after 8.2. > >Signed-off-by: Mark Cave-Ayland I've successfully tested this series on top of my pc-via branch,

Re: [PATCH 1/2] ide/pci.c: introduce pci_ide_update_mode() function

2023-10-22 Thread Bernhard Beschow
Am 19. Oktober 2023 13:04:51 UTC schrieb Mark Cave-Ayland : >This function reads the value of the PCI_CLASS_PROG register for PCI IDE >controllers and configures the PCI BARs and/or IDE ioports accordingly. > >In the case where we switch to legacy mode, the PCI BARs are set to return zero >(as

Re: [PULL 01/10] hw/sd/sdhci: Do not force sdhci_mmio_*_ops onto all SD controllers

2023-08-30 Thread Bernhard Beschow
Am 25. Juli 2023 14:58:20 UTC schrieb "Philippe Mathieu-Daudé" : >From: Bernhard Beschow > >Since commit c0a55a0c9da2 "hw/sd/sdhci: Support big endian SD host controller >interfaces" sdhci_common_realize() forces all SD card controllers to use either >sdh

Re: [PATCH] hw/sd/sdhci: Do not force sdhci_mmio_*_ops onto all SD controllers

2023-07-24 Thread Bernhard Beschow
Am 16. Juli 2023 19:53:37 UTC schrieb Bernhard Beschow : > > >Am 10. Juli 2023 16:01:46 UTC schrieb Bernhard Beschow : >> >> >>Am 10. Juli 2023 10:16:35 UTC schrieb "Philippe Mathieu-Daudé" >>: >>>On 9/7/23 10:09, Bernhard Beschow wrote: >

Re: [PATCH v2] hw/ide/piix: properly initialize the BMIBA register

2023-07-17 Thread Bernhard Beschow
Am 5. Juli 2023 10:01:21 UTC schrieb Olaf Hering : >Tue, 4 Jul 2023 08:38:33 +0200 Paolo Bonzini : > >> I agree that calling pci_device_reset() would be a better match for >> pci_xen_ide_unplug(). > >This change works as well: > >--- a/hw/i386/xen/xen_platform.c >+++

Re: [PATCH] hw/sd/sdhci: Do not force sdhci_mmio_*_ops onto all SD controllers

2023-07-16 Thread Bernhard Beschow
Am 10. Juli 2023 16:01:46 UTC schrieb Bernhard Beschow : > > >Am 10. Juli 2023 10:16:35 UTC schrieb "Philippe Mathieu-Daudé" >: >>On 9/7/23 10:09, Bernhard Beschow wrote: >>> Since commit c0a55a0c9da2 "hw/sd/sdhci: Support big endian SD host >>&

Re: [PATCH v2] hw/ide/piix: properly initialize the BMIBA register

2023-07-11 Thread Bernhard Beschow
Am 11. Juli 2023 09:11:33 UTC schrieb Olaf Hering : >Wed, 05 Jul 2023 21:52:05 +0000 Bernhard Beschow : > >> I wonder if we should fix this line rather than dropping it. > >I think this needs to be fixed, just to fix the initial commit which >added this bug. This w

Re: [PATCH v2] hw/ide/piix: properly initialize the BMIBA register

2023-07-11 Thread Bernhard Beschow
(Step A1) and Improved support for >82371SB (Function 1)") > >Signed-off-by: Olaf Hering With the changed commit message: Reviewed-by: Bernhard Beschow >--- > hw/ide/piix.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/hw/ide/pi

Re: [PATCH v3 0/7] VIA and general PCI IDE cleanup

2023-07-10 Thread Bernhard Beschow
Am 31. Mai 2023 21:10:36 UTC schrieb Bernhard Beschow : >This series is split off from a more general PCI IDE refactoring aiming for a > >common implementation of the PCI IDE controller specification for all > >TYPE_PCI_IDE models [1]. > > > >The first three

Re: [PATCH] hw/sd/sdhci: Do not force sdhci_mmio_*_ops onto all SD controllers

2023-07-10 Thread Bernhard Beschow
Am 10. Juli 2023 10:16:35 UTC schrieb "Philippe Mathieu-Daudé" : >On 9/7/23 10:09, Bernhard Beschow wrote: >> Since commit c0a55a0c9da2 "hw/sd/sdhci: Support big endian SD host controller >> interfaces" sdhci_common_realize() forces all SD

[PATCH] hw/sd/sdhci: Do not force sdhci_mmio_*_ops onto all SD controllers

2023-07-09 Thread Bernhard Beschow
e() only if there is a matchig big endian variant available. Fixes: c0a55a0c9da2 ("hw/sd/sdhci: Support big endian SD host controller interfaces") Signed-off-by: Bernhard Beschow --- hw/sd/sdhci.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/hw/sd/

Re: [PATCH v2] hw/ide/piix: properly initialize the BMIBA register

2023-07-05 Thread Bernhard Beschow
Am 5. Juli 2023 10:01:21 UTC schrieb Olaf Hering : >Tue, 4 Jul 2023 08:38:33 +0200 Paolo Bonzini : > >> I agree that calling pci_device_reset() would be a better match for >> pci_xen_ide_unplug(). > >This change works as well: Nice! > >--- a/hw/i386/xen/xen_platform.c >+++

Re: [PATCH v2] hw/ide/piix: properly initialize the BMIBA register

2023-07-03 Thread Bernhard Beschow
Am 3. Juli 2023 07:59:29 UTC schrieb Olaf Hering : >Sun, 02 Jul 2023 22:18:50 +0000 Bernhard Beschow : > >> Do you know if that command calls pci_device_reset() (which would eventually >> call piix_ide_reset())? > >The function is pci_xen_ide_unplug, which calls dev

Re: [PATCH v2] hw/ide/piix: properly initialize the BMIBA register

2023-07-02 Thread Bernhard Beschow
Am 1. Juli 2023 17:46:59 UTC schrieb Olaf Hering : >According to the 82371FB documentation (82371FB.pdf, 2.3.9. BMIBA—BUS >MASTER INTERFACE BASE ADDRESS REGISTER, April 1997), the register is >32bit wide. To properly reset it to default values, all 32bit need to be >cleared. Bit #0 "Resource

Re: [PATCH 12/12] hw/vmapple/vmapple: Add vmapple machine type

2023-06-20 Thread Bernhard Beschow
Am 14. Juni 2023 22:57:34 UTC schrieb Alexander Graf : >Apple defines a new "vmapple" machine type as part of its proprietary >macOS Virtualization.Framework vmm. This machine type is similar to the >virt one, but with subtle differences in base devices, a few special >vmapple device additions

Re: [PATCH 5/5] cmd646: move device-specific BMDMA registers to separate memory region

2023-06-13 Thread Bernhard Beschow
On Tue, Jun 13, 2023 at 12:39 AM Philippe Mathieu-Daudé wrote: > On 12/6/23 21:28, Bernhard Beschow wrote: > > > > > > Am 9. Juni 2023 18:51:19 UTC schrieb Mark Cave-Ayland < > mark.cave-ayl...@ilande.co.uk>: > >> The aim here is to eliminate any device-s

  1   2   3   4   5   6   >