Re: [Qemu-block] [Qemu-devel] [PATCH v2 14/14] blockjob: Remove BlockJob.bs

On 05/24/2016 09:47 PM, Kevin Wolf wrote: There is a single remaining user in qemu-img, which can be trivially converted to using BlockJob.blk instead. Signed-off-by: Kevin Wolf Reviewed-by: Max Reitz --- blockjob.c | 1 -

Re: [Qemu-block] [Qemu-devel] [PATCH v2 08/14] mirror: Use BlockBackend for I/O

On 05/25/2016 12:01 PM, Eric Blake wrote: On 05/24/2016 09:51 PM, Changlong Xie wrote: On 05/24/2016 09:47 PM, Kevin Wolf wrote: +s->target = blk_new(); blk_new(errp); Depends on Kevin's block/next branch, which currently includes: commit 5d7dd50566a4f9786b95f49448f48fead0bb34d8 Aut

Re: [Qemu-block] [Qemu-devel] [PATCH v2 13/14] commit: Use BlockBackend for I/O

On 05/24/2016 09:47 PM, Kevin Wolf wrote: +s->base = blk_new(); blk_new(errp); +blk_insert_bs(s->base, base); + +s->top = blk_new(); blk_new(errp);

Re: [Qemu-block] [Qemu-devel] [PATCH v2 12/14] backup: Use BlockBackend for I/O

On 05/24/2016 09:47 PM, Kevin Wolf wrote: +job->target = blk_new(); blk_new(errp);

Re: [Qemu-block] [Qemu-devel] [PATCH v2 04/14] block: Convert block job core to BlockBackend

On 05/24/2016 09:47 PM, Kevin Wolf wrote: +blk = blk_new(); blk_new(errp);

Re: [Qemu-block] [Qemu-devel] [PATCH v2 08/14] mirror: Use BlockBackend for I/O

On 05/24/2016 09:47 PM, Kevin Wolf wrote: +s->target = blk_new(); blk_new(errp);

[Qemu-block] [PATCH v19 06/10] auto complete active commit

From: Wen Congyang <we...@cn.fujitsu.com> Auto complete mirror job in background to prevent from blocking synchronously Signed-off-by: Wen Congyang <we...@cn.fujitsu.com> Signed-off-by: Changlong Xie <xiecl.f...@cn.fujitsu.com> --- block/mirror.c| 13 +++

[Qemu-block] [PATCH v19 04/10] Link backup into block core

uawei.com> Signed-off-by: Changlong Xie <xiecl.f...@cn.fujitsu.com> Reviewed-by: Stefan Hajnoczi <stefa...@redhat.com> Reviewed-by: Jeff Cody <jc...@redhat.com> --- block/Makefile.objs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/block/Makefile.objs b/block/M

[Qemu-block] [PATCH v19 07/10] Introduce new APIs to do replication operation

Signed-off-by: Wen Congyang <we...@cn.fujitsu.com> Signed-off-by: zhanghailiang <zhang.zhanghaili...@huawei.com> Signed-off-by: Gonglei <arei.gong...@huawei.com> Signed-off-by: Changlong Xie <xiecl.f...@cn.fujitsu.com> --- Makefile.objs| 1 + qa

[Qemu-block] [PATCH v19 03/10] Backup: export interfaces for extra serialization

); out: return ret; } Signed-off-by: Changlong Xie <xiecl.f...@cn.fujitsu.com> Signed-off-by: Wen Congyang <we...@cn.fujitsu.com> --- block/backup.c | 41 ++--- include/block/block_backup.h | 14 ++ 2 files changed,

[Qemu-block] [PATCH v19 08/10] Implement new driver for block replication

From: Wen Congyang <we...@cn.fujitsu.com> Signed-off-by: Wen Congyang <we...@cn.fujitsu.com> Signed-off-by: zhanghailiang <zhang.zhanghaili...@huawei.com> Signed-off-by: Gonglei <arei.gong...@huawei.com> Signed-off-by: Changlong Xie <xiecl.f...@cn.fujitsu.com>

[Qemu-block] [PATCH v19 01/10] unblock backup operations in backing file

From: Wen Congyang <we...@cn.fujitsu.com> Signed-off-by: Wen Congyang <we...@cn.fujitsu.com> Signed-off-by: Changlong Xie <xiecl.f...@cn.fujitsu.com> --- block.c | 17 + 1 file changed, 17 insertions(+) diff --git a/block.c b/block.c index 1205ef8..8c4c2c2 10

[Qemu-block] [PATCH v19 05/10] docs: block replication's description

From: Wen Congyang <we...@cn.fujitsu.com> Signed-off-by: Wen Congyang <we...@cn.fujitsu.com> Signed-off-by: zhanghailiang <zhang.zhanghaili...@huawei.com> Signed-off-by: Gonglei <arei.gong...@huawei.com> Signed-off-by: Changlong Xie <xiecl.f...@cn.fujitsu.com> -

[Qemu-block] [PATCH v19 10/10] support replication driver in blockdev-add

From: Wen Congyang <we...@cn.fujitsu.com> Signed-off-by: Wen Congyang <we...@cn.fujitsu.com> Signed-off-by: zhanghailiang <zhang.zhanghaili...@huawei.com> Signed-off-by: Gonglei <arei.gong...@huawei.com> Signed-off-by: Changlong Xie <xiecl.f...@cn.fujitsu.com>

[Qemu-block] [PATCH v19 02/10] Backup: clear all bitmap when doing block checkpoint

From: Wen Congyang <we...@cn.fujitsu.com> Signed-off-by: Wen Congyang <we...@cn.fujitsu.com> Signed-off-by: zhanghailiang <zhang.zhanghaili...@huawei.com> Signed-off-by: Gonglei <arei.gong...@huawei.com> Signed-off-by: Changlong Xie <xiecl.f...@cn.fujit

[Qemu-block] [PATCH v19 00/10] Block replication for continuous checkpoints

. Use Error objects to return error message 3. Address the comments from Max Reitz and Eric Blake Changlong Xie (3): Backup: export interfaces for extra serialization Introduce new APIs to do replication operation tests: add unit test case for replication Wen Congyang (7): unblock backup ope

[Qemu-block] [PATCH v19 09/10] tests: add unit test case for replication

Signed-off-by: Wen Congyang <we...@cn.fujitsu.com> Signed-off-by: Changlong Xie <xiecl.f...@cn.fujitsu.com> --- tests/.gitignore | 1 + tests/Makefile | 4 + tests/test-replication.c | 523 +++ 3 files changed, 52

[Qemu-block] [RFC] backup: export interfaces for extra serialization

6ac Mon Sep 17 00:00:00 2001 From: Changlong Xie <xiecl.f...@cn.fujitsu.com> Date: Wed, 18 May 2016 16:19:51 +0800 Subject: [PATCH] [RFC] backup: export interfaces for extra serialization Normal backup(sync='none') workflow: step 1. NBD peformance I/O write from client to server qcow2_

Re: [Qemu-block] [Qemu-devel] [PATCH v18 7/8] Implement new driver for block replication

On 05/06/2016 11:46 PM, Stefan Hajnoczi wrote: On Fri, Apr 15, 2016 at 04:10:37PM +0800, Changlong Xie wrote: +static void replication_close(BlockDriverState *bs) +{ +BDRVReplicationState *s = bs->opaque; + +if (s->mode == REPLICATION_MODE_SECONDARY) { +g_free(s-&

Re: [Qemu-block] [PATCH v18 0/8] Block replication for continuous checkpoints

On 05/06/2016 11:51 PM, Stefan Hajnoczi wrote: On Fri, Apr 15, 2016 at 04:10:30PM +0800, Changlong Xie wrote: Block replication is a very important feature which is used for continuous checkpoints(for example: COLO). You can get the detailed information about block replication from here: http

Re: [Qemu-block] [Qemu-devel] [PATCH v18 7/8] Implement new driver for block replication

On 05/06/2016 11:46 PM, Stefan Hajnoczi wrote: On Fri, Apr 15, 2016 at 04:10:37PM +0800, Changlong Xie wrote: +static void replication_close(BlockDriverState *bs) +{ +BDRVReplicationState *s = bs->opaque; + +if (s->mode == REPLICATION_MODE_SECONDARY) { +g_free(s-&

[Qemu-block] [PATCH v14 3/3] qmp: add monitor command to add/remove a child

ng <we...@cn.fujitsu.com> Signed-off-by: zhanghailiang <zhang.zhanghaili...@huawei.com> Signed-off-by: Gonglei <arei.gong...@huawei.com> Signed-off-by: Changlong Xie <xiecl.f...@cn.fujitsu.com> Reviewed-by: Max Reitz <mre...@redhat.com> Reviewed-by: Alberto Garcia <be...@iga

[Qemu-block] [PATCH v14 0/3] qapi: child add/delete support

ChangLog: v14: 1. Address commets from Betro and Max p2: introduce bdrv_drained_begin/end, rename last_index, remove redundant assert codes v13: 1. Rebase to the newest codes 2. Address commets from Betro and Max p1. Add R-B, fix incorrect syntax p2. Add missing "qemu/cutils.h" since 2.6, and

[Qemu-block] [PATCH v14 1/3] Add new block driver interface to add/delete a BDS's child

..@huawei.com> Signed-off-by: Changlong Xie <xiecl.f...@cn.fujitsu.com> Reviewed-by: Max Reitz <mre...@redhat.com> Reviewed-by: Alberto Garcia <be...@igalia.com> --- block.c | 49 +++ include/block/block.h

[Qemu-block] [PATCH v14 2/3] quorum: implement bdrv_add_child() and bdrv_del_child()

From: Wen Congyang <we...@cn.fujitsu.com> Signed-off-by: Wen Congyang <we...@cn.fujitsu.com> Signed-off-by: zhanghailiang <zhang.zhanghaili...@huawei.com> Signed-off-by: Gonglei <arei.gong...@huawei.com> Signed-off-by: Changlong Xie <xiecl.f...@cn.fujitsu.com> -

Re: [Qemu-block] [PATCH v13 2/3] quorum: implement bdrv_add_child() and bdrv_del_child()

On 05/09/2016 11:52 PM, Alberto Garcia wrote: On Wed 13 Apr 2016 10:33:08 AM CEST, Changlong Xie wrote: Sorry for the late reply! Never mind : ) The patch looks good, I have some additional comments on top of what Max Wrote, nothing serious though :) @@ -67,6 +68,9 @@ typedef struct

Re: [Qemu-block] [PATCH v13 2/3] quorum: implement bdrv_add_child() and bdrv_del_child()

On 05/06/2016 11:20 PM, Max Reitz wrote: On 13.04.2016 10:33, Changlong Xie wrote: From: Wen Congyang <we...@cn.fujitsu.com> Signed-off-by: Wen Congyang <we...@cn.fujitsu.com> Signed-off-by: zhanghailiang <zhang.zhanghaili...@huawei.com> Signed-off-by: Gonglei <arei.gong.

Re: [Qemu-block] [PATCH v18 7/8] Implement new driver for block replication

On 04/15/2016 04:10 PM, Changlong Xie wrote: From: Wen Congyang<we...@cn.fujitsu.com> Signed-off-by: Wen Congyang<we...@cn.fujitsu.com> Signed-off-by: zhanghailiang<zhang.zhanghaili...@huawei.com> Signed-off-by: Gonglei<arei.gong...@huawei.com> Signed-off-b

Re: [Qemu-block] [PATCH v18 0/8] Block replication for continuous checkpoints

The main migration code for COLO looks OK now，and they depend on my block part. So i'd like to ping here. Thanks -Xie On 04/15/2016 04:10 PM, Changlong Xie wrote: Block replication is a very important feature which is used for continuous checkpoints(for example: COLO). You can get

Re: [Qemu-block] [PATCH v13 2/3] quorum: implement bdrv_add_child() and bdrv_del_child()

ping... On 04/13/2016 04:33 PM, Changlong Xie wrote: From: Wen Congyang <we...@cn.fujitsu.com> Signed-off-by: Wen Congyang <we...@cn.fujitsu.com> Signed-off-by: zhanghailiang <zhang.zhanghaili...@huawei.com> Signed-off-by: Gonglei <arei.gong...@huawei.com> Signed-off-by

[Qemu-block] [PATCH v18 7/8] Implement new driver for block replication

From: Wen Congyang <we...@cn.fujitsu.com> Signed-off-by: Wen Congyang <we...@cn.fujitsu.com> Signed-off-by: zhanghailiang <zhang.zhanghaili...@huawei.com> Signed-off-by: Gonglei <arei.gong...@huawei.com> Signed-off-by: Changlong Xie <xiecl.f...@cn.fujitsu.com> ---

[Qemu-block] [PATCH v18 4/8] docs: block replication's description

From: Wen Congyang <we...@cn.fujitsu.com> Signed-off-by: Wen Congyang <we...@cn.fujitsu.com> Signed-off-by: zhanghailiang <zhang.zhanghaili...@huawei.com> Signed-off-by: Gonglei <arei.gong...@huawei.com> Signed-off-by: Changlong Xie <xiecl.f...@cn.fujitsu.com> -

[Qemu-block] [PATCH v18 8/8] support replication driver in blockdev-add

From: Wen Congyang <we...@cn.fujitsu.com> Signed-off-by: Wen Congyang <we...@cn.fujitsu.com> Signed-off-by: zhanghailiang <zhang.zhanghaili...@huawei.com> Signed-off-by: Gonglei <arei.gong...@huawei.com> Signed-off-by: Changlong Xie <xiecl.f...@cn.fujitsu.com>

[Qemu-block] [PATCH v18 6/8] Introduce new APIs to do replication operation

Signed-off-by: Wen Congyang <we...@cn.fujitsu.com> Signed-off-by: zhanghailiang <zhang.zhanghaili...@huawei.com> Signed-off-by: Gonglei <arei.gong...@huawei.com> Signed-off-by: Changlong Xie <xiecl.f...@cn.fujitsu.com> --- Makefile.objs| 1 + qa

[Qemu-block] [PATCH v18 1/8] unblock backup operations in backing file

From: Wen Congyang <we...@cn.fujitsu.com> Signed-off-by: Wen Congyang <we...@cn.fujitsu.com> Signed-off-by: Changlong Xie <xiecl.f...@cn.fujitsu.com> --- block.c | 17 + 1 file changed, 17 insertions(+) diff --git a/block.c b/block.c index 4bdc6b3..1e5a4fd 10

[Qemu-block] [PATCH v18 3/8] Link backup into block core

uawei.com> Signed-off-by: Changlong Xie <xiecl.f...@cn.fujitsu.com> Reviewed-by: Stefan Hajnoczi <stefa...@redhat.com> Reviewed-by: Jeff Cody <jc...@redhat.com> --- block/Makefile.objs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/block/Makefile.objs b/block/M

[Qemu-block] [PATCH v18 5/8] auto complete active commit

From: Wen Congyang <we...@cn.fujitsu.com> Auto complete mirror job in background to prevent from blocking synchronously Signed-off-by: Wen Congyang <we...@cn.fujitsu.com> Signed-off-by: Changlong Xie <xiecl.f...@cn.fujitsu.com> --- block/mirror.c| 13 +++

[Qemu-block] [PATCH v18 0/8] Block replication for continuous checkpoints

same AioContext 4. Add a testcase to test new hbitmap API V2: 1. Redesign the secondary qemu(use image-fleecing) 2. Use Error objects to return error message 3. Address the comments from Max Reitz and Eric Blake Changlong Xie (1): Introduce new APIs to do replication operation Wen Congyang (7): unbl

[Qemu-block] [PATCH v18 2/8] Backup: clear all bitmap when doing block checkpoint

From: Wen Congyang <we...@cn.fujitsu.com> Signed-off-by: Wen Congyang <we...@cn.fujitsu.com> Signed-off-by: zhanghailiang <zhang.zhanghaili...@huawei.com> Signed-off-by: Gonglei <arei.gong...@huawei.com> Signed-off-by: Changlong Xie <xiecl.f...@cn.fujitsu.com> ---

Re: [Qemu-block] [PATCH v17 7/8] Implement new driver for block replication

On 04/13/2016 09:02 PM, Stefan Hajnoczi wrote: On Mon, Apr 11, 2016 at 04:22:58PM +0800, Changlong Xie wrote: +static coroutine_fn int replication_co_writev(BlockDriverState *bs, + int64_t sector_num

Re: [Qemu-block] [PATCH v17 6/8] Introduce new APIs to do replication operation

On 04/13/2016 08:47 PM, Stefan Hajnoczi wrote: On Mon, Apr 11, 2016 at 04:22:57PM +0800, Changlong Xie wrote: +/* + * The caller of the function MUST make sure vm stopped + */ +void replication_start_all(ReplicationMode mode, Error **errp) +{ +ReplicationState *rs, *next

[Qemu-block] [PATCH v13 2/3] quorum: implement bdrv_add_child() and bdrv_del_child()

From: Wen Congyang <we...@cn.fujitsu.com> Signed-off-by: Wen Congyang <we...@cn.fujitsu.com> Signed-off-by: zhanghailiang <zhang.zhanghaili...@huawei.com> Signed-off-by: Gonglei <arei.gong...@huawei.com> Signed-off-by: Changlong Xie <xiecl.f...@cn.fujitsu.com> -

[Qemu-block] [PATCH v13 3/3] qmp: add monitor command to add/remove a child

ng <we...@cn.fujitsu.com> Signed-off-by: zhanghailiang <zhang.zhanghaili...@huawei.com> Signed-off-by: Gonglei <arei.gong...@huawei.com> Signed-off-by: Changlong Xie <xiecl.f...@cn.fujitsu.com> Reviewed-by: Max Reitz <mre...@redhat.com> Reviewed-by: Alberto Garcia <be...@iga

[Qemu-block] [PATCH v13 0/3] qapi: child add/delete support

ChangLog: v13: 1. Rebase to the newest codes 2. Address commets from Betro and Max p1. Add R-B, fix incorrect syntax p2. Add missing "qemu/cutils.h" since 2.6, and rewrite quorum_add/del_child p3. Remove unnecessary "id", add "since 2.7" v11~v12: 1. Address comments from Max p1. Add R-B p2. Add

[Qemu-block] [PATCH v13 1/3] Add new block driver interface to add/delete a BDS's child

..@huawei.com> Signed-off-by: Changlong Xie <xiecl.f...@cn.fujitsu.com> Reviewed-by: Max Reitz <mre...@redhat.com> Reviewed-by: Alberto Garcia <be...@igalia.com> --- block.c | 49 +++ include/block/block.h

[Qemu-block] [PATCH v17 2/8] Backup: clear all bitmap when doing block checkpoint

From: Wen Congyang <we...@cn.fujitsu.com> Signed-off-by: Wen Congyang <we...@cn.fujitsu.com> Signed-off-by: zhanghailiang <zhang.zhanghaili...@huawei.com> Signed-off-by: Gonglei <arei.gong...@huawei.com> Signed-off-by: Changlong Xie <xiecl.f...@cn.fujitsu.com> ---

[Qemu-block] [PATCH v17 5/8] auto complete active commit

From: Wen Congyang <we...@cn.fujitsu.com> Auto complete mirror job in background to prevent from blocking synchronously Signed-off-by: Wen Congyang <we...@cn.fujitsu.com> Signed-off-by: Changlong Xie <xiecl.f...@cn.fujitsu.com> --- block/mirror.c| 13 +++

[Qemu-block] [PATCH v17 1/8] unblock backup operations in backing file

From: Wen Congyang <we...@cn.fujitsu.com> Signed-off-by: Wen Congyang <we...@cn.fujitsu.com> Signed-off-by: Changlong Xie <xiecl.f...@cn.fujitsu.com> --- block.c | 17 + 1 file changed, 17 insertions(+) diff --git a/block.c b/block.c index 4bdc6b3..1e5a4fd 10

[Qemu-block] [PATCH v17 7/8] Implement new driver for block replication

From: Wen Congyang <we...@cn.fujitsu.com> Signed-off-by: Wen Congyang <we...@cn.fujitsu.com> Signed-off-by: zhanghailiang <zhang.zhanghaili...@huawei.com> Signed-off-by: Gonglei <arei.gong...@huawei.com> Signed-off-by: Changlong Xie <xiecl.f...@cn.fujitsu.com> ---

[Qemu-block] [PATCH v17 8/8] support replication driver in blockdev-add

From: Wen Congyang <we...@cn.fujitsu.com> Signed-off-by: Wen Congyang <we...@cn.fujitsu.com> Signed-off-by: zhanghailiang <zhang.zhanghaili...@huawei.com> Signed-off-by: Gonglei <arei.gong...@huawei.com> Signed-off-by: Changlong Xie <xiecl.f...@cn.fujitsu.com>

[Qemu-block] [PATCH v17 3/8] Link backup into block core

uawei.com> Signed-off-by: Changlong Xie <xiecl.f...@cn.fujitsu.com> Reviewed-by: Stefan Hajnoczi <stefa...@redhat.com> Reviewed-by: Jeff Cody <jc...@redhat.com> --- block/Makefile.objs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/block/Makefile.objs b/block/M

[Qemu-block] [PATCH v17 6/8] Introduce new APIs to do replication operation

Signed-off-by: Wen Congyang <we...@cn.fujitsu.com> Signed-off-by: zhanghailiang <zhang.zhanghaili...@huawei.com> Signed-off-by: Gonglei <arei.gong...@huawei.com> Signed-off-by: Changlong Xie <xiecl.f...@cn.fujitsu.com> --- Makefile.objs| 1 + qa

[Qemu-block] [PATCH v17 0/8] Block replication for continuous checkpoints

s to return error message 3. Address the comments from Max Reitz and Eric Blake Changlong Xie (1): Introduce new APIs to do replication operation Wen Congyang (7): unblock backup operations in backing file Backup: clear all bitmap when doing block checkpoint Link backup into block core

[Qemu-block] [PATCH v17 4/8] docs: block replication's description

From: Wen Congyang <we...@cn.fujitsu.com> Signed-off-by: Wen Congyang <we...@cn.fujitsu.com> Signed-off-by: zhanghailiang <zhang.zhanghaili...@huawei.com> Signed-off-by: Gonglei <arei.gong...@huawei.com> Signed-off-by: Changlong Xie <xiecl.f...@cn.fujitsu.com> -

Re: [Qemu-block] [PATCH v12 2/3] quorum: implement bdrv_add_child() and bdrv_del_child()

On 03/30/2016 11:07 PM, Max Reitz wrote: On 30.03.2016 13:39, Alberto Garcia wrote: On Tue 29 Mar 2016 05:51:22 PM CEST, Max Reitz wrote: It sounds like the argument here, and in Max's thread on query-block-node-tree, is that we DO have cases where order matters, and so we need a way for the

Re: [Qemu-block] [PATCH v16 2/8] Backup: clear all bitmap when doing block checkpoint

On 03/17/2016 02:48 AM, Jeff Cody wrote: On Fri, Mar 11, 2016 at 06:34:09PM +0800, Changlong Xie wrote: From: Wen Congyang <we...@cn.fujitsu.com> Signed-off-by: Wen Congyang <we...@cn.fujitsu.com> Signed-off-by: zhanghailiang <zhang.zhanghaili...@huawei.com> Signed-off-by:

Re: [Qemu-block] [PATCH v12 2/3] quorum: implement bdrv_add_child() and bdrv_del_child()

On 03/11/2016 08:21 PM, Alberto Garcia wrote: On Thu 10 Mar 2016 03:49:40 AM CET, Changlong Xie wrote: @@ -81,6 +82,8 @@ typedef struct BDRVQuorumState { bool rewrite_corrupted;/* true if the driver must rewrite-on-read corrupted * block if Quorum is reached

Re: [Qemu-block] [Qemu-devel] [PATCH] quorum: Fix crash in quorum_aio_cb()

On 03/11/2016 04:25 PM, Alberto Garcia wrote: On Fri 11 Mar 2016 02:31:31 AM CET, Wen Congyang wrote: On 03/10/2016 08:13 PM, Alberto Garcia wrote: quorum_aio_cb() emits the QUORUM_REPORT_BAD event if there's an I/O error in a Quorum child. However sacb->aiocb must be correctly initialized for

Re: [Qemu-block] [PATCH v12 2/3] quorum: implement bdrv_add_child() and bdrv_del_child()

On 03/11/2016 08:21 PM, Alberto Garcia wrote: On Thu 10 Mar 2016 03:49:40 AM CET, Changlong Xie wrote: @@ -81,6 +82,8 @@ typedef struct BDRVQuorumState { bool rewrite_corrupted;/* true if the driver must rewrite-on-read corrupted * block if Quorum is reached

[Qemu-block] [PATCH v16 4/8] docs: block replication's description

From: Wen Congyang <we...@cn.fujitsu.com> Signed-off-by: Wen Congyang <we...@cn.fujitsu.com> Signed-off-by: zhanghailiang <zhang.zhanghaili...@huawei.com> Signed-off-by: Gonglei <arei.gong...@huawei.com> Signed-off-by: Changlong Xie <xiecl.f...@cn.fujitsu.com> -

[Qemu-block] [PATCH v16 6/8] Introduce new APIs to do replication operation

Signed-off-by: Wen Congyang <we...@cn.fujitsu.com> Signed-off-by: zhanghailiang <zhang.zhanghaili...@huawei.com> Signed-off-by: Gonglei <arei.gong...@huawei.com> Signed-off-by: Changlong Xie <xiecl.f...@cn.fujitsu.com> --- Makefile.objs| 1 + qa

[Qemu-block] [PATCH v16 1/8] unblock backup operations in backing file

From: Wen Congyang <we...@cn.fujitsu.com> Signed-off-by: Wen Congyang <we...@cn.fujitsu.com> Signed-off-by: Changlong Xie <xiecl.f...@cn.fujitsu.com> --- block.c | 18 ++ 1 file changed, 18 insertions(+) diff --git a/block.c b/block.c index 0e165f9..c78cf47 10

[Qemu-block] [PATCH v16 3/8] Link backup into block core

uawei.com> Signed-off-by: Changlong Xie <xiecl.f...@cn.fujitsu.com> Reviewed-by: Stefan Hajnoczi <stefa...@redhat.com> Reviewed-by: Jeff Cody <jc...@redhat.com> --- block/Makefile.objs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/block/Makefile.objs b/block/M

[Qemu-block] [PATCH v16 0/8] Block replication for continuous checkpoints

tmap API V2: 1. Redesign the secondary qemu(use image-fleecing) 2. Use Error objects to return error message 3. Address the comments from Max Reitz and Eric Blake Changlong Xie (1): Introduce new APIs to do replication operation Wen Congyang (7): unblock backup operations in backing file Backup: cl

[Qemu-block] [PATCH v16 8/8] support replication driver in blockdev-add

From: Wen Congyang <we...@cn.fujitsu.com> Signed-off-by: Wen Congyang <we...@cn.fujitsu.com> Signed-off-by: zhanghailiang <zhang.zhanghaili...@huawei.com> Signed-off-by: Gonglei <arei.gong...@huawei.com> Signed-off-by: Changlong Xie <xiecl.f...@cn.fujitsu.com>

[Qemu-block] [PATCH v16 5/8] auto complete active commit

From: Wen Congyang <we...@cn.fujitsu.com> Auto complete mirror job in background to prevent from blocking synchronously Signed-off-by: Wen Congyang <we...@cn.fujitsu.com> Signed-off-by: Changlong Xie <xiecl.f...@cn.fujitsu.com> --- block/mirror.c| 13 +++

[Qemu-block] [PATCH v16 2/8] Backup: clear all bitmap when doing block checkpoint

From: Wen Congyang <we...@cn.fujitsu.com> Signed-off-by: Wen Congyang <we...@cn.fujitsu.com> Signed-off-by: zhanghailiang <zhang.zhanghaili...@huawei.com> Signed-off-by: Gonglei <arei.gong...@huawei.com> Signed-off-by: Changlong Xie <xiecl.f...@cn.fujitsu.com> ---

Re: [Qemu-block] [PATCH v12 1/3] Add new block driver interface to add/delete a BDS's child

On 03/10/2016 10:57 PM, Alberto Garcia wrote: On Thu 10 Mar 2016 03:49:39 AM CET, Changlong Xie wrote: From: Wen Congyang <we...@cn.fujitsu.com> In some cases, we want to take a quorum child offline, and take another child online. Signed-off-by: Wen Congyang <we...@cn.fujitsu.com>

[Qemu-block] [PATCH v12 1/3] Add new block driver interface to add/delete a BDS's child

..@huawei.com> Signed-off-by: Changlong Xie <xiecl.f...@cn.fujitsu.com> Reviewed-by: Max Reitz <mre...@redhat.com> --- block.c | 49 +++ include/block/block.h | 4 include/block/block_int.h | 5 + 3 files c

[Qemu-block] [PATCH v12 3/3] qmp: add monitor command to add/remove a child

ng <we...@cn.fujitsu.com> Signed-off-by: zhanghailiang <zhang.zhanghaili...@huawei.com> Signed-off-by: Gonglei <arei.gong...@huawei.com> Signed-off-by: Changlong Xie <xiecl.f...@cn.fujitsu.com> Reviewed-by: Max Reitz <mre...@redhat.co

[Qemu-block] [PATCH v12 0/3] qapi: child add/delete support

ChangLog: v11~v12: 1. Address comments from Max p1. Add R-B p2. Add R-B, remove unnecessary "endptr" "value" p3. Add R-B v10~v11: 1. Rebase to the newest codes 2. Address comment from Max Don't use contractions in error messages, p1: Remove R-Bs, and use "BdrvChild *child" in bdrv_del_child p2:

Re: [Qemu-block] [PATCH v11 2/3] quorum: implement bdrv_add_child() and bdrv_del_child()

On 03/10/2016 02:11 AM, Max Reitz wrote: On 09.03.2016 04:51, Changlong Xie wrote: From: Wen Congyang <we...@cn.fujitsu.com> Signed-off-by: Wen Congyang <we...@cn.fujitsu.com> Signed-off-by: zhanghailiang <zhang.zhanghaili...@huawei.com> Signed-off-by: Gonglei <arei.gong.

Re: [Qemu-block] [Qemu-devel] [PATCH v15 8/9] Implement new driver for block replication

On 03/05/2016 01:53 AM, Stefan Hajnoczi wrote: On Fri, Feb 05, 2016 at 12:18:07PM +0800, Changlong Xie wrote: +static void secondary_do_checkpoint(BDRVReplicationState *s, Error **errp) +{ +Error *local_err = NULL; +int ret; + +if (!s->secondary_disk->bs->job) { +e

[Qemu-block] [PATCH v11 2/3] quorum: implement bdrv_add_child() and bdrv_del_child()

From: Wen Congyang <we...@cn.fujitsu.com> Signed-off-by: Wen Congyang <we...@cn.fujitsu.com> Signed-off-by: zhanghailiang <zhang.zhanghaili...@huawei.com> Signed-off-by: Gonglei <arei.gong...@huawei.com> Signed-off-by: Changlong Xie <xiecl.f...@cn.fujitsu.com> --

[Qemu-block] [PATCH v11 1/3] Add new block driver interface to add/delete a BDS's child

..@huawei.com> Signed-off-by: Changlong Xie <xiecl.f...@cn.fujitsu.com> --- block.c | 49 +++ include/block/block.h | 4 include/block/block_int.h | 5 + 3 files changed, 58 insertions(+) diff --git a/block.c b/

[Qemu-block] [PATCH v11 3/3] qmp: add monitor command to add/remove a child

ng <we...@cn.fujitsu.com> Signed-off-by: zhanghailiang <zhang.zhanghaili...@huawei.com> Signed-off-by: Gonglei <arei.gong...@huawei.com> Signed-off-by: Changlong Xie <xiecl.f...@cn.fujitsu.com> --- blockdev.c | 55 +

[Qemu-block] [PATCH v11 0/3] qapi: child add/delete support

ChangLog: v10~v11: 1. Rebase to the newest codes 2. Address comment from Max Don't use contractions in error messages, p1: Remove R-Bs, and use "BdrvChild *child" in bdrv_del_child p2: Fix error logic in get_new_child_index/remove_child_index, and prefect child->name parsing p3: Make

Re: [Qemu-block] [Qemu-devel] [PATCH v15 8/9] Implement new driver for block replication

On 03/05/2016 01:39 AM, Stefan Hajnoczi wrote: On Fri, Feb 05, 2016 at 12:18:07PM +0800, Changlong Xie wrote: +static void replication_start(ReplicationState *rs, ReplicationMode mode, + Error **errp) +{ +BlockDriverState *bs = rs->opa

Re: [Qemu-block] [Qemu-devel] [PATCH v15 8/9] Implement new driver for block replication

On 03/05/2016 01:53 AM, Stefan Hajnoczi wrote: On Fri, Feb 05, 2016 at 12:18:07PM +0800, Changlong Xie wrote: +static void secondary_do_checkpoint(BDRVReplicationState *s, Error **errp) +{ +Error *local_err = NULL; +int ret; + +if (!s->secondary_disk->bs->job) { +e

Re: [Qemu-block] [Qemu-devel] [PATCH v15 8/9] Implement new driver for block replication

On 03/05/2016 01:39 AM, Stefan Hajnoczi wrote: On Fri, Feb 05, 2016 at 12:18:07PM +0800, Changlong Xie wrote: +static void replication_start(ReplicationState *rs, ReplicationMode mode, + Error **errp) +{ +BlockDriverState *bs = rs->opa

Re: [Qemu-block] [PATCH v15 7/9] Introduce new APIs to do replication operation

On 03/05/2016 12:13 AM, Stefan Hajnoczi wrote: On Fri, Feb 05, 2016 at 12:18:06PM +0800, Changlong Xie wrote: diff --git a/replication.h b/replication.h new file mode 100644 index 000..faea649 --- /dev/null +++ b/replication.h @@ -0,0 +1,53 @@ +/* + * Replication filter + * + * Copyright (c

Re: [Qemu-block] [PATCH v10 2/3] quorum: implement bdrv_add_child() and bdrv_del_child()

On 03/08/2016 12:02 AM, Max Reitz wrote: On 07.03.2016 17:02, Eric Blake wrote: On 03/05/2016 11:13 AM, Max Reitz wrote: +index = atoi(child->name + 9); Optional: Assert absence of an error: Indeed, atoi() is worthless, because it cannot do error detection. unsigned long index;

Re: [Qemu-block] [PATCH v10 2/3] quorum: implement bdrv_add_child() and bdrv_del_child()

On 03/08/2016 12:02 AM, Eric Blake wrote: On 03/05/2016 11:13 AM, Max Reitz wrote: +index = atoi(child->name + 9); Optional: Assert absence of an error: Indeed, atoi() is worthless, because it cannot do error detection. unsigned long index; char *endptr; index = strtoul(child->name

Re: [Qemu-block] [PATCH v10 1/3] Add new block driver interface to add/delete a BDS's child

On 03/06/2016 01:27 AM, Max Reitz wrote: Sorry that I wasn't so pedantic last time; or maybe I should rather be sorry that I'm so pedantic this time. Hi Max Welcome all your comments : ) On 16.02.2016 10:37, Changlong Xie wrote: From: Wen Congyang <we...@cn.fujitsu.com> I

Re: [Qemu-block] [Qemu-devel] [PATCH v15 0/9] Block replication for continuous checkpoints

Ping again ... Thanks -Xie On 02/05/2016 12:17 PM, Changlong Xie wrote: Block replication is a very important feature which is used for continuous checkpoints(for example: COLO). You can get the detailed information about block replication from here: http://wiki.qemu.org/Features

[Qemu-block] [PATCH v10 2/3] quorum: implement bdrv_add_child() and bdrv_del_child()

From: Wen Congyang <we...@cn.fujitsu.com> Signed-off-by: Wen Congyang <we...@cn.fujitsu.com> Signed-off-by: zhanghailiang <zhang.zhanghaili...@huawei.com> Signed-off-by: Gonglei <arei.gong...@huawei.com> Signed-off-by: Changlong Xie <xiecl.f...@cn.fujitsu.com> --

[Qemu-block] [PATCH v10 3/3] qmp: add monitor command to add/remove a child

ng <we...@cn.fujitsu.com> Signed-off-by: zhanghailiang <zhang.zhanghaili...@huawei.com> Signed-off-by: Gonglei <arei.gong...@huawei.com> Signed-off-by: Changlong Xie <xiecl.f...@cn.fujitsu.com> --- blockdev.c | 54 +

[Qemu-block] [PATCH v10 1/3] Add new block driver interface to add/delete a BDS's child

..@huawei.com> Signed-off-by: Changlong Xie <xiecl.f...@cn.fujitsu.com> Reviewed-by: Eric Blake <ebl...@redhat.com> Reviewed-by: Alberto Garcia <be...@igalia.com> --- block.c | 50 +++ include/block/block.h

Re: [Qemu-block] [PATCH v9 2/3] quorum: implement bdrv_add_child() and bdrv_del_child()

On 02/09/2016 01:06 AM, Alberto Garcia wrote: On Fri 22 Jan 2016 09:02:10 PM CET, "Dr. David Alan Gilbert" wrote: In general, what do you do to make sure that the data in a new Quorum child is consistent with that of the rest of the array? Quorum can have more than one

Re: [Qemu-block] [PATCH v9 3/3] qmp: add monitor command to add/remove a child

On 02/11/2016 02:02 AM, Max Reitz wrote: On 25.12.2015 10:22, Changlong Xie wrote: From: Wen Congyang <we...@cn.fujitsu.com> The new QMP command name is x-blockdev-change. It's just for adding/removing quorum's child now, and doesn't support all kinds of children, all kinds of operation

Re: [Qemu-block] [PATCH v15 7/9] Introduce new APIs to do replication operation

On 02/15/2016 08:57 AM, Hailiang Zhang wrote: On 2016/2/5 12:18, Changlong Xie wrote: Signed-off-by: Wen Congyang <we...@cn.fujitsu.com> Signed-off-by: zhanghailiang <zhang.zhanghaili...@huawei.com> Signed-off-by: Gonglei <arei.gong...@huawei.com> Signed-off-by: Chan

Re: [Qemu-block] [PATCH v13 00/10] Block replication for continuous checkpoints

On 02/04/2016 05:07 PM, Dr. David Alan Gilbert wrote: * Changlong Xie (xiecl.f...@cn.fujitsu.com) wrote: On 02/01/2016 09:18 AM, Wen Congyang wrote: On 01/29/2016 06:47 PM, Dr. David Alan Gilbert wrote: * Wen Congyang (we...@cn.fujitsu.com) wrote: On 01/29/2016 06:07 PM, Dr. David Alan

[Qemu-block] [PATCH v15 5/9] docs: block replication's description

From: Wen Congyang <we...@cn.fujitsu.com> Signed-off-by: Wen Congyang <we...@cn.fujitsu.com> Signed-off-by: zhanghailiang <zhang.zhanghaili...@huawei.com> Signed-off-by: Gonglei <arei.gong...@huawei.com> Signed-off-by: Changlong Xie <xiecl.f...@cn.fujitsu.com> -

[Qemu-block] [PATCH v15 4/9] Link backup into block core

uawei.com> Signed-off-by: Changlong Xie <xiecl.f...@cn.fujitsu.com> Reviewed-by: Stefan Hajnoczi <stefa...@redhat.com> Reviewed-by: Jeff Cody <jc...@redhat.com> --- block/Makefile.objs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/block/Makefile.objs b/block/M

[Qemu-block] [PATCH v15 8/9] Implement new driver for block replication

From: Wen Congyang <we...@cn.fujitsu.com> Signed-off-by: Wen Congyang <we...@cn.fujitsu.com> Signed-off-by: zhanghailiang <zhang.zhanghaili...@huawei.com> Signed-off-by: Gonglei <arei.gong...@huawei.com> Signed-off-by: Changlong Xie <xiecl.f...@cn.fujitsu.com>

[Qemu-block] [PATCH v15 6/9] auto complete active commit

From: Wen Congyang <we...@cn.fujitsu.com> Auto complete mirror job in background to prevent from blocking synchronously Signed-off-by: Wen Congyang <we...@cn.fujitsu.com> Signed-off-by: Changlong Xie <xiecl.f...@cn.fujitsu.com> --- block/mirror.c| 13 +++

[Qemu-block] [PATCH v15 2/9] Store parent BDS in BdrvChild

From: Wen Congyang <we...@cn.fujitsu.com> We need to access the parent BDS to get the root BDS. Signed-off-by: Wen Congyang <we...@cn.fujitsu.com> Signed-off-by: Changlong Xie <xiecl.f...@cn.fujitsu.com> --- block.c | 1 + include/block/block_int.h | 1 +

[Qemu-block] [PATCH v15 1/9] unblock backup operations in backing file

From: Wen Congyang <we...@cn.fujitsu.com> Signed-off-by: Wen Congyang <we...@cn.fujitsu.com> Signed-off-by: Changlong Xie <xiecl.f...@cn.fujitsu.com> --- block.c | 18 ++ 1 file changed, 18 insertions(+) diff --git a/block.c b/block.c index a285de5..70ab625 10

[Qemu-block] [PATCH v15 3/9] Backup: clear all bitmap when doing block checkpoint

From: Wen Congyang <we...@cn.fujitsu.com> Signed-off-by: Wen Congyang <we...@cn.fujitsu.com> Signed-off-by: zhanghailiang <zhang.zhanghaili...@huawei.com> Signed-off-by: Gonglei <arei.gong...@huawei.com> Signed-off-by: Changlong Xie <xiecl.f...@cn.fujitsu.com> ---

[Qemu-block] [PATCH v15 0/9] Block replication for continuous checkpoints

image-fleecing) 2. Use Error objects to return error message 3. Address the comments from Max Reitz and Eric Blake Changlong Xie (1): Introduce new APIs to do replication operation Wen Congyang (8): unblock backup operations in backing file Store parent BDS in BdrvChild Backup: clear all

<    1   2   3   >