On Wed, Sep 20, 2023 at 06:31:25AM -0700, Klaus Jensen wrote:
> On Sep 20 07:54, Corey Minyard wrote:
> > On Wed, Sep 20, 2023 at 12:48:03PM +0100, Jonathan Cameron via wrote:
> > > On Thu, 14 Sep 2023 11:53:40 +0200
> > > Klaus Jensen wrote:
> > >
> > &
On Wed, Sep 20, 2023 at 12:48:03PM +0100, Jonathan Cameron via wrote:
> On Thu, 14 Sep 2023 11:53:40 +0200
> Klaus Jensen wrote:
>
> > This adds a generic MCTP endpoint model that other devices may derive
> > from.
> >
> > Also included is a very basic implementation of an NVMe-MI device,
> > su
previously posted code by Padmakar Kalghatgi, Arun
> Kumar Agasar and Saurav Kumar.
This seems fine.
Acked-by: Corey Minyard
One question, though. You don't have any tests. Did you test invalid
packets and such? I think the logic is correct, but those are things
that are good to test.
derive from this and implement the class
> methods.
>
> Parts of this implementation is inspired by code[1] previously posted by
> Jonathan Cameron.
I've been kind of watching this, I guess I need to review. I've been
over the logic and it all looks good, I think. So I c
On Thu, Sep 14, 2023 at 11:53:41AM +0200, Klaus Jensen wrote:
> From: Klaus Jensen
>
> Add i2c_smbus_pec() to calculate the SMBus Packet Error Code for a
> message.
Seems fine.
Acked-by: Corey Minyard
>
> Reviewed-by: Jonathan Cameron
> Signed-off-by: Klaus Je
On Wed, May 31, 2023 at 01:47:41PM +0200, Klaus Jensen wrote:
> From: Klaus Jensen
>
> This adds a generic MCTP endpoint model that other devices may derive
> from. I'm not 100% happy with the design of the class methods, but it's
> a start.
>
> Also included is a very basic implementation of an
On Wed, Apr 26, 2023 at 09:11:16AM +0200, Klaus Jensen wrote:
> On Apr 25 10:19, Corey Minyard wrote:
> > On Tue, Apr 25, 2023 at 08:35:38AM +0200, Klaus Jensen wrote:
> > > From: Klaus Jensen
> > >
> > > Add an abstract MCTP over I2C endpoint model. This i
On Tue, Apr 25, 2023 at 08:35:38AM +0200, Klaus Jensen wrote:
> From: Klaus Jensen
>
> Add an abstract MCTP over I2C endpoint model. This implements MCTP
> control message handling as well as handling the actual I2C transport
> (packetization).
>
> Devices are intended to derive from this and im
On Wed, Nov 16, 2022 at 09:43:11AM +0100, Klaus Jensen wrote:
> From: Klaus Jensen
>
> Add an abstract MCTP over I2C endpoint model. This implements MCTP
> control message handling as well as handling the actual I2C transport
> (packetization).
>
> Devices are intended to derive from this and im
On Wed, Nov 16, 2022 at 09:43:10AM +0100, Klaus Jensen wrote:
> From: Klaus Jensen
>
> It is not given that the current master will release the bus after a
> transfer ends. Only schedule a pending master if the bus is idle.
>
Yes, I think this is correct.
Acked-by: Corey Minya
On Sun, Apr 12, 2020 at 11:09:53PM +0200, Philippe Mathieu-Daudé wrote:
> The OBJECT() macro is defined as:
>
> #define OBJECT(obj) ((Object *)(obj))
>
> Remove unnecessary OBJECT() casts.
For ipmi change:
Acked-by: Corey Minyard
>
> Patch created mechanically u
rmation, while the IOReadHandler
> is in-band),
> - help static code analyzers.
For the IPMI part:
Acked-by: Corey Minyard
>
> This patch was produced with the following spatch script:
>
> @match@
> expression backend, opaque, context, set_open;
> identifier
unsigned char ch)
> ibe->outbuf[ibe->outlen] = VM_ESCAPE_CHAR;
> ibe->outlen++;
> ch |= 0x10;
> -/* No break */
> -
> +/* fall through */
> default:
> ibe->outbuf[ibe->outlen] = ch;
> ibe->outlen++;
> --
> 2.20.1
>
Well, whatever, this is fine.
Acked-by: Corey Minyard
13 matches
Mail list logo
