Re: [PULL 18/20] block/nbd: drop connection_co

Am 27.09.21 um 23:55 schrieb Eric Blake: > From: Vladimir Sementsov-Ogievskiy > > OK, that's a big rewrite of the logic. > > Pre-patch we have an always running coroutine - connection_co. It does > reply receiving and reconnecting. And it leads to a lot of difficult > and unobvious code around d

Re: [PULL 18/20] block/nbd: drop connection_co

Am 02.02.22 um 15:21 schrieb Hanna Reitz: > On 02.02.22 14:53, Eric Blake wrote: >> On Wed, Feb 02, 2022 at 12:49:36PM +0100, Fabian Ebner wrote: >>> Am 27.09.21 um 23:55 schrieb Eric Blake: >>>> From: Vladimir Sementsov-Ogievskiy >>>> >>>>

[PATCH 4/4] qemu-img: dd: add -l option for loading a snapshot

Signed-off-by: Fabian Ebner --- docs/tools/qemu-img.rst | 7 --- qemu-img-cmds.hx| 4 ++-- qemu-img.c | 33 +++-- 3 files changed, 37 insertions(+), 7 deletions(-) diff --git a/docs/tools/qemu-img.rst b/docs/tools/qemu-img.rst index

[PATCH 2/4] qemu-img: dd: add isize parameter

add documenation] Signed-off-by: Fabian Ebner --- docs/tools/qemu-img.rst | 10 -- qemu-img-cmds.hx| 4 ++-- qemu-img.c | 24 +++- 3 files changed, 33 insertions(+), 5 deletions(-) diff --git a/docs/tools/qemu-img.rst b/docs/tools/qemu-img.rst

[PATCH 0/4] Make qemu-img dd more flexible

Derumier (1): qemu-img: dd: add -n option (skip target volume creation) Fabian Ebner (1): qemu-img: dd: add -l option for loading a snapshot Wolfgang Bumiller (2): qemu-img: dd: add osize and read from/to stdin/stdout qemu-img: dd: add isize parameter docs/tools/qemu-img.rst | 28

[PATCH 1/4] qemu-img: dd: add osize and read from/to stdin/stdout

ride the output file's size. Signed-off-by: Wolfgang Bumiller Signed-off-by: Thomas Lamprecht [FE: add documentation avoid error when osize is larger than input image's size fail if both count and osize are specified fail if skip is specified when reading from stdin] Signed

[PATCH 3/4] qemu-img: dd: add -n option (skip target volume creation)

] Signed-off-by: Fabian Ebner --- docs/tools/qemu-img.rst | 6 +- qemu-img-cmds.hx| 4 ++-- qemu-img.c | 23 ++- 3 files changed, 21 insertions(+), 12 deletions(-) diff --git a/docs/tools/qemu-img.rst b/docs/tools/qemu-img.rst index 43328fe108..9b022d93

[PATCH v2] block/io_uring: resubmit when result is -EAGAIN

Reviewed-by: Stefano Garzarella Signed-off-by: Fabian Ebner --- Changes from v1: * Focus on what's relevant for the patch itself in the commit message. * Add Stefan's comment. * Add Stefano's R-b tag (I hope that's fine, since there was no change

Re: [PATCH 0/4] Make qemu-img dd more flexible

Am 11.02.22 um 17:42 schrieb Hanna Reitz: > On 11.02.22 17:31, Eric Blake wrote: >> On Thu, Feb 10, 2022 at 02:31:19PM +0100, Fabian Ebner wrote: >>> Adds support for reading from stdin and writing to stdout (when raw >>> format is used), as well as overriding the size

[PATCH] block/gluster: correctly set max_pdiscard which is int64_t

emu-sta...@nongnu.org Signed-off-by: Fabian Ebner --- block/gluster.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/block/gluster.c b/block/gluster.c index 398976bc66..592e71b22a 100644 --- a/block/gluster.c +++ b/block/gluster.c @@ -891,7 +891,7

Re: [PATCH] block/gluster: correctly set max_pdiscard which is int64_t

Am 06.05.22 um 17:39 schrieb Eric Blake: > On Thu, May 05, 2022 at 10:31:24AM +0200, Fabian Ebner wrote: >> Previously, max_pdiscard would be zero in the following assertion: >> qemu-system-x86_64: ../block/io.c:3166: bdrv_co_pdiscard: Assertion >> `max_pdiscard >= bs->b

[PATCH v2] block/gluster: correctly set max_pdiscard

t64_t instead of int in driver discard handlers") Cc: qemu-sta...@nongnu.org Signed-off-by: Fabian Ebner --- block/gluster.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/block/gluster.c b/block/gluster.c index 398976bc66..f711bf0bd6 100644 --- a/block/gluster.c

Re: [PATCH v2] block/gluster: correctly set max_pdiscard

Am 12.05.22 um 18:05 schrieb Stefano Garzarella: > On Thu, May 12, 2022 at 05:44:13PM +0200, Stefano Garzarella wrote: >> On Thu, May 12, 2022 at 12:30:48PM +0200, Fabian Ebner wrote: >>> On 64-bit platforms, SIZE_MAX is too large for max_pdiscard, which is >> >> The

[PATCH v3] block/gluster: correctly set max_pdiscard

n question, so it is kept as is. And since max_pdiscard is still <= SIZE_MAX, relying on max_pdiscard is still fine. Fixes: 0c8022876f ("block: use int64_t instead of int in driver discard handlers") Cc: qemu-sta...@nongnu.org Signed-off-by: Fabian Ebner --- v2 -> v3: * Kee