Re: [PATCH for-8.0] nbd/server: Request TCP_NODELAY

2023-03-27 Thread Florian Westphal
ab.com/nbdkit/nbdkit/-/blob/45b72f5b/server/sockets.c#L430 > > CC: Florian Westphal > Signed-off-by: Eric Blake > --- > nbd/server.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/nbd/server.c b/nbd/server.c > index a4750e41880..976223860bf 100644 > --

Re: [Libguestfs] [PATCH 1/1] nbd/server: push pending frames after sending reply

2023-03-24 Thread Florian Westphal
Eric Blake wrote: > On Fri, Mar 24, 2023 at 02:41:20PM -0500, Eric Blake wrote: > > On Fri, Mar 24, 2023 at 11:47:20AM +0100, Florian Westphal wrote: > > > qemu-nbd doesn't set TCP_NODELAY on the tcp socket. > > Replying to myself, WHY aren't we setting T

Re: [PATCH 1/1] nbd/server: push pending frames after sending reply

2023-03-24 Thread Florian Westphal
Kevin Wolf wrote: > Am 24.03.2023 um 11:47 hat Florian Westphal geschrieben: > > +qio_channel_set_cork(client->ioc, true); > > + > > if (ret < 0) { > > /* It wasn't -EIO, so, according to nbd_co_receive_request() > >

[PATCH 1/1] nbd/server: push pending frames after sending reply

2023-03-24 Thread Florian Westphal
s, with tls: 15s VM Boot time, qemu-nbd via network (same lan): main:no tls: 18s, with tls: 1m50s patched: no tls: 17s, with tls: 18s Future optimization: if we could detect if there is another pending request we could defer the uncork operation because more data would be appended. Signed-off-