Re: [PATCH for-5.2 v2 9/9] tests/qtest/cdrom: Add more s390x-related boot tests

2020-08-06 Thread Janosch Frank
90-ccw bios used to fail when other unbootable devices have > been specified before the bootable device (without "bootindex"). Now > that the s390-ccw bios is a little bit smarter here, we should test > this scenario, too, to avoid regressions. > > Signed-off-by: Thomas Hu

Re: [PATCH for-5.2 v2 4/9] pc-bios/s390-ccw: Move the inner logic of find_subch() to a separate function

2020-08-06 Thread Janosch Frank
On 8/6/20 12:53 PM, Thomas Huth wrote: > Move the code to a separate function to be able to re-use it from a > different spot later. > > Reviewed-by: Claudio Imbrenda > Signed-off-by: Thomas Huth The new function name helps a lot :) Reviewed-by: Janosch Frank > --- &

Re: [PATCH for-5.2 v2 3/9] pc-bios/s390-ccw: Introduce ENODEV define and remove guards of others

2020-08-06 Thread Janosch Frank
ay, then it's better to see the error at compile time instead > of hunting weird behavior during runtime later. > Also define ENODEV - we will use this in a later patch. > > Signed-off-by: Thomas Huth Would it make sense to use the errno.h numbers for the defines? Reviewed-by: Ja

Re: [Qemu-block] [Qemu-devel] [PATCH 9/9] iotests.py: use io.StringIO with python3

2017-12-20 Thread Janosch Frank
On 19.12.2017 18:34, Philippe Mathieu-Daudé wrote: > Signed-off-by: Philippe Mathieu-Daudé > --- > tests/qemu-iotests/iotests.py | 7 +-- > 1 file changed, 5 insertions(+), 2 deletions(-) > > diff --git a/tests/qemu-iotests/iotests.py b/tests/qemu-iotests/iotests.py > index 4c515d2e6c..0e1b8