[Qemu-block] [PATCH v2 for-2.10 0/4] VHDX bugfixes

eck for overflow in offset prior to calling bdrv_truncate(). Jeff Cody (4): block/vhdx: check error return of bdrv_getlength() block/vhdx: check for offset overflow to bdrv_truncate() block/vhdx: check error return of bdrv_flush() block/vhdx: check error return of bdrv_truncate() block/vhdx-lo

[Qemu-block] [PATCH v2 for-2.10 4/4] block/vhdx: check error return of bdrv_truncate()

Signed-off-by: Jeff Cody <jc...@redhat.com> --- block/vhdx-log.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/block/vhdx-log.c b/block/vhdx-log.c index a27dc05..14b724e 100644 --- a/block/vhdx-log.c +++ b/block/vhdx-log.c @@ -558,7 +558,11 @@ static int vhdx_log

Re: [Qemu-block] [PATCH 1/2] block/vhdx: check error return of bdrv_getlength()

On Mon, Aug 07, 2017 at 12:46:30PM +0200, Kevin Wolf wrote: > Am 07.08.2017 um 05:08 hat Jeff Cody geschrieben: > > Calls to bdrv_getlength() were not checking for error. In vhdx.c, this > > can lead to truncating an image file, so it is a definite bug. In > > vhdx-log.c,

Re: [Qemu-block] [Qemu-devel] [PATCH 2/2] block/vhdx: check for offset overflow to bdrv_truncate()

On Mon, Aug 07, 2017 at 06:24:30AM -0500, Eric Blake wrote: > On 08/06/2017 10:08 PM, Jeff Cody wrote: > > VHDX uses uint64_t types for most offsets, following the VHDX spec. > > However, bdrv_truncate() takes an int64_t value for the truncating > > offset. Check for ov

[Qemu-block] [PATCH 2/2] block/vhdx: check for offset overflow to bdrv_truncate()

the spec to be 64TB. Signed-off-by: Jeff Cody <jc...@redhat.com> --- block/vhdx-log.c | 4 block/vhdx.c | 3 +++ 2 files changed, 7 insertions(+) diff --git a/block/vhdx-log.c b/block/vhdx-log.c index fd4e7af..3b74e5d 100644 --- a/block/vhdx-log.c +++ b/block/vhdx-log.c @@ -554,6 +

[Qemu-block] [PATCH 0/2] VHDX cleanup

Two VHDX items cleaned up: 1. Check for error when calling bdrv_getlength() [Markus] 2. Check for overflow in offset prior to calling bdrv_truncate(). Jeff Cody (2): block/vhdx: check error return of bdrv_getlength() block/vhdx: check for offset overflow to bdrv_truncate() block/vhdx

[Qemu-block] [PATCH 1/2] block/vhdx: check error return of bdrv_getlength()

ed-off-by: Jeff Cody <jc...@redhat.com> --- block/vhdx-log.c | 20 block/vhdx.c | 9 - 2 files changed, 24 insertions(+), 5 deletions(-) diff --git a/block/vhdx-log.c b/block/vhdx-log.c index 01278f3..fd4e7af 100644 --- a/block/vhdx-log.c +++ b/block/vhdx-log

Re: [Qemu-block] [PATCH v2] qemu-img: Clarify about relative backing file options

{filename}. > + > @var{cache} specifies the cache mode to be used for @var{filename}, whereas > @var{src_cache} specifies the cache mode for reading backing files. > > -- > 2.13.3 > > Reviewed-by: Jeff Cody <jc...@redhat.com>

Re: [Qemu-block] [PATCH] block/null: Remove 'filename' option

.bdrv_file_open = null_file_open, > +.bdrv_parse_filename= null_co_parse_filename, > .bdrv_close = null_close, > .bdrv_getlength = null_getlength, > > @@ -261,6 +281,7 @@ static BlockDriver bdrv_null_aio = { > .instance_size = sizeof(BDRVNullState), > > .bdrv_file_open = null_file_open, > +.bdrv_parse_filename= null_aio_parse_filename, > .bdrv_close = null_close, > .bdrv_getlength = null_getlength, > > -- > 2.13.3 > > Reviewed-by: Jeff Cody <jc...@redhat.com>

Re: [Qemu-block] Is the use of bdrv_getlength() in vhdx*.c kosher?

On Fri, Aug 04, 2017 at 02:49:42PM +0200, Markus Armbruster wrote: > bdrv_getlength() can fail. There are several calls in vhdx*.c that > don't seem to check. Bug or not? Most definitely a bug. Shall I queue up some patches, or do you already have some?

Re: [Qemu-block] [PATCH for-2.10 5/5] qemu-iotests: Test reopen between read-only and read-write

> +here=`pwd` > +status=1 # failure is the default! > + > +_cleanup() > +{ > + _cleanup_test_img > +rm -f "$TEST_IMG.2" > + rm -f "$TEST_IMG.3" > +} > +trap "_cleanup; exit \$status" 0 1 2 3 15 > + As Eric noted, I'll need

Re: [Qemu-block] [PATCH for-2.10 4/5] qemu-io: Allow reopen read-write

RDWR; > +has_rw_option = true; > +break; > +case 'w': > +if (has_rw_option) { > +error_report("Only one -r/-w option may be given"); > +return 0; > +} > +flags |= BDRV_O_RDWR; > +has_rw_option = true; > break; > default: > qemu_opts_reset(_opts); > -- > 2.13.3 > > Reviewed-by: Jeff Cody <jc...@redhat.com>

Re: [Qemu-block] [PATCH for-2.10 3/5] block: Set BDRV_O_ALLOW_RDWR during rw reopen

COL; > +if (flags & BDRV_O_RDWR) { > +flags |= BDRV_O_ALLOW_RDWR; > +} > > QLIST_FOREACH(child, >children, next) { > QDict *new_child_options; > -- > 2.13.3 > > Reviewed-by: Jeff Cody <jc...@redhat.com>

Re: [Qemu-block] [PATCH for-2.10 2/5] block: Allow reopen rw without BDRV_O_ALLOW_RDWR

n_flags & BDRV_O_INACTIVE); > } > > -int bdrv_can_set_read_only(BlockDriverState *bs, bool read_only, Error > **errp) > +int bdrv_can_set_read_only(BlockDriverState *bs, bool read_only, > + bool ignore_allow_rdw, Error **errp) I think 'ove

Re: [Qemu-block] [PATCH for-2.10 1/5] block: Fix order in bdrv_replace_child()

t; @@ -1942,8 +1944,6 @@ static void bdrv_replace_child(BdrvChild *child, > BlockDriverState *new_bs) > bdrv_set_perm(old_bs, perm, shared_perm); > } > > -bdrv_replace_child_noperm(child, new_bs); > - > if (new_bs) { > bdrv_get_cumulative_per

Re: [Qemu-block] [PATCH 1/1] qemu-iotests/109: Fix lock race condition

will then > attempt to open the TEST_IMG file before it can secure a lock on it. > > This attempts a more graceful shutdown, and waits for the QEMU process > to exit. > > Signed-off-by: Cleber Rosa <cr...@redhat.com> Reviewed-by: Jeff Cody <jc...@redhat.com> >

Re: [Qemu-block] [Qemu-devel] [PATCH v2 for-2.11 3/3] qemu-iotests: add option to save temp files on error

On Tue, Aug 01, 2017 at 08:34:01AM +0200, Markus Armbruster wrote: > Jeff Cody <jc...@redhat.com> writes: > > > Now that ./check takes care of cleaning up after each tests, it > > can also selectively not clean up. Add option to leave all output from > > tests i

Re: [Qemu-block] [PATCH v3] qemu-iotests: add a "how to" to ./README

.ac.in> > Reviewed-by: Eric Blake <ebl...@redhat.com> > Reviewed-by: Philippe Mathieu-Daudé <f4...@amsat.org> > Signed-off-by: Stefan Hajnoczi <stefa...@redhat.com> Reviewed-by: Jeff Cody <jc...@redhat.com> > --- > v3: > * Explicitly mention sou

Re: [Qemu-block] [Qemu-devel] [PATCH for-2.10] block/qapi: Remove redundat NULL check to silence Coverity

On Mon, Jul 31, 2017 at 11:54:57AM -0300, Philippe Mathieu-Daudé wrote: > On 07/31/2017 11:38 AM, Jeff Cody wrote: > >On Mon, Jul 31, 2017 at 02:51:11PM +0200, Kevin Wolf wrote: > >>When skipping implicit nodes in bdrv_block_device_info(), we know that > >>bs0 is

Re: [Qemu-block] [PATCH v2 for-2.11 1/3] qemu-iotests: set TEST_DIR to a unique dir for each test

On Mon, Jul 31, 2017 at 09:44:13AM -0500, Eric Blake wrote: > On 07/31/2017 08:47 AM, Jeff Cody wrote: > > Right now, all qemu-iotests output data into the same scratch directory, > > and so each tests needs to be responsible for cleanup up its own files. > > s/cleanup up/c

Re: [Qemu-block] [Qemu-devel] [PATCH for-2.10] block/qapi: Remove redundat NULL check to silence Coverity

gned-off-by: Kevin Wolf <kw...@redhat.com> Reviewed-by: Jeff Cody <jc...@redhat.com> > --- > block/qapi.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/block/qapi.c b/block/qapi.c > index d2b18ee9df..5f1a71f5d2 100644 >

[Qemu-block] [PATCH v2 for-2.11 3/3] qemu-iotests: add option to save temp files on error

. Reviewed-by: Eric Blake <ebl...@redhat.com> Signed-off-by: Jeff Cody <jc...@redhat.com> --- tests/qemu-iotests/check | 5 - tests/qemu-iotests/common | 6 ++ 2 files changed, 10 insertions(+), 1 deletion(-) diff --git a/tests/qemu-iotests/check b/tests/qemu-iotests/check i

[Qemu-block] [PATCH v2 for-2.11 2/3] qemu-iotests: remove file cleanup from bash tests

eanup_qemu. Signed-off-by: Jeff Cody <jc...@redhat.com> --- tests/qemu-iotests/001 | 6 -- tests/qemu-iotests/002 | 6 -- tests/qemu-iotests/003 | 6 -- tests/qemu-iotests/004 | 6 -- tests/qemu-iotests/005 | 6 -- tests/qemu-iotests/007 |

[Qemu-block] [PATCH v2 for-2.11 1/3] qemu-iotests: set TEST_DIR to a unique dir for each test

-by: Eric Blake <ebl...@redhat.com> Signed-off-by: Jeff Cody <jc...@redhat.com> --- tests/qemu-iotests/check | 21 + 1 file changed, 17 insertions(+), 4 deletions(-) diff --git a/tests/qemu-iotests/check b/tests/qemu-iotests/check index 2a55ec9..7a21ef6 100755 ---

[Qemu-block] [PATCH v2 for-2.11 0/3] qemu-iotests: place output in unique dir

rently only for Bash tests, as the Python tests still cleanup up after themselves. Jeff Cody (3): qemu-iotests: set TEST_DIR to a unique dir for each test qemu-iotests: remove file cleanup from bash tests qemu-iotests: add option to save temp files on error tests/qemu-iotests/001 | 6 --

Re: [Qemu-block] [Qemu-devel] [PATCH for-2.11 2/3] qemu-iotests: remove file cleanup from bash tests

On Mon, Jul 31, 2017 at 07:20:03AM -0500, Eric Blake wrote: > On 07/31/2017 12:04 AM, Jeff Cody wrote: > > All files for a given test are now self-contained in a subdirectory, > > and therefore the "./check" script can do all file-related cleanup > > without any h

[Qemu-block] [PATCH for-2.11 2/3] qemu-iotests: remove file cleanup from bash tests

eanup_qemu. Signed-off-by: Jeff Cody <jc...@redhat.com> --- tests/qemu-iotests/001 | 6 -- tests/qemu-iotests/002 | 6 -- tests/qemu-iotests/003 | 6 -- tests/qemu-iotests/004 | 6 -- tests/qemu-iotests/005 | 6 -- tests/qemu-iotests/007 |

[Qemu-block] [PATCH for-2.11 3/3] qemu-iotests: add option to save temp files on error

. Signed-off-by: Jeff Cody <jc...@redhat.com> --- tests/qemu-iotests/check | 5 - tests/qemu-iotests/common | 6 ++ 2 files changed, 10 insertions(+), 1 deletion(-) diff --git a/tests/qemu-iotests/check b/tests/qemu-iotests/check index 20cb93d..48d206c 100755 --- a/tests/qemu-iotests

[Qemu-block] [PATCH for-2.11 1/3] qemu-iotests: set TEST_DIR to a unique dir for each test

-off-by: Jeff Cody <jc...@redhat.com> --- tests/qemu-iotests/check | 21 + 1 file changed, 17 insertions(+), 4 deletions(-) diff --git a/tests/qemu-iotests/check b/tests/qemu-iotests/check index 2a55ec9..20cb93d 100755 --- a/tests/qemu-iotests/check +++ b/tests/qemu-iotests

[Qemu-block] [PATCH for-2.11 0/3] qemu-iotests: place output in unique dir

still cleanup up after themselves. Jeff Cody (3): qemu-iotests: set TEST_DIR to a unique dir for each test qemu-iotests: remove file cleanup from bash tests qemu-iotests: add option to save temp files on error tests/qemu-iotests/001 | 6 -- tests/qemu-iotests/002 | 6

Re: [Qemu-block] [Qemu-devel] [PATCH for-2.10 7/7] qemu-iotests/059: Fix leaked image files

ing afl image with a very large capacity === > qemu-img: Can't get image size 'TEST_DIR/afl9.IMGFMT': File too large > diff --git a/tests/qemu-iotests/common.rc b/tests/qemu-iotests/common.rc > index 2548e58b99..bfbc80e5f6 100644 > --- a/tests/qemu-iotests/common.rc > +++ b/tests/qemu-iotests/common.rc > @@ -92,6 +92,7 @@ else > TEST_IMG=$IMGPROTO:$TEST_DIR/t.$IMGFMT > fi > fi > +ORIG_TEST_IMG="$TEST_IMG" > > _optstr_add() > { > @@ -228,6 +229,8 @@ _cleanup_test_img() > if [ -n "$SAMPLE_IMG_FILE" ] > then > rm -f "$TEST_DIR/$SAMPLE_IMG_FILE" > +SAMPLE_IMG_FILE= > +TEST_IMG="$ORIG_TEST_IMG" > fi > ;; > > -- > 2.13.3 > > You aren't kidding; I did a before and after test while reviewing, and it left 518 (mostly empty) images behind before! Reviewed-by: Jeff Cody <jc...@redhat.com>

Re: [Qemu-block] [Qemu-devel] [PATCH for-2.10 1/7] qemu-iotests/041: Fix leaked scratch images

tearDown(self): > self.vm.shutdown() > -for i in self.IMAGES + [ quorum_repair_img ]: > +for i in self.IMAGES + [ quorum_repair_img, quorum_snapshot_file ]: > # Do a try/except because the test may have deleted some images > try: > os.remove(i) > -- > 2.13.3 > > Reviewed-by: Jeff Cody <jc...@redhat.com>

Re: [Qemu-block] [Qemu-devel] [PATCH for-2.10 6/7] qemu-iotests/063: Fix leaked image

rap "_cleanup; exit \$status" 0 1 2 3 15 > > @@ -91,8 +91,6 @@ if $QEMU_IMG convert -f $IMGFMT -O $IMGFMT -n > "$TEST_IMG.orig" "$TEST_IMG" >/dev > exit 1 > fi > > -rm -f "$TEST_IMG.orig" "$TEST_IMG.raw" "$TEST_IMG.raw2" > - > echo "*** done" > rm -f $seq.full > status=0 > -- > 2.13.3 > > Reviewed-by: Jeff Cody <jc...@redhat.com>

Re: [Qemu-block] [Qemu-devel] [PATCH for-2.10 5/7] qemu-iotests/162: Fix leaked temporary files

1 2 3 15 > + > # get standard environment, filters and checks > . ./common.rc > . ./common.filter > -- > 2.13.3 > > Reviewed-by: Jeff Cody <jc...@redhat.com>

Re: [Qemu-block] [Qemu-devel] [PATCH for-2.10 3/7] qemu-iotests/141: Fix image cleanup

/qemu-iotests/141 > +++ b/tests/qemu-iotests/141 > @@ -31,7 +31,7 @@ _cleanup() > { > _cleanup_qemu > _cleanup_test_img > -rm -f "$TEST_DIR/{b,m,o}.$IMGFMT" > +rm -f "$TEST_DIR"/{b,m,o}.$IMGFMT > } > trap "_cleanup; exit \$status" 0 1 2 3 15 > > -- > 2.13.3 > > Reviewed-by: Jeff Cody <jc...@redhat.com>

Re: [Qemu-block] [Qemu-devel] [PATCH for-2.10 4/7] qemu-iotests/153: Fix leaked scratch images

; > rm -f "${TEST_IMG}.a" > rm -f "${TEST_IMG}.b" > +rm -f "${TEST_IMG}.c" > rm -f "${TEST_IMG}.lnk" > } > trap "_cleanup; exit \$status" 0 1 2 3 15 > -- > 2.13.3 > > Reviewed-by: Jeff Cody <jc...@redhat.com>

Re: [Qemu-block] [Qemu-devel] [PATCH for-2.10 2/7] qemu-iotests: Remove blkdebug.conf after tests

8db8fe0..115944a753 100755 > --- a/tests/qemu-iotests/179 > +++ b/tests/qemu-iotests/179 > @@ -30,6 +30,7 @@ status=1# failure is the default! > _cleanup() > { > _cleanup_test_img > +rm -f "$TEST_DIR/blkdebug.conf" > } > trap "_cleanup; exit \$status" 0 1 2 3 15 > > -- > 2.13.3 > > Reviewed-by: Jeff Cody <jc...@redhat.com>

Re: [Qemu-block] [Qemu-devel] [PATCH 2/2] iotests: Redirect stderr to stdout in 186

gt; Testing: -drive if=scsi,driver=null-co,media=cdrom > QEMU X.Y.Z monitor - type 'help' for more information > -(qemu) info block > +(qemu) QEMU_PROG: -drive if=scsi,driver=null-co,media=cdrom: warning: > bus=0,unit=0 is deprecated with this machine type > +info block > scsi0-cd0 (NODE_NAME): null-co:// (null-co, read-only) > Attached to: /machine/unattached/device[27]/scsi.0/legacy[0] > Removable device: not locked, tray closed > -- > 2.9.4 > > Reviewed-by: Jeff Cody <jc...@redhat.com>

Re: [Qemu-block] [Qemu-devel] [PATCH 1/2] iotests: Fix test 156

ay" _make_test_img -b "$TEST_IMG.target" 1M > +TEST_IMG="$TEST_IMG.target.overlay" _make_test_img -u -b "$TEST_IMG.target" > 1M > > # Mirror snapshot > _send_qemu_cmd $QEMU_HANDLE \ > -- > 2.9.4 > > Reviewed-by: Jeff Cody <jc...@redhat.com>

Re: [Qemu-block] [PATCH] qemu-iotests: add a "how to" to ./README

On Fri, Jul 21, 2017 at 10:34:16AM +0100, Stefan Hajnoczi wrote: > There is not much getting started documentation for qemu-iotests. This > patch explains how to create a new test and covers the overall testing > approach. > > Cc: Ishani Chugh > Signed-off-by:

Re: [Qemu-block] [PATCH] iotests: Remove a few tests from 'quick' group

oup > @@ -175,11 +175,11 @@ > 175 auto quick > 176 rw auto backing > 177 rw auto quick > -178 auto quick > +178 auto > 179 rw auto quick > 181 rw auto migration > 182 rw auto quick > 183 rw auto migration > 185 rw auto > 188 rw auto quick > -189 rw auto quick > +189 rw auto > -- > 2.13.3 > > Reviewed-by: Jeff Cody <jc...@redhat.com>

[Qemu-block] [PULL 1/2] bitmaps.md: Convert to rST; move it into 'interop' dir

Reviewed-by: Eric Blake <ebl...@redhat.com> Message-id: 20170717105205.32639-2-kcham...@redhat.com Signed-off-by: Jeff Cody <jc...@redhat.com> --- docs/devel/bitmaps.md| 505 -- docs/interop/bitmaps.rst | 555 ++

[Qemu-block] [PULL 2/2] live-block-ops.txt: Rename, rewrite, and improve it

hat.com> Reviewed-by: Eric Blake <ebl...@redhat.com> Message-id: 20170717105205.32639-3-kcham...@redhat.com Signed-off-by: Jeff Cody <jc...@redhat.com> --- docs/interop/live-block-operations.rst | 1088 docs/live-block-ops.txt| 72 --- 2 files

[Qemu-block] [PULL 0/2] Block patches

The following changes since commit ca4e667dbf431d4a2a5a619cde79d30dd2ac3eb2: Merge remote-tracking branch 'remotes/kraxel/tags/usb-20170717-pull-request' into staging (2017-07-17 17:54:17 +0100) are available in the git repository at: git://github.com/codyprime/qemu-kvm-jtc.git

Re: [Qemu-block] [PATCH v7 0/2] Rewrite 'live-block-ops.txt'; convert 'bitmaps.md' to rST

On Mon, Jul 17, 2017 at 12:52:03PM +0200, Kashyap Chamarthy wrote: > v7: Address feedback from Eric; add his 'Reviewed-by' on both patches; > also retain John Snow's 'Reviewed-by' on bitmaps.rst > v6: https://lists.nongnu.org/archive/html/qemu-devel/2017-07/msg02188.html > v5:

Re: [Qemu-block] [PATCH v2] tests: Avoid non-portable 'echo -ARG'

err=false > -echo -n "$seq" > +printf "$seq" > if [ -n "$TESTS_REMAINING_LOG" ] ; then > sed -e "s/$seq//" -e 's/ / /' -e 's/^ *//' $TESTS_REMAINING_LOG > > $TESTS_REMAINING_LOG.tmp > mv $TESTS_REMAINING_LOG.tmp $TESTS_REMAINING_LOG > @@ -281,9 +281,9 @@ do > rm -f $seq.out.bad > lasttime=`sed -n -e "/^$seq /s/.* //p" <$TIMESTAMP_FILE` > if [ "X$lasttime" != X ]; then > -echo -n " ${lasttime}s ..." > +printf " ${lasttime}s ..." > else > -echo -n ""# prettier output with timestamps. > +printf ""# prettier output with timestamps. > fi > rm -f core $seq.notrun > > @@ -291,7 +291,7 @@ do > echo "$seq" > "${TEST_DIR}"/check.sts > > start=`_wallclock` > -$timestamp && echo -n "["`date "+%T"`"]" > +$timestamp && printf "[$(date "+%T")]" > > if [ "$(head -n 1 "$source_iotests/$seq")" == "#!/usr/bin/env > python" ]; then > run_command="$PYTHON $seq" > @@ -314,21 +314,21 @@ do > > if [ -f core ] > then > -echo -n " [dumped core]" > +printf " [dumped core]" > mv core $seq.core > err=true > fi > > if [ -f $seq.notrun ] > then > -$timestamp || echo -n " [not run] " > -$timestamp && echo " [not run]" && echo -n "$seq -- " > +$timestamp || printf " [not run] " > +$timestamp && echo " [not run]" && printf "$seq -- " > cat $seq.notrun > notrun="$notrun $seq" > else > if [ $sts -ne 0 ] > then > -echo -n " [failed, exit status $sts]" > +printf " [failed, exit status $sts]" > err=true > fi > > diff --git a/tests/rocker/all b/tests/rocker/all > index d5ae963..3f9b786 100755 > --- a/tests/rocker/all > +++ b/tests/rocker/all > @@ -1,19 +1,19 @@ > -echo -n "Running port test... " > +printf "Running port test... " > ./port > if [ $? -eq 0 ]; then echo "pass"; else echo "FAILED"; exit 1; fi > > -echo -n "Running bridge test..." > +printf "Running bridge test..." > ./bridge > if [ $? -eq 0 ]; then echo "pass"; else echo "FAILED"; exit 1; fi > > -echo -n "Running bridge STP test..." > +printf "Running bridge STP test..." > ./bridge-stp > if [ $? -eq 0 ]; then echo "pass"; else echo "FAILED"; exit 1; fi > > -echo -n "Running bridge VLAN test... " > +printf "Running bridge VLAN test... " > ./bridge-vlan > if [ $? -eq 0 ]; then echo "pass"; else echo "FAILED"; exit 1; fi > > -echo -n "Running bridge VLAN STP test... " > +printf "Running bridge VLAN STP test... " > ./bridge-vlan-stp > if [ $? -eq 0 ]; then echo "pass"; else echo "FAILED"; exit 1; fi > diff --git a/tests/tcg/cris/Makefile b/tests/tcg/cris/Makefile > index 6b3dba4..6888263 100644 > --- a/tests/tcg/cris/Makefile > +++ b/tests/tcg/cris/Makefile > @@ -150,17 +150,17 @@ check_addcv17.tst: crtv10.o sysv10.o > build: $(CRT) $(SYS) $(TESTCASES) > > check: $(CRT) $(SYS) $(TESTCASES) > - @echo -e "\nQEMU simulator." > + @printf "\nQEMU simulator.\n" > for case in $(TESTCASES); do \ > - echo -n "$$case "; \ > + printf "$$case "; \ > SIMARGS=; \ > case $$case in *v17*) SIMARGS="-cpu crisv17";; esac; \ > $(SIM) $$SIMARGS ./$$case; \ > done > check-g: $(CRT) $(SYS) $(TESTCASES) > - @echo -e "\nGDB simulator." > + @printf "\nGDB simulator.\n" > @for case in $(TESTCASES); do \ > - echo -n "$$case "; \ > + printf "$$case "; \ > $(SIMG) $$case; \ > done > > -- > 2.9.4 > > Reviewed-by: Jeff Cody <jc...@redhat.com>

Re: [Qemu-block] [PATCH v4 1/2] iotests: Use absolute paths for executables

On Fri, Jun 30, 2017 at 02:45:46PM -0500, Eric Blake wrote: > On 06/30/2017 02:41 PM, Eric Blake wrote: > > > +++ 068.out.bad 2017-06-30 14:35:28.720241398 -0500 > > @@ -1,4 +1,5 @@ > > QA output created by 068 > > +realpath: '': No such file or directory > > > > The culprit?

Re: [Qemu-block] [PATCH v3 20/20] block: Make bdrv_is_allocated_above() byte-based

particularly stream_run(), > gets a lot simpler because it no longer has to mess with sectors. > > For ease of review, bdrv_is_allocated() was tackled separately. > > Signed-off-by: Eric Blake <ebl...@redhat.com> > Reviewed-by: John Snow <js...@redhat.com> > Review

Re: [Qemu-block] [PATCH v3 19/20] block: Minimize raw use of bds->total_sectors

is > called more frequently. > > Suggested-by: John Snow <js...@redhat.com> > Signed-off-by: Eric Blake <ebl...@redhat.com> > Reviewed-by: Jeff Cody <jc...@redhat.com> > --- > v2: new patch > --- > block/io.c | 12 +++- > 1 file changed, 7 inse

Re: [Qemu-block] [PATCH v3 18/20] block: Make bdrv_is_allocated() byte-based

the initial offset. > > For ease of review, bdrv_is_allocated_above() will be tackled > separately. > > Signed-off-by: Eric Blake <ebl...@redhat.com> > Reviewed-by: John Snow <js...@redhat.com> > Reviewed-by: Jeff Cody <jc...@redhat.com> > --- > v2: reb

Re: [Qemu-block] [PATCH v3 17/20] backup: Switch backup_run() to byte-based

l guaranteed that we iterate by steps that > are cluster-aligned). > > Signed-off-by: Eric Blake <ebl...@redhat.com> > Reviewed-by: John Snow <js...@redhat.com> > Reviewed-by: Jeff Cody <jc...@redhat.com> > --- > v2: no change > --- > block/backup.c |

Re: [Qemu-block] [PATCH v3 16/20] backup: Switch backup_do_cow() to byte-based

at.com> > Reviewed-by: John Snow <js...@redhat.com> > Reviewed-by: Jeff Cody <jc...@redhat.com> > --- > v2: no change > --- > block/backup.c | 62 > -- > 1 file changed, 26 insertions(+), 36 deletions(-)

Re: [Qemu-block] [PATCH v3 15/20] backup: Switch block_backup.h to byte-based

.@redhat.com> > Reviewed-by: John Snow <js...@redhat.com> > Reviewed-by: Jeff Cody <jc...@redhat.com> > --- > v2: change a couple more parameter names > --- > include/block/block_backup.h | 11 +-- > block/backup.c | 33 ---

Re: [Qemu-block] [PATCH v3 14/20] backup: Switch BackupBlockJob to byte-based

gress. Drop a redundant local variable bytes_per_cluster. > > Signed-off-by: Eric Blake <ebl...@redhat.com> > Reviewed-by: John Snow <js...@redhat.com> > Reviewed-by: Jeff Cody <jc...@redhat.com> > --- > v2: no change > --- > block/backup.c | 33

Re: [Qemu-block] [PATCH v3 13/20] block: Drop unused bdrv_round_sectors_to_clusters()

now <js...@redhat.com> > Reviewed-by: Jeff Cody <jc...@redhat.com> > --- > v2: hoist to earlier series, no change > --- > include/block/block.h | 4 > block/io.c| 21 - > 2 files changed, 25 deletions(-) > > diff --git a/i

Re: [Qemu-block] [PATCH v3 12/20] mirror: Switch mirror_iteration() to byte-based

l guaranteed that we iterate by steps that > are both sector-aligned and multiples of the granularity). Drop > the now-unused mirror_clip_sectors(). > > Signed-off-by: Eric Blake <ebl...@redhat.com> > Reviewed-by: John Snow <js...@redhat.com> > Reviewed-by: Jeff C

Re: [Qemu-block] [PATCH v3 11/20] mirror: Switch mirror_do_read() to byte-based

at.com> > Reviewed-by: John Snow <js...@redhat.com> > Reviewed-by: Jeff Cody <jc...@redhat.com> > --- > v2: rebase to earlier changes > --- > block/mirror.c | 75 > ++ > 1 file changed, 33 insertions(+),

Re: [Qemu-block] [PATCH v3 10/20] mirror: Switch mirror_cow_align() to byte-based

counterpart to mirror_clip_sectors(). Some of the conversion is > a bit tricky, requiring temporaries to convert between units; it > will be cleared up in a following patch. > > Signed-off-by: Eric Blake <ebl...@redhat.com> > Reviewed-by: John Snow <js...@redhat.com> > Reviewed-by

Re: [Qemu-block] [PATCH v3 09/20] mirror: Update signature of mirror_clip_sectors()

> Signed-off-by: Eric Blake <ebl...@redhat.com> > Reviewed-by: John Snow <js...@redhat.com> > Reviewed-by: Jeff Cody <jc...@redhat.com> > --- > v2: new patch > --- > block/mirror.c | 15 --- > 1 file changed, 8 insertions(+), 7 deletions(-) &g

Re: [Qemu-block] [PATCH v3 08/20] mirror: Switch mirror_do_zero_or_discard() to byte-based

at.com> > Reviewed-by: John Snow <js...@redhat.com> > Reviewed-by: Jeff Cody <jc...@redhat.com> > --- > v2: no change > --- > block/mirror.c | 20 +++- > 1 file changed, 11 insertions(+), 9 deletions(-) > > diff --git a/block/mirror.c b/

Re: [Qemu-block] [PATCH v3 07/20] mirror: Switch MirrorBlockJob to byte-based

buffer size. > > [checkpatch has a false positive on use of MIN() in this patch] > > Signed-off-by: Eric Blake <ebl...@redhat.com> > Reviewed-by: John Snow <js...@redhat.com> > Reviewed-by: Jeff Cody <jc...@redhat.com> &g

Re: [Qemu-block] [PATCH v3 06/20] commit: Switch commit_run() to byte-based

l guaranteed that we iterate by steps that > are sector-aligned). > > Signed-off-by: Eric Blake <ebl...@redhat.com> > Reviewed-by: John Snow <js...@redhat.com> > Reviewed-by: Jeff Cody <jc...@redhat.com> > --- > v2: no change > --- > block/commit.c | 1

Re: [Qemu-block] [PATCH v3 05/20] commit: Switch commit_populate() to byte-based

;ebl...@redhat.com> > Reviewed-by: John Snow <js...@redhat.com> > Reviewed-by: Jeff Cody <jc...@redhat.com> > --- > v2: no change > --- > block/commit.c | 15 --- > 1 file changed, 8 insertions(+), 7 deletions(-) > > diff --git a/block/commit.c b/

Re: [Qemu-block] [PATCH v3 04/20] stream: Switch stream_run() to byte-based

l guaranteed that we iterate by steps that > are sector-aligned). > > Signed-off-by: Eric Blake <ebl...@redhat.com> > Reviewed-by: John Snow <js...@redhat.com> > Reviewed-by: Jeff Cody <jc...@redhat.com> > --- > v2: no change > --- > block/str

Re: [Qemu-block] [PATCH v3 03/20] stream: Switch stream_populate() to byte-based

;ebl...@redhat.com> > Reviewed-by: John Snow <js...@redhat.com> > Reviewed-by: Jeff Cody <jc...@redhat.com> > --- > v2: no change > --- > block/stream.c | 11 ++- > 1 file changed, 6 insertions(+), 5 deletions(-) > > diff --git a/block/stream.c b/block/str

Re: [Qemu-block] [PATCH v3 02/20] trace: Show blockjob actions via bytes, not sectors

at.com> > Reviewed-by: John Snow <js...@redhat.com> > Reviewed-by: Jeff Cody <jc...@redhat.com> > --- > v2: improve commit message, no code change > --- > block/backup.c | 16 ++-- > block/commit.c | 3 ++- > block/mirror.c | 26 +

Re: [Qemu-block] [PATCH v3 01/20] blockjob: Track job ratelimits via bytes, not sectors

t; > Signed-off-by: Eric Blake <ebl...@redhat.com> > Reviewed-by: John Snow <js...@redhat.com> > Reviewed-by: Jeff Cody <jc...@redhat.com> > --- > v2: adjust commit message based on review; no code change > --- > include/qemu/ratelimit.h | 3 ++- > block

Re: [Qemu-block] [Qemu-devel] [PULL 0/2] Block patches

On Wed, Jun 14, 2017 at 03:26:52PM -0700, no-re...@patchew.org wrote: > Hi, > > This series failed automatic build test. Please find the testing commands and > their output below. If you have docker installed, you can probably reproduce > it > locally. > > Type: series > Subject: [Qemu-devel]

[Qemu-block] [PULL 0/2] Block patches

Jeff Cody (2): block/rbd: enable filename option and parsing block/iscsi: enable filename option and parsing block/iscsi.c | 22 +- block/rbd.c | 22 +- 2 files changed, 42 insertions(+), 2 deletions(-) -- 2.9.3

[Qemu-block] [PULL 2/2] block/iscsi: enable filename option and parsing

images that used to work fine. See bug: https://bugzilla.redhat.com/show_bug.cgi?id=1457088 Tested-by: Richard W.M. Jones <rjo...@redhat.com> Signed-off-by: Jeff Cody <jc...@redhat.com> Message-id: 0789ab6c32814ab4b6896707d378804bd4424c65.1497444637.git.jc...@redhat.com Signed-off-by: J

[Qemu-block] [PULL 1/2] block/rbd: enable filename option and parsing

that used to work fine. See bug: https://bugzilla.redhat.com/show_bug.cgi?id=1457088 Tested-by: Richard W.M. Jones <rjo...@redhat.com> Signed-off-by: Jeff Cody <jc...@redhat.com> Message-id: 937dc9fde348d13311eb8e23444df3bc3190b612.1497444637.git.jc...@redhat.com Signed-off-by: J

Re: [Qemu-block] [PATCH v2 0/2] Parse 'filename' option for RBD/iSCSI

On Wed, Jun 14, 2017 at 08:53:18AM -0400, Jeff Cody wrote: > Change from v2: > Add warning message that this is an unsupported option that may > be deprecated in the future. > > We need to be able to parse the 'filename' option for rbd and iscsi, because > there may exist

[Qemu-block] [PATCH v2 2/2] block/iscsi: enable filename option and parsing

images that used to work fine. See bug: https://bugzilla.redhat.com/show_bug.cgi?id=1457088 Tested-by: Richard W.M. Jones <rjo...@redhat.com> Signed-off-by: Jeff Cody <jc...@redhat.com> --- block/iscsi.c | 22 +- 1 file changed, 21 insertions(+), 1 deletion(-) diff -

[Qemu-block] [PATCH v2 1/2] block/rbd: enable filename option and parsing

that used to work fine. See bug: https://bugzilla.redhat.com/show_bug.cgi?id=1457088 Tested-by: Richard W.M. Jones <rjo...@redhat.com> Signed-off-by: Jeff Cody <jc...@redhat.com> --- block/rbd.c | 22 +- 1 file changed, 21 insertions(+), 1 deletion(-) diff -

[Qemu-block] [PATCH v2 0/2] Parse 'filename' option for RBD/iSCSI

Change from v2: Add warning message that this is an unsupported option that may be deprecated in the future. We need to be able to parse the 'filename' option for rbd and iscsi, because there may exist images in the wild that have json backing files, that specify the filename argument. Jeff Cody

[Qemu-block] [PATCH 1/2] block/rbd: enable filename option and parsing

that used to work fine. See bug: https://bugzilla.redhat.com/show_bug.cgi?id=1457088 Tested-by: Richard W.M. Jones <rjo...@redhat.com> Signed-off-by: Jeff Cody <jc...@redhat.com> --- block/rbd.c | 19 ++- 1 file changed, 18 insertions(+), 1 deletion(-) diff --git a/b

[Qemu-block] [PATCH 0/2] Parse 'filename' option for RBD/iSCSI

We need to be able to parse the 'filename' option for rbd and iscsi, because there may exist images in the wild that have json backing files, that specify the filename argument. Jeff Cody (2): block/rbd: enable filename option and parsing block/iscsi: enable filename option and parsing

[Qemu-block] [PATCH 2/2] block/iscsi: enable filename option and parsing

images that used to work fine. See bug: https://bugzilla.redhat.com/show_bug.cgi?id=1457088 Tested-by: Richard W.M. Jones <rjo...@redhat.com> Signed-off-by: Jeff Cody <jc...@redhat.com> --- block/iscsi.c | 19 ++- 1 file changed, 18 insertions(+), 1 deletion(-) diff -

[Qemu-block] [RFC 1/2] block/rbd: enable filename option and parsing

that used to work fine. See bug: https://bugzilla.redhat.com/show_bug.cgi?id=1457088 Signed-off-by: Jeff Cody <jc...@redhat.com> --- block/rbd.c | 19 ++- 1 file changed, 18 insertions(+), 1 deletion(-) diff --git a/block/rbd.c b/block/rbd.c index e551639..cbc0b85

[Qemu-block] [RFC 0/2] Parse 'filename' option for RBD/iSCSI

will give preference to the 'filename' parameter over passed options. Jeff Cody (2): block/rbd: enable filename option and parsing block/iscsi: enable filename option and parsing block/iscsi.c | 19 ++- block/rbd.c | 19 ++- 2 files changed, 36 insertions(+), 2

[Qemu-block] [RFC 2/2] block/iscsi: enable filename option and parsing

images that used to work fine. See bug: https://bugzilla.redhat.com/show_bug.cgi?id=1457088 Signed-off-by: Jeff Cody <jc...@redhat.com> --- block/iscsi.c | 19 ++- 1 file changed, 18 insertions(+), 1 deletion(-) diff --git a/block/iscsi.c b/block/iscsi.c index 5daa201..ba50e76

[Qemu-block] [PULL 1/1] block/gluster.c: Handle qdict_array_entries() failure

n type of qdict_array_entries() and also the type we use for the loop enumeration variable 'i'. (Spotted by Coverity, CID 1360960.) Signed-off-by: Peter Maydell <peter.mayd...@linaro.org> Reviewed-by: Eric Blake <ebl...@redhat.com> Reviewed-by: Jeff Cody <jc...@redhat.com> Messa

[Qemu-block] [PULL 0/1] Block patches

The following changes since commit 64175afc695c0672876fbbfc31b299c86d562cb4: arm_gicv3: Fix ICC_BPR1 reset value when EL3 not implemented (2017-06-07 17:21:44 +0100) are available in the git repository at: git://github.com/codyprime/qemu-kvm-jtc.git tags/block-pull-request for you to

[Qemu-block] [PATCH] block: fix external snapshot abort permission error

by Kevin Wolf) is to call bdrv_set_backing_hd() on the new node, to set the backing node to NULL. Signed-off-by: Jeff Cody <jc...@redhat.com> --- blockdev.c | 4 1 file changed, 4 insertions(+) diff --git a/blockdev.c b/blockdev.c index 892d768..6472548 100644 --- a/blockdev.c

Re: [Qemu-block] [PATCH] block/gluster.c: Handle qdict_array_entries() failure

Error *local_err = NULL; > char *str = NULL; > const char *ptr; > -size_t num_servers; > -int i, type; > +int i, type, num_servers; > > /* create opts info from runtime_json_opts list */ > opts = qemu_opts_create(_json_opts, NULL, 0, _abort

[Qemu-block] [PULL 1/1] gluster: add support for PREALLOC_MODE_FALLOC

hat.com> Signed-off-by: Niels de Vos <nde...@redhat.com> Message-id: 20170528063114.28691-1-nde...@redhat.com URL: https://bugzilla.redhat.com/1450759 Signed-off-by: Niels de Vos <nde...@redhat.com> Signed-off-by: Jeff Cody <jc...@

[Qemu-block] [PULL 0/1] Block patches

The following changes since commit d47a851caeda96d5979bf48d4bae6a87784ad91d: Merge remote-tracking branch 'remotes/juanquintela/tags/migration/20170601' into staging (2017-06-02 14:07:53 +0100) are available in the git repository at: git://github.com/codyprime/qemu-kvm-jtc.git

Re: [Qemu-block] [PATCH v3] gluster: add support for PREALLOC_MODE_FALLOC

figure. > > Reported-by: Satheesaran Sundaramoorthi <sasun...@redhat.com> > URL: https://bugzilla.redhat.com/1450759 > Signed-off-by: Niels de Vos <nde...@redhat.com> > --- > v3 typo fixes spotted by Jeff Cody and Eric Blake: > - typo in the commit message (Eric) > -

Re: [Qemu-block] [PATCH v3 4/4] qemu-iotests: Block migration test

false}} > + > +=== Do some I/O on the destination === > + > +{"timestamp": {"seconds": TIMESTAMP, "microseconds": TIMESTAMP}, "event": > "RESUME"} > +{"return": {"status": "running", "singlestep": false, "running": true}} > +read 65536/65536 bytes at offset 0 > +64 KiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec) > +{"return": ""} > +wrote 65536/65536 bytes at offset 1048576 > +64 KiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec) > +{"return": ""} > + > +=== Shut down and check image === > + > +{"return": {}} > +{"return": {}} > +{"timestamp": {"seconds": TIMESTAMP, "microseconds": TIMESTAMP}, "event": > "SHUTDOWN", "data": {"guest": false}} > +{"timestamp": {"seconds": TIMESTAMP, "microseconds": TIMESTAMP}, "event": > "SHUTDOWN", "data": {"guest": false}} > +No errors were found on the image. > +No errors were found on the image. > +wrote 65536/65536 bytes at offset 1048576 > +64 KiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec) > +Images are identical. > +*** done > diff --git a/tests/qemu-iotests/group b/tests/qemu-iotests/group > index 5c8ea0f..a6acaff 100644 > --- a/tests/qemu-iotests/group > +++ b/tests/qemu-iotests/group > @@ -174,3 +174,4 @@ > 179 rw auto quick > 181 rw auto migration > 182 rw auto quick > +183 rw auto migration > -- > 1.8.3.1 > Reviewed-by: Jeff Cody <jc...@redhat.com>

Re: [Qemu-block] [PATCH v2 4/4] qemu-iotests: Block migration test

On Tue, May 30, 2017 at 06:57:05PM +0200, Kevin Wolf wrote: > Am 30.05.2017 um 17:52 hat Jeff Cody geschrieben: > > On Tue, May 30, 2017 at 05:22:53PM +0200, Kevin Wolf wrote: > > > Signed-off-by: Kevin Wolf <kw...@redhat.com> > > > --- > &

Re: [Qemu-block] [PATCH v2 4/4] qemu-iotests: Block migration test

"{ 'execute': 'migrate', > + 'arguments': { 'uri': 'unix:${MIG_SOCKET}', 'blk': true } }" \ > +'return\|error')" > +echo "$reply" > +if echo "$reply" | grep "compiled without old-style" > /dev/null; then > +_notrun "mi

Re: [Qemu-block] [PATCH v2 3/4] migration/block: Clean up BBs in block_save_complete()

T(_mig_state.blk_list)) != NULL) { > @@ -843,6 +851,10 @@ static int block_save_complete(QEMUFile *f, void *opaque) > > qemu_put_be64(f, BLK_MIG_FLAG_EOS); > > +/* Make sure that our BlockBackends are gone, so that the block driver > + * nodes can be inactivated. */ > +block_migration_cleanup_bmds(); > + > return 0; > } > > -- > 1.8.3.1 > > Reviewed-by: Jeff Cody <jc...@redhat.com>

Re: [Qemu-block] [PATCH v2 2/4] migration: Inactivate images after .save_live_complete_precopy()

(ret >= 0) { > +s->block_inactive = true; > +} > } > } > qemu_mutex_unlock_iothread(); > -- > 1.8.3.1 > > Reviewed-by: Jeff Cody <jc...@redhat.com>

Re: [Qemu-block] [PATCH v2 1/4] block: Fix anonymous BBs in blk_root_inactivate()

ackends. If there is still any other user like a block job, then > * we simply can't inactivate the image. */ > -if (!blk->dev && !blk->name[0]) { > +if (!blk->dev && !blk_name(blk)[0]) { > return -EPERM; > } > > -- > 1.8.3.1 > > Reviewed-by: Jeff Cody <jc...@redhat.com>

[Qemu-block] [PULL 10/12] blockjob: reorganize block_job_completed_txn_abort

<stefa...@redhat.com> Signed-off-by: Paolo Bonzini <pbonz...@redhat.com> Message-id: 20170508141310.8674-11-pbonz...@redhat.com Signed-off-by: Jeff Cody <jc...@redhat.com> --- blockjob.c | 35 ++- 1 file changed, 22 insertions(+), 13 deletions(-) d

[Qemu-block] [PULL 12/12] block/gluster: glfs_lseek() workaround

start) the same as if an error value other than ENXIO is returned; we will assume we learned nothing, and there are no holes in the file. Signed-off-by: Jeff Cody <jc...@redhat.com> Reviewed-by: Eric Blake <ebl...@redhat.com> Reviewed-by: Niels de Vos <

[Qemu-block] [PULL 07/12] blockjob: introduce block_job_cancel_async, check iostatus invariants

erwise leave it as the entry point for resetting the iostatus. Reviewed-by: Stefan Hajnoczi <stefa...@redhat.com> Signed-off-by: Paolo Bonzini <pbonz...@redhat.com> Message-id: 20170508141310.8674-8-pbonz...@redhat.com Signed-off-by: Jeff Cody <jc...@redhat.com&

[Qemu-block] [PULL 04/12] blockjob: introduce block_job_pause/resume_all

ohn Snow <js...@redhat.com> Signed-off-by: Paolo Bonzini <pbonz...@redhat.com> Reviewed-by: Jeff Cody <jc...@redhat.com> Message-id: 20170508141310.8674-5-pbonz...@redhat.com Signed-off-by: Jeff Cody <jc...@redhat.com> --- block/io.c | 19 ++--

[Qemu-block] [PULL 02/12] blockjob: remove iostatus_reset callback

<f4...@amsat.org> Signed-off-by: Paolo Bonzini <pbonz...@redhat.com> Reviewed-by: Jeff Cody <jc...@redhat.com> Message-id: 20170508141310.8674-3-pbonz...@redhat.com Signed-off-by: Jeff Cody <jc...@redhat.com> --- blockjob.c | 3 --- include/block/blockjob_int.h

[Qemu-block] [PULL 09/12] blockjob: strengthen a bit test-blockjob-txn

Stefan Hajnoczi <stefa...@redhat.com> Reviewed-by: John Snow <js...@redhat.com> Signed-off-by: Paolo Bonzini <pbonz...@redhat.com> Message-id: 20170508141310.8674-10-pbonz...@redhat.com Signed-off-by: Jeff Cody <jc...@redhat.com> --- tests/test-blockjob-txn.c | 7 +--

<    1   2   3   4   5   6   7   8   9   10   >