Re: [Qemu-block] [PATCH 2/4] block/rbd: code movement

dded Ah, sorry - yes. The lack of a commit message was a mistake when squashing patches. > > On Mon, Feb 27, 2017 at 02:30:39AM -0500, Jeff Cody wrote: > > Signed-off-by: Jeff Cody <jc...@redhat.com> > > --- > > block/rbd.c | 64 > > +

Re: [Qemu-block] [PATCH 4/4] block/rbd: Add blockdev-add support

On Mon, Feb 27, 2017 at 02:30:41AM -0500, Jeff Cody wrote: > Signed-off-by: Jeff Cody <jc...@redhat.com> > --- > qapi/block-core.json | 47 --- > 1 file changed, 44 insertions(+), 3 deletions(-) > > diff --git a/qapi/bloc

[Qemu-block] [PATCH 2/4] block/rbd: code movement

Signed-off-by: Jeff Cody <jc...@redhat.com> --- block/rbd.c | 64 +++-- 1 file changed, 45 insertions(+), 19 deletions(-) diff --git a/block/rbd.c b/block/rbd.c index 3f1a9de..c8d4eb1 100644 --- a/block/rbd.c +++ b/block/rbd.c @@

[Qemu-block] [PATCH 3/4] block/rbd: parse all options via bdrv_parse_filename

is continued in this patch; there is an option "keyvalue-pairs" that is populated with all the key/value pairs that the QEMU driver does not care about. These key/value pairs will override any settings in the 'conf' configuration file, just as they did before. Signed-off-by: Jeff Cody <jc.

[Qemu-block] [PATCH 1/4] block/rbd: don't copy strings in qemu_rbd_next_tok()

, and offload the responsibility for safely handling/coping these strings to the caller. This also cleans up error handling some, as the callers now rely on the Error object to determine if there is a parse error. Signed-off-by: Jeff Cody <jc...@redhat.com> --- block/rbd.

[Qemu-block] [PATCH 0/4] RBD: blockdev-add

it is with an array schema of structs. I'll reply to the specific patches in the problem areas, and see what the preference is from an API perspective to handle this. Jeff Cody (4): block/rbd: don't copy strings in qemu_rbd_next_tok() block/rbd: code movement block/rbd: parse all options via

[Qemu-block] [PATCH 4/4] block/rbd: Add blockdev-add support

Signed-off-by: Jeff Cody <jc...@redhat.com> --- qapi/block-core.json | 47 --- 1 file changed, 44 insertions(+), 3 deletions(-) diff --git a/qapi/block-core.json b/qapi/block-core.json index 5f82d35..08a1419 100644 --- a/qapi/block-core.json +++

[Qemu-block] [PULL 3/3] RBD: Add support readv,writev for rbd

From: tianqing <tianq...@unitedstack.com> Rbd can do readv and writev directly, so wo do not need to transform iov to buf or vice versa any more. Signed-off-by: tianqing <tianq...@unitedstack.com> Reviewed-by: Jeff Cody <jc...@redhat.com> Signed-off-by: Jeff Cody <jc...@r

[Qemu-block] [PULL 0/3] Block patches

The following changes since commit fe8ee082db5038a05dbd8872e946049e9a9c550e: Merge remote-tracking branch 'remotes/armbru/tags/pull-qapi-2017-02-22' into staging (2017-02-24 15:00:51 +) are available in the git repository at: https://github.com/codyprime/qemu-kvm-jtc.git

[Qemu-block] [PULL 1/3] block/nfs: convert to preadv / pwritev

From: Peter Lieven <p...@kamp.de> Signed-off-by: Peter Lieven <p...@kamp.de> Reviewed-by: Jeff Cody <jc...@redhat.com> Message-id: 1487349541-10201-2-git-send-email...@kamp.de Signed-off-by: Jeff Cody <jc...@redhat.com> --- block/nfs.c | 33 +++--

[Qemu-block] [PULL 2/3] block/nfs: try to avoid the bounce buffer in pwritev

From: Peter Lieven <p...@kamp.de> if the passed qiov contains exactly one iov we can pass the buffer directly. Signed-off-by: Peter Lieven <p...@kamp.de> Reviewed-by: Jeff Cody <jc...@redhat.com> Message-id: 1487349541-10201-3-git-send-email...@kamp.de Signed-off-by: Jeff Cody

Re: [Qemu-block] [RFC v6] RBD: Add support readv,writev for rbd

On Fri, Feb 24, 2017 at 02:09:31PM +0800, Jaze Lee wrote: > 2017-02-24 11:52 GMT+08:00 Jeff Cody <jc...@redhat.com>: > > On Tue, Feb 21, 2017 at 02:50:03PM +0800, jaze...@gmail.com wrote: > >> From: tianqing <tianq...@unitedstack.com> > >> > >>

Re: [Qemu-block] [RFC v6] RBD: Add support readv,writev for rbd

On Tue, Feb 21, 2017 at 02:50:03PM +0800, jaze...@gmail.com wrote: > From: tianqing > > Rbd can do readv and writev directly, so wo do not need to transform > iov to buf or vice versa any more. > > Signed-off-by: tianqing > --- This is

Re: [Qemu-block] [PATCH 0/2] block/nfs optimizations

On Fri, Feb 17, 2017 at 05:38:59PM +0100, Peter Lieven wrote: > Peter Lieven (2): > block/nfs: convert to preadv / pwritev > block/nfs: try to avoid the bounce buffer in pwritev > > block/nfs.c | 50 -- > 1 file changed, 28 insertions(+), 22

Re: [Qemu-block] [Qemu-devel] [PATCH 2/2] block/nfs: try to avoid the bounce buffer in pwritev

On Wed, Feb 22, 2017 at 01:47:10PM +0100, Kevin Wolf wrote: > Am 17.02.2017 um 22:51 hat Jeff Cody geschrieben: > > On Fri, Feb 17, 2017 at 03:42:52PM -0600, Eric Blake wrote: > > > On 02/17/2017 03:37 PM, Jeff Cody wrote: > > > > On Fri, Feb 17, 2017 at 05:39:

[Qemu-block] [PULL 7/9] QAPI: Fix blockdev-add example documentation

Signed-off-by: Jeff Cody <jc...@redhat.com> --- qapi/block-core.json | 50 +- 1 file changed, 25 insertions(+), 25 deletions(-) diff --git a/qapi/block-core.json b/qapi/block-core.json index ea9b04a..5f82d35 100644 --- a/qapi/block-core.json

[Qemu-block] [PULL 1/9] iscsi: Split URL into individual options

From: Kevin Wolf <kw...@redhat.com> This introduces a .bdrv_parse_filename handler for iscsi which parses an URL if given and translates it to individual options. Reviewed-by: Fam Zheng <f...@redhat.com> Signed-off-by: Kevin Wolf <kw...@redhat.com> Signed-off-by: Jeff Cody

[Qemu-block] [PULL 5/9] iscsi: Add timeout option

option for the iscsi block driver now. Reviewed-by: Daniel P. Berrange <berra...@redhat.com> Reviewed-by: Fam Zheng <f...@redhat.com> Signed-off-by: Kevin Wolf <kw...@redhat.com> Signed-off-by: Jeff Cody <jc...@redhat.com> --- block/iscsi.c | 37 +++

[Qemu-block] [PULL 3/9] iscsi: Add initiator-name option

gt; Reviewed-by: Fam Zheng <f...@redhat.com> Signed-off-by: Kevin Wolf <kw...@redhat.com> Signed-off-by: Jeff Cody <jc...@redhat.com> --- block/iscsi.c | 32 +++- 1 file changed, 15 insertions(+), 17 deletions(-) diff --git a/block/iscsi.c b/block/iscsi.c

[Qemu-block] [PULL 8/9] mirror: do not increase offset during initial zero_or_discard phase

d...@openvz.org> Reviewed-by: Eric Blake <ebl...@redhat.com> Reviewed-by: Stefan Hajnoczi <stefa...@redhat.com> Message-id: 1486045515-8009-1-git-send-email-...@openvz.org CC: Jeff Cody <jc...@redhat.com> CC: Kevin Wolf <kw...@redhat.com> CC: Max Reitz <mre...@re

[Qemu-block] [PULL 9/9] qemu-options: Fix broken sheepdog URL

From: Thomas Huth <th...@redhat.com> The sheepdog URL is broken twice: First it uses a duplicated http:// prefix, second the website seems to have moved to https://sheepdog.github.io/sheepdog/ instead. Signed-off-by: Thomas Huth <th...@redhat.com> Signed-off-by: Jeff Cody <j

[Qemu-block] [PULL 6/9] iscsi: Add blockdev-add support

From: Kevin Wolf <kw...@redhat.com> This adds blockdev-add support for iscsi devices. Reviewed-by: Daniel P. Berrange <berra...@redhat.com> Reviewed-by: Fam Zheng <f...@redhat.com> Signed-off-by: Kevin Wolf <kw...@redhat.com> Signed-off-by: Jeff Cody <jc...@red

[Qemu-block] [PULL 0/9] Block patches

Anton Nefedov (1): mirror: do not increase offset during initial zero_or_discard phase Jeff Cody (1): QAPI: Fix blockdev-add example documentation Kevin Wolf (6): iscsi: Split URL into individual options iscsi: Handle -iscsi user/password in bdrv_parse_filename() iscsi: Add initiator-name

[Qemu-block] [PULL 4/9] iscsi: Add header-digest option

gt; Reviewed-by: Fam Zheng <f...@redhat.com> Signed-off-by: Kevin Wolf <kw...@redhat.com> Signed-off-by: Jeff Cody <jc...@redhat.com> --- block/iscsi.c | 39 +++ 1 file changed, 15 insertions(+), 24 deletions(-) diff --git a/block/iscsi.c b/block/

[Qemu-block] [PULL 2/9] iscsi: Handle -iscsi user/password in bdrv_parse_filename()

w...@redhat.com> Signed-off-by: Jeff Cody <jc...@redhat.com> --- block/iscsi.c | 78 +-- 1 file changed, 44 insertions(+), 34 deletions(-) diff --git a/block/iscsi.c b/block/iscsi.c index d61d3d8..ec26fc6 100644 --- a/block/iscsi.c +++ b/b

Re: [Qemu-block] [RFC v6] RBD: Add support readv,writev for rbd

On Tue, Feb 21, 2017 at 11:43:36AM +0800, jaze...@gmail.com wrote: > From: tianqing > > Rbd can do readv and writev directly, so wo do not need to transform > iov to buf or vice versa any more. > > Signed-off-by: tianqing > --- > block/rbd.c

Re: [Qemu-block] [Qemu-devel] [PATCH 2/2] block/nfs: try to avoid the bounce buffer in pwritev

On Fri, Feb 17, 2017 at 03:42:52PM -0600, Eric Blake wrote: > On 02/17/2017 03:37 PM, Jeff Cody wrote: > > On Fri, Feb 17, 2017 at 05:39:01PM +0100, Peter Lieven wrote: > >> if the passed qiov contains exactly one iov we can > >> pass the buffer directly. > >>

Re: [Qemu-block] [Qemu-devel] [PATCH v2 6/7] iscsi: Add blockdev-add support

On Fri, Feb 17, 2017 at 03:40:21PM -0600, Eric Blake wrote: > On 01/25/2017 11:42 AM, Jeff Cody wrote: > > From: Kevin Wolf <kw...@redhat.com> > > > > This adds blockdev-add support for iscsi devices. > > > > Reviewed-by: Daniel P. Berrange <berra...@red

Re: [Qemu-block] [PATCH 2/2] block/nfs: try to avoid the bounce buffer in pwritev

On Fri, Feb 17, 2017 at 05:39:01PM +0100, Peter Lieven wrote: > if the passed qiov contains exactly one iov we can > pass the buffer directly. > > Signed-off-by: Peter Lieven > --- > block/nfs.c | 23 --- > 1 file changed, 16 insertions(+), 7 deletions(-) > >

Re: [Qemu-block] [PATCH 1/2] block/nfs: convert to preadv / pwritev

open_prepare, > > -.bdrv_co_readv = nfs_co_readv, > -.bdrv_co_writev = nfs_co_writev, > +.bdrv_co_preadv = nfs_co_preadv, > +.bdrv_co_pwritev= nfs_co_pwritev, > .bdrv_co_flush_to_disk = nfs_co_flush, > > .bdrv_detach_aio_context= nfs_detach_aio_context, > -- > 1.9.1 > Reviewed-by: Jeff Cody <jc...@redhat.com>

Re: [Qemu-block] [PATCH v2 0/7] iscsi: Add blockdev-add support

On Wed, Jan 25, 2017 at 12:42:01PM -0500, Jeff Cody wrote: > This adds blockdev-add support to the iscsi block driver. > > Picked this series up from Kevin. I've tested it on my local iscsi setup. > > There are only a few minor changes: > > * In patch 2, fixed the

Re: [Qemu-block] [RFC v5] RBD: Add support readv,writev for rbd

On Thu, Feb 16, 2017 at 05:00:02PM +0800, jaze...@gmail.com wrote: > From: tianqing > > Rbd can do readv and writev directly, so wo do not need to transform > iov to buf or vice versa any more. > > Signed-off-by: tianqing > --- > block/rbd.c

Re: [Qemu-block] [PATCH v3] backup: allow target without .bdrv_get_info

On Wed, Feb 15, 2017 at 05:58:13PM +0300, Vladimir Sementsov-Ogievskiy wrote: > Currently backup to nbd target is broken, as nbd doesn't have > .bdrv_get_info realization. > > Signed-off-by: Vladimir Sementsov-Ogievskiy > --- > > v3: fix compilation (I feel like an

[Qemu-block] [PATCH 1/1] qemu-iotests: redirect nbd server stdout to /dev/null

Some iotests (e.g. 174) try to filter the output of _make_test_image by piping the stdout. Pipe the server stdout to /dev/null, so that filter pipe does not need to wait until process completion. Signed-off-by: Jeff Cody <jc...@redhat.com> --- tests/qemu-iotests/common.rc | 2 +- 1 file c

[Qemu-block] [PATCH 1/2] qemu-iotests: Test 137 only supports 'file' protocol

Since test 137 make uses of qcow2.py, only local files are supported. Signed-off-by: Jeff Cody <jc...@redhat.com> --- tests/qemu-iotests/137 | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/qemu-iotests/137 b/tests/qemu-iotests/137 index e5e30de..eb91e51

[Qemu-block] [PATCH 2/2] qemu-iotests: add ability to exclude certain protocols from tests

Add the ability for shell script tests to exclude specific protocols. This is useful to allow all protocols except ones known to not support a feature used in the test (e.g. .bdrv_create). Signed-off-by: Jeff Cody <jc...@redhat.com> --- tests/qemu-iotests/common.rc | 12

[Qemu-block] [PATCH 0/2] qemu-iotest tweaks

Some minor qemu-iotest tweaks. The second patch makes it easier to add some upcoming protocols such as VXHS, that do not support .bdrv_create. Jeff Cody (2): qemu-iotests: Test 137 only supports 'file' protocol qemu-iotests: add ability to exclude certain protocols from tests tests/qemu

Re: [Qemu-block] [PATCH] qemu-options: Fix broken sheepdog URL

On Thu, Feb 09, 2017 at 01:10:18PM +0100, Thomas Huth wrote: > The sheepdog URL is broken twice: First it uses a duplicated > http:// prefix, second the website seems to have moved to > https://sheepdog.github.io/sheepdog/ instead. > > Signed-off-by: Thomas Huth > --- >

Re: [Qemu-block] [PATCH for-2.9 v3 0/5] Sheepdog cleanups

On Mon, Jan 30, 2017 at 07:48:56PM -0600, Paolo Bonzini wrote: > > > On 04/01/2017 11:47, Jeff Cody wrote: > > On Wed, Jan 04, 2017 at 12:42:53PM +0100, Paolo Bonzini wrote: > >> > >> > >> On 04/01/2017 05:07, Jeff Cody wrote: > >>> On Wed,

[Qemu-block] [PULL 3/5] sheepdog: do not use BlockAIOCB

From: Paolo Bonzini <pbonz...@redhat.com> Sheepdog's AIOCB are completely internal entities for a group of requests and do not need dynamic allocation. Signed-off-by: Paolo Bonzini <pbonz...@redhat.com> Message-id: 20161129113245.32724-4-pbonz...@redhat.com Signed-off-by: J

[Qemu-block] [PULL 2/5] sheepdog: reorganize coroutine flow

Remove sd_co_rw_vector's return value; just leave with no pending requests. [Jeff: added missing 'return' back, spotted by Paolo after series was applied.] Signed-off-by: Jeff Cody <jc...@redhat.com> --- block/sheepdog.c | 115 ---

[Qemu-block] [PULL 4/5] sheepdog: simplify inflight_aio_head management

.@redhat.com Signed-off-by: Jeff Cody <jc...@redhat.com> --- block/sheepdog.c | 23 ++- 1 file changed, 6 insertions(+), 17 deletions(-) diff --git a/block/sheepdog.c b/block/sheepdog.c index 33ded57..3ef7601 100644 --- a/block/sheepdog.c +++ b/block/sheepdog.c @@ -479,1

[Qemu-block] [PULL 0/5] Block patches

The following changes since commit a0def594286d9110a6035e02eef558cf3cf5d847: Merge remote-tracking branch 'remotes/bonzini/tags/for-upstream' into staging (2017-01-30 10:23:20 +) are available in the git repository at: https://github.com/codyprime/qemu-kvm-jtc.git

[Qemu-block] [PULL 1/5] sheepdog: remove unused cancellation support

From: Paolo Bonzini <pbonz...@redhat.com> SheepdogAIOCB is internal to sheepdog.c, hence it is never canceled. Signed-off-by: Paolo Bonzini <pbonz...@redhat.com> Message-id: 20161129113245.32724-2-pbonz...@redhat.com Signed-off-by: Jeff Cody <jc...@redhat.com> --- blo

[Qemu-block] [PATCH v2 0/3] block: check full backing filename when searching protocol filenames

Differences from v1: Patch 1: set local_error = NULL after freeing (Thanks Eric) Patch 2: new patch, groundwork for qemu-iotest in patch 3 Patch 3: qemu-iotest, as requested (Thanks Max) Jeff Cody (3): block: check full backing filename when searching protocol filenames qemu-iotests: Don't

[Qemu-block] [PATCH v2 2/3] qemu-iotests: Don't create fifos / pidfiles with protocol paths

Trying to create, use, and remove fifos and pidfiles on protocol paths (e.g. nfs://localhost/scratch/qemu-nbd.pid) is obviously broken. Use the local $TEST_DIR path before it is 'protocolized' for these files. Signed-off-by: Jeff Cody <jc...@redhat.com> --- tests/qemu-iotests/common.confi

[Qemu-block] [PATCH v2 1/3] block: check full backing filename when searching protocol filenames

, if the straight comparison fails, this patch will also compare against the full backing filename to see if that is a match. Signed-off-by: Jeff Cody <jc...@redhat.com> --- block.c | 13 + 1 file changed, 13 insertions(+) diff --git a/block.c b/block.c index 39ddea3..d97c009

[Qemu-block] [PATCH v2 3/3] qemu-iotest: test to lookup protocol-based image with relative backing

This test uses NFS and block-stream to force a lookup of a backing image that has a relative filename, but a full backing image name with the protocol path intact. Signed-off-by: Jeff Cody <jc...@redhat.com> --- tests/qemu-iotests/173

Re: [Qemu-block] [PATCH 1/1] block: check full backing filename when searching protocol filenames

Forgot to cc qemu-block, added. On Wed, Jan 25, 2017 at 12:22:02PM -0500, Jeff Cody wrote: > In bdrv_find_backing_image(), if we are searching an image for a backing > file that contains a protocol, we currently only compare unmodified > paths. > > However, some management softw

[Qemu-block] [PATCH v2 6/7] iscsi: Add blockdev-add support

From: Kevin Wolf <kw...@redhat.com> This adds blockdev-add support for iscsi devices. Reviewed-by: Daniel P. Berrange <berra...@redhat.com> Signed-off-by: Kevin Wolf <kw...@redhat.com> Signed-off-by: Jeff Cody <jc...@redhat.com> --- block/iscsi.c| 14 ++--

[Qemu-block] [PATCH v2 2/7] iscsi: Handle -iscsi user/password in bdrv_parse_filename()

ername and password specified with -iscsi only take effect when a URL is provided. This is intentional, -iscsi is a legacy interface only supported for compatibility, new users should use the proper driver-specific options. Signed-off-by: Kevin Wolf <kw...@redhat.com> Signed-off-by: Jeff Cody <j

[Qemu-block] [PATCH v2 5/7] iscsi: Add timeout option

option for the iscsi block driver now. Reviewed-by: Daniel P. Berrange <berra...@redhat.com> Signed-off-by: Kevin Wolf <kw...@redhat.com> Signed-off-by: Jeff Cody <jc...@redhat.com> --- block/iscsi.c | 37 +++-- 1 file changed, 11 insertions(+), 26

[Qemu-block] [PATCH v2 1/7] iscsi: Split URL into individual options

From: Kevin Wolf <kw...@redhat.com> This introduces a .bdrv_parse_filename handler for iscsi which parses an URL if given and translates it to individual options. Signed-off-by: Kevin Wolf <kw...@redhat.com> Signed-off-by: Jeff Cody <jc...@redhat.com> --- b

[Qemu-block] [PATCH v2 0/7] iscsi: Add blockdev-add support

* New patch 7, to fix some out of date documentation in the qapi schema Jeff Cody (1): QAPI: Fix blockdev-add example documentation Kevin Wolf (6): iscsi: Split URL into individual options iscsi: Handle -iscsi user/password in bdrv_parse_filename() iscsi: Add initiator-name option iscsi

[Qemu-block] [PATCH v2 4/7] iscsi: Add header-digest option

; Signed-off-by: Kevin Wolf <kw...@redhat.com> Signed-off-by: Jeff Cody <jc...@redhat.com> --- block/iscsi.c | 39 +++ 1 file changed, 15 insertions(+), 24 deletions(-) diff --git a/block/iscsi.c b/block/iscsi.c index 3401b7e..a989b52 100644 --- a/b

[Qemu-block] [PATCH v2 7/7] QAPI: Fix blockdev-add example documentation

Signed-off-by: Jeff Cody <jc...@redhat.com> --- qapi/block-core.json | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/qapi/block-core.json b/qapi/block-core.json index 4ebb8d8..adc089f 100644 --- a/qapi/block-core.json +++ b/qapi/block-core.json @@ -2

[Qemu-block] [PATCH v2 3/7] iscsi: Add initiator-name option

; Signed-off-by: Kevin Wolf <kw...@redhat.com> Signed-off-by: Jeff Cody <jc...@redhat.com> --- block/iscsi.c | 32 +++- 1 file changed, 15 insertions(+), 17 deletions(-) diff --git a/block/iscsi.c b/block/iscsi.c index fc91d0f..3401b7e 100644 --- a/block/isc

Re: [Qemu-block] [RFC PATCH 0/6] iscsi: Add blockdev-add support

On Tue, Jan 24, 2017 at 11:35:12AM +, Daniel P. Berrange wrote: > On Thu, Dec 08, 2016 at 02:23:05PM +0100, Kevin Wolf wrote: > > This adds blockdev-add support to the iscsi block driver. > > > > Note that this is only compile tested at this point. Jeff is going to > > take over from here and

Re: [Qemu-block] [PATCH 01/21] backup: move from done_bitmap to copy_bitmap

ite_notify; > bdrv_add_before_write_notifier(bs, >before_write); > @@ -524,7 +527,7 @@ static void coroutine_fn backup_run(void *opaque) > /* wait until pending backup_do_cow() calls have completed */ > qemu_co_rwlock_wrlock(>flush_rwlock); > qemu_co_rwlock_unlock(>flush_rwlock); > -g_free(job->done_bitmap); > +hbitmap_free(job->copy_bitmap); > > data = g_malloc(sizeof(*data)); > data->ret = ret; > -- > 1.8.3.1 > Reviewed-by: Jeff Cody <jc...@redhat.com>

Re: [Qemu-block] [PATCH 00/21] new backup architecture

On Mon, Jan 09, 2017 at 11:04:27AM +, Stefan Hajnoczi wrote: > On Fri, Dec 23, 2016 at 05:28:43PM +0300, Vladimir Sementsov-Ogievskiy wrote: > > Jeff or John: are you reviewing this? It's in my review queue, but it would probably be a good one for John to review as well if he has time. > >

Re: [Qemu-block] [PATCH for-2.9 v3 0/5] Sheepdog cleanups

On Wed, Jan 04, 2017 at 12:42:53PM +0100, Paolo Bonzini wrote: > > > On 04/01/2017 05:07, Jeff Cody wrote: > > On Wed, Dec 21, 2016 at 03:07:07PM +0100, Paolo Bonzini wrote: > >> > >> > >> On 29/11/2016 12:32, Paolo Bonzini wrote: > >>&g

Re: [Qemu-block] [PATCH for-2.9 v3 0/5] Sheepdog cleanups

On Wed, Dec 21, 2016 at 03:07:07PM +0100, Paolo Bonzini wrote: > > > On 29/11/2016 12:32, Paolo Bonzini wrote: > > Cleaning up the code and removing duplication makes it simpler to > > later adapt it for the multiqueue work. > > > > Tested against sheepdog 1.0. I also tested taking snapshots

[Qemu-block] [PULL for-2.8 3/3] qemu-doc: update gluster protocol usage guide

t;prasanna.kale...@redhat.com> Reviewed-by: Eric Blake <ebl...@redhat.com> Signed-off-by: Jeff Cody <jc...@redhat.com> --- qemu-doc.texi | 59 +++-- qemu-options.hx | 25 ++-- 2 files changed, 68 insertions(+), 1

[Qemu-block] [PULL for-2.8 2/3] block/nfs: fix QMP to match debug option

umar Kalever <prasanna.kale...@redhat.com> Reviewed-by: Eric Blake <ebl...@redhat.com> Signed-off-by: Jeff Cody <jc...@redhat.com> --- block/nfs.c | 4 ++-- qapi/block-core.json | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/block/nfs.c b/block/nfs.c

[Qemu-block] [PULL for-2.8 1/3] block/gluster: fix QMP to match debug option

umar Kalever <prasanna.kale...@redhat.com> Reviewed-by: Eric Blake <ebl...@redhat.com> Signed-off-by: Jeff Cody <jc...@redhat.com> --- block/gluster.c | 38 +++--- qapi/block-core.json | 4 ++-- 2 files changed, 21 insertions(+), 21 deletions(-)

[Qemu-block] [PULL for-2.8 0/3] Block patches for -rc3

The following changes since commit bc66cedb4141fb7588f2462c74310d8fb5dd4cf1: Merge remote-tracking branch 'yongbok/tags/mips-20161204' into staging (2016-12-05 10:56:45 +) are available in the git repository at: https://github.com/codyprime/qemu-kvm-jtc.git tags/block-pull-request for

[Qemu-block] [PULL for-2.8 1/1] gluster: Fix use after free in glfs_clear_preopened()

end-email-kw...@redhat.com Reviewed-by: Jeff Cody <jc...@redhat.com> Signed-off-by: Jeff Cody <jc...@redhat.com> --- block/gluster.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/block/gluster.c b/block/gluster.c index 0ce15f7..891c13b 100644 --- a/block/gluster.c +++ b/bl

[Qemu-block] [PULL for-2.8 0/1] Block patches for 2.8

The following changes since commit c36ed06e9159fa484b711dfdd27ec64d7ac3d17a: Merge remote-tracking branch 'mst/tags/for_upstream' into staging (2016-11-21 11:09:58 +) are available in the git repository at: https://github.com/codyprime/qemu-kvm-jtc.git tags/block-pull-request for you

Re: [Qemu-block] [PATCH for-2.8] gluster: Fix use after free in glfs_clear_preopened()

On Thu, Nov 17, 2016 at 11:30:08AM +0100, Kevin Wolf wrote: > This fixes a use-after-free bug introduced in commit 6349c154. We need > to use QLIST_FOREACH_SAFE() when freeing elements in the loop. Spotted > by Coverity. > > Signed-off-by: Kevin Wolf > --- > block/gluster.c |

[Qemu-block] [PULL for-2.8 13/13] mirror: do not flush every time the disks are synced

close to the BLOCK_JOB_READY event, the cost of the second flush should be small anyway. Signed-off-by: Paolo Bonzini <pbonz...@redhat.com> Message-id: 20161109162008.27287-2-pbonz...@redhat.com Signed-off-by: Jeff Cody <jc...@redhat.com> --- block/mirror.c | 40 +-

[Qemu-block] [PULL for-2.8 08/13] block/curl: Drop TFTP "support"

tually used it. Therefore, it should be safe to just drop it from curl's protocol list. [Jeff Cody: Below is additional summary pulled, with some rewording, from followup emails between Max and Markus, to explain what worked and what didn't] TFTP would sometimes work, to a l

[Qemu-block] [PULL for-2.8 09/13] block/curl: Use BDRV_SECTOR_SIZE

com> Message-id: 20161025025431.24714-2-mre...@redhat.com Signed-off-by: Jeff Cody <jc...@redhat.com> --- block/curl.c | 11 +-- 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/block/curl.c b/block/curl.c index ba8adae..1d19e64 100644 --- a/block/curl.c +++ b/block/curl.c

[Qemu-block] [PULL for-2.8 11/13] block/curl: Remember all sockets

1025025431.24714-4-mre...@redhat.com Signed-off-by: Jeff Cody <jc...@redhat.com> --- block/curl.c | 47 +-- 1 file changed, 41 insertions(+), 6 deletions(-) diff --git a/block/curl.c b/block/curl.c index 7a7e831..273f329 100644 --- a/block/curl.c +++ b/blo

[Qemu-block] [PULL for-2.8 12/13] block/curl: Do not wait for data beyond EOF

mu-sta...@nongnu.org Signed-off-by: Max Reitz <mre...@redhat.com> Message-id: 20161025025431.24714-5-mre...@redhat.com Signed-off-by: Jeff Cody <jc...@redhat.com> --- block/curl.c | 32 +++- 1 file changed, 23 insertions(+), 9 deletions(-) diff --git a/block/cur

[Qemu-block] [PULL for-2.8 07/13] qemu-iotests: avoid spurious failure on test 109

;return": [{"io-status": "ok", "device": "src", "busy": true, "len": 31457280, "offset": OFFSET, "paused": false, "speed": 0, "ready": false, "type": "mirror"}]} Assert that the completei

[Qemu-block] [PULL for-2.8 10/13] block/curl: Fix return value from curl_read_cb

e-id: 20161025025431.24714-3-mre...@redhat.com Signed-off-by: Jeff Cody <jc...@redhat.com> --- block/curl.c | 11 +++ 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/block/curl.c b/block/curl.c index 1d19e64..7a7e831 100644 --- a/block/curl.c +++ b/block/curl.c @

[Qemu-block] [PULL for-2.8 05/13] blockjob: refactor backup_start as backup_job_create

8587839-9834-6-git-send-email-js...@redhat.com Signed-off-by: Jeff Cody <jc...@redhat.com> --- block/backup.c| 26 --- block/replication.c | 12 --- blockdev.c| 81 ++- include/block/block_int.h | 23

[Qemu-block] [PULL for-2.8 04/13] blockjob: add block_job_start

tarted. Signed-off-by: John Snow <js...@redhat.com> Message-id: 1478587839-9834-5-git-send-email-js...@redhat.com Signed-off-by: Jeff Cody <jc...@redhat.com> --- block/backup.c| 3 +-- block/commit.c| 5 ++--- block/mirror.c| 5 ++--- block/stream

[Qemu-block] [PULL for-2.8 06/13] iotests: add transactional failure race test

9834-7-git-send-email-js...@redhat.com Signed-off-by: Jeff Cody <jc...@redhat.com> --- tests/qemu-iotests/124 | 53 ++ tests/qemu-iotests/124.out | 4 ++-- 2 files changed, 37 insertions(+), 20 deletions(-) diff --git a/tests/qemu-iotests/124

[Qemu-block] [PULL for-2.8 03/13] blockjob: add .start field

839-9834-4-git-send-email-js...@redhat.com Signed-off-by: Jeff Cody <jc...@redhat.com> --- block/backup.c | 25 + block/commit.c | 3 ++- block/mirror.c | 4 +++- block/stream.c | 3 ++- include/block/blockj

[Qemu-block] [PULL for-2.8 02/13] blockjob: add .clean property

; Signed-off-by: John Snow <js...@redhat.com> Reviewed-by: Kevin Wolf <kw...@redhat.com> Message-id: 1478587839-9834-3-git-send-email-js...@redhat.com Signed-off-by: Jeff Cody <jc...@redhat.com> --- block/backup.c | 15 ++- blockjob.c

[Qemu-block] [PULL for-2.8 01/13] blockjob: fix dead pointer in txn list

Wolf <kw...@redhat.com> Signed-off-by: John Snow <js...@redhat.com> Signed-off-by: Jeff Cody <jc...@redhat.com> --- blockjob.c | 1 + 1 file changed, 1 insertion(+) diff --git a/blockjob.c b/blockjob.c index 4aa14a4..4d0ef53 100644 --- a/blockjob.c +++ b/blockjob.c

[Qemu-block] [PULL for-2.8 00/13] Block patches for 2.8

The following changes since commit 682df581c65ed2c1b9e77093e332214ecaa1ee93: Merge remote-tracking branch 'jsnow/tags/ide-pull-request' into staging (2016-11-14 17:07:16 +) are available in the git repository at: https://github.com/codyprime/qemu-kvm-jtc.git tags/block-pull-request

Re: [Qemu-block] [PATCH for-2.8] mirror: do not flush every time the disks are synced

On Wed, Nov 09, 2016 at 05:01:31PM -0500, Paolo Bonzini wrote: > > > - Original Message - > > From: "Jeff Cody" <jc...@redhat.com> > > To: "Paolo Bonzini" <pbonz...@redhat.com> > > Cc: qemu-de...@nongnu.org, qemu-block@nongnu.or

Re: [Qemu-block] [Qemu-devel] [PATCH 0/4] block/curl: Fix FTP

On Wed, Oct 26, 2016 at 10:44:02AM +0100, Richard W.M. Jones wrote: > As well as testing patch 2 on its own, I also tested all 4 patches > together on top of current qemu from git. > > In summary, it seems to work fine and doesn't break http or https as > far as I can tell. > > Rich. > > $

Re: [Qemu-block] [Qemu-devel] [PATCH v4 0/6] jobs: fix transactional race condition

On Mon, Nov 14, 2016 at 01:58:03PM -0500, John Snow wrote: > Jeff, where did we leave off on this? > > --js I've applied it to my branch, but you made me realize I didn't send out a notice. Sorry about that! Here is my notice: :) Thanks, Applied to my block branch:

Re: [Qemu-block] [Qemu-devel] [PATCH for-2.8? 0/3] block/curl: Drop TFTP "support"

On Fri, Nov 11, 2016 at 08:46:11PM +0100, Max Reitz wrote: > On 09.11.2016 20:15, Jeff Cody wrote: > > On Tue, Nov 08, 2016 at 08:14:58AM +0100, Markus Armbruster wrote: > >> Max Reitz <mre...@redhat.com> writes: > >> > >>> On 07.11.2016 09:20, M

Re: [Qemu-block] [Qemu-devel] [PATCH for-2.8? 0/3] block/curl: Drop TFTP "support"

On Tue, Nov 08, 2016 at 08:14:58AM +0100, Markus Armbruster wrote: > Max Reitz writes: > > > On 07.11.2016 09:20, Markus Armbruster wrote: > >> Max Reitz writes: > >> > >>> On 03.11.2016 08:56, Markus Armbruster wrote: > Max Reitz

Re: [Qemu-block] [PATCH for-2.8] qemu-iotests: avoid spurious failure on test 109

On Wed, Nov 09, 2016 at 05:20:07PM +0100, Paolo Bonzini wrote: > In some cases it is possible that query-io-status is called just > before the job is completed, causing > > -{"timestamp": {"seconds": TIMESTAMP, "microseconds": TIMESTAMP}, > "event": "BLOCK_JOB_COMPLETED", "data":

Re: [Qemu-block] [PATCH for-2.8] mirror: do not flush every time the disks are synced

On Wed, Nov 09, 2016 at 05:20:08PM +0100, Paolo Bonzini wrote: > This puts a huge strain on the disks when there are many concurrent > migrations. With this patch we only flush twice: just before issuing > the event, and just before pivoting to the destination. If management > will complete the

Re: [Qemu-block] [PATCH for-2.8] qemu-iotests: avoid spurious failure on test 109

sts/109 b/tests/qemu-iotests/109 > index 280ed27..927151a 100755 > --- a/tests/qemu-iotests/109 > +++ b/tests/qemu-iotests/109 > @@ -62,6 +62,9 @@ function run_qemu() > "return" > > _send_qemu_cmd $QEMU_HANDLE '' "$qmp_event" > +if test "$qmp_event" = BLOCK_JOB_ERROR; then > +_send_qemu_cmd $QEMU_HANDLE '' "BLOCK_JOB_COMPLETED" > +fi > _send_qemu_cmd $QEMU_HANDLE '{"execute":"query-block-jobs"}' "return" > _cleanup_qemu > } > -- > 2.9.3 > > Thanks, Reviewed-by: Jeff Cody <jc...@redhat.com>

Re: [Qemu-block] [PATCH v4 0/6] jobs: fix transactional race condition

On Tue, Nov 08, 2016 at 01:50:33AM -0500, John Snow wrote: > There are a few problems with transactional job completion right now. > > First, if jobs complete so quickly they complete before remaining jobs > get a chance to join the transaction, the completion mode can leave well > known state

Re: [Qemu-block] [PATCH v4 0/6] jobs: fix transactional race condition

On Tue, Nov 08, 2016 at 01:50:33AM -0500, John Snow wrote: > There are a few problems with transactional job completion right now. > > First, if jobs complete so quickly they complete before remaining jobs > get a chance to join the transaction, the completion mode can leave well > known state

Re: [Qemu-block] [Qemu-devel] [PATCH v3 5/6] blockjob: refactor backup_start as backup_job_create

On Tue, Nov 08, 2016 at 10:24:50AM -0500, John Snow wrote: > > > On 11/08/2016 04:11 AM, Kevin Wolf wrote: > >Am 08.11.2016 um 06:41 hat John Snow geschrieben: > >>On 11/03/2016 09:17 AM, Kevin Wolf wrote: > >>>Am 02.11.2016 um 18:50 hat John Snow geschrieben: > Refactor backup_start as

Re: [Qemu-block] [PATCH v3 5/6] blockjob: refactor backup_start as backup_job_create

. But I won't ask you to do it :) > > static void drive_backup_prepare(BlkActionState *common, Error **errp) > @@ -1835,23 +1835,27 @@ static void drive_backup_prepare(BlkActionState > *common, Error **errp) > bdrv_drained_begin(bs); > state->bs = bs; > > -

Re: [Qemu-block] [PATCH v3 3/6] blockjob: add .start field

tart(bs, base, s, s->common.co); > qemu_coroutine_enter(s->common.co); > } > diff --git a/include/block/blockjob_int.h b/include/block/blockjob_int.h > index 60d91a0..8223822 100644 > --- a/include/block/blockjob_int.h > +++ b/include/block/blockjob_int.h > @@ -47,6 +47,9 @@ struct BlockJobDriver { > /** Optional callback for job types that need to forward I/O status > reset */ > void (*iostatus_reset)(BlockJob *job); > > +/** Mandatory: Entrypoint for the Coroutine. */ > +CoroutineEntry *start; > + > /** > * Optional callback for job types whose completion must be triggered > * manually. > -- > 2.7.4 > Reviewed-by: Jeff Cody <jc...@redhat.com>

Re: [Qemu-block] [PATCH v3 2/6] blockjob: add .clean property

NULL, it will be invoked after a call to either > + * .commit() or .abort(). Regardless of which callback is invoked after > + * completion, .clean() will always be called, even if the job does not > + * belong to a transaction group. > + */ > +void (*clean)(BlockJob *job); > + > +/** > * If the callback is not NULL, it will be invoked when the job > transitions > * into the paused state. Paused jobs must not perform any asynchronous > * I/O or event loop activity. This callback is used to quiesce jobs. > -- > 2.7.4 > Reviewed-by: Jeff Cody <jc...@redhat.com>

Re: [Qemu-block] [PATCH v3 1/6] blockjob: fix dead pointer in txn list

lockJob *job) > } > > if (job->txn) { > + QLIST_REMOVE(job, txn_list); > block_job_txn_unref(job->txn); > } > block_job_unref(job); > -- > 2.7.4 > Reviewed-by: Jeff Cody <jc...@redhat.com>

Re: [Qemu-block] [Qemu-devel] [PATCH v3 4/6] blockjob: add block_job_start

On Mon, Nov 07, 2016 at 09:02:14PM -0500, John Snow wrote: > > > On 11/03/2016 08:17 AM, Kevin Wolf wrote: > >Am 02.11.2016 um 18:50 hat John Snow geschrieben: > >>Instead of automatically starting jobs at creation time via backup_start > >>et al, we'd like to return a job object pointer that

Re: [Qemu-block] [PATCH for-2.8? 2/3] qapi: Drop curl's TFTP protocol

'replication', 'ssh', 'tftp', 'vdi', 'vhdx', 'vmdk', 'vpc', > +'replication', 'ssh', 'vdi', 'vhdx', 'vmdk', 'vpc', > 'vvfat' ] } > > ## > @@ -2410,7 +2410,6 @@ >'replication':'BlockdevOptionsReplication', > # TODO sheepdog: Wait for structured options >'ssh':'BlockdevOptionsSsh', > - 'tftp': 'BlockdevOptionsCurl', >'vdi':'BlockdevOptionsGenericFormat', >'vhdx': 'BlockdevOptionsGenericFormat', >'vmdk': 'BlockdevOptionsGenericCOWFormat', > -- > 2.10.2 > Reviewed-by: Jeff Cody <jc...@redhat.com>

<    3   4   5   6   7   8   9   10   11   12   >