Re: [PULL 1/5] hw/nvme: move adjustment of data_units{read,written}

On Mon, Mar 06, 2023 at 03:34:29PM +0100, Klaus Jensen wrote: > From: Joel Granados > > Move the rounding of bytes read/written into nvme_smart_log which > reports in units of 512 bytes, rounded up in thousands. This is in > preparation for adding the Endurance Group Information

Re: [PATCH v3 3/5] hw/nvme: add basic endurance group support

On Mon, Feb 20, 2023 at 12:59:24PM +0100, Jesper Devantier wrote: > From: Klaus Jensen > > Add the mandatory Endurance Group identify data structures and log > pages. > > For now, all namespaces in a subsystem belongs to a single Endurance > Group. > > Signed-off-by: Klaus Jensen > --- >

Re: [PATCH v3 1/5] hw/nvme: move adjustment of data_units{read,written}

On Mon, Feb 20, 2023 at 12:59:22PM +0100, Jesper Devantier wrote: > From: Joel Granados > > In order to return the units_{read/written} required by the SMART log we > need to shift the number of bytes value by BDRV_SECTORS_BITS and multiply > by 1000. This is a prep p

Re: [PATCH v2 0/3] Add OCP extended log to nvme QEMU

e the "Media Bytes with Metadata Written" in the statistics log page of the newly ratified FDP TP. Thx for the review Best Joel > > On Mon, Nov 14, 2022 at 02:50:40PM +0100, Joel Granados wrote: > > The motivation and description are contained in the last patch in this set. >

Re: [PATCH v4 0/2] Add OCP extended log to nvme QEMU

ping. Is the solution to the guid constant ok? Best On Fri, Nov 25, 2022 at 10:48:06AM +0100, Joel Granados wrote: > The motivation and description are contained in the last patch in this set. > Will copy paste it here for convenience: > > In order to evaluate write amplific

[PATCH v4 1/2] nvme: Move adjustment of data_units{read,written}

extended smart log values. Signed-off-by: Joel Granados --- hw/nvme/ctrl.c | 14 -- 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/hw/nvme/ctrl.c b/hw/nvme/ctrl.c index 87aeba0564..bf291f7ffe 100644 --- a/hw/nvme/ctrl.c +++ b/hw/nvme/ctrl.c @@ -4449,8 +4449,8 @@ static void

[PATCH v4 2/2] nvme: Add physical writes/reads from OCP log

and log_page_uuid. Signed-off-by: Joel Granados --- docs/system/devices/nvme.rst | 7 + hw/nvme/ctrl.c | 59 hw/nvme/nvme.h | 1 + include/block/nvme.h | 36 ++ 4 files changed, 103 insertions(+) diff --git

[PATCH v4 0/2] Add OCP extended log to nvme QEMU

all namespaces and report them back on the extended log as per the spec. 3. I removed the default case in the switch in nvme_vendor_specific_log as it does not have any special function. Joel Granados (2): nvme: Move adjustment of data_units{read,written} nvme: Add physical writes/reads f

Re: [PATCH v3 2/2] nvme: Add physical writes/reads from OCP log

On Thu, Nov 17, 2022 at 08:30:46AM +0100, Klaus Jensen wrote: > On Nov 16 18:14, Joel Granados wrote: > > In order to evaluate write amplification factor (WAF) within the storage > > stack it is important to know the number of bytes written to the > > controller. The exi

[PATCH v3 1/2] nvme: Move adjustment of data_units{read,written}

extended smart log values. Signed-off-by: Joel Granados --- hw/nvme/ctrl.c | 14 -- 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/hw/nvme/ctrl.c b/hw/nvme/ctrl.c index 87aeba0564..bf291f7ffe 100644 --- a/hw/nvme/ctrl.c +++ b/hw/nvme/ctrl.c @@ -4449,8 +4449,8 @@ static void

[PATCH v3 0/2] Add OCP extended log to nvme QEMU

special function. Joel Granados (2): nvme: Move adjustment of data_units{read,written} nvme: Add physical writes/reads from OCP log docs/system/devices/nvme.rst | 7 hw/nvme/ctrl.c | 69 hw/nvme/nvme.h | 1 + include

[PATCH v3 2/2] nvme: Add physical writes/reads from OCP log

and log_page_uuid. Signed-off-by: Joel Granados --- docs/system/devices/nvme.rst | 7 + hw/nvme/ctrl.c | 55 hw/nvme/nvme.h | 1 + include/block/nvme.h | 36 +++ 4 files changed, 99 insertions(+) diff --git

Re: [PATCH v2 3/3] nvme: Add physical writes/reads from OCP log

On Tue, Nov 15, 2022 at 12:26:17PM +0100, Klaus Jensen wrote: > On Nov 14 14:50, Joel Granados wrote: > > In order to evaluate write amplification factor (WAF) within the storage > > stack it is important to know the number of bytes written to the > > controller. The exi

Re: [PATCH v2 2/3] nvme: Add ocp to the subsys

On Tue, Nov 15, 2022 at 12:11:50PM +0100, Klaus Jensen wrote: > On Nov 14 14:50, Joel Granados wrote: > > The Open Compute Project defines a Datacenter NVMe SSD Spec that sits on > > top of the NVMe spec. Additional commands and NVMe behaviors specific for > > the Datacenter.

[PATCH v2 2/3] nvme: Add ocp to the subsys

The Open Compute Project defines a Datacenter NVMe SSD Spec that sits on top of the NVMe spec. Additional commands and NVMe behaviors specific for the Datacenter. This is a preparation patch that introduces an argument to activate OCP in nvme. Signed-off-by: Joel Granados --- hw/nvme/nvme.h

[PATCH v2 3/3] nvme: Add physical writes/reads from OCP log

the command is 0xC0 and ocp has been turned on in the args. Though we add the whole nvme smart log extended structure, we only populate the physical_media_units_{read,written}, log_page_version and log_page_uuid. Signed-off-by: Joel Granados squash with main Signed-off-by: Joel Granados

[PATCH v2 0/3] Add OCP extended log to nvme QEMU

on the extended log as per the spec. 3. I removed the default case in the switch in nvme_vendor_specific_log as it does not have any special function. Joel Granados (3): nvme: Move adjustment of data_units{read,written} nvme: Add ocp to the subsys nvme: Add physical writes/reads from OCP log hw

[PATCH v2 1/3] nvme: Move adjustment of data_units{read,written}

extended smart log values. Signed-off-by: Joel Granados --- hw/nvme/ctrl.c | 14 -- 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/hw/nvme/ctrl.c b/hw/nvme/ctrl.c index 87aeba0564..220683201a 100644 --- a/hw/nvme/ctrl.c +++ b/hw/nvme/ctrl.c @@ -4449,8 +4449,8 @@ static void