insertion(+), 1 deletion(-)
diff --git a/MAINTAINERS b/MAINTAINERS
index cad58b9487..47694cd02f 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -2367,7 +2367,7 @@ S: Supported
F: block/vmdk.c
RBD
-M: Josh Durgin
+M: Jason Dillaman
L: qemu-block@nongnu.org
S: Supported
F: block/rbd.c
c | 38 +++---
1 file changed, 23 insertions(+), 15 deletions(-)
Looks good, thanks!
Reviewed-by: Josh Durgin <jdur...@redhat.com>
diff --git a/block/rbd.c b/block/rbd.c
index 5bc5b32..5226b6f 100644
--- a/block/rbd.c
+++ b/block/rbd.c
@@ -290,7 +290,8 @@ static int qemu_rbd_set_conf(rad
On 05/17/2016 03:03 AM, Sebastian Färber wrote:
Hi Kevin,
A correct reopen implementation must consider all options and flags that
.bdrv_open() looked at.
The options are okay, as both "filename" and "password-secret" aren't
things that we want to allow a reopen to change. However, in the
$QEMU -object secret,id=secret0,file=poolkey.b64,format=base64 \
-drive driver=rbd,filename=rbd:pool/image:id=myname:\
auth_supported=cephx,passwordid=secret0
Signed-off-by: Daniel P. Berrange <berra...@redhat.com>
Looks good to me, thanks!
Reviewed-by
On 10/19/2015 08:09 AM, Daniel P. Berrange wrote:
Currently RBD passwords must be provided on the command line
via
$QEMU -drive file=rbd:pool/image:id=myname:\
key=QVFDVm41aE82SHpGQWhBQXEwTkN2OGp0SmNJY0UrSE9CbE1RMUE=:\
auth_supported=cephx
This is insecure because the key is
On 07/14/2015 07:20 AM, Kevin Wolf wrote:
Am 09.07.2015 um 11:59 hat Stefan Hajnoczi geschrieben:
On Tue, Jun 30, 2015 at 11:28:18AM -0700, Josh Durgin wrote:
Ping
On 06/10/2015 08:28 PM, Josh Durgin wrote:
Patches 1 and 2 are simple cleanups. 3 and 4 fix the precedence of
cache options
Ping
On 06/10/2015 08:28 PM, Josh Durgin wrote:
Patches 1 and 2 are simple cleanups. 3 and 4 fix the precedence of
cache options and ceph settings. The cache option precedence in
particular is important due to the potential for misconfigurations
(ceph.conf setting rbd_cache=true, qemu setting
it, although this would just be a performance problem.
Fix this by changing rbd's cache setting to match qemu after all other
ceph settings have been applied.
Signed-off-by: Josh Durgin jdur...@redhat.com
---
block/rbd.c | 24
1 file changed, 12 insertions(+), 12 deletions
Patches 1 and 2 are simple cleanups. 3 and 4 fix the precedence of
cache options and ceph settings. The cache option precedence in
particular is important due to the potential for misconfigurations
(ceph.conf setting rbd_cache=true, qemu setting cache=none) to
accidentally put data at risk.
Josh
Apply the ceph settings from a config file before any ceph settings
from the command line. Since the ceph config file location may be
specified on the command line, parse it once to read the config file,
and do a second pass to apply the rest of the command line ceph
options.
Signed-off-by: Josh
The old one still works for now, but will not work indefinitely.
Signed-off-by: Josh Durgin jdur...@redhat.com
---
MAINTAINERS | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/MAINTAINERS b/MAINTAINERS
index 4ed8215..34eeb88 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
RBDAIOCB.status was only used for cancel, which was removed in
7691e24dbebb46658e89b3f950fda6ec78bbb823.
RBDAIOCB.sector_num was never used.
RADOSCB.done and rcbid were never used.
RBD_FD* are obsolete since the pipe was removed in
e04fb07fd1676e9facd7f3f878c1bbe03bccd26b.
Signed-off-by: Josh
12 matches
Mail list logo
