Re: [PATCH v4 01/15] pcie: Add support for Single Root I/O Virtualization (SR/IOV)

2022-01-26 Thread Knut Omang
On Wed, 2022-01-26 at 18:11 +0100, Lukasz Maniak wrote: > From: Knut Omang > > This patch provides the building blocks for creating an SR/IOV > PCIe Extended Capability header and register/unregister > SR/IOV Virtual Functions. > > Signed-off-by: Knut Omang > -

Re: [PATCH v3 01/15] pcie: Add support for Single Root I/O Virtualization (SR/IOV)

2022-01-26 Thread Knut Omang
On Wed, 2022-01-26 at 14:23 +0100, Łukasz Gieryk wrote: > I'm sorry for the delayed response. We (I and the other Lukasz) somehow > had hoped that Knut, the original author of this patch, would have > responded. Yes, sorry - this one flushed past me here for some reason, > > Let me address your

Re: [PATCH 01/15] pcie: Set default and supported MaxReadReq to 512

2021-10-26 Thread Knut Omang
On Tue, 2021-10-26 at 16:36 +0200, Lukasz Maniak wrote: > On Thu, Oct 07, 2021 at 06:12:41PM -0400, Michael S. Tsirkin wrote: > > On Thu, Oct 07, 2021 at 06:23:52PM +0200, Lukasz Maniak wrote: > > > From: Knut Omang > > > > > > Make the default PCI Exp

Re: [PATCH 13/15] pcie: Add helpers to the SR/IOV API

2021-10-26 Thread Knut Omang
n that owns this VF. >   * Returns NULL if dev is not a virtual function >   */ >  PCIDevice *pcie_sriov_get_pf(PCIDevice *dev); >   > +/* Get the n-th VF of this physical function - only valid for PF. > + * Returns NULL if index is invalid > + */ > +PCIDevice *pcie_sriov_get_vf_at_index(PCIDevice *dev, int n); > + >  #endif /* QEMU_PCIE_SRIOV_H */ These look like natural improvements to me, thanks! Reviewed-by: Knut Omang