Hi Markus and Philippe,
I agree to remove QERR_UNSUPPORTED and have more specific errors
or even remove the functions from the schema in some cases instead of
copy-paste QERR_UNSUPPORTED from platform to platform.
Best Regards,
Konstantin Kostiuk.
On Wed, Jun 12, 2024 at 4:07 PM Markus
Reviewed-by: Konstantin Kostiuk
On Mon, Feb 5, 2024 at 9:47 AM Markus Armbruster wrote:
> The command's doc comment describes the argument, but it's not marked
> up as such. Easy enough to fix.
>
> Signed-off-by: Markus Armbruster
> ---
> qga/qapi-schema.json |
Reviewed-by: Konstantin Kostiuk
On Mon, Feb 5, 2024 at 9:47 AM Markus Armbruster wrote:
> The command's doc comment describes the argument, but it's not marked
> up as such. Easy enough to fix.
>
> Signed-off-by: Markus Armbruster
> ---
> qga/qapi-schema.json |
Reviewed-by: Konstantin Kostiuk
On Mon, Jan 29, 2024 at 1:50 PM Markus Armbruster wrote:
> Documentation of type BlockdevOptionsIscsi describes the type's
> purpose after its members. Everywhere else, we do it the other way
> round. Move it for consistency.
>
> S
Reviewed-by: Konstantin Kostiuk
On Mon, Jan 29, 2024 at 1:50 PM Markus Armbruster wrote:
> Documentation of commands guest-ssh-get-authorized-keys,
> guest-ssh-add-authorized-keys, and guest-ssh-remove-authorized-keys
> describes the command's purpose after its arguments. E
Hi Akihiko,
Thanks for ping.
I will merge this commit with other qga fixes.
Best Regards,
Konstantin Kostiuk.
On Thu, Sep 21, 2023 at 10:58 AM Akihiko Odaki
wrote:
> On 2022/11/17 18:45, Konstantin Kostiuk wrote:
> > Reviewed-by: Konstantin Kostiuk > <mailto:kkos
Reviewed-by: Konstantin Kostiuk
On Tue, Apr 4, 2023 at 2:59 PM Markus Armbruster wrote:
> Delete "error state indicates", because it doesn't make sense.
> I suspect it was an accident.
>
> Signed-off-by: Markus Armbruster
> ---
> qga/qapi-schema.json | 2
Reviewed-by: Konstantin Kostiuk
On Thu, Jan 19, 2023 at 9:00 AM Markus Armbruster wrote:
> Clean up includes so that osdep.h is included first and headers
> which it implies are not included manually.
>
> This commit was created with scripts/clean-includes.
>
> Sig
Reviewed-by: Konstantin Kostiuk
Will merge this patch in QGA series
On Thu, Nov 10, 2022 at 12:06 PM Akihiko Odaki
wrote:
> GUID_DEVINTERFACE_DISK and GUID_DEVINTERFACE_STORAGEPORT are already
> defined by MinGW-w64. They are not only unnecessary, but can lead to
> duplicate definiti
On Thu, Nov 10, 2022 at 8:25 AM Akihiko Odaki
wrote:
> GUID_DEVINTERFACE_DISK and GUID_DEVINTERFACE_STORAGEPORT are already
> defined by MinGW-w64. They are not only unnecessary, but can lead to
> duplicate definition errors at link time with some unknown condition.
>
What version of MinGW-w64 d
Reviewed-by: Konstantin Kostiuk
On Thu, May 5, 2022 at 11:16 AM wrote:
> From: Marc-André Lureau
>
> Use more conventional variables to set the location of pre-built
> DLL/bin.
>
> Signed-off-by: Marc-André Lureau
> ---
> configure | 9
Reviewed-by: Konstantin Kostiuk
On Thu, May 5, 2022 at 11:16 AM wrote:
> From: Marc-André Lureau
>
> Sadly, wixl doesn't have 'elif'.
>
> Signed-off-by: Marc-André Lureau
> ---
> qga/installer/qemu-ga.wxs | 20 +++-
> 1 file changed, 7
Reviewed-by: Konstantin Kostiuk
On Thu, May 5, 2022 at 11:16 AM wrote:
> From: Marc-André Lureau
>
> No clear reason to make guesses here.
>
> Signed-off-by: Marc-André Lureau
> ---
> qga/installer/qemu-ga.wxs | 9 -
> 1 file changed, 9 deletions(-)
>
&
Reviewed-by: Konstantin Kostiuk
On Thu, May 5, 2022 at 11:16 AM wrote:
> From: Marc-André Lureau
>
> No need to setup an environment or to check if the variable is undefined
> manually.
>
> Signed-off-by: Marc-André Lureau
> ---
> qga/in
14 matches
Mail list logo
