2aaa40e03d (qapi: Add blank lines before
bulleted lists)
Fixes: 467ef823d83e (qmp: add filtering of statistics by target vCPU)
Signed-off-by: Markus Armbruster
---
qapi/stats.json | 1 +
qapi/trace.json | 1 +
2 files changed, 2 insertions(+)
diff --git a/qapi/stats.json b/qapi/stats.json
index
it as another definition list. Comes out as nested
definitions: term "bps_max: int (optional)" defined as term "total
throughput limit during bursts," defined as "in bytes (Since 1.7)".
rST truly is the Perl of ASCII-based markups.
Fix by deleting the extra
Delete "error state indicates", because it doesn't make sense.
I suspect it was an accident.
Signed-off-by: Markus Armbruster
---
qga/qapi-schema.json | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/qga/qapi-schema.json b/qga/qapi-schema.json
index 796434e
ing colons, delete extra spaces.
Signed-off-by: Markus Armbruster
---
qapi/block-core.json | 2 +-
qapi/job.json| 2 +-
qapi/rdma.json | 2 +-
3 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/qapi/block-core.json b/qapi/block-core.json
index 2382772e17..9dd5ed9a47 10
Documentation section "Stability Considerations" dates back to the
early days of QMP (commit 82a56f0d83d (Monitor: Introduce the
qmp-commands.hx file)). It became largely misleading years ago.
Delete it.
Signed-off-by: Markus Armbruster
---
qapi/qapi-schema.json | 22 ---
Commit 81cbfd50886 (block: remove dirty bitmaps 'status' field)
removed deprecated BlockDirtyInfo member @status. It neglected to
remove references to its enumeration values from the documentation of
its replacements. Do that now.
Signed-off-by: Markus Armbruster
---
qapi/block-cor
Signed-off-by: Markus Armbruster
---
qapi/block-core.json | 6 +++---
qapi/stats.json | 2 +-
qapi/tpm.json| 3 +--
qapi/ui.json | 6 +++---
4 files changed, 8 insertions(+), 9 deletions(-)
diff --git a/qapi/block-core.json b/qapi/block-core.json
index 9dd5ed9a47
It's always nice to get doc fixes into the release, but if it's too
late, it's too late.
Generated code does not change, except for the last patch, which moves
a bit of code without changing it.
Markus Armbruster (16):
qga/qapi-schema: Tidy up documentation of guest-fsfreeze-st
37bcdf9e0 (qapi: Convert query-balloon)
Signed-off-by: Markus Armbruster
---
qapi/machine-target.json | 2 +-
qapi/machine.json| 4 ++--
qapi/migration.json | 2 +-
3 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/qapi/machine-target.json b/qapi/machine-target.json
i
GuestDiskStatsInfo's member documentation is parsed as ordinary text
due to missing colons. The generated documentation shows these
members as "Not documented".
The fix is obvious: add the missing colons.
Signed-off-by: Markus Armbruster
---
qga/qapi-schema.json | 6 +++---
1
)
Fixes: f323bc9e8b3b (qmp: add interface blockdev-snapshot-internal-sync)
Fixes: ba1c048a8f9c (qapi: Introduce add-fd, remove-fd, query-fdsets)
Fixes: ed61fc10e8c8 (QAPI: add command for live block commit, 'block-commit')
Fixes: e4c8f004c55d (qapi: convert sendkey)
Signed-off-by: Markus
embers, to
match existing member documentation there. For the others, merely
move existing "since" information.
Signed-off-by: Markus Armbruster
---
qapi/machine.json | 11 ---
qapi/net.json | 21 -
qapi/run-state.json | 6 +-
3 files changed,
Thomas Huth writes:
> On 03/04/2023 16.55, Markus Armbruster wrote:
>> Alex Bennée writes:
>>
>>> Markus Armbruster writes:
>>>
>>>> Alex Bennée writes:
> ...
>>> I was under the impression things like -hda wouldn't work say on an
Alex Bennée writes:
> Markus Armbruster writes:
>
>> Alex Bennée writes:
>>
>>> We are a bit premature in recommending -blockdev/-device as the best
>>> way to configure block devices, especially in the common case.
>>> Improve the language to hop
Alex Bennée writes:
> We are a bit premature in recommending -blockdev/-device as the best
> way to configure block devices, especially in the common case.
> Improve the language to hopefully make things clearer.
>
> Suggested-by: Michael Tokarev
> Signed-off-by: Alex Bennée
> ---
> qemu-optio
e?
>
> Signed-off-by: Alex Bennée
> Cc: Thomas Huth
> Cc: Daniel P. Berrangé
> Cc: Markus Armbruster
> Cc: Kashyap Chamarthy
> Cc: Paolo Bonzini
> Cc: Peter Maydell
> Cc: Philippe Mathieu-Daudé
> Cc: Bernhard Beschow
Reviewed-by: Markus Armbruster
Sam Li writes:
> Taking account of the new zone append write operation for zoned devices,
> BLOCK_ACCT_ZONE_APPEND enum is introduced as other I/O request type (read,
> write, flush).
>
> Signed-off-by: Sam Li
[...]
> diff --git a/qapi/block-core.json b/qapi/block-core.json
> index c05ad0c07e.
Markus Armbruster writes:
> Stefan Hajnoczi writes:
>
>> monitor_cleanup() is called from the main loop thread. Calling
>
> Correct.
>
>> AIO_WAIT_WHILE(qemu_get_aio_context(), ...) from the main loop thread is
>> equivalent to AIO_WAIT_WHILE_UNLOCKED(NULL, ..
Stefan Hajnoczi writes:
> On Thu, Mar 02, 2023 at 04:02:22PM +0100, Markus Armbruster wrote:
>> Stefan Hajnoczi writes:
>>
>> > On Thu, Mar 02, 2023 at 08:17:43AM +0100, Markus Armbruster wrote:
>> >> Stefan Hajnoczi writes:
>> >>
>> >
Stefan Hajnoczi writes:
> On Thu, Mar 02, 2023 at 08:17:43AM +0100, Markus Armbruster wrote:
>> Stefan Hajnoczi writes:
>>
>> > The HMP monitor runs in the main loop thread. Calling
>>
>> Correct.
>>
>> > AIO_WAIT_WHILE(qemu_g
while shutting down the dispatcher
> @@ -679,7 +679,7 @@ void monitor_cleanup(void)
> aio_co_wake(qmp_dispatcher_co);
> }
>
> -AIO_WAIT_WHILE(qemu_get_aio_context(),
> +AIO_WAIT_WHILE_UNLOCKED(NULL,
> (aio_poll(iohandler_get_aio_context(), false),
>
enter(qemu_get_aio_context(), co);
> -AIO_WAIT_WHILE(qemu_get_aio_context(), !data.done);
> +AIO_WAIT_WHILE_UNLOCKED(NULL, !data.done);
> }
>
> qobject_unref(qdict);
Acked-by: Markus Armbruster
For an R-by, I need to understand this in more detail. I'm not fa
Philippe Mathieu-Daudé writes:
> ping^2
You misspelled "Paolo?" You're welcome! ;-P
Philippe Mathieu-Daudé writes:
> ForeachArgs::name is only used once as TYPE_IPMI_BMC.
> Since the penultimate commit, object_child_foreach_recursive()'s
> handler takes an Error* argument and return a boolean.
> We can directly pass ForeachArgs::obj as context, removing the
> ForeachArgs structu
Philippe Mathieu-Daudé writes:
> Following the Error API best practices documented in commit
> e3fe3988d7 ("error: Document Error API usage rules"), have the
> object_child_foreach[_recursive]() handler take a Error* argument
> and return a boolean indicating whether this error is set or not.
> C
ize(ram_addr_t sz)
> diff --git a/include/hw/nmi.h b/include/hw/nmi.h
> index fff41bebc6..3e827a254a 100644
> --- a/include/hw/nmi.h
> +++ b/include/hw/nmi.h
> @@ -37,7 +37,8 @@ typedef struct NMIState NMIState;
> struct NMIClass {
> InterfaceClass parent_class;
>
> -void (*nmi_monitor_handler)(NMIState *n, int cpu_index, Error **errp);
> +/** Returns: %true on success, %false on error. */
> +bool (*nmi_monitor_handler)(NMIState *n, int cpu_index, Error **errp);
> };
>
> void nmi_monitor_handle(int cpu_index, Error **errp);
None of the handlers can actually fail. Evidence: you add only return
true, never return false. Correct (I checked).
I think I'd make it official and drop the handler's Error ** parameter
instead of changing its return type.
You decide.
Reviewed-by: Markus Armbruster
John Snow writes:
> On Wed, Feb 22, 2023 at 2:15 AM Markus Armbruster wrote:
>>
>> John Snow writes:
>>
>> > On Tue, Feb 21, 2023, 1:50 AM Markus Armbruster wrote:
>> >
>> >> John Snow writes:
>> >>
>> &
A half-baked thought has been sloshing around in my head. Perhaps I can
bake it some more by writing it up.
Reference-counting and finalizers that can fail are uneasy partners.
When managing lifetimes manually, you control where finalization
happens. When finalization can fail, you're as empowe
John Snow writes:
> On Tue, Feb 21, 2023, 1:50 AM Markus Armbruster wrote:
>
>> John Snow writes:
>>
>> > Once upon a time, "sphinx-build" on certain RPM platforms invoked
>> > specifically a Python 2.x version, while "sphinx-build-3
John Snow writes:
> Python 3.6 was EOL 2021-12-31. Newer versions of upstream libraries have
> been dropping support for this version and it is becoming more
> cumbersome to support. Avocado-framework and qemu.qmp each have their
> own reasons for wanting to drop Python 3.6, but won't until QEMU
John Snow writes:
> CI: https://gitlab.com/jsnow/qemu/-/pipelines/783612696
> [Updated for v3, still all green.]
> GL: https://gitlab.com/jsnow/qemu/-/commits/python-require-37
>
> Hi, discussion about this series is ongoing. This series (v3) is not
> meant to address all of that discussion,
John Snow writes:
> Once upon a time, "sphinx-build" on certain RPM platforms invoked
> specifically a Python 2.x version, while "sphinx-build-3" was a distro
> shim for the Python 3.x version.
>
> These days, none of our supported platforms utilize a 2.x version, so it
> should be safe to search
John Snow writes:
> On Tue, Feb 14, 2023 at 12:26 PM Kevin Wolf wrote:
>>
>> Am 14.02.2023 um 15:03 hat Paolo Bonzini geschrieben:
>> > In the case of Python the issue is not the interpreter per se, though
>> > there are a couple new feature in Python 3.7 that are quite nice (for
>> > example im
Thomas Huth writes:
> On 15/02/2023 20.05, Markus Armbruster wrote:
>> The discussion under PATCH 6 makes me think there's a bit of confusion
>> about the actual impact of dropping support for Python 3.6. Possibly
>> because it's spelled out in the com
Peter Maydell writes:
> On Wed, 15 Feb 2023 at 19:05, Markus Armbruster wrote:
>>
>> The discussion under PATCH 6 makes me think there's a bit of confusion
>> about the actual impact of dropping support for Python 3.6. Possibly
>> because it's spelled out i
Daniel P. Berrangé writes:
> On Tue, Feb 14, 2023 at 08:40:20AM +0100, Markus Armbruster wrote:
>> Daniel P. Berrangé writes:
>>
>> [...]
>>
>> > We don't have to drop python 3.6. It is a choice because
>> > of a desire to be able to use
Daniel P. Berrangé writes:
> On Tue, Feb 14, 2023 at 09:52:44PM +0100, Paolo Bonzini wrote:
>> Il mar 14 feb 2023, 18:26 Kevin Wolf ha scritto:
>>
>> > Am 14.02.2023 um 15:03 hat Paolo Bonzini geschrieben:
>> > > In the case of Python the issue is not the interpreter per se, though
>> > > there
Daniel P. Berrangé writes:
> On Tue, Feb 14, 2023 at 09:35:44AM +0100, Thomas Huth wrote:
>> On 14/02/2023 08.40, Markus Armbruster wrote:
>> > Daniel P. Berrangé writes:
>> >
>> > [...]
>> >
>> > > We don't have to drop python 3.
Kevin Wolf writes:
> Am 14.02.2023 um 08:40 hat Markus Armbruster geschrieben:
>> I read this on Friday, and decided to let it sit until after the
>> weekend. Well, it's now Tuesday, and to be frank, it's still as
>> offensively flippant as it was on Friday. It
The discussion under PATCH 6 makes me think there's a bit of confusion
about the actual impact of dropping support for Python 3.6. Possibly
because it's spelled out in the commit message of PATCH 7. Let me
summarize it in one sentence:
*** All supported host systems continue to work ***
Evi
Kevin Wolf writes:
> Am 13.01.2023 um 08:30 hat Markus Armbruster geschrieben:
>> Drive-by comment...
>>
>> Kevin Wolf writes:
>>
>> > This series addresses the problem described in these bug reports:
>> > https://gitlab.com/qemu-project/qemu/-
Cédric Le Goater writes:
> On 2/15/23 07:38, Markus Armbruster wrote:
>> Cédric Le Goater writes:
>>
>>> Hello,
>>>
>>> This series starts with a first set of patches fixing I2C slave mode
>>> in the Aspeed I2C controller, a test device and
Cédric Le Goater writes:
> Hello,
>
> This series starts with a first set of patches fixing I2C slave mode
> in the Aspeed I2C controller, a test device and its associated test in
> avocado.
>
> Follow some cleanups which allow the use of block devices instead of
> drives. So that, instead of spe
Daniel P. Berrangé writes:
[...]
> We don't have to drop python 3.6. It is a choice because
> of a desire to be able to use some shiny new python
> features without caring about back compat.
I read this on Friday, and decided to let it sit until after the
weekend. Well, it's now Tuesday, and t
>props_, indent);
> class = object_class_get_parent(class);
> } while (class != object_class_by_name(TYPE_DEVICE));
> -bus_print_dev(dev->parent_bus, mon, dev, indent);
> +bus_print_dev(mon, dev, indent);
> QLIST_FOREACH(child, &dev->child_bus, sibling) {
> qbus_print(mon, child, indent);
> }
Reviewed-by: Markus Armbruster
First, a plea. Supporting 3.6 has made a few of us prisoners dragging
ball and chain. So, please, *please* let us cut of these leg irons!
The series does not include follow-up cleanups. Fine with me.
This commit was created with scripts/clean-includes.
Signed-off-by: Markus Armbruster
Reviewed-by: Philippe Mathieu-Daudé
Reviewed-by: Michael S. Tsirkin
Reviewed-by: Juan Quintela
---
audio/sndioaudio.c | 2 +-
backends/hostmem-epc.c | 2 +-
block/export/vduse-blk.c | 2 +-
hw
Signed-off-by: Markus Armbruster
Reviewed-by: Christian Schoenebeck
Reviewed-by: Michael S. Tsirkin
---
hw/9pfs/9p.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/hw/9pfs/9p.c b/hw/9pfs/9p.c
index 9621ec1341..aa736af380 100644
--- a/hw/9pfs/9p.c
+++ b/hw/9pfs/9p.c
@@ -17,9 +17,6
When a symbolic link points to a file that needs cleaning, the script
replaces the link with a cleaned regular file. Not wanted; skip them.
We have a few symbolic links under subprojects/libvduse/ and
subprojects/libvhost-user/.
Signed-off-by: Markus Armbruster
Reviewed-by: Michael S. Tsirkin
Tracked down with the help of scripts/clean-includes.
Signed-off-by: Markus Armbruster
Acked-by: Dr. David Alan Gilbert
Reviewed-by: Greg Kurz
Reviewed-by: Michael S. Tsirkin
Reviewed-by: Juan Quintela
---
include/hw/arm/fsl-imx6ul.h | 1 -
include/hw/arm/fsl-imx7.h | 1 -
backends
, including headers qemu/osdep.h includes is redundant.
Drop these, too.
Signed-off-by: Markus Armbruster
Reviewed-by: Michael S. Tsirkin
Reviewed-by: Eric Blake
---
include/block/graph-lock.h | 1 -
include/block/write-threshold.h | 2 --
block/qapi.c| 1 -
3 files
, including headers qemu/osdep.h includes is redundant.
Drop these, too.
Signed-off-by: Markus Armbruster
Reviewed-by: Michael S. Tsirkin
---
include/hw/input/pl050.h | 1 -
hw/input/tsc210x.c | 1 -
2 files changed, 2 deletions(-)
diff --git a/include/hw/input/pl050.h b/include/hw/input
, including headers qemu/osdep.h includes is redundant.
Drop these, too.
Signed-off-by: Markus Armbruster
Reviewed-by: Warner Losh
Reviewed-by: Michael S. Tsirkin
---
bsd-user/bsd-proc.h | 4
bsd-user/qemu.h | 1 -
bsd-user/arm/signal.c | 1 +
bsd
, including headers qemu/osdep.h includes is redundant.
Drop these, too.
Signed-off-by: Markus Armbruster
Reviewed-by: Philippe Mathieu-Daudé
Reviewed-by: Michael S. Tsirkin
---
crypto/block-luks-priv.h | 1 -
1 file changed, 1 deletion(-)
diff --git a/crypto/block-luks-priv.h b/crypto/block
, including headers qemu/osdep.h includes is redundant.
Drop these, too.
Signed-off-by: Markus Armbruster
Reviewed-by: Philippe Mathieu-Daudé
Reviewed-by: Alistair Francis
Reviewed-by: Michael S. Tsirkin
---
target/riscv/pmu.h | 1 -
1 file changed, 1 deletion(-)
diff --git a/target/riscv
ATCH 3: v1 posted separately
* PATCH 4: New
[1] Message-ID: <87h9g8j57d@blackfin.pond.sub.org>
https://lists.nongnu.org/archive/html/qemu-devel/2016-03/msg03345.html
Markus Armbruster (20):
scripts/clean-includes: Fully skip / ignore files
scripts/clean-includes: Don't cl
, including headers qemu/osdep.h includes is redundant.
Drop these, too.
Signed-off-by: Markus Armbruster
Reviewed-by: Philippe Mathieu-Daudé
Reviewed-by: Michael S. Tsirkin
---
include/sysemu/accel-blocker.h | 1 -
1 file changed, 1 deletion(-)
diff --git a/include/sysemu/accel-blocker.h b
, including headers qemu/osdep.h includes is redundant.
Drop these, too.
Signed-off-by: Markus Armbruster
Reviewed-by: Michael S. Tsirkin
---
include/hw/cxl/cxl_component.h | 2 --
include/hw/cxl/cxl_host.h | 1 -
include/hw/cxl/cxl_pci.h | 1 -
3 files changed, 4 deletions(-)
diff
#include
check", duplicating the prior mistake.
Fix the script to fully skip files.
Fixes: fd3e39a40ca2 ("scripts/clean-includes: Enhance to handle header files")
Fixes: d66253e46ae2 ("scripts/clean-includes: added duplicate #include check")
Signed-off-by: Markus Armbruster
R
When running with --check-dup-head, the script always claims it "Found
duplicate header file includes." Fix to do it only when it actually
found some.
Fixes: d66253e46ae2 ("scripts/clean-includes: added duplicate #include check")
Signed-off-by: Markus Armbruster
Reviewed-by
, including headers qemu/osdep.h includes is redundant.
Drop these, too.
Signed-off-by: Markus Armbruster
Reviewed-by: Philippe Mathieu-Daudé
Reviewed-by: Michael S. Tsirkin
---
net/vmnet_int.h | 1 -
1 file changed, 1 deletion(-)
diff --git a/net/vmnet_int.h b/net/vmnet_int.h
index adf6e8c20d
The script drops #include "qemu/osdep.h" from headers. Mention it in
the commit message it uses for --git.
Signed-off-by: Markus Armbruster
Reviewed-by: Juan Quintela
---
scripts/clean-includes | 12 +---
1 file changed, 9 insertions(+), 3 deletions(-)
diff --git a/scr
arget/hexagon/idef-parser/parser-helpers.c
target/hexagon/idef-parser/parser-helpers.h
Signed-off-by: Markus Armbruster
Reviewed-by: Taylor Simpson
Reviewed-by: Michael S. Tsirkin
---
target/hexagon/hex_arch_types.h | 1 -
target/hexagon/mmvec/macros.h | 1 -
2 files changed, 2 deletions(-)
, including headers qemu/osdep.h includes is redundant.
Drop these, too.
Signed-off-by: Markus Armbruster
Reviewed-by: Dr. David Alan Gilbert
Reviewed-by: Michael S. Tsirkin
Reviewed-by: Juan Quintela
---
include/qemu/userfaultfd.h | 1 -
1 file changed, 1 deletion(-)
diff --git a/include/qemu
, including headers qemu/osdep.h includes is redundant.
Drop these, too.
Signed-off-by: Markus Armbruster
Reviewed-by: Philippe Mathieu-Daudé
Reviewed-by: Michael S. Tsirkin
---
include/hw/tricore/triboard.h | 1 -
1 file changed, 1 deletion(-)
diff --git a/include/hw/tricore/triboard.h b
This commit was created with scripts/clean-includes.
Signed-off-by: Markus Armbruster
Acked-by: Christian Schoenebeck
Reviewed-by: Michael S. Tsirkin
---
backends/tpm/tpm_ioctl.h | 2 --
fsdev/p9array.h | 2 --
include/hw/misc/aspeed_lpc.h | 2 --
include/hw
, including headers qemu/osdep.h includes is redundant.
Drop these, too.
Signed-off-by: Markus Armbruster
Reviewed-by: Konstantin Kostiuk
Reviewed-by: Michael S. Tsirkin
---
qga/cutils.h | 2 --
qga/commands-posix.c | 1 -
qga/cutils.c | 3 ++-
3 files changed, 2 insertions(+), 4
Juan Quintela writes:
> Markus Armbruster wrote:
>> Juan Quintela writes:
>>
>>> Markus Armbruster wrote:
>>>> Juan Quintela writes:
>>>>
>>>>> Markus Armbruster wrote:
>>>>>> The script drops #include "
Juan Quintela writes:
> Markus Armbruster wrote:
>> Juan Quintela writes:
>>
>>> Markus Armbruster wrote:
>>>> The script drops #include "qemu/osdep.h" from headers. Mention it in
>>>> the commit message it uses for --git.
>>
Juan Quintela writes:
> Markus Armbruster wrote:
>> The script drops #include "qemu/osdep.h" from headers. Mention it in
>> the commit message it uses for --git.
>>
>> Signed-off-by: Markus Armbruster
>> ---
>> scripts/clean-includes | 4 ++--
Clean up includes so that qemu/osdep.h is included first in .c, and
not in .h, and headers which it implies are not included manually.
This commit was created with scripts/clean-includes.
Signed-off-by: Markus Armbruster
Reviewed-by: Philippe Mathieu-Daudé
Reviewed-by: Michael S. Tsirkin
When a symbolic link points to a file that needs cleaning, the script
replaces the link with a cleaned regular file. Not wanted; skip them.
We have a few symbolic links under subprojects/libvduse/ and
subprojects/libvhost-user/.
Signed-off-by: Markus Armbruster
Reviewed-by: Michael S. Tsirkin
Clean up includes so that qemu/osdep.h is included first in .c, and
not in .h, and headers which it implies are not included manually.
This commit was created with scripts/clean-includes.
Signed-off-by: Markus Armbruster
Reviewed-by: Philippe Mathieu-Daudé
Reviewed-by: Michael S. Tsirkin
Clean up includes so that qemu/osdep.h is included first in .c, and
not in .h, and headers which it implies are not included manually.
This commit was created with scripts/clean-includes.
Signed-off-by: Markus Armbruster
Reviewed-by: Michael S. Tsirkin
Reviewed-by: Eric Blake
---
include
Clean up includes so that qemu/osdep.h is included first in .c, and
not in .h, and headers which it implies are not included manually.
This commit was created with scripts/clean-includes.
Signed-off-by: Markus Armbruster
Reviewed-by: Philippe Mathieu-Daudé
Reviewed-by: Michael S. Tsirkin
The script drops #include "qemu/osdep.h" from headers. Mention it in
the commit message it uses for --git.
Signed-off-by: Markus Armbruster
---
scripts/clean-includes | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/scripts/clean-includes b/scripts/clean-incl
Clean up includes so that qemu/osdep.h is included first in .c, and
not in .h, and headers which it implies are not included manually.
This commit was created with scripts/clean-includes.
Signed-off-by: Markus Armbruster
Reviewed-by: Dr. David Alan Gilbert
Reviewed-by: Michael S. Tsirkin
Tracked down with the help of scripts/clean-includes.
Signed-off-by: Markus Armbruster
Acked-by: Dr. David Alan Gilbert
Reviewed-by: Greg Kurz
Reviewed-by: Michael S. Tsirkin
Reviewed-by: Juan Quintela
---
include/hw/arm/fsl-imx6ul.h | 1 -
include/hw/arm/fsl-imx7.h | 1 -
backends
This commit was created with scripts/clean-includes.
Signed-off-by: Markus Armbruster
Reviewed-by: Philippe Mathieu-Daudé
Reviewed-by: Michael S. Tsirkin
Reviewed-by: Juan Quintela
---
audio/sndioaudio.c | 2 +-
backends/hostmem-epc.c | 2 +-
block/export/vduse-blk.c | 2 +-
hw
arget/hexagon/gen_dectree_import.c
target/hexagon/gen_semantics.c
target/hexagon/idef-parser/idef-parser.h
target/hexagon/idef-parser/parser-helpers.c
target/hexagon/idef-parser/parser-helpers.h
Signed-off-by: Markus Armbruster
Reviewed-by: Taylor Simpson
Reviewed-by: Michael S. Ts
Clean up includes so that qemu/osdep.h is included first in .c, and
not in .h, and headers which it implies are not included manually.
This commit was created with scripts/clean-includes.
Signed-off-by: Markus Armbruster
Reviewed-by: Philippe Mathieu-Daudé
Reviewed-by: Alistair Francis
Clean up includes so that qemu/osdep.h is included first in .c, and
not in .h, and headers which it implies are not included manually.
This commit was created with scripts/clean-includes.
Signed-off-by: Markus Armbruster
Reviewed-by: Warner Losh
Reviewed-by: Michael S. Tsirkin
---
bsd-user
Clean up includes so that qemu/osdep.h is included first in .c, and
not in .h, and headers which it implies are not included manually.
This commit was created with scripts/clean-includes.
Signed-off-by: Markus Armbruster
Reviewed-by: Philippe Mathieu-Daudé
Reviewed-by: Michael S. Tsirkin
Clean up includes so that qemu/osdep.h is included first in .c, and
not in .h, and headers which it implies are not included manually.
This commit was created with scripts/clean-includes.
Signed-off-by: Markus Armbruster
Reviewed-by: Konstantin Kostiuk
Reviewed-by: Michael S. Tsirkin
---
qga
Signed-off-by: Markus Armbruster
Reviewed-by: Christian Schoenebeck
Reviewed-by: Michael S. Tsirkin
---
hw/9pfs/9p.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/hw/9pfs/9p.c b/hw/9pfs/9p.c
index 9621ec1341..aa736af380 100644
--- a/hw/9pfs/9p.c
+++ b/hw/9pfs/9p.c
@@ -17,9 +17,6
This commit was created with scripts/clean-includes.
Signed-off-by: Markus Armbruster
Acked-by: Christian Schoenebeck
Reviewed-by: Michael S. Tsirkin
---
backends/tpm/tpm_ioctl.h | 2 --
fsdev/p9array.h | 2 --
include/hw/misc/aspeed_lpc.h | 2 --
include/hw
Clean up includes so that qemu/osdep.h is included first in .c, and
not in .h, and headers which it implies are not included manually.
This commit was created with scripts/clean-includes.
Signed-off-by: Markus Armbruster
Reviewed-by: Michael S. Tsirkin
---
include/hw/input/pl050.h | 1 -
hw
Clean up includes so that qemu/osdep.h is included first in .c, and
not in .h, and headers which it implies are not included manually.
This commit was created with scripts/clean-includes.
Signed-off-by: Markus Armbruster
Reviewed-by: Michael S. Tsirkin
---
include/hw/cxl/cxl_component.h | 2
When running with --check-dup-head, the script always claims it "Found
duplicate header file includes." Fix to do it only when it actually
found some.
Fixes: d66253e46ae2 ("scripts/clean-includes: added duplicate #include check")
Signed-off-by: Markus Armbruster
Reviewed-by
lists.nongnu.org/archive/html/qemu-devel/2016-03/msg03345.html
Markus Armbruster (20):
scripts/clean-includes: Fully skip / ignore files
scripts/clean-includes: Don't claim duplicate headers found when not
scripts/clean-includes: Skip symbolic links
scripts/clean-includes: Improve --git
#include
check", duplicating the prior mistake.
Fix the script to fully skip files.
Fixes: fd3e39a40ca2 ("scripts/clean-includes: Enhance to handle header files")
Fixes: d66253e46ae2 ("scripts/clean-includes: added duplicate #include check")
Signed-off-by: Markus Armbruster
R
"Michael S. Tsirkin" writes:
> On Fri, Jan 27, 2023 at 10:01:57AM -0500, Michael S. Tsirkin wrote:
>> On Fri, Jan 27, 2023 at 02:54:30PM +, Peter Maydell wrote:
>> > On Thu, 19 Jan 2023 at 14:42, Warner Losh wrote:
>> > >
>> > > Also, why didn't you move sys/resource.h and other such files
>
"Michael S. Tsirkin" writes:
> On Thu, Jan 19, 2023 at 07:59:41AM +0100, Markus Armbruster wrote:
>> When clean-includes claims to skip or ignore a file, only the part
>> that sanitizes use of qemu/osdep.h skips the file. The part that
>> looks for duplicate #inc
Philippe Mathieu-Daudé writes:
> On 19/1/23 12:41, Markus Armbruster wrote:
>> Philippe Mathieu-Daudé writes:
>>
>>> On 19/1/23 07:59, Markus Armbruster wrote:
>>>> This commit was created with scripts/clean-includes.
>>>> Signed-off-by
Warner Losh writes:
[...]
> So I'm happy with it. Thanks for the cleanup and the time to answer my
> questions.
>
> Reviewed-by: Warner Losh
Thank *you* for reviewing my patch :)
This moves these commands from MAINTAINERS section "Human
Monitor (HMP)" to "Machine core".
Signed-off-by: Markus Armbruster
---
hw/core/machine-hmp-cmds.c | 208
monitor/hmp-cmds.c | 209 -
This moves these commands from MAINTAINERS sections "Human
Monitor (HMP)" and "QMP" to "QOM".
Signed-off-by: Markus Armbruster
---
monitor/hmp-cmds.c | 19 -
monitor/misc.c | 49
This moves the command from MAINTAINERS section "QMP" to section
"ACPI/SMBIOS)".
Signed-off-by: Markus Armbruster
---
hw/acpi/acpi-qmp-cmds.c | 30 ++
monitor/qmp-cmds.c | 21 -
hw/acpi/meson.build | 1 +
3 files ch
This moves these commands from MAINTAINERS sections "Human
Monitor (HMP)" and "QMP" to "Network device backends".
Signed-off-by: Markus Armbruster
---
monitor/hmp-cmds.c | 61 ---
monitor/misc.c | 56 --
monitor_putc() will soon be used from more than one .c file.
Signed-off-by: Markus Armbruster
---
include/monitor/monitor.h | 1 +
monitor/misc.c| 27 ---
monitor/monitor.c | 27 +++
3 files changed, 28 insertions(+), 27
501 - 600 of 3457 matches
Mail list logo
