Re: [PATCH] cleanup: Tweak and re-run return_directly.cocci

2022-11-21 Thread Max Filippov
On Mon, Nov 21, 2022 at 6:01 AM Markus Armbruster wrote: > .../xtensa/core-dsp3400/xtensa-modules.c.inc | 136 +- > target/xtensa/core-lx106/xtensa-modules.c.inc | 16 +-- These files are generated and were imported from xtensa configuration overlays, they're not supposed to be

Re: [PATCH 3/4] hw/xtensa/xtfpga: Get pflash MemoryRegion with sysbus_mmio_get_region()

2021-03-08 Thread Max Filippov
fi01_get_memory() helper. > > Signed-off-by: Philippe Mathieu-Daudé > --- > hw/xtensa/xtfpga.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) Acked-by: Max Filippov -- Thanks. -- Max

Re: [Qemu-block] [Qemu-devel] [PATCH 10/10] hw/arm hw/xtensa: De-duplicate pflash creation code some

2019-02-19 Thread Max Filippov
On Mon, Feb 18, 2019 at 5:07 AM Markus Armbruster wrote: > > pflash_cfi01_register() creates a TYPE_CFI_PFLASH01 device, sets > properties, realizes, and wires up. > > We have three modified copies of it, because their users need to set > additional properties, or have the wiring done differently.

Re: [Qemu-block] [PATCH 4/4] Remove unnecessary variables for function return value

2018-03-22 Thread Max Filippov
On Thu, Mar 22, 2018 at 9:12 AM, Laurent Vivier wrote: > Re-run Coccinelle script scripts/coccinelle/return_directly.cocci > > Signed-off-by: Laurent Vivier > --- > target/xtensa/core-dc232b/xtensa-modules.c | 56 > ++ > target/xtensa/core-dc233c/xtensa-modules.c

Re: [Qemu-block] [PATCH 4/4] Remove unnecessary variables for function return value

2018-03-22 Thread Max Filippov
On Thu, Mar 22, 2018 at 10:23 AM, Peter Maydell wrote: > On 22 March 2018 at 17:19, Max Filippov wrote: >> Ok, I can add a fixup that changes #include to #include >> "xtensa-isa.h". >> Adding #include "qemu/osdep.h" there seems pointless to me. &g

Re: [Qemu-block] [PATCH 4/4] Remove unnecessary variables for function return value

2018-03-22 Thread Max Filippov
On Thu, Mar 22, 2018 at 9:59 AM, Eric Blake wrote: > On 03/22/2018 11:51 AM, Max Filippov wrote: >> >> On Thu, Mar 22, 2018 at 9:12 AM, Laurent Vivier >> wrote: >>> >>> Re-run Coccinelle script scripts/coccinelle/return_directly.cocci >>> >>

Re: [Qemu-block] [PATCH 4/4] Remove unnecessary variables for function return value

2018-03-22 Thread Max Filippov
On Thu, Mar 22, 2018 at 9:58 AM, Laurent Vivier wrote: > On 22/03/2018 17:51, Max Filippov wrote: >> On Thu, Mar 22, 2018 at 9:12 AM, Laurent Vivier wrote: >>> Re-run Coccinelle script scripts/coccinelle/return_directly.cocci >>> >>> Signed-off-by: Laurent Viv